flipper-mongo 0.2.1 → 0.2.2

data/Gemfile

@@ -15,5 +15,6 @@ group(:test) do
   gem 'timecop'
   gem 'bson_ext'
   gem 'mongo'
+  gem 'rack-test'
 end
 

data/lib/flipper/adapters/mongo/version.rb

@@ -1,7 +1,7 @@
 module Flipper
   module Adapters
     class Mongo
-      VERSION = "0.2.1"
+      VERSION = "0.2.2"
     end
   end
 end

data/lib/flipper/adapters/mongo_single_document.rb

@@ -11,13 +11,43 @@ module Flipper
       def initialize(collection, options = {})
         @collection = collection
         @options = options
+        @document_cache = false
       end
 
       def_delegators :document, :read, :write, :delete, :set_members, :set_add, :set_delete
 
+      def using_document_cache?
+        @document_cache == true
+      end
+
+      def document_cache=(value)
+        reset_document_cache
+        @document_cache = value
+      end
+
+      def use_document_cache(&block)
+        original = @document_cache
+        @document_cache = true
+        yield
+      ensure
+        @document_cache = original
+      end
+
+      def reset_document_cache
+        @document = nil
+      end
+
       private
 
       def document
+        if @document_cache == true
+          @document ||= fresh_document
+        else
+          fresh_document
+        end
+      end
+
+      def fresh_document
         Document.new(@collection, :id => @options[:id])
       end
     end

data/lib/flipper/middleware/mongo_single_document_query_cache.rb

@@ -0,0 +1,36 @@
+module Flipper
+  module Middleware
+    class MongoSingleDocumentQueryCache
+      class Body
+        def initialize(target, adapter, original)
+          @target   = target
+          @adapter  = adapter
+          @original = original
+        end
+
+        def each(&block)
+          @target.each(&block)
+        end
+
+        def close
+          @target.close if @target.respond_to?(:close)
+        ensure
+          @adapter.document_cache = @original
+        end
+      end
+
+      def initialize(app, adapter)
+        @app = app
+        @adapter = adapter
+      end
+
+      def call(env)
+        original = @adapter.using_document_cache?
+        @adapter.document_cache = true
+
+        status, headers, body = @app.call(env)
+        [status, headers, Body.new(body, @adapter, original)]
+      end
+    end
+  end
+end

data/spec/flipper/adapters/mongo_single_document_spec.rb

@@ -35,5 +35,59 @@ describe Flipper::Adapters::MongoSingleDocument do
     collection.update criteria, updates, options
   end
 
-  it_should_behave_like 'a flipper adapter'
+  context "with cache" do
+    before do
+      subject.document_cache = true
+    end
+
+    it_should_behave_like 'a flipper adapter'
+
+    it "should only query mongo once until reloaded" do
+      collection.should_receive(:find_one).with(criteria).once.and_return({})
+      subject.read('foo')
+      subject.read('foo')
+      subject.read('foo')
+      subject.set_members('users')
+
+      subject.reset_document_cache
+
+      collection.should_receive(:find_one).with(criteria).once.and_return({})
+      subject.read('foo')
+      subject.read('foo')
+      subject.set_members('users')
+    end
+  end
+
+  context "without cache" do
+    before do
+      subject.document_cache = false
+    end
+
+    it_should_behave_like 'a flipper adapter'
+  end
+
+  describe "#use_document_cache" do
+    it "turns cache on for block and restores to original after block" do
+      subject.using_document_cache?.should be_false
+      subject.use_document_cache do
+        subject.using_document_cache?.should be_true
+      end
+      subject.using_document_cache?.should be_false
+    end
+  end
+
+  describe "#document_cache=" do
+    it "sets document cache" do
+      subject.document_cache = true
+      subject.using_document_cache?.should be_true
+
+      subject.document_cache = false
+      subject.using_document_cache?.should be_false
+    end
+
+    it "resets cached document" do
+      subject.should_receive(:reset_document_cache)
+      subject.document_cache = true
+    end
+  end
 end

data/spec/flipper/middleware/mongo_single_document_query_cache_spec.rb

@@ -0,0 +1,121 @@
+require 'helper'
+require 'rack/test'
+require 'flipper/middleware/mongo_single_document_query_cache'
+
+describe Flipper::Middleware::MongoSingleDocumentQueryCache do
+  include Rack::Test::Methods
+
+  let(:collection) { Mongo::Connection.new.db('testing')['testing'] }
+  let(:adapter)    { Flipper::Adapters::MongoSingleDocument.new(collection) }
+  let(:flipper)    { Flipper.new(adapter) }
+
+  class Enum < Struct.new(:iter)
+    def each(&b)
+      iter.call(&b)
+    end
+  end
+
+  let(:app) {
+    # ensure scoped for builder block, annoying...
+    instance = adapter
+    middleware = described_class
+
+    Rack::Builder.new do
+      use middleware, instance
+
+      map "/" do
+        run lambda {|env| [200, {}, []] }
+      end
+
+      map "/fail" do
+        run lambda {|env| raise "FAIL!" }
+      end
+    end.to_app
+  }
+
+  it "delegates" do
+    called = false
+    app = lambda { |env|
+      called = true
+      [200, {}, nil]
+    }
+    middleware = described_class.new app, adapter
+    middleware.call({})
+    called.should be_true
+  end
+
+  it "enables document cache during delegation" do
+    app = lambda { |env|
+      adapter.using_document_cache?.should be_true
+      [200, {}, nil]
+    }
+    middleware = described_class.new app, adapter
+    middleware.call({})
+  end
+
+  it "enables document cache for body each" do
+    app = lambda { |env|
+      [200, {}, Enum.new(lambda { |&b|
+        adapter.using_document_cache?.should be_true
+        b.call "hello"
+      })]
+    }
+    middleware = described_class.new app, adapter
+    body = middleware.call({}).last
+    body.each { |x| x.should eql('hello') }
+  end
+
+  it "disables document cache after body close" do
+    app = lambda { |env| [200, {}, []] }
+    middleware = described_class.new app, adapter
+    body = middleware.call({}).last
+
+    adapter.using_document_cache?.should be_true
+    body.close
+    adapter.using_document_cache?.should be_false
+  end
+
+  it "clears document cache after body close" do
+    app = lambda { |env| [200, {}, []] }
+    middleware = described_class.new app, adapter
+    body = middleware.call({}).last
+    adapter.write('hello', 'world')
+
+    adapter.instance_variable_get("@document").should_not be_nil
+    body.close
+    adapter.instance_variable_get("@document").should be_nil
+  end
+
+  it "really does cache" do
+    flipper[:stats].enable
+
+    collection.should_receive(:find_one).once.and_return({})
+
+    app = lambda { |env|
+      flipper[:stats].enabled?
+      flipper[:stats].enabled?
+      flipper[:stats].enabled?
+      flipper[:stats].enabled?
+      flipper[:stats].enabled?
+      flipper[:stats].enabled?
+
+      [200, {}, []]
+    }
+    middleware = described_class.new app, adapter
+    middleware.call({})
+  end
+
+  context "with a successful request" do
+    it "clears the document cache" do
+      adapter.should_receive(:reset_document_cache).twice
+      get '/'
+    end
+  end
+
+  context "when the request raises an error" do
+    it "clears the document cache" do
+      adapter.should_receive(:reset_document_cache).once
+      get '/fail' rescue nil
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flipper-mongo
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-07 00:00:00.000000000 Z
+date: 2012-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
-  requirement: &70319593304120 !ruby/object:Gem::Requirement
+  requirement: &70110164650060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,7 +21,7 @@ dependencies:
         version: '0.2'
   type: :runtime
   prerelease: false
-  version_requirements: *70319593304120
+  version_requirements: *70110164650060
 description: Mongo adapter for Flipper
 email:
 - nunemaker@gmail.com
@@ -41,9 +41,11 @@ files:
 - lib/flipper/adapters/mongo/document.rb
 - lib/flipper/adapters/mongo/version.rb
 - lib/flipper/adapters/mongo_single_document.rb
+- lib/flipper/middleware/mongo_single_document_query_cache.rb
 - spec/flipper/adapters/mongo/document_spec.rb
 - spec/flipper/adapters/mongo_single_document_spec.rb
 - spec/flipper/adapters/mongo_spec.rb
+- spec/flipper/middleware/mongo_single_document_query_cache_spec.rb
 - spec/helper.rb
 - spec/support/accessor_helpers.rb
 homepage: http://jnunemaker.github.com/flipper-mongo
@@ -60,7 +62,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3598565635761616349
+      hash: -3406714501289693291
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -69,7 +71,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3598565635761616349
+      hash: -3406714501289693291
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.10
@@ -80,5 +82,6 @@ test_files:
 - spec/flipper/adapters/mongo/document_spec.rb
 - spec/flipper/adapters/mongo_single_document_spec.rb
 - spec/flipper/adapters/mongo_spec.rb
+- spec/flipper/middleware/mongo_single_document_query_cache_spec.rb
 - spec/helper.rb
 - spec/support/accessor_helpers.rb