flipper-dalli 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 663526b8a3f866ac7150affe4d0ccc3882a8d135929622b1631dbcf36f5f91a9
-  data.tar.gz: b9d80d481fd319d86b24acca3170a5ef28156401287b9ceaa59a5001af4603e0
+  metadata.gz: 5ab7d84ca0cfcde7d80882fde5f30a65352291b9922e5fd19d6aa86ae360214f
+  data.tar.gz: 0eb5ae0eb3b124b16b6995a292554c1a7af72e0605036fad24066d8e8a9ef983
 SHA512:
-  metadata.gz: af43b94ce3effeb2ff64e86fb64bdd21374ffebcb708c6e284928299c3ed46ee77e8d0ed3d78c2226700e65746cb6cf84817dfa4bb2bb534a4bfb9124e5cadca
-  data.tar.gz: 623a1164e98aaff4aaf41db86a354fbd141b2571677e945d5e441d83d03167e17b9a4b92d15e7c742c852d8e5134e681440382886795018c95aecd1fd1ec9fcc
+  metadata.gz: 9da38d17e220fc3924e1b7be24db7680a8bc85ccda6c759f1658942d001250336a67db362f0860b3706367569d29e16b22a5162bfb85693df8d867115cf7ff55
+  data.tar.gz: 1aeb61c9b9217dcc366342a4a7ce411992c2bd076ccab2238086ca1c7bf6df89f89cca07885f70364cda4490407e25bdee783a2a55212d94346a8c8b039a0f52

data/lib/flipper/adapters/dalli.rb

@@ -8,31 +8,22 @@ module Flipper
     class Dalli
       include ::Flipper::Adapter
 
-      Version = 'v1'.freeze
-      Namespace = "flipper/#{Version}".freeze
-      FeaturesKey = "#{Namespace}/features".freeze
-      GetAllKey = "#{Namespace}/get_all".freeze
-
-      # Private
-      def self.key_for(key)
-        "#{Namespace}/feature/#{key}"
-      end
-
       # Internal
       attr_reader :cache
 
-      # Public: The name of the adapter.
-      attr_reader :name
-
       # Public: The ttl for all cached data.
       attr_reader :ttl
 
       # Public
       def initialize(adapter, cache, ttl = 0)
         @adapter = adapter
-        @name = :dalli
         @cache = cache
         @ttl = ttl
+
+        @cache_version = 'v1'.freeze
+        @namespace = "flipper/#{@cache_version}".freeze
+        @features_key = "#{@namespace}/features".freeze
+        @get_all_key = "#{@namespace}/get_all".freeze
       end
 
       # Public
@@ -43,14 +34,14 @@ module Flipper
       # Public
       def add(feature)
         result = @adapter.add(feature)
-        @cache.delete(FeaturesKey)
+        @cache.delete(@features_key)
         result
       end
 
       # Public
       def remove(feature)
         result = @adapter.remove(feature)
-        @cache.delete(FeaturesKey)
+        @cache.delete(@features_key)
         @cache.delete(key_for(feature.key))
         result
       end
@@ -74,12 +65,12 @@ module Flipper
       end
 
       def get_all
-        if @cache.add(GetAllKey, Time.now.to_i, @ttl)
+        if @cache.add(@get_all_key, Time.now.to_i, @ttl)
           response = @adapter.get_all
           response.each do |key, value|
             @cache.set(key_for(key), value, @ttl)
           end
-          @cache.set(FeaturesKey, response.keys.to_set, @ttl)
+          @cache.set(@features_key, response.keys.to_set, @ttl)
           response
         else
           features = read_feature_keys.map { |key| Flipper::Feature.new(key, self) }
@@ -104,11 +95,11 @@ module Flipper
       private
 
       def key_for(key)
-        self.class.key_for(key)
+        "#{@namespace}/feature/#{key}"
       end
 
       def read_feature_keys
-        @cache.fetch(FeaturesKey, @ttl) { @adapter.features }
+        @cache.fetch(@features_key, @ttl) { @adapter.features }
       end
 
       # Internal: Given an array of features, attempts to read through cache in

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '1.0.0'.freeze
+  VERSION = '1.1.0'.freeze
 end

data/spec/flipper/adapters/dalli_spec.rb

@@ -26,7 +26,7 @@ RSpec.describe Flipper::Adapters::Dalli do
       feature = flipper[:stats]
       adapter.get(feature)
       adapter.remove(feature)
-      expect(cache.get(described_class.key_for(feature))).to be(nil)
+      expect(cache.get("flipper/v1/#{feature.key}")).to be(nil)
     end
   end
 
@@ -41,13 +41,13 @@ RSpec.describe Flipper::Adapters::Dalli do
       memory_adapter.reset
 
       adapter.get(stats)
-      expect(cache.get(described_class.key_for(search))).to be(nil)
-      expect(cache.get(described_class.key_for(other))).to be(nil)
+      expect(cache.get("flipper/v1/feature/#{search.key}")).to be(nil)
+      expect(cache.get("flipper/v1/feature/#{other.key}")).to be(nil)
 
       adapter.get_multi([stats, search, other])
 
-      expect(cache.get(described_class.key_for(search))[:boolean]).to eq('true')
-      expect(cache.get(described_class.key_for(other))[:boolean]).to be(nil)
+      expect(cache.get("flipper/v1/feature/#{search.key}")[:boolean]).to eq('true')
+      expect(cache.get("flipper/v1/feature/#{other.key}")[:boolean]).to be(nil)
 
       adapter.get_multi([stats, search, other])
       adapter.get_multi([stats, search, other])
@@ -66,9 +66,9 @@ RSpec.describe Flipper::Adapters::Dalli do
 
     it 'warms all features' do
       adapter.get_all
-      expect(cache.get(described_class.key_for(stats))[:boolean]).to eq('true')
-      expect(cache.get(described_class.key_for(search))[:boolean]).to be(nil)
-      expect(cache.get(described_class::GetAllKey)).to be_within(2).of(Time.now.to_i)
+      expect(cache.get("flipper/v1/feature/#{stats.key}")[:boolean]).to eq('true')
+      expect(cache.get("flipper/v1/feature/#{search.key}")[:boolean]).to be(nil)
+      expect(cache.get("flipper/v1/get_all")).to be_within(2).of(Time.now.to_i)
     end
 
     it 'returns same result when already cached' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-dalli
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-23 00:00:00.000000000 Z
+date: 2023-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: dalli
   requirement: !ruby/object:Gem::Requirement