flipper-api 1.2.1 → 1.3.0.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58d461415a5ed29c22d0a6e086d849ff542d570b71538083ddc02fcc76d31b65
-  data.tar.gz: c21e1075bf3cb9d3c02fa0f592da7264eaa9600b80e48ec885797687771b0b57
+  metadata.gz: 35faa9238c95b07d1bde406a088808f18b2b7cf915d9c95751e6ebb111d99080
+  data.tar.gz: 9ed7baec0b1a6b6ad2dc0458a7989d82c284f80ccd86e6e3f3d7640ed54720a8
 SHA512:
-  metadata.gz: 6b5ebedf60b6cc27b02e9c494e263dae117eade08b8e5879c050730812ffc58681d88839e581cd97da011a4a3dc27553bddf0dd74b44c5789a8632146a06cec5
-  data.tar.gz: 5b4616c11300e5c9c0879c57aa630919a82a99b0e6200befc9c61e778c582b1fe5075784ddeb75c72749431ad34f56b05c2646c35343476b7c930036c53860d9
+  metadata.gz: b3c7a5545c7be59b68e5e56029f4292efa89860bdab7b53ddc123f466d49ed5036739f02fee622fad052ddc529d989173ef0754cbe8435b6f6cd2f6723678596
+  data.tar.gz: f206617cd06710e4df31552a98a48ab0fbc04a6056c1406e2f285b418ad6fc8976164fba91f03037ca72350d71800d19f52042fdc5f82081a85157c153b3fa34

data/lib/flipper/api/json_params.rb

@@ -12,6 +12,7 @@ module Flipper
       CONTENT_TYPE = 'CONTENT_TYPE'.freeze
       QUERY_STRING = 'QUERY_STRING'.freeze
       REQUEST_BODY = 'rack.input'.freeze
+      REWIND_BODY = Gem::Version.new(Rack.release) < Gem::Version.new('3.0.0')
 
       # Public: Merge request body params with query string params
       # This way can access all params with Rack::Request#params
@@ -21,7 +22,7 @@ module Flipper
       def call(env)
         if env[CONTENT_TYPE] == 'application/json'
           body = env[REQUEST_BODY].read
-          env[REQUEST_BODY].rewind
+          env[REQUEST_BODY].rewind if REWIND_BODY
           update_params(env, body)
         end
         @app.call(env)

data/lib/flipper/api/middleware.rb

@@ -34,6 +34,8 @@ module Flipper
       def call!(env)
         request = Rack::Request.new(env)
         action_class = @action_collection.action_for_request(request)
+        env["flipper.action_class"] = action_class
+        env["flipper.action_method"] = request.request_method.downcase
 
         if action_class.nil?
           @app.call(env)

data/lib/flipper/api/v1/actions/import.rb

@@ -10,8 +10,11 @@ module Flipper
           route %r{\A/import/?\Z}
 
           def post
+            # Rack 3 changed the requirement to rewind the body, so we can't assume it is rewound,
+            # so rewind before under Rack 3+ and after under Rack 2.
+            request.body.rewind if Gem::Version.new(Rack.release) >= Gem::Version.new('3.0.0')
             body = request.body.read
-            request.body.rewind
+            request.body.rewind if Gem::Version.new(Rack.release) < Gem::Version.new('3.0.0')
             export = Flipper::Exporters::Json::Export.new(contents: body)
             flipper.import(export)
             json_response({}, 204)

data/lib/flipper/api/v1/decorators/actor.rb

@@ -1,3 +1,5 @@
+require 'delegate'
+
 module Flipper
   module Api
     module V1

data/lib/flipper/api/v1/decorators/feature.rb

@@ -1,24 +1,24 @@
-require 'delegate'
 require 'flipper/api/v1/decorators/gate'
 
 module Flipper
   module Api
     module V1
       module Decorators
-        class Feature < SimpleDelegator
-          # Public: The feature being decorated.
-          alias_method :feature, :__getobj__
+        class Feature
+          def initialize(feature)
+            @feature = feature
+          end
 
           # Public: Returns instance as hash that is ready to be json dumped.
           def as_json(exclude_gates: false, exclude_gate_names: false)
             result = {
-              'key' => key,
-              'state' => state.to_s,
+              'key' => @feature.key,
+              'state' => @feature.state.to_s,
             }
 
             unless exclude_gates
-              gate_values = feature.adapter.get(self)
-              result['gates'] = gates.map do |gate|
+              gate_values = @feature.adapter.get(@feature)
+              result['gates'] = @feature.gates.map do |gate|
                 Decorators::Gate.new(gate, gate_values[gate.key]).as_json(exclude_name: exclude_gate_names)
               end
             end

data/lib/flipper/api/v1/decorators/gate.rb

@@ -2,24 +2,18 @@ module Flipper
   module Api
     module V1
       module Decorators
-        class Gate < SimpleDelegator
-          # Public the gate being decorated
-          alias_method :gate, :__getobj__
-
-          # Public: the value for the gate from the adapter.
-          attr_reader :value
-
+        class Gate
           def initialize(gate, value = nil)
-            super gate
+            @gate = gate
             @value = value
           end
 
           def as_json(exclude_name: false)
             as_json = {
-              'key' => gate.key.to_s,
+              'key' => @gate.key.to_s,
               'value' => value_as_json,
             }
-            as_json['name'] = gate.name.to_s unless exclude_name
+            as_json['name'] = @gate.name.to_s unless exclude_name
             as_json
           end
 
@@ -30,7 +24,7 @@ module Flipper
 
           # json doesn't like sets
           def value_as_json
-            JSON_ARRAY_TYPES.include?(data_type) ? value.to_a : value
+            JSON_ARRAY_TYPES.include?(@gate.data_type) ? @value.to_a : @value
           end
         end
       end

data/lib/flipper/api.rb

@@ -9,11 +9,15 @@ module Flipper
 
     def self.app(flipper = nil, options = {})
       env_key = options.fetch(:env_key, 'flipper')
+      use_rewindable_middleware = options.fetch(:use_rewindable_middleware) {
+        Gem::Version.new(Rack.release) >= Gem::Version.new('3.0.0')
+      }
       app = ->(_) { [404, { Rack::CONTENT_TYPE => CONTENT_TYPE }, ['{}'.freeze]] }
       builder = Rack::Builder.new
       yield builder if block_given?
       builder.use Rack::Head
       builder.use Rack::Deflater
+      builder.use Rack::RewindableInput::Middleware if use_rewindable_middleware
       builder.use Flipper::Api::JsonParams
       builder.use Flipper::Middleware::SetupEnv, flipper, env_key: env_key
       builder.use Flipper::Api::Middleware, env_key: env_key

data/lib/flipper/version.rb

@@ -1,5 +1,5 @@
 module Flipper
-  VERSION = '1.2.1'.freeze
+  VERSION = '1.3.0.pre'.freeze
 
   REQUIRED_RUBY_VERSION = '2.6'.freeze
   NEXT_REQUIRED_RUBY_VERSION = '3.0'.freeze

data/spec/flipper/api_spec.rb

@@ -8,6 +8,9 @@ RSpec.describe Flipper::Api do
 
       get '/features'
 
+      expect(last_request.env["flipper.action_class"]).to eq(Flipper::Api::V1::Actions::Features)
+      expect(last_request.env["flipper.action_method"]).to eq("get")
+
       expect(last_response.status).to be(200)
       feature_names = json_response.fetch('features').map { |feature| feature.fetch('key') }
       expect(feature_names).to eq(%w(a b))

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-api
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0.pre
 platform: ruby
 authors:
 - John Nunemaker
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-01-15 00:00:00.000000000 Z
+date: 2024-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.3.0.pre
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.3.0.pre
 description:
 email: support@flippercloud.io
 executables: []
@@ -97,7 +97,7 @@ metadata:
   homepage_uri: https://www.flippercloud.io
   source_code_uri: https://github.com/flippercloud/flipper
   bug_tracker_uri: https://github.com/flippercloud/flipper/issues
-  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.2.1
+  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.3.0.pre
 post_install_message:
 rdoc_options: []
 require_paths: