flipper-api 0.9.2 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 602b1d466a68b777063b76d351ab845843057406
-  data.tar.gz: a0a32a90d8accbce74b0dec3b2157cf9bb669dc2
+  metadata.gz: fd696bdc261c62486cab5a607d1ef98e21eaf9d1
+  data.tar.gz: 3bec1050517cd29ac18233562644ea0d859f00b7
 SHA512:
-  metadata.gz: 81401173dd23fe114cde4087e1469ddb5289cf2032f99062225247ad88933c858401c88d60810d16d9ccd51a2ea18bc030b7b3ba42183e3cb1c49c1da33fbce4
-  data.tar.gz: 8dcdac503eefc843e1c1e61e0e465f70a01d4b4ec556a0212d8c6f373d84663df9b3e0cfc9a10a55d7d2e2cc85c447c87315c1d3c6c319a1d7715a97eebd414a
+  metadata.gz: 08e7142b00964657bf6e21afc3fb192c900305b8825e67c500bffc1e51bfe271a80be3f2ac6b0288cf9fb44eb3476bddc0220013e01f6b8339454d0a42159deb
+  data.tar.gz: f6c94f090cc3e2745348a06edaf4aed37449df84879888f697e55b14046a7cb1e9ff4f0e9a9b657afd39db3df6a5d743e4640fcd8514999c8c3280a4c94df364

data/lib/flipper/api.rb

@@ -1,6 +1,7 @@
 require 'rack'
 require 'flipper'
 require 'flipper/api/middleware'
+require 'flipper/api/actor'
 
 module Flipper
   module Api

data/lib/flipper/api/action.rb

@@ -1,5 +1,6 @@
 require 'forwardable'
 require 'flipper/api/error'
+require 'flipper/api/error_response'
 require 'json'
 
 module Flipper
@@ -88,6 +89,12 @@ module Flipper
         throw :halt, response
       end
 
+      # Public: Call this with a json serializable object (i.e. Hash)
+      # to serialize object and respond to request
+      #
+      # object - json serializable object
+      # status - http status code
+
       def json_response(object, status = 200)
         header 'Content-Type', Api::CONTENT_TYPE
         status(status)
@@ -95,6 +102,16 @@ module Flipper
         halt [@code, @headers, [body]]
       end
 
+      # Public: Call this with an ErrorResponse::ERRORS key to respond
+      # with the serialized error object as response body
+      #
+      # error_key - key to lookup error object
+
+      def json_error_response(error_key)
+        error = ErrorResponse::ERRORS.fetch(error_key.to_sym)
+        json_response(error.as_json, error.http_status)
+      end
+
       # Public: Set the status code for the response.
       #
       # code - The Integer code you would like the response to return.

data/lib/flipper/api/actor.rb

@@ -0,0 +1,13 @@
+module Flipper
+  module Api
+    # Internal: Shim for turning a string flipper id into something that responds to
+    # flipper_id for Flipper::Types::Actor.
+    class Actor
+      attr_reader :flipper_id
+
+      def initialize(flipper_id)
+        @flipper_id = flipper_id
+      end
+    end
+  end
+end

data/lib/flipper/api/error_response.rb

@@ -0,0 +1,32 @@
+module Flipper
+  module Api
+    module ErrorResponse
+      class Error
+        attr_reader :http_status
+
+        def initialize(code, message, info, http_status)
+          @code = code
+          @message = message
+          @more_info = info
+          @http_status = http_status
+        end
+
+        def as_json
+          {
+            code: @code,
+            message: @message,
+            more_info: @more_info,
+          }
+        end
+      end
+
+      ERRORS = {
+        feature_not_found: Error.new(1, "Feature not found.", "", 404),
+        group_not_registered: Error.new(2, "Group not registered.", "", 404),
+        percentage_invalid: Error.new(3, "Percentage must be a positive number less than or equal to 100.", "", 422),
+        flipper_id_invalid: Error.new(4, "Required parameter flipper_id is missing.", "", 422),
+        name_invalid: Error.new(5, "Required parameter name is missing.", "", 422),
+      }
+    end
+  end
+end

data/lib/flipper/api/middleware.rb

@@ -35,6 +35,10 @@ module Flipper
         end
 
         @action_collection = ActionCollection.new
+        @action_collection.add Api::V1::Actions::PercentageOfTimeGate
+        @action_collection.add Api::V1::Actions::PercentageOfActorsGate
+        @action_collection.add Api::V1::Actions::ActorsGate
+        @action_collection.add Api::V1::Actions::GroupsGate
         @action_collection.add Api::V1::Actions::BooleanGate
         @action_collection.add Api::V1::Actions::Feature
         @action_collection.add Api::V1::Actions::Features

data/lib/flipper/api/v1/actions/actors_gate.rb

@@ -0,0 +1,54 @@
+require 'flipper/api/action'
+require 'flipper/api/v1/decorators/feature'
+
+module Flipper
+  module Api
+    module V1
+      module Actions
+        class ActorsGate < Api::Action
+          route %r{api/v1/features/[^/]*/actors/?\Z}
+
+          def post
+            ensure_valid_params
+            feature = flipper[feature_name]
+            actor = Actor.new(flipper_id)
+            feature.enable_actor(actor)
+            decorated_feature = Decorators::Feature.new(feature)
+            json_response(decorated_feature.as_json, 200)
+          end
+
+          def delete
+            ensure_valid_params
+            feature = flipper[feature_name]
+            actor = Actor.new(flipper_id)
+            feature.disable_actor(actor)
+            decorated_feature = Decorators::Feature.new(feature)
+            json_response(decorated_feature.as_json, 200)
+          end
+
+          private
+
+          def ensure_valid_params
+            unless feature_names.include?(feature_name)
+              json_error_response(:feature_not_found)
+            end
+
+            json_error_response(:flipper_id_invalid) if flipper_id.nil?
+          end
+
+          def feature_name
+            @feature_name ||= Rack::Utils.unescape(path_parts[-2])
+          end
+
+          def flipper_id
+            @flipper_id ||= params['flipper_id']
+          end
+
+          def feature_names
+            @feature_names ||= flipper.adapter.features
+          end
+        end
+      end
+    end
+  end
+end

data/lib/flipper/api/v1/actions/boolean_gate.rb

@@ -1,18 +1,27 @@
 require 'flipper/api/action'
+require 'flipper/api/v1/decorators/feature'
 
 module Flipper
   module Api
     module V1
       module Actions
         class BooleanGate < Api::Action
-          route %r{api/v1/features/[^/]*/(enable|disable)/?\Z}
-          
-          def put
+          route %r{api/v1/features/[^/]*/boolean/?\Z}
+
+          def post
+            feature_name = Rack::Utils.unescape(path_parts[-2])
+            feature = flipper[feature_name]
+            feature.enable
+            decorated_feature = Decorators::Feature.new(feature)
+            json_response(decorated_feature.as_json, 200)
+          end
+
+          def delete
             feature_name = Rack::Utils.unescape(path_parts[-2])
             feature = flipper[feature_name.to_sym]
-            action = Rack::Utils.unescape(path_parts.last)
-            feature.send(action)
-            json_response({}, 204)
+            feature.disable
+            decorated_feature = Decorators::Feature.new(feature)
+            json_response(decorated_feature.as_json, 200)
           end
         end
       end

data/lib/flipper/api/v1/actions/feature.rb

@@ -14,17 +14,16 @@ module Flipper
               feature = Decorators::Feature.new(flipper[feature_name])
               json_response(feature.as_json)
             else
-              json_response({}, 404)
+              json_error_response(:feature_not_found)
             end
           end
 
           def delete
             if feature_names.include?(feature_name)
               flipper.remove(feature_name)
-
               json_response({}, 204)
             else
-              json_response({}, 404)
+              json_error_response(:feature_not_found)
             end
           end
 

data/lib/flipper/api/v1/actions/features.rb

@@ -21,16 +21,11 @@ module Flipper
           end
 
           def post
-            feature_name = params.fetch('name') do
-              json_response({
-                errors: [{
-                  message: 'Missing post parameter: name',
-                }]
-              }, 422)
-            end
-
-            flipper.adapter.add(flipper[feature_name])
-            json_response({}, 200)
+            feature_name = params.fetch('name') { json_error_response(:name_invalid) }
+            feature = flipper[feature_name]
+            flipper.adapter.add(feature)
+            decorated_feature = Decorators::Feature.new(feature)
+            json_response(decorated_feature.as_json, 200)
           end
         end
       end

data/lib/flipper/api/v1/actions/groups_gate.rb

@@ -0,0 +1,49 @@
+require 'flipper/api/action'
+require 'flipper/api/v1/decorators/feature'
+
+module Flipper
+  module Api
+    module V1
+      module Actions
+        class GroupsGate < Api::Action
+          route %r{api/v1/features/[^/]*/groups/?\Z}
+
+          def post
+            ensure_valid_params
+            feature = flipper[feature_name]
+            feature.enable_group(group_name)
+            decorated_feature = Decorators::Feature.new(feature)
+            json_response(decorated_feature.as_json, 200)
+          end
+
+          def delete
+            ensure_valid_params
+            feature = flipper[feature_name]
+            feature.disable_group(group_name)
+            decorated_feature = Decorators::Feature.new(feature)
+            json_response(decorated_feature.as_json, 200)
+          end
+
+          private
+
+          def ensure_valid_params
+            json_error_response(:feature_not_found) unless feature_names.include?(feature_name)
+            json_error_response(:group_not_registered) unless Flipper.group_exists?(group_name)
+          end
+
+          def feature_name
+            @feature_name ||= Rack::Utils.unescape(path_parts[-2])
+          end
+
+          def group_name
+            @group_name ||= params['name']
+          end
+
+          def feature_names
+            @feature_names ||= flipper.adapter.features
+          end
+        end
+      end
+    end
+  end
+end

data/lib/flipper/api/v1/actions/percentage_of_actors_gate.rb

@@ -0,0 +1,64 @@
+require 'flipper/api/action'
+require 'flipper/api/v1/decorators/feature'
+
+module Flipper
+  module Api
+    module V1
+      module Actions
+        class PercentageOfActorsGate < Api::Action
+          route %r{api/v1/features/[^/]*/percentage_of_actors/?\Z}
+
+          def post
+            ensure_valid_enable_params
+            feature = flipper[feature_name]
+            feature.enable_percentage_of_actors(percentage)
+            decorated_feature = Decorators::Feature.new(feature)
+            json_response(decorated_feature.as_json, 200)
+          end
+
+          def delete
+            ensure_valid_disable_params
+            feature = flipper[feature_name]
+            feature.disable_percentage_of_actors
+            decorated_feature = Decorators::Feature.new(feature)
+            json_response(decorated_feature.as_json, 200)
+          end
+
+          private
+
+          def ensure_valid_enable_params
+            unless feature_names.include?(feature_name)
+              json_error_response(:feature_not_found)
+            end
+
+            if percentage < 0 || percentage > 100
+              json_error_response(:percentage_invalid)
+            end
+          end
+
+          def ensure_valid_disable_params
+            unless feature_names.include?(feature_name)
+              json_error_response(:feature_not_found)
+            end
+          end
+
+          def feature_name
+            @feature_name ||= Rack::Utils.unescape(path_parts[-2])
+          end
+
+          def percentage
+            @percentage ||= begin
+              Integer(params['percentage'])
+            rescue ArgumentError, TypeError
+              -1
+            end
+          end
+
+            def feature_names
+              @feature_names ||= flipper.adapter.features
+            end
+          end
+        end
+      end
+    end
+  end

data/lib/flipper/api/v1/actions/percentage_of_time_gate.rb

@@ -0,0 +1,64 @@
+require 'flipper/api/action'
+require 'flipper/api/v1/decorators/feature'
+
+module Flipper
+  module Api
+    module V1
+      module Actions
+        class PercentageOfTimeGate < Api::Action
+          route %r{api/v1/features/[^/]*/percentage_of_time/?\Z}
+
+          def post
+            ensure_valid_enable_params
+            feature = flipper[feature_name]
+            feature.enable_percentage_of_time(percentage)
+            decorated_feature = Decorators::Feature.new(feature)
+            json_response(decorated_feature.as_json, 200)
+          end
+
+          def delete
+            ensure_valid_disable_params
+            feature = flipper[feature_name]
+            feature.disable_percentage_of_time
+            decorated_feature = Decorators::Feature.new(feature)
+            json_response(decorated_feature.as_json, 200)
+          end
+
+          private
+
+          def ensure_valid_enable_params
+            unless feature_names.include?(feature_name)
+              json_error_response(:feature_not_found)
+            end
+
+            if percentage < 0 || percentage > 100
+              json_error_response(:percentage_invalid)
+            end
+          end
+
+          def ensure_valid_disable_params
+            unless feature_names.include?(feature_name)
+              json_error_response(:feature_not_found)
+            end
+          end
+
+          def feature_name
+            @feature_name ||= Rack::Utils.unescape(path_parts[-2])
+          end
+
+          def percentage
+            @percentage ||= begin
+              Integer(params['percentage'])
+            rescue ArgumentError, TypeError
+              -1
+            end
+          end
+
+          def feature_names
+            @feature_names ||= flipper.adapter.features
+          end
+        end
+      end
+    end
+  end
+end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = "0.9.2".freeze
+  VERSION = "0.10.0".freeze
 end

data/spec/flipper/api/action_spec.rb

@@ -25,35 +25,84 @@ RSpec.describe Flipper::Api::Action do
     end
   }
 
-  it "won't run method that isn't whitelisted" do
-    fake_request = Struct.new(:request_method, :env, :session).new("NOOOOPE", {}, {})
-    action = action_subclass.new(flipper, fake_request)
-    expect {
-      action.run
-    }.to raise_error(Flipper::Api::RequestMethodNotSupported)
-  end
+  describe 'https verbs' do
 
-  it "will run get" do
-    fake_request = Struct.new(:request_method, :env, :session).new("GET", {}, {})
-    action = action_subclass.new(flipper, fake_request)
-    expect(action.run).to eq([200, {}, "get"])
-  end
+    it "won't run method that isn't whitelisted" do
+      fake_request = Struct.new(:request_method, :env, :session).new("NOOOOPE", {}, {})
+      action = action_subclass.new(flipper, fake_request)
+      expect {
+        action.run
+      }.to raise_error(Flipper::Api::RequestMethodNotSupported)
+    end
 
-  it "will run post" do
-    fake_request = Struct.new(:request_method, :env, :session).new("POST", {}, {})
-    action = action_subclass.new(flipper, fake_request)
-    expect(action.run).to eq([200, {}, "post"])
-  end
+    it "will run get" do
+      fake_request = Struct.new(:request_method, :env, :session).new("GET", {}, {})
+      action = action_subclass.new(flipper, fake_request)
+      expect(action.run).to eq([200, {}, "get"])
+    end
+
+    it "will run post" do
+      fake_request = Struct.new(:request_method, :env, :session).new("POST", {}, {})
+      action = action_subclass.new(flipper, fake_request)
+      expect(action.run).to eq([200, {}, "post"])
+    end
+
+    it "will run put" do
+      fake_request = Struct.new(:request_method, :env, :session).new("PUT", {}, {})
+      action = action_subclass.new(flipper, fake_request)
+      expect(action.run).to eq([200, {}, "put"])
+    end
 
-  it "will run put" do
-    fake_request = Struct.new(:request_method, :env, :session).new("PUT", {}, {})
-    action = action_subclass.new(flipper, fake_request)
-    expect(action.run).to eq([200, {}, "put"])
+    it "will run delete" do
+      fake_request = Struct.new(:request_method, :env, :session).new("DELETE", {}, {})
+      action = action_subclass.new(flipper, fake_request)
+      expect(action.run).to eq([200, {}, "delete"])
+    end
   end
 
-  it "will run delete" do
-    fake_request = Struct.new(:request_method, :env, :session).new("DELETE", {}, {})
-    action = action_subclass.new(flipper, fake_request)
-    expect(action.run).to eq([200, {}, "delete"])
+  describe '#json_error_response' do
+    describe ":feature_not_found" do
+
+      it 'locates and serializes error correctly' do
+        action = action_subclass.new({}, {})
+        response = catch(:halt) do
+          action.json_error_response(:feature_not_found)
+        end
+        status, headers, body = response
+        parsed_body = JSON.parse(body[0])
+
+        expect(headers["Content-Type"]).to eq("application/json")
+        expect(parsed_body["code"]).to eq(1)
+        expect(parsed_body["message"]).to eq("Feature not found.")
+        expect(parsed_body["more_info"]).to eq("")
+      end
+    end
+
+    describe ':group_not_registered' do
+
+      it 'locates and serializes error correctly' do
+        action = action_subclass.new({}, {})
+        response = catch(:halt) do
+          action.json_error_response(:group_not_registered)
+        end
+        status, headers, body = response
+        parsed_body = JSON.parse(body[0])
+
+        expect(headers["Content-Type"]).to eq("application/json")
+        expect(parsed_body["code"]).to eq(2)
+        expect(parsed_body["message"]).to eq("Group not registered.")
+        expect(parsed_body["more_info"]).to eq("")
+      end
+    end
+
+    describe 'invalid error key' do
+
+      it 'raises descriptive error' do
+        action = action_subclass.new({}, {})
+        catch(:halt) do
+          expect{ action.json_error_response(:invalid_error_key) }.to raise_error(KeyError)
+        end
+      end
+    end
   end
 end

data/spec/flipper/api/v1/actions/actors_gate_spec.rb

@@ -0,0 +1,115 @@
+require 'helper'
+
+RSpec.describe Flipper::Api::V1::Actions::ActorsGate do
+  let(:app) { build_api(flipper) }
+
+  describe 'enable' do
+    let(:actor) { Flipper::Api::Actor.new("1") }
+
+    before do
+      flipper[:my_feature].disable_actor(actor)
+      post '/api/v1/features/my_feature/actors', { flipper_id: actor.flipper_id }
+    end
+
+    it 'enables feature for actor' do
+      expect(last_response.status).to eq(200)
+      expect(flipper[:my_feature].enabled?(actor)).to be_truthy
+      expect(flipper[:my_feature].enabled_gate_names).to eq([:actor])
+    end
+
+    it 'returns decorated feature with actor enabled' do
+      gate = json_response['gates'].find { |gate| gate['key'] == 'actors' }
+      expect(gate['value']).to eq(["1"])
+    end
+  end
+
+  describe 'disable' do
+    let(:actor) { Flipper::Api::Actor.new("1") }
+
+    before do
+      flipper[:my_feature].enable_actor(actor)
+      delete '/api/v1/features/my_feature/actors', { flipper_id: actor.flipper_id }
+    end
+
+    it 'disables feature' do
+      expect(last_response.status).to eq(200)
+      expect(flipper[:my_feature].enabled?(actor)).to be_falsy
+      expect(flipper[:my_feature].enabled_gate_names).to be_empty
+    end
+
+    it 'returns decorated feature with boolean gate disabled' do
+      gate = json_response['gates'].find { |gate| gate['key'] == 'actors' }
+      expect(gate['value']).to be_empty
+    end
+  end
+
+  describe 'enable missing flipper_id parameter' do
+    before do
+      flipper[:my_feature].enable
+      post '/api/v1/features/my_feature/actors'
+    end
+
+    it 'returns correct error response' do
+      expect(last_response.status).to eq(422)
+      expect(json_response).to eq({ 'code' => 4, 'message' => 'Required parameter flipper_id is missing.', 'more_info' => '' })
+    end
+  end
+
+  describe 'disable missing flipper_id parameter' do
+    before do
+      flipper[:my_feature].enable
+      delete '/api/v1/features/my_feature/actors'
+    end
+
+    it 'returns correct error response' do
+      expect(last_response.status).to eq(422)
+      expect(json_response).to eq({ 'code' => 4, 'message' => 'Required parameter flipper_id is missing.', 'more_info' => '' })
+    end
+  end
+
+  describe 'enable nil flipper_id parameter' do
+    before do
+      flipper[:my_feature].enable
+      post '/api/v1/features/my_feature/actors', { flipper_id: nil }
+    end
+
+    it 'returns correct error response' do
+      expect(last_response.status).to eq(422)
+      expect(json_response).to eq({ 'code' => 4, 'message' => 'Required parameter flipper_id is missing.', 'more_info' => '' })
+    end
+  end
+
+  describe 'disable nil flipper_id parameter' do
+    before do
+      flipper[:my_feature].enable
+      delete '/api/v1/features/my_feature/actors', { flipper_id: nil }
+    end
+
+    it 'returns correct error response' do
+      expect(last_response.status).to eq(422)
+      expect(json_response).to eq({ 'code' => 4, 'message' => 'Required parameter flipper_id is missing.', 'more_info' => '' })
+    end
+  end
+
+  describe 'enable missing feature' do
+    before do
+      post '/api/v1/features/my_feature/actors'
+    end
+
+    it 'returns correct error response' do
+      expect(last_response.status).to eq(404)
+      expect(json_response).to eq({ 'code' => 1, 'message' => 'Feature not found.', 'more_info' => '' })
+    end
+  end
+
+  describe 'disable missing feature' do
+    before do
+      delete '/api/v1/features/my_feature/actors'
+    end
+
+    it 'returns correct error response' do
+      expect(last_response.status).to eq(404)
+      expect(json_response).to eq({ 'code' => 1, 'message' => 'Feature not found.', 'more_info' => '' })
+    end
+  end
+end

data/spec/flipper/api/v1/actions/boolean_gate_spec.rb

@@ -6,34 +6,34 @@ RSpec.describe Flipper::Api::V1::Actions::BooleanGate do
   describe 'enable' do
     before do
       flipper[:my_feature].disable
-      put '/api/v1/features/my_feature/enable'
+      post '/api/v1/features/my_feature/boolean'
     end
 
     it 'enables feature' do
-      expect(last_response.status).to eq(204)
+      expect(last_response.status).to eq(200)
       expect(flipper[:my_feature].on?).to be_truthy
     end
+
+    it 'returns decorated feature with boolean gate enabled' do
+      boolean_gate = json_response['gates'].find { |gate| gate['key'] == 'boolean' }
+      expect(boolean_gate['value']).to be_truthy
+    end
   end
 
   describe 'disable' do
     before do
       flipper[:my_feature].enable
-      put '/api/v1/features/my_feature/disable'
+      delete '/api/v1/features/my_feature/boolean'
     end
 
     it 'disables feature' do
-      expect(last_response.status).to eq(204)
+      expect(last_response.status).to eq(200)
       expect(flipper[:my_feature].off?).to be_truthy
     end
-  end
-
-  describe 'invalid paremeter' do
-    before do
-      put '/api/v1/features/my_feature/invalid_param'
-    end
 
-    it 'responds with 404 when not sent enable or disable parameter' do
-      expect(last_response.status).to eq(404)
+    it 'returns decorated feature with boolean gate disabled' do
+      boolean_gate = json_response['gates'].find { |gate| gate['key'] == 'boolean' }
+      expect(boolean_gate['value']).to be_falsy
     end
   end
 end

data/spec/flipper/api/v1/actions/feature_spec.rb

@@ -103,16 +103,36 @@ RSpec.describe Flipper::Api::V1::Actions::Feature do
       it 'returns 404' do
         expect(last_response.status).to eq(404)
       end
+
+      it 'returns formatted error response body' do
+        expect(json_response).to eq({ "code" => 1, "message" => "Feature not found.", "more_info" => "" })
+      end
     end
   end
 
   describe 'delete' do
-    it 'deletes feature' do
-      flipper[:my_feature].enable
-      expect(flipper.features.map(&:key)).to include('my_feature')
-      delete 'api/v1/features/my_feature'
-      expect(last_response.status).to eq(204)
-      expect(flipper.features.map(&:key)).not_to include('my_feature')
+    context 'succesful request' do
+      it 'deletes feature' do
+        flipper[:my_feature].enable
+        expect(flipper.features.map(&:key)).to include('my_feature')
+        delete 'api/v1/features/my_feature'
+        expect(last_response.status).to eq(204)
+        expect(flipper.features.map(&:key)).not_to include('my_feature')
+      end
+    end
+
+    context 'feature not found' do
+      before do
+        delete 'api/v1/features/my_feature'
+      end
+
+      it 'returns 404' do
+        expect(last_response.status).to eq(404)
+      end
+
+      it 'returns formatted error response body' do
+        expect(json_response).to eq({ "code" => 1, "message" => "Feature not found.", "more_info" => "" })
+      end
     end
   end
 end

data/spec/flipper/api/v1/actions/features_spec.rb

@@ -17,22 +17,23 @@ RSpec.describe Flipper::Api::V1::Actions::Features do
         expected_response = {
           "features" => [
             {
-              "key" =>"my_feature",
+              "key" => "my_feature",
               "state" => "on",
               "gates" => [
                 {
                   "key"=> "boolean",
                   "name"=> "boolean",
-                  "value" => true},
-                  {
-                  "key" =>"groups",
+                  "value" => true
+                },
+                {
+                  "key" => "groups",
                   "name" => "group",
-                  "value" =>[],
+                  "value" => [],
                 },
                 {
                   "key" => "actors",
-                  "name"=>"actor",
-                  "value"=>["10"],
+                  "name" => "actor",
+                  "value" => ["10"],
                 },
                 {
                   "key" => "percentage_of_actors",
@@ -44,7 +45,7 @@ RSpec.describe Flipper::Api::V1::Actions::Features do
                   "name"=> "percentage_of_time",
                   "value"=> 0,
                 },
-            ],
+              ],
             },
           ]
         }
@@ -74,9 +75,44 @@ RSpec.describe Flipper::Api::V1::Actions::Features do
         post 'api/v1/features', { name: 'my_feature' }
       end
 
-      it 'responds 200 on success' do
+      it 'responds 200 ' do
         expect(last_response.status).to eq(200)
-        expect(json_response).to eq({})
+      end
+
+      it 'returns decorated feature' do
+        expected_response = {
+
+          "key" => "my_feature",
+          "state" => "off",
+          "gates" => [
+            {
+              "key"=> "boolean",
+              "name"=> "boolean",
+              "value" => false,
+            },
+            {
+              "key" => "groups",
+              "name" => "group",
+              "value" => [],
+            },
+            {
+              "key" => "actors",
+              "name" => "actor",
+              "value" => [],
+            },
+            {
+              "key" => "percentage_of_actors",
+              "name" => "percentage_of_actors",
+              "value" => 0,
+            },
+            {
+              "key"=> "percentage_of_time",
+              "name"=> "percentage_of_time",
+              "value"=> 0,
+            },
+          ],
+        }
+        expect(json_response).to eq(expected_response)
       end
 
       it 'adds feature' do
@@ -98,8 +134,7 @@ RSpec.describe Flipper::Api::V1::Actions::Features do
       end
 
       it 'returns formatted error' do
-        errors = json_response['errors']
-        expect(errors.first['message']).to eq('Missing post parameter: name')
+        expect(json_response).to eq({ 'code' => 5, 'message' => 'Required parameter name is missing.', 'more_info' => '' })
       end
     end
   end

data/spec/flipper/api/v1/actions/groups_gate_spec.rb

@@ -0,0 +1,75 @@
+require 'helper'
+
+RSpec.describe Flipper::Api::V1::Actions::GroupsGate do
+  let(:app) { build_api(flipper) }
+
+  describe 'enable' do
+    before do
+      flipper[:my_feature].disable
+      Flipper.register(:admins) do |actor|
+        actor.respond_to?(:admin?) && actor.admin?
+      end
+      post '/api/v1/features/my_feature/groups', { name: 'admins' }
+    end
+
+    it 'enables feature for group' do
+      person = double
+      allow(person).to receive(:flipper_id).and_return(1)
+      allow(person).to receive(:admin?).and_return(true)
+      expect(last_response.status).to eq(200)
+      expect(flipper[:my_feature].enabled?(person)).to be_truthy
+    end
+
+    it 'returns decorated feature with group enabled' do
+      group_gate = json_response['gates'].find { |m| m['name'] == 'group' }
+      expect(group_gate['value']).to eq(['admins'])
+    end
+  end
+
+  describe 'disable' do
+    before do
+      flipper[:my_feature].disable
+      Flipper.register(:admins) do |actor|
+        actor.respond_to?(:admin?) && actor.admin?
+      end
+      flipper[:my_feature].enable_group(:admins)
+      delete '/api/v1/features/my_feature/groups', { name: 'admins' }
+    end
+
+    it 'disables feature for group' do
+      person = double
+      allow(person).to receive(:flipper_id).and_return(1)
+      allow(person).to receive(:admin?).and_return(true)
+      expect(last_response.status).to eq(200)
+      expect(flipper[:my_feature].enabled?(person)).to be_falsey
+    end
+
+    it 'returns decorated feature with group disabled' do
+      group_gate = json_response['gates'].find { |m| m['name'] == 'group' }
+      expect(group_gate['value']).to eq([])
+    end
+  end
+
+  describe 'non-existent feature' do
+    before do
+      delete '/api/v1/features/my_feature/groups', { name:  'admins' }
+    end
+
+    it  '404s with correct error response when feature does not exist' do
+      expect(last_response.status).to eq(404)
+      expect(json_response).to eq({ 'code' => 1, 'message' => 'Feature not found.', 'more_info' => '' })
+    end
+  end
+
+  describe 'group not registered' do
+    before do
+      flipper[:my_feature].disable
+      delete '/api/v1/features/my_feature/groups', { name: 'admins' }
+    end
+
+    it '404s with correct error response when group not registered' do
+      expect(last_response.status).to eq(404)
+      expect(json_response).to eq({ 'code' => 2, 'message' => 'Group not registered.', 'more_info' => '' })
+    end
+  end
+end

data/spec/flipper/api/v1/actions/percentage_of_actors_gate_spec.rb

@@ -0,0 +1,85 @@
+require 'helper'
+
+RSpec.describe Flipper::Api::V1::Actions::PercentageOfActorsGate do
+  let(:app) { build_api(flipper) }
+
+  describe 'enable' do
+    before do
+      flipper[:my_feature].disable
+      post '/api/v1/features/my_feature/percentage_of_actors', { percentage: '10' }
+    end
+
+    it 'enables gate for feature' do
+      expect(flipper[:my_feature].enabled_gate_names).to include(:percentage_of_actors)
+    end
+
+    it 'returns decorated feature with gate enabled for 10 percent of actors' do
+      gate = json_response['gates'].find { |gate| gate['name'] == 'percentage_of_actors' }
+      expect(gate['value']).to eq(10)
+    end
+
+  end
+
+  describe 'disable' do
+    before do
+      flipper[:my_feature].enable_percentage_of_actors(10)
+      delete '/api/v1/features/my_feature/percentage_of_actors'
+    end
+
+    it 'disables gate for feature' do
+      expect(flipper[:my_feature].enabled_gates).to be_empty
+    end
+
+    it 'returns decorated feature with gate disabled' do
+      gate = json_response['gates'].find { |gate| gate['name'] == 'percentage_of_actors' }
+      expect(gate['value']).to eq(0)
+    end
+  end
+
+  describe 'non-existent feature' do
+    before do
+      delete '/api/v1/features/my_feature/percentage_of_actors'
+    end
+
+    it  '404s with correct error response when feature does not exist' do
+      expect(last_response.status).to eq(404)
+      expect(json_response).to eq({ 'code' => 1, 'message' => 'Feature not found.', 'more_info' => '' })
+    end
+  end
+
+  describe 'out of range parameter percentage parameter' do
+    before do
+      flipper[:my_feature].disable
+      post '/api/v1/features/my_feature/percentage_of_actors', { percentage: '300' }
+    end
+
+    it '422s with correct error response when percentage parameter is invalid' do
+      expect(last_response.status).to eq(422)
+      expect(json_response).to eq({ 'code' => 3, 'message' => 'Percentage must be a positive number less than or equal to 100.', 'more_info' => '' })
+    end
+  end
+
+  describe 'percentage parameter not an integer' do
+    before do
+      flipper[:my_feature].disable
+      post '/api/v1/features/my_feature/percentage_of_actors', { percentage: 'foo' }
+    end
+
+    it '422s with correct error response when percentage parameter is invalid' do
+      expect(last_response.status).to eq(422)
+      expect(json_response).to eq({ 'code' => 3, 'message' => 'Percentage must be a positive number less than or equal to 100.', 'more_info' => '' })
+    end
+  end
+
+  describe 'missing percentage parameter' do
+    before do
+      flipper[:my_feature].disable
+      post '/api/v1/features/my_feature/percentage_of_actors'
+    end
+
+    it '422s with correct error response when percentage parameter is missing' do
+      expect(last_response.status).to eq(422)
+      expect(json_response).to eq({ 'code' => 3, 'message' => 'Percentage must be a positive number less than or equal to 100.', 'more_info' => '' })
+    end
+  end
+end

data/spec/flipper/api/v1/actions/percentage_of_time_gate_spec.rb

@@ -0,0 +1,84 @@
+require 'helper'
+
+RSpec.describe Flipper::Api::V1::Actions::PercentageOfTimeGate do
+  let(:app) { build_api(flipper) }
+
+  describe 'enable' do
+    before do
+      flipper[:my_feature].disable
+      post '/api/v1/features/my_feature/percentage_of_time', { percentage: '10' }
+    end
+
+    it 'enables gate for feature' do
+      expect(flipper[:my_feature].enabled_gate_names).to include(:percentage_of_time)
+    end
+
+    it 'returns decorated feature with gate enabled for 5% of time' do
+      gate = json_response['gates'].find { |gate| gate['name'] == 'percentage_of_time' }
+      expect(gate['value']).to eq(10)
+    end
+  end
+
+  describe 'disable' do
+    before do
+      flipper[:my_feature].enable_percentage_of_time(10)
+      delete '/api/v1/features/my_feature/percentage_of_time'
+    end
+
+    it 'disables gate for feature' do
+      expect(flipper[:my_feature].enabled_gates).to be_empty
+    end
+
+    it 'returns decorated feature with gate disabled' do
+      gate = json_response['gates'].find { |gate| gate['name'] == 'percentage_of_time' }
+      expect(gate['value']).to eq(0)
+    end
+  end
+
+  describe 'non-existent feature' do
+    before do
+      delete '/api/v1/features/my_feature/percentage_of_time'
+    end
+
+    it  '404s with correct error response when feature does not exist' do
+      expect(last_response.status).to eq(404)
+      expect(json_response).to eq({ 'code' => 1, 'message' => 'Feature not found.', 'more_info' => '' })
+    end
+  end
+
+  describe 'out of range parameter percentage parameter' do
+    before do
+      flipper[:my_feature].disable
+      post '/api/v1/features/my_feature/percentage_of_time', { percentage: '300' }
+    end
+
+    it '422s with correct error response when percentage parameter is invalid' do
+      expect(last_response.status).to eq(422)
+      expect(json_response).to eq({ 'code' => 3, 'message' => 'Percentage must be a positive number less than or equal to 100.', 'more_info' => '' })
+    end
+  end
+
+  describe 'percentage parameter not an integer' do
+    before do
+      flipper[:my_feature].disable
+      post '/api/v1/features/my_feature/percentage_of_time', { percentage: 'foo' }
+    end
+
+    it '422s with correct error response when percentage parameter is invalid' do
+      expect(last_response.status).to eq(422)
+      expect(json_response).to eq({ 'code' => 3, 'message' => 'Percentage must be a positive number less than or equal to 100.', 'more_info' => '' })
+    end
+  end
+
+  describe 'missing percentage parameter' do
+    before do
+      flipper[:my_feature].disable
+      post '/api/v1/features/my_feature/percentage_of_time'
+    end
+
+    it '422s with correct error response when percentage parameter is missing' do
+      expect(last_response.status).to eq(422)
+      expect(json_response).to eq({ 'code' => 3, 'message' => 'Percentage must be a positive number less than or equal to 100.', 'more_info' => '' })
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-api
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.10.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-22 00:00:00.000000000 Z
+date: 2016-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 0.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 0.10.0
 description: Rack middleware that provides an API for the flipper gem.
 email:
 - nunemaker@gmail.com
@@ -56,18 +56,28 @@ files:
 - lib/flipper/api.rb
 - lib/flipper/api/action.rb
 - lib/flipper/api/action_collection.rb
+- lib/flipper/api/actor.rb
 - lib/flipper/api/error.rb
+- lib/flipper/api/error_response.rb
 - lib/flipper/api/middleware.rb
+- lib/flipper/api/v1/actions/actors_gate.rb
 - lib/flipper/api/v1/actions/boolean_gate.rb
 - lib/flipper/api/v1/actions/feature.rb
 - lib/flipper/api/v1/actions/features.rb
+- lib/flipper/api/v1/actions/groups_gate.rb
+- lib/flipper/api/v1/actions/percentage_of_actors_gate.rb
+- lib/flipper/api/v1/actions/percentage_of_time_gate.rb
 - lib/flipper/api/v1/decorators/feature.rb
 - lib/flipper/api/v1/decorators/gate.rb
 - lib/flipper/version.rb
 - spec/flipper/api/action_spec.rb
+- spec/flipper/api/v1/actions/actors_gate_spec.rb
 - spec/flipper/api/v1/actions/boolean_gate_spec.rb
 - spec/flipper/api/v1/actions/feature_spec.rb
 - spec/flipper/api/v1/actions/features_spec.rb
+- spec/flipper/api/v1/actions/groups_gate_spec.rb
+- spec/flipper/api/v1/actions/percentage_of_actors_gate_spec.rb
+- spec/flipper/api/v1/actions/percentage_of_time_gate_spec.rb
 homepage: https://github.com/jnunemaker/flipper
 licenses:
 - MIT
@@ -94,6 +104,10 @@ specification_version: 4
 summary: API for the Flipper gem
 test_files:
 - spec/flipper/api/action_spec.rb
+- spec/flipper/api/v1/actions/actors_gate_spec.rb
 - spec/flipper/api/v1/actions/boolean_gate_spec.rb
 - spec/flipper/api/v1/actions/feature_spec.rb
 - spec/flipper/api/v1/actions/features_spec.rb
+- spec/flipper/api/v1/actions/groups_gate_spec.rb
+- spec/flipper/api/v1/actions/percentage_of_actors_gate_spec.rb
+- spec/flipper/api/v1/actions/percentage_of_time_gate_spec.rb