flipper-api 0.21.0 → 0.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e44a0aba5ffc0b448f66a49335a97100d0d7aa25f69823d65df4a2742ef63171
-  data.tar.gz: 274e4eb1ba9885b67e7e9dbba8ee8015159d213dc613888e053e6c404b713237
+  metadata.gz: c88c8fcf2cad7d28ac9a1c968cb4afa798006f34aef33ee0fbf4c47da64275e8
+  data.tar.gz: 5395ef9526ad46564c569d2fdc0f0f58376f5a4956fdb2929c9454b6e3e4d26e
 SHA512:
-  metadata.gz: f20d11dc71866738074a3b6465c4082314a4caaf85cced364dba3210cd5ae4d62805ed3f0596a189dbfd41b357b96ed0f3e159527fde2c7618bc2b3825cbcbc3
-  data.tar.gz: 5c0d32e915b77887ce01e783a84151de21e15ad339b6c27778cc985a6d87a5c4573e05573a40495a553b08ab79062b2a77714edc9ffe5eaba4e0491409241a98
+  metadata.gz: d5eb1d1990347809c8383465585ba4926bb622c600870bd382bab3341028202e372311f63fd39f18b506172913e5b3ca7a93f456bfe9438e001da67efe9c5f36
+  data.tar.gz: 31316d4c9e04cf706ace8290733102c313053e571c497a4eac5a9bddbb32367dc60ca9a75d6e25245604ce6b7c983b84c9e00bc1fda9219031b1749b7e2561c8

data/lib/flipper/api/error_response.rb

@@ -8,7 +8,7 @@ module Flipper
           @code = code
           @message = message
           @more_info =
-            'https://github.com/jnunemaker/flipper/tree/master/docs/api#error-code-reference'
+            'https://flippercloud.io/docs/api#error-code-reference'
           @http_status = http_status
         end
 

data/lib/flipper/api/middleware.rb

@@ -32,10 +32,11 @@ module Flipper
       def call!(env)
         request = Rack::Request.new(env)
         action_class = @action_collection.action_for_request(request)
+
         if action_class.nil?
           @app.call(env)
         else
-          flipper = env.fetch(@env_key)
+          flipper = env.fetch(@env_key) { Flipper }
           action_class.run(flipper, request)
         end
       end

data/lib/flipper/api.rb

@@ -9,14 +9,11 @@ module Flipper
 
     def self.app(flipper = nil, options = {})
       env_key = options.fetch(:env_key, 'flipper')
-      memoizer_options = options.fetch(:memoizer_options, {})
-
       app = ->(_) { [404, { 'Content-Type'.freeze => CONTENT_TYPE }, ['{}'.freeze]] }
       builder = Rack::Builder.new
       yield builder if block_given?
       builder.use Flipper::Api::JsonParams
       builder.use Flipper::Middleware::SetupEnv, flipper, env_key: env_key
-      builder.use Flipper::Middleware::Memoizer, memoizer_options.merge(env_key: env_key)
       builder.use Flipper::Api::Middleware, env_key: env_key
       builder.run app
       klass = self

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.21.0'.freeze
+  VERSION = '0.23.0'.freeze
 end

data/spec/flipper/api/action_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::Action do
   let(:action_subclass) do
     Class.new(described_class) do

data/spec/flipper/api/json_params_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::JsonParams do
   let(:app) do
     app = lambda do |env|

data/spec/flipper/api/v1/actions/actors_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::ActorsGate do
   let(:app) { build_api(flipper) }
   let(:actor) { Flipper::Actor.new('1') }
@@ -44,7 +42,7 @@ RSpec.describe Flipper::Api::V1::Actions::ActorsGate do
 
   describe 'enable feature with slash in name' do
     before do
-      flipper[:my_feature].disable_actor(actor)
+      flipper["my/feature"].disable_actor(actor)
       post '/features/my/feature/actors', flipper_id: actor.flipper_id
     end
 
@@ -60,6 +58,24 @@ RSpec.describe Flipper::Api::V1::Actions::ActorsGate do
     end
   end
 
+  describe 'enable feature with space in name' do
+    before do
+      flipper["sp ace"].disable_actor(actor)
+      post '/features/sp%20ace/actors', flipper_id: actor.flipper_id
+    end
+
+    it 'enables feature for actor' do
+      expect(last_response.status).to eq(200)
+      expect(flipper["sp ace"].enabled?(actor)).to be_truthy
+      expect(flipper["sp ace"].enabled_gate_names).to eq([:actor])
+    end
+
+    it 'returns decorated feature with actor enabled' do
+      gate = json_response['gates'].find { |gate| gate['key'] == 'actors' }
+      expect(gate['value']).to eq(['1'])
+    end
+  end
+
   describe 'enable missing flipper_id parameter' do
     before do
       flipper[:my_feature].enable

data/spec/flipper/api/v1/actions/actors_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::Actors do
   let(:app) { build_api(flipper) }
   let(:actor) { Flipper::Actor.new('User123') }

data/spec/flipper/api/v1/actions/boolean_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::BooleanGate do
   let(:app) { build_api(flipper) }
 

data/spec/flipper/api/v1/actions/clear_feature_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::ClearFeature do
   let(:app) { build_api(flipper) }
 

data/spec/flipper/api/v1/actions/feature_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::Feature do
   let(:app) { build_api(flipper) }
   let(:feature) { build_feature }

data/spec/flipper/api/v1/actions/features_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::Features do
   let(:app) { build_api(flipper) }
   let(:feature) { build_feature }

data/spec/flipper/api/v1/actions/groups_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::GroupsGate do
   let(:app) { build_api(flipper) }
 

data/spec/flipper/api/v1/actions/percentage_of_actors_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::PercentageOfActorsGate do
   let(:app) { build_api(flipper) }
 

data/spec/flipper/api/v1/actions/percentage_of_time_gate_spec.rb

@@ -1,5 +1,3 @@
-require 'helper'
-
 RSpec.describe Flipper::Api::V1::Actions::PercentageOfTimeGate do
   let(:app) { build_api(flipper) }
 

data/spec/flipper/api_spec.rb

@@ -1,6 +1,34 @@
-require 'helper'
-
 RSpec.describe Flipper::Api do
+  describe 'Initializing middleware with flipper instance' do
+    let(:app) { build_api(flipper) }
+
+    it 'works' do
+      flipper.enable :a
+      flipper.disable :b
+
+      get '/features'
+
+      expect(last_response.status).to be(200)
+      feature_names = json_response.fetch('features').map { |feature| feature.fetch('key') }
+      expect(feature_names).to eq(%w(a b))
+    end
+  end
+
+  describe 'Initializing middleware lazily with a block' do
+    let(:app) { build_api(-> { flipper }) }
+
+    it 'works' do
+      flipper.enable :a
+      flipper.disable :b
+
+      get '/features'
+
+      expect(last_response.status).to be(200)
+      feature_names = json_response.fetch('features').map { |feature| feature.fetch('key') }
+      expect(feature_names).to eq(%w(a b))
+    end
+  end
+
   context 'when initialized with flipper instance and flipper instance in env' do
     let(:app) { build_api(flipper) }
 
@@ -76,4 +104,10 @@ RSpec.describe Flipper::Api do
       expect(json_response).to eq({})
     end
   end
+
+  describe 'Inspecting the built Rack app' do
+    it 'returns a String' do
+      expect(build_api(flipper).inspect).to be_a(String)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-api
 version: !ruby/object:Gem::Version
-  version: 0.21.0
+  version: 0.23.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-09 00:00:00.000000000 Z
+date: 2021-12-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.21.0
+        version: 0.23.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.21.0
+        version: 0.23.0
 description: 
 email:
 - nunemaker@gmail.com
@@ -105,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: API for the Flipper gem