flipper-api 0.20.3 → 0.20.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cddd925172819bb8de72eb02d85ee014bd170fb0bfd0b4e071eabeedb162911f
-  data.tar.gz: 6be5a9daf2461963d9b14b5c2f3edab6102e4c69f6952ca13168d53690701131
+  metadata.gz: a40863332ca45acc5a6a715634982928ad4e7b824ea10483c391cfaea36cd6b8
+  data.tar.gz: ad9f03047543318357d4fdc16126906517d2cb06a07a95bc31659ad12eae5f1a
 SHA512:
-  metadata.gz: e749a826aae5fa8c9e9942e828f77eb738d62788a646637bb5c46723a85f8444cf760b8630bbcf562bed90121ca43f488d1b45f9575f67db3cac995ea96b3427
-  data.tar.gz: 978a81bbab7f4d5bb2dc1cb5004c0328e7d379f23f6dddd7a60762f5a7ee69b54c860aa70539271a2e66e219a16de55ac1173d0ba593a632d16570627b775a19
+  metadata.gz: 71cddf631f88df621174a9999b2707083c8b107fa7d05721112a01b07cf1c72e7dfa73d6c19d2823a8e0035e27494380caf0da3288cb01e2d2fac870a8f1703d
+  data.tar.gz: '092823278f7f9ff4ea8a33252b6ba7739b0ae7cc56a1674f4955fd36561cd662934157c66b5f269d0c897eb6049aa09775a8fb8023fb1fc350b92c3580d92852'

data/lib/flipper/api/v1/actions/percentage_of_actors_gate.rb

@@ -30,9 +30,17 @@ module Flipper
 
           private
 
+          def percentage_param
+            @percentage_param ||= params['percentage'].to_s
+          end
+
           def percentage
             @percentage ||= begin
-              Integer(params['percentage'])
+              unless percentage_param.match(/\d/)
+                raise ArgumentError, "invalid numeric value: #{percentage_param}"
+              end
+
+              Flipper::Types::Percentage.new(percentage_param).value
             rescue ArgumentError, TypeError
               -1
             end

data/lib/flipper/api/v1/actions/percentage_of_time_gate.rb

@@ -31,9 +31,17 @@ module Flipper
 
           private
 
+          def percentage_param
+            @percentage_param ||= params['percentage'].to_s
+          end
+
           def percentage
             @percentage ||= begin
-              Integer(params['percentage'])
+              unless percentage_param.match(/\d/)
+                raise ArgumentError, "invalid numeric value: #{percentage_param}"
+              end
+
+              Flipper::Types::Percentage.new(percentage_param).value
             rescue ArgumentError, TypeError
               -1
             end

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.20.3'.freeze
+  VERSION = '0.20.4'.freeze
 end

data/spec/flipper/api/v1/actions/percentage_of_actors_gate_spec.rb

@@ -4,53 +4,79 @@ RSpec.describe Flipper::Api::V1::Actions::PercentageOfActorsGate do
   let(:app) { build_api(flipper) }
 
   describe 'enable' do
+    shared_examples 'gates with percentage' do
+      it 'enables gate for feature' do
+        expect(flipper[path].enabled_gate_names).to include(:percentage_of_actors)
+      end
+
+      it 'returns decorated feature with gate enabled for a percent of actors' do
+        gate = json_response['gates'].find { |gate| gate['name'] == 'percentage_of_actors' }
+        expect(gate['value']).to eq(percentage)
+      end
+    end
+
     context 'for feature with slash in name' do
+      let(:path) { 'my/feature' }
+
       before do
-        flipper["my/feature"].disable
-        post '/features/my/feature/percentage_of_actors', percentage: '10'
+        flipper[path].disable
+        post "/features/#{path}/percentage_of_actors", percentage: percentage
       end
 
-      it 'enables gate for feature' do
-        expect(flipper["my/feature"].enabled_gate_names).to include(:percentage_of_actors)
+      context 'with integer percentage' do
+        let(:percentage) { '10' }
+
+        it_behaves_like 'gates with percentage'
       end
 
-      it 'returns decorated feature with gate enabled for 10 percent of actors' do
-        gate = json_response['gates'].find { |gate| gate['name'] == 'percentage_of_actors' }
-        expect(gate['value']).to eq('10')
+      context 'with decimal percentage' do
+        let(:percentage) { '0.05' }
+
+        it_behaves_like 'gates with percentage'
       end
     end
 
     context 'url-encoded request' do
+      let(:path) { :my_feature }
+
       before do
         flipper[:my_feature].disable
-        post '/features/my_feature/percentage_of_actors', percentage: '10'
+        post "/features/#{path}/percentage_of_actors", percentage: percentage
       end
 
-      it 'enables gate for feature' do
-        expect(flipper[:my_feature].enabled_gate_names).to include(:percentage_of_actors)
+      context 'with integer percentage' do
+        let(:percentage) { '10' }
+
+        it_behaves_like 'gates with percentage'
       end
 
-      it 'returns decorated feature with gate enabled for 10 percent of actors' do
-        gate = json_response['gates'].find { |gate| gate['name'] == 'percentage_of_actors' }
-        expect(gate['value']).to eq('10')
+      context 'with decimal percentage' do
+        let(:percentage) { '0.05' }
+
+        it_behaves_like 'gates with percentage'
       end
     end
 
     context 'json request' do
+      let(:path) { :my_feature }
+
       before do
         flipper[:my_feature].disable
-        post '/features/my_feature/percentage_of_actors',
-             JSON.generate(percentage: '10'),
+        post "/features/#{path}/percentage_of_actors",
+             JSON.generate(percentage: percentage),
              'CONTENT_TYPE' => 'application/json'
       end
 
-      it 'enables gate for feature' do
-        expect(flipper[:my_feature].enabled_gate_names).to include(:percentage_of_actors)
+      context 'with integer percentage' do
+        let(:percentage) { '10' }
+
+        it_behaves_like 'gates with percentage'
       end
 
-      it 'returns decorated feature with gate enabled for 10 percent of actors' do
-        gate = json_response['gates'].find { |gate| gate['name'] == 'percentage_of_actors' }
-        expect(gate['value']).to eq('10')
+      context 'with decimal percentage' do
+        let(:percentage) { '0.05' }
+
+        it_behaves_like 'gates with percentage'
       end
     end
   end
@@ -113,7 +139,7 @@ RSpec.describe Flipper::Api::V1::Actions::PercentageOfActorsGate do
     end
   end
 
-  describe 'percentage parameter not an integer' do
+  describe 'percentage parameter not a number' do
     before do
       flipper[:my_feature].disable
       post '/features/my_feature/percentage_of_actors', percentage: 'foo'

data/spec/flipper/api/v1/actions/percentage_of_time_gate_spec.rb

@@ -4,34 +4,80 @@ RSpec.describe Flipper::Api::V1::Actions::PercentageOfTimeGate do
   let(:app) { build_api(flipper) }
 
   describe 'enable' do
-    before do
-      flipper[:my_feature].disable
-      post '/features/my_feature/percentage_of_time', percentage: '10'
-    end
+    shared_examples 'gates with percentage' do
+      it 'enables gate for feature' do
+        expect(flipper[path].enabled_gate_names).to include(:percentage_of_time)
+      end
 
-    it 'enables gate for feature' do
-      expect(flipper[:my_feature].enabled_gate_names).to include(:percentage_of_time)
+      it 'returns decorated feature with gate enabled for a percent of times' do
+        gate = json_response['gates'].find { |gate| gate['name'] == 'percentage_of_time' }
+        expect(gate['value']).to eq(percentage)
+      end
     end
 
-    it 'returns decorated feature with gate enabled for 5% of time' do
-      gate = json_response['gates'].find { |gate| gate['name'] == 'percentage_of_time' }
-      expect(gate['value']).to eq('10')
-    end
-  end
+    context 'for feature with slash in name' do
+      let(:path) { 'my/feature' }
 
-  describe 'enable for feature with slash in name' do
-    before do
-      flipper["my/feature"].disable
-      post '/features/my/feature/percentage_of_time', percentage: '10'
+      before do
+        flipper[path].disable
+        post "/features/#{path}/percentage_of_time", percentage: percentage
+      end
+
+      context 'with integer percentage' do
+        let(:percentage) { '10' }
+
+        it_behaves_like 'gates with percentage'
+      end
+
+      context 'with decimal percentage' do
+        let(:percentage) { '0.05' }
+
+        it_behaves_like 'gates with percentage'
+      end
     end
 
-    it 'enables gate for feature' do
-      expect(flipper["my/feature"].enabled_gate_names).to include(:percentage_of_time)
+    context 'url-encoded request' do
+      let(:path) { :my_feature }
+
+      before do
+        flipper[:my_feature].disable
+        post "/features/#{path}/percentage_of_time", percentage: percentage
+      end
+
+      context 'with integer percentage' do
+        let(:percentage) { '10' }
+
+        it_behaves_like 'gates with percentage'
+      end
+
+      context 'with decimal percentage' do
+        let(:percentage) { '0.05' }
+
+        it_behaves_like 'gates with percentage'
+      end
     end
 
-    it 'returns decorated feature with gate enabled for 5% of time' do
-      gate = json_response['gates'].find { |gate| gate['name'] == 'percentage_of_time' }
-      expect(gate['value']).to eq('10')
+    context 'json request' do
+      let(:path) { :my_feature }
+
+      before do
+        flipper[:my_feature].disable
+        post "/features/#{path}/percentage_of_time",
+             JSON.generate(percentage: percentage),
+             'CONTENT_TYPE' => 'application/json'
+      end
+
+      context 'with integer percentage' do
+        let(:percentage) { '10' }
+
+        it_behaves_like 'gates with percentage'
+      end
+
+      context 'with decimal percentage' do
+        let(:percentage) { '0.05' }
+
+        it_behaves_like 'gates with percentage'
+      end
     end
   end
 
@@ -93,7 +139,7 @@ RSpec.describe Flipper::Api::V1::Actions::PercentageOfTimeGate do
     end
   end
 
-  describe 'percentage parameter not an integer' do
+  describe 'percentage parameter not an number' do
     before do
       flipper[:my_feature].disable
       post '/features/my_feature/percentage_of_time', percentage: 'foo'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-api
 version: !ruby/object:Gem::Version
-  version: 0.20.3
+  version: 0.20.4
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-10 00:00:00.000000000 Z
+date: 2021-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.20.3
+        version: 0.20.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.20.3
+        version: 0.20.4
 description: 
 email:
 - nunemaker@gmail.com