flipper-active_support_cache_store 1.3.5 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 356c52f80f850af9e58db4ffb2fc51975e10480ed7fa8ab1a1aa6a7841259fae
-  data.tar.gz: d371916168473712352d6741495c4d4b2a13c64ec950bd4cfe84085eb3fc9497
+  metadata.gz: f24ef2d4b542a165ec1c70ec7e52c28f7fd666f3a8c5b7c58ddd79d1cbedaad7
+  data.tar.gz: d7aa239fa34e287564fadded1ecd86e502f9a2efa6f6e76620838ddfda6f93c7
 SHA512:
-  metadata.gz: e9a31f234074b60d3af10c5c56d38e7c5c435e994cb713aed8b3db0045424461b61684598d814e46ab5f48c0992da1c43ead88bb9eb062fdb683d315911b8e4d
-  data.tar.gz: 9f0952d9b947c523c0c9e4b1fc1c2ceecb09951aa63948b0b73aa8eef9856690bcca5b878841c211515593b74b91b2e54550322387dc65f1846cebcfb2a90abf
+  metadata.gz: e5c6170f5a3cfc6d2bf352aa68cdb43088a9a18189ce63b196493367e24e029c16c6636bc5c896c01070587762333073f27240411a692c05f16dfc8de894ede9
+  data.tar.gz: 0f24fa65c8075ad1f66abc716f0c82490869e91a81dff0840778b7647812e4e7df621784720aff8534734dc0343f39f81df2f055b28d1e081d98070cb0daf969

data/lib/flipper/adapters/active_support_cache_store.rb

@@ -7,7 +7,11 @@ module Flipper
     # Public: Adapter that wraps another adapter with the ability to cache
     # adapter calls in ActiveSupport::ActiveSupportCacheStore caches.
     class ActiveSupportCacheStore < CacheBase
-      def initialize(adapter, cache, ttl = nil, expires_in: :none_provided, write_through: false, prefix: nil)
+
+      # Public: The race_condition_ttl for all cached data.
+      attr_reader :race_condition_ttl
+
+      def initialize(adapter, cache, ttl = nil, expires_in: :none_provided, race_condition_ttl: nil, write_through: false, prefix: nil)
         if expires_in == :none_provided
           ttl ||= nil
         else
@@ -18,6 +22,7 @@ module Flipper
           ttl = expires_in
         end
         super(adapter, cache, ttl, prefix: prefix)
+        @race_condition_ttl = race_condition_ttl
         @write_through = write_through
       end
 
@@ -36,6 +41,7 @@ module Flipper
         if @write_through
           result = @adapter.enable(feature, gate, thing)
           cache_write feature_cache_key(feature.key), @adapter.get(feature)
+          expire_get_all_cache
           result
         else
           super
@@ -46,6 +52,7 @@ module Flipper
         if @write_through
           result = @adapter.disable(feature, gate, thing)
           cache_write feature_cache_key(feature.key), @adapter.get(feature)
+          expire_get_all_cache
           result
         else
           super
@@ -73,6 +80,7 @@ module Flipper
       def write_options
         write_options = {}
         write_options[:expires_in] = @ttl if @ttl
+        write_options[:race_condition_ttl] if @race_condition_ttl
         write_options
       end
     end

data/lib/flipper/version.rb

@@ -1,5 +1,5 @@
 module Flipper
-  VERSION = '1.3.5'.freeze
+  VERSION = '1.4.0'.freeze
 
   REQUIRED_RUBY_VERSION = '2.6'.freeze
   NEXT_REQUIRED_RUBY_VERSION = '3.0'.freeze

data/spec/flipper/adapters/active_support_cache_store_spec.rb

@@ -8,7 +8,8 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
   end
   let(:cache) { ActiveSupport::Cache::MemoryStore.new }
   let(:write_through) { false }
-  let(:adapter) { described_class.new(memory_adapter, cache, 10, write_through: write_through) }
+  let(:race_condition_ttl) { 5 }
+  let(:adapter) { described_class.new(memory_adapter, cache, 10, race_condition_ttl: race_condition_ttl, write_through: write_through) }
   let(:flipper) { Flipper.new(adapter) }
 
   subject { adapter }
@@ -42,6 +43,15 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
     expect(adapter.ttl).to be(nil)
   end
 
+  it "knows race_condition_ttl" do
+    expect(adapter.race_condition_ttl).to eq(race_condition_ttl)
+  end
+
+  it "knows default when no ttl or expires_in provided" do
+    adapter = described_class.new(memory_adapter, cache)
+    expect(adapter.race_condition_ttl).to be(nil)
+  end
+
   it "knows features_cache_key" do
     expect(adapter.features_cache_key).to eq("flipper/v1/features")
   end
@@ -51,9 +61,13 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
     adapter.features
     expect(cache.read("flipper/v1/features")).not_to be(nil)
 
+    adapter.get_all
+    expect(cache.read("flipper/v1/get_all")).not_to be(nil)
+
     # expire cache
     adapter.expire_features_cache
     expect(cache.read("flipper/v1/features")).to be(nil)
+    expect(cache.read("flipper/v1/get_all")).to be(nil)
   end
 
   it "can expire feature cache" do
@@ -61,9 +75,13 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
     adapter.get(flipper[:stats])
     expect(cache.read("flipper/v1/feature/stats")).not_to be(nil)
 
+    adapter.get_all
+    expect(cache.read("flipper/v1/get_all")).not_to be(nil)
+
     # expire cache
     adapter.expire_feature_cache("stats")
     expect(cache.read("flipper/v1/feature/stats")).to be(nil)
+    expect(cache.read("flipper/v1/get_all")).to be(nil)
   end
 
   it "can generate feature cache key" do
@@ -78,6 +96,10 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
       expect(adapter.features_cache_key).to eq("foo/flipper/v1/features")
     end
 
+    it "knows get_all_cache_key" do
+      expect(adapter.get_all_cache_key).to eq("foo/flipper/v1/get_all")
+    end
+
     it "can generate feature cache key" do
       expect(adapter.feature_cache_key("stats")).to eq("foo/flipper/v1/feature/stats")
     end
@@ -99,9 +121,10 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
       adapter.get_all
 
       # verify cached with prefix
+      get_all_cache_value = cache.read("foo/flipper/v1/get_all")
       expect(cache.read("foo/flipper/v1/features")).to eq(Set["stats", "search"])
-      expect(cache.read("foo/flipper/v1/feature/search")[:percentage_of_actors]).to eq("10")
-      expect(cache.read("foo/flipper/v1/feature/stats")[:boolean]).to eq("true")
+      expect(get_all_cache_value["search"][:percentage_of_actors]).to eq("10")
+      expect(get_all_cache_value["stats"][:boolean]).to eq("true")
     end
   end
 
@@ -110,11 +133,13 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
 
     before do
       adapter.get(feature)
+      adapter.get_all
       adapter.remove(feature)
     end
 
     it 'expires feature and deletes the cache' do
       expect(cache.read("flipper/v1/feature/#{feature.key}")).to be_nil
+      expect(cache.read("flipper/v1/get_all")).to be(nil)
       expect(cache.exist?("flipper/v1/feature/#{feature.key}")).to be(false)
       expect(feature).not_to be_enabled
     end
@@ -134,10 +159,13 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
     let(:feature) { flipper[:stats] }
 
     before do
+      adapter.get(feature)
+      adapter.get_all
       adapter.enable(feature, feature.gate(:boolean), Flipper::Types::Boolean.new(true))
     end
 
     it 'enables feature and deletes the cache' do
+      expect(cache.read("flipper/v1/get_all")).to be(nil)
       expect(cache.read("flipper/v1/feature/#{feature.key}")).to be_nil
       expect(cache.exist?("flipper/v1/feature/#{feature.key}")).to be(false)
       expect(feature).to be_enabled
@@ -147,6 +175,7 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
       let(:write_through) { true }
 
       it 'expires feature and writes to the cache' do
+        expect(cache.read("flipper/v1/get_all")).to be(nil)
         expect(cache.exist?("flipper/v1/feature/#{feature.key}")).to be(true)
         expect(cache.read("flipper/v1/feature/#{feature.key}")).to include(boolean: 'true')
         expect(feature).to be_enabled
@@ -158,10 +187,13 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
     let(:feature) { flipper[:stats] }
 
     before do
+      adapter.get(feature)
+      adapter.get_all
       adapter.disable(feature, feature.gate(:boolean), Flipper::Types::Boolean.new)
     end
 
     it 'disables feature and deletes the cache' do
+      expect(cache.read("flipper/v1/get_all")).to be(nil)
       expect(cache.read("flipper/v1/feature/#{feature.key}")).to be_nil
       expect(cache.exist?("flipper/v1/feature/#{feature.key}")).to be(false)
       expect(feature).not_to be_enabled
@@ -214,8 +246,10 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
 
     it 'warms all features' do
       adapter.get_all
-      expect(cache.read("flipper/v1/feature/#{stats.key}")[:boolean]).to eq('true')
-      expect(cache.read("flipper/v1/feature/#{search.key}")[:boolean]).to be(nil)
+      get_all_cache_value = cache.read("flipper/v1/get_all")
+      expect(get_all_cache_value).not_to be(nil)
+      expect(get_all_cache_value["stats"][:boolean]).to eq('true')
+      expect(get_all_cache_value["search"][:boolean]).to be(nil)
       expect(cache.read("flipper/v1/features")).to eq(Set["stats", "search"])
     end
 
@@ -226,9 +260,8 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
     it 'only invokes two calls to wrapped adapter (for features set and gate data for each feature in set)' do
       memory_adapter.reset
       5.times { adapter.get_all }
-      expect(memory_adapter.count(:features)).to eq(1)
-      expect(memory_adapter.count(:get_multi)).to eq(1)
-      expect(memory_adapter.count).to eq(2)
+      expect(memory_adapter.count(:get_all)).to eq(1)
+      expect(memory_adapter.count).to eq(1)
     end
   end
 

metadata

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-active_support_cache_store
 version: !ruby/object:Gem::Version
-  version: 1.3.5
+  version: 1.4.0
 platform: ruby
 authors:
 - John Nunemaker
+autorequire:
 bindir: bin
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2026-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
@@ -15,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.5
+        version: 1.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.5
+        version: 1.4.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -43,6 +44,7 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '9'
+description:
 email: support@flippercloud.io
 executables: []
 extensions: []
@@ -61,8 +63,9 @@ metadata:
   homepage_uri: https://www.flippercloud.io
   source_code_uri: https://github.com/flippercloud/flipper
   bug_tracker_uri: https://github.com/flippercloud/flipper/issues
-  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.3.5
+  changelog_uri: https://github.com/flippercloud/flipper/releases/tag/v1.4.0
   funding_uri: https://github.com/sponsors/flippercloud
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -77,8 +80,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.5.22
+signing_key:
 specification_version: 4
 summary: ActiveSupport::Cache feature flag cache adapter for Flipper
-test_files:
-- spec/flipper/adapters/active_support_cache_store_spec.rb
+test_files: []