flipper-active_support_cache_store 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4af9c24a757e7b8a54a0aeb46b2ab060e7800c8d8c38c90daff37b046a0c3a13
-  data.tar.gz: dadc9bba7b9be524803b436548dd4cb1e67dac3ee3b8ea1b6f3bc53c58ebd980
+  metadata.gz: a0ef54c96a5931fdee8bdeedffa0e6eee6f66c0163a463a0286157a2b3be9ddc
+  data.tar.gz: fa00f5dbcf917275ef8f675396487e1d5404f85b5c884de7aed9f3d15d3228d4
 SHA512:
-  metadata.gz: 05f3321be57b5faf88b94bdde97c04d6716524b87947661a989d51c840f1437f8ba75e68ba86828bd582d66de4c3bf612e18dbaef72a7baef37cb92a2e0edcbd
-  data.tar.gz: 22e35550741299a38bba9867baec0915b293d5b93f78a4dba1696c374d8c87390c5a71ebb2b3f558dba2a72bf7c30b31c39125ae23f28e6dee23bdb7af94ff42
+  metadata.gz: a150b0fc8ab3366f832c77388eaf2e70e3ac11576e19f77c7c8fe7212113a9c9393399c5cd1abe2d4ee81a0156033202a2ed42412981d0fbe96dbedc345870c5
+  data.tar.gz: 739e96d8c2d3558a90a58eca3520f1654ddf91343f0202fc764ed1dcfbf968d56179549ec10374fdfd29320f7541df283552234cec41613df5213fe03653cc65

data/lib/flipper/adapters/active_support_cache_store.rb

@@ -9,30 +9,21 @@ module Flipper
     class ActiveSupportCacheStore
       include ::Flipper::Adapter
 
-      Version = 'v1'.freeze
-      Namespace = "flipper/#{Version}".freeze
-      FeaturesKey = "#{Namespace}/features".freeze
-      GetAllKey = "#{Namespace}/get_all".freeze
-
-      # Private
-      def self.key_for(key)
-        "#{Namespace}/feature/#{key}"
-      end
-
       # Internal
       attr_reader :cache
 
-      # Public: The name of the adapter.
-      attr_reader :name
-
       # Public
       def initialize(adapter, cache, expires_in: nil, write_through: false)
         @adapter = adapter
-        @name = :active_support_cache_store
         @cache = cache
         @write_options = {}
         @write_options[:expires_in] = expires_in if expires_in
         @write_through = write_through
+
+        @cache_version = 'v1'.freeze
+        @namespace = "flipper/#{@cache_version}".freeze
+        @features_key = "#{@namespace}/features".freeze
+        @get_all_key = "#{@namespace}/get_all".freeze
       end
 
       # Public
@@ -43,14 +34,14 @@ module Flipper
       # Public
       def add(feature)
         result = @adapter.add(feature)
-        @cache.delete(FeaturesKey)
+        @cache.delete(@features_key)
         result
       end
 
       ## Public
       def remove(feature)
         result = @adapter.remove(feature)
-        @cache.delete(FeaturesKey)
+        @cache.delete(@features_key)
 
         if @write_through
           @cache.write(key_for(feature.key), default_config, @write_options)
@@ -80,12 +71,12 @@ module Flipper
       end
 
       def get_all
-        if @cache.write(GetAllKey, Time.now.to_i, @write_options.merge(unless_exist: true))
+        if @cache.write(@get_all_key, Time.now.to_i, @write_options.merge(unless_exist: true))
           response = @adapter.get_all
           response.each do |key, value|
             @cache.write(key_for(key), value, @write_options)
           end
-          @cache.write(FeaturesKey, response.keys.to_set, @write_options)
+          @cache.write(@features_key, response.keys.to_set, @write_options)
           response
         else
           features = read_feature_keys.map { |key| Flipper::Feature.new(key, self) }
@@ -122,12 +113,12 @@ module Flipper
       private
 
       def key_for(key)
-        self.class.key_for(key)
+        "#{@namespace}/feature/#{key}"
       end
 
       # Internal: Returns an array of the known feature keys.
       def read_feature_keys
-        @cache.fetch(FeaturesKey, @write_options) { @adapter.features }
+        @cache.fetch(@features_key, @write_options) { @adapter.features }
       end
 
       # Internal: Given an array of features, attempts to read through cache in

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '1.0.0'.freeze
+  VERSION = '1.1.0'.freeze
 end

data/spec/flipper/adapters/active_support_cache_store_spec.rb

@@ -28,8 +28,8 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
     end
 
     it 'expires feature and deletes the cache' do
-      expect(cache.read(described_class.key_for(feature))).to be_nil
-      expect(cache.exist?(described_class.key_for(feature))).to be(false)
+      expect(cache.read("flipper/v1/feature/#{feature.key}")).to be_nil
+      expect(cache.exist?("flipper/v1/feature/#{feature.key}")).to be(false)
       expect(feature).not_to be_enabled
     end
 
@@ -37,8 +37,8 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
       let(:write_through) { true }
 
       it 'expires feature and writes an empty value to the cache' do
-        expect(cache.read(described_class.key_for(feature))).to eq(adapter.default_config)
-        expect(cache.exist?(described_class.key_for(feature))).to be(true)
+        expect(cache.read("flipper/v1/feature/#{feature.key}")).to eq(adapter.default_config)
+        expect(cache.exist?("flipper/v1/feature/#{feature.key}")).to be(true)
         expect(feature).not_to be_enabled
       end
     end
@@ -52,8 +52,8 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
     end
 
     it 'enables feature and deletes the cache' do
-      expect(cache.read(described_class.key_for(feature))).to be_nil
-      expect(cache.exist?(described_class.key_for(feature))).to be(false)
+      expect(cache.read("flipper/v1/feature/#{feature.key}")).to be_nil
+      expect(cache.exist?("flipper/v1/feature/#{feature.key}")).to be(false)
       expect(feature).to be_enabled
     end
 
@@ -61,8 +61,8 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
       let(:write_through) { true }
 
       it 'expires feature and writes to the cache' do
-        expect(cache.exist?(described_class.key_for(feature))).to be(true)
-        expect(cache.read(described_class.key_for(feature))).to include(boolean: 'true')
+        expect(cache.exist?("flipper/v1/feature/#{feature.key}")).to be(true)
+        expect(cache.read("flipper/v1/feature/#{feature.key}")).to include(boolean: 'true')
         expect(feature).to be_enabled
       end
     end
@@ -76,8 +76,8 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
     end
 
     it 'disables feature and deletes the cache' do
-      expect(cache.read(described_class.key_for(feature))).to be_nil
-      expect(cache.exist?(described_class.key_for(feature))).to be(false)
+      expect(cache.read("flipper/v1/feature/#{feature.key}")).to be_nil
+      expect(cache.exist?("flipper/v1/feature/#{feature.key}")).to be(false)
       expect(feature).not_to be_enabled
     end
 
@@ -85,8 +85,8 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
       let(:write_through) { true }
 
       it 'expires feature and writes to the cache' do
-        expect(cache.exist?(described_class.key_for(feature))).to be(true)
-        expect(cache.read(described_class.key_for(feature))).to include(boolean: nil)
+        expect(cache.exist?("flipper/v1/feature/#{feature.key}")).to be(true)
+        expect(cache.read("flipper/v1/feature/#{feature.key}")).to include(boolean: nil)
         expect(feature).not_to be_enabled
       end
     end
@@ -103,13 +103,13 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
       memory_adapter.reset
 
       adapter.get(stats)
-      expect(cache.read(described_class.key_for(search))).to be(nil)
-      expect(cache.read(described_class.key_for(other))).to be(nil)
+      expect(cache.read("flipper/v1/feature/#{search.key}")).to be(nil)
+      expect(cache.read("flipper/v1/feature/#{other.key}")).to be(nil)
 
       adapter.get_multi([stats, search, other])
 
-      expect(cache.read(described_class.key_for(search))[:boolean]).to eq('true')
-      expect(cache.read(described_class.key_for(other))[:boolean]).to be(nil)
+      expect(cache.read("flipper/v1/feature/#{search.key}")[:boolean]).to eq('true')
+      expect(cache.read("flipper/v1/feature/#{other.key}")[:boolean]).to be(nil)
 
       adapter.get_multi([stats, search, other])
       adapter.get_multi([stats, search, other])
@@ -128,9 +128,9 @@ RSpec.describe Flipper::Adapters::ActiveSupportCacheStore do
 
     it 'warms all features' do
       adapter.get_all
-      expect(cache.read(described_class.key_for(stats))[:boolean]).to eq('true')
-      expect(cache.read(described_class.key_for(search))[:boolean]).to be(nil)
-      expect(cache.read(described_class::GetAllKey)).to be_within(2).of(Time.now.to_i)
+      expect(cache.read("flipper/v1/feature/#{stats.key}")[:boolean]).to eq('true')
+      expect(cache.read("flipper/v1/feature/#{search.key}")[:boolean]).to be(nil)
+      expect(cache.read("flipper/v1/get_all")).to be_within(2).of(Time.now.to_i)
     end
 
     it 'returns same result when already cached' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-active_support_cache_store
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - John Nunemaker
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-23 00:00:00.000000000 Z
+date: 2023-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement