flipper-active_record 0.17.1 → 0.20.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 580a17c75e03a7c98a7361a34f24ae82124491bf02e1351972bd1f6d5b627f79
-  data.tar.gz: f9a57fae9ea74c31101e3e461e0afbd622977351fae841428b35f746badfc803
+  metadata.gz: ebacf897cd1f4bd3642c1d40728c3b3fa3c1faab744a51606956bb1d08a916ff
+  data.tar.gz: fff30b5e99f921b72a087a0c726ef474615c116ee55e7fb8c8e7fcf1d3e21158
 SHA512:
-  metadata.gz: 71e7004c6d628e0fe95f3e2d1adaa85d572a557d139634562bb79ccb76a2fd986778773c0aa7895d87db398a16483e6ecf3b3dc26cd067ff7919e810232ab78a
-  data.tar.gz: 05b9b9d298593eddcacb447ac3270a9685bdc25881b67ca37a89c944626e631178ece3910b2931a0b6cb5a7ca553579830f486cd5f2093dfd618e8d978d4eec9
+  metadata.gz: b9f8b3a23b118e6696574c548b48fdc453aab19756d66abf401bcdabac926ec547e2d3085821c9def33d606e62af97dfefbc8b112afd49c50894a9e5252cb773
+  data.tar.gz: f2f139836011c304e90584d35db748302d8d825111ff31649b9ac347202ee13fc2dbb8c522ee113f8a1ee3b9525453c738ab4a74cad0c2acf5051e425739e718

data/docs/active_record/README.md

@@ -4,7 +4,6 @@ An ActiveRecord adapter for [Flipper](https://github.com/jnunemaker/flipper).
 
 Supported Active Record versions:
 
-* 4.2.x
 * 5.0.x
 * 6.0.x
 
@@ -37,6 +36,8 @@ flipper = Flipper.new(adapter)
 # profit...
 ```
 
+Note that the active record adapter requires the database tables to be created in order to work; failure to run the migration first will cause an exception to be raised when attempting to initialize the active record adapter.
+
 ## Internals
 
 Each feature is stored as a row in a features table. Each gate is stored as a row in a gates table, related to the feature by the feature's key.

data/flipper-active_record.gemspec

@@ -10,7 +10,6 @@ Gem::Specification.new do |gem|
   gem.authors       = ['John Nunemaker']
   gem.email         = ['nunemaker@gmail.com']
   gem.summary       = 'ActiveRecord adapter for Flipper'
-  gem.description   = 'ActiveRecord adapter for Flipper'
   gem.license       = 'MIT'
   gem.homepage      = 'https://github.com/jnunemaker/flipper'
 
@@ -19,12 +18,12 @@ Gem::Specification.new do |gem|
     'lib/flipper/version.rb',
   ]
   gem.files         = `git ls-files`.split("\n").select(&flipper_active_record_files) + extra_files
-  gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n").select(&flipper_active_record_files) # rubocop:disable Metrics/LineLength
+  gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n").select(&flipper_active_record_files)
   gem.name          = 'flipper-active_record'
   gem.require_paths = ['lib']
   gem.version       = Flipper::VERSION
   gem.metadata      = Flipper::METADATA
 
   gem.add_dependency 'flipper', "~> #{Flipper::VERSION}"
-  gem.add_dependency 'activerecord', '>= 4.2', '< 7'
+  gem.add_dependency 'activerecord', '>= 5.0', '< 7'
 end

data/lib/flipper/adapters/active_record.rb

@@ -59,7 +59,7 @@ module Flipper
           unless @feature_class.where(key: feature.key).first
             begin
               @feature_class.create! { |f| f.key = feature.key }
-            rescue ActiveRecord::RecordNotUnique
+            rescue ::ActiveRecord::RecordNotUnique
             end
           end
         end
@@ -125,7 +125,9 @@ module Flipper
       # Returns true.
       def enable(feature, gate, thing)
         case gate.data_type
-        when :boolean, :integer
+        when :boolean
+          set(feature, gate, thing, clear: true)
+        when :integer
           set(feature, gate, thing)
         when :set
           enable_multi(feature, gate, thing)
@@ -165,8 +167,10 @@ module Flipper
 
       private
 
-      def set(feature, gate, thing)
+      def set(feature, gate, thing, options = {})
+        clear_feature = options.fetch(:clear, false)
         @gate_class.transaction do
+          clear(feature) if clear_feature
           @gate_class.where(feature_key: feature.key, key: gate.key).destroy_all
           @gate_class.create! do |g|
             g.feature_key = feature.key

data/lib/flipper/version.rb

@@ -1,3 +1,3 @@
 module Flipper
-  VERSION = '0.17.1'.freeze
+  VERSION = '0.20.0.beta1'.freeze
 end

data/spec/flipper/adapters/active_record_requires_spec.rb

@@ -0,0 +1,5 @@
+# This nominally-empty spec ensures that the file "flipper-active_record.rb" can be
+# required without error, and guards against regressions of the kind fixed in
+# https://github.com/jnunemaker/flipper/pull/437.
+
+require "flipper-active_record.rb"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flipper-active_record
 version: !ruby/object:Gem::Version
-  version: 0.17.1
+  version: 0.20.0.beta1
 platform: ruby
 authors:
 - John Nunemaker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-14 00:00:00.000000000 Z
+date: 2020-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: flipper
@@ -16,21 +16,21 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.17.1
+        version: 0.20.0.beta1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.17.1
+        version: 0.20.0.beta1
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '7'
@@ -40,11 +40,11 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '7'
-description: ActiveRecord adapter for Flipper
+description: 
 email:
 - nunemaker@gmail.com
 executables: []
@@ -61,6 +61,7 @@ files:
 - lib/flipper/version.rb
 - lib/generators/flipper/active_record_generator.rb
 - lib/generators/flipper/templates/migration.erb
+- spec/flipper/adapters/active_record_requires_spec.rb
 - spec/flipper/adapters/active_record_spec.rb
 - test/adapters/active_record_test.rb
 - test_rails/generators/flipper/active_record_generator_test.rb
@@ -80,14 +81,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: ActiveRecord adapter for Flipper
 test_files:
+- spec/flipper/adapters/active_record_requires_spec.rb
 - spec/flipper/adapters/active_record_spec.rb
 - test/adapters/active_record_test.rb