flipflop 2.2.1 → 2.3.0

data/test/integration/dashboard_test.rb

@@ -5,59 +5,123 @@ require "capybara/dsl"
 describe Flipflop do
   include Capybara::DSL
 
-  before do
-    @app = TestApp.new
-  end
-
-  subject do
-    @app
-  end
-
-  after do
-    Flipflop::Strategies::AbstractStrategy::RequestInterceptor.request = nil
-  end
-
-  describe "without features" do
+  describe "without translations" do
     before do
-      visit "/flipflop"
+      @app = TestApp.new
     end
 
-    it "should show feature table with header" do
-      assert_equal ["Cookie", "Active record", "Default"],
-        all("thead th").map(&:text)[3..-1]
+    after do
+      @app.unload!
     end
 
-    it "should show no features" do
-      assert all("tbody tr").empty?
+    subject do
+      @app
     end
-  end
 
-  describe "with features" do
-    before do
-      Flipflop::FeatureSet.current.instance_variable_set(:@features, {})
-      Module.new do
-        extend Flipflop::Configurable
-        feature :world_domination, description: "Try and take over the world!"
-        feature :shiny_things, default: true
+    describe "without features" do
+      before do
+        visit "/flipflop"
+      end
+
+      it "should show feature header" do
+        assert_equal "My Test App Features", first("h1").text
       end
 
-      Capybara.current_session.driver.browser.clear_cookies
-      Flipflop::Feature.delete_all
+      it "should show feature table with header" do
+        assert_equal ["Cookie", "Active record", "Default"],
+          all("thead th").map(&:text)[3..-1]
+      end
 
-      visit "/flipflop"
+      it "should show no features" do
+        assert all("tbody tr").empty?
+      end
     end
 
-    it "should show feature rows" do
-      assert_equal ["World domination", "Shiny things"],
-        all("tr[data-feature] td.name").map(&:text)
+    describe "with features" do
+      before do
+        Flipflop::FeatureSet.current.instance_variable_set(:@features, {})
+        Module.new do
+          extend Flipflop::Configurable
+          feature :world_domination, description: "Try and take over the world!"
+          feature :shiny_things, default: true
+        end
+
+        Capybara.current_session.driver.browser.clear_cookies
+        Flipflop::Feature.delete_all
+
+        visit "/flipflop"
+      end
+
+      it "should show feature header" do
+        assert_equal "My Test App Features", first("h1").text
+      end
+
+      it "should show feature names" do
+        assert_equal ["World domination", "Shiny things"],
+          all("tr[data-feature] td.name").map(&:text)
+      end
+
+      it "should show feature descriptions" do
+        assert_equal ["Try and take over the world!", "Shiny things."],
+          all("tr[data-feature] td.description").map(&:text)
+      end
+
+      it "should not show feature group" do
+        assert_equal [], all("tr h2").map(&:text)
+      end
     end
 
-    it "should show feature descriptions" do
-      assert_equal ["Try and take over the world!", "Shiny things."],
-        all("tr[data-feature] td.description").map(&:text)
+    describe "with grouped features" do
+      before do
+        Flipflop::FeatureSet.current.instance_variable_set(:@features, {})
+        Module.new do
+          extend Flipflop::Configurable
+          group "world" do
+            feature :world_domination, description: "Try and take over the world!"
+          end
+          feature :shiny_things, default: true
+        end
+
+        Capybara.current_session.driver.browser.clear_cookies
+        Flipflop::Feature.delete_all
+
+        visit "/flipflop"
+      end
+
+      it "should show feature header" do
+        assert_equal "My Test App Features", first("h1").text
+      end
+
+      it "should show feature names" do
+        assert_equal ["World domination", "Shiny things"],
+          all("tr[data-feature] td.name").map(&:text)
+      end
+
+      it "should show feature descriptions" do
+        assert_equal ["Try and take over the world!", "Shiny things."],
+          all("tr[data-feature] td.description").map(&:text)
+      end
+
+      it "should show feature groups" do
+        assert_equal ["World", "Other features"], all("tr h2").map(&:text)
+      end
     end
 
     describe "with cookie strategy" do
+      before do
+        Flipflop::FeatureSet.current.instance_variable_set(:@features, {})
+        Module.new do
+          extend Flipflop::Configurable
+          feature :world_domination, description: "Try and take over the world!"
+          feature :shiny_things, default: true
+        end
+
+        Capybara.current_session.driver.browser.clear_cookies
+        Flipflop::Feature.delete_all
+
+        visit "/flipflop"
+      end
+
       it "should enable feature" do
         within("tr[data-feature=world-domination] td[data-strategy=cookie]") do
           click_on "on"
@@ -65,7 +129,7 @@ describe Flipflop do
 
         within("tr[data-feature=world-domination]") do
           assert_equal "on", first("td.status").text
-          assert_equal "on", first("td[data-strategy=cookie] input.active[type=submit]").value
+          assert_equal "on", first("td[data-strategy=cookie] button.active").text
         end
       end
 
@@ -76,7 +140,7 @@ describe Flipflop do
 
         within("tr[data-feature=world-domination]") do
           assert_equal "off", first("td.status").text
-          assert_equal "off", first("td[data-strategy=cookie] input.active[type=submit]").value
+          assert_equal "off", first("td[data-strategy=cookie] button.active").text
         end
       end
 
@@ -91,7 +155,7 @@ describe Flipflop do
 
         within("tr[data-feature=world-domination]") do
           assert_equal "off", first("td.status").text
-          refute has_selector?("td[data-strategy=cookie] input.active[type=submit]")
+          refute has_selector?("td[data-strategy=cookie] button.active")
         end
       end
 
@@ -109,12 +173,26 @@ describe Flipflop do
 
         within("tr[data-feature=world-domination]") do
           assert_equal "on", first("td.status").text
-          assert_equal "on", first("td[data-strategy=cookie] input.active[type=submit]").value
+          assert_equal "on", first("td[data-strategy=cookie] button.active").text
         end
       end
     end
 
     describe "with active record strategy" do
+      before do
+        Flipflop::FeatureSet.current.instance_variable_set(:@features, {})
+        Module.new do
+          extend Flipflop::Configurable
+          feature :world_domination, description: "Try and take over the world!"
+          feature :shiny_things, default: true
+        end
+
+        Capybara.current_session.driver.browser.clear_cookies
+        Flipflop::Feature.delete_all
+
+        visit "/flipflop"
+      end
+
       it "should enable feature" do
         within("tr[data-feature=world-domination] td[data-strategy=active-record]") do
           click_on "on"
@@ -122,7 +200,7 @@ describe Flipflop do
 
         within("tr[data-feature=world-domination]") do
           assert_equal "on", first("td.status").text
-          assert_equal "on", first("td[data-strategy=active-record] input.active[type=submit]").value
+          assert_equal "on", first("td[data-strategy=active-record] button.active").text
         end
       end
 
@@ -133,7 +211,7 @@ describe Flipflop do
 
         within("tr[data-feature=world-domination]") do
           assert_equal "off", first("td.status").text
-          assert_equal "off", first("td[data-strategy=active-record] input.active[type=submit]").value
+          assert_equal "off", first("td[data-strategy=active-record] button.active").text
         end
       end
 
@@ -148,7 +226,7 @@ describe Flipflop do
 
         within("tr[data-feature=world-domination]") do
           assert_equal "off", first("td.status").text
-          refute has_selector?("td[data-strategy=active-record] input.active[type=submit]")
+          refute has_selector?("td[data-strategy=active-record] button.active")
         end
       end
 
@@ -166,25 +244,290 @@ describe Flipflop do
 
         within("tr[data-feature=world-domination]") do
           assert_equal "on", first("td.status").text
-          assert_equal "on", first("td[data-strategy=active-record] input.active[type=submit]").value
+          assert_equal "on", first("td[data-strategy=active-record] button.active").text
         end
       end
     end
+
+    describe "with hidden strategy" do
+      before do
+        Flipflop::FeatureSet.current.instance_variable_set(:@strategies, {})
+        Module.new do
+          extend Flipflop::Configurable
+          strategy :query_string, hidden: true
+        end
+
+        visit "/flipflop"
+      end
+
+      it "should not show hidden strategy" do
+        assert_equal [], all("thead th").map(&:text)[3..-1]
+      end
+    end
   end
 
-  describe "with hidden strategy" do
+  describe "with translations" do
     before do
-      Flipflop::FeatureSet.current.instance_variable_set(:@strategies, {})
-      Module.new do
-        extend Flipflop::Configurable
-        strategy :query_string, hidden: true
+      @app = TestApp.new([
+        TestLocaleGenerator,
+      ])
+
+      I18n.locale = :nl
+    end
+
+    after do
+      @app.unload!
+    end
+
+    subject do
+      @app
+    end
+
+    describe "without features" do
+      before do
+        visit "/flipflop"
+      end
+
+      it "should show feature header" do
+        assert_equal "My Test App Functionaliteiten", first("h1").text
+      end
+
+      it "should show feature table with header" do
+        assert_equal ["Koekje", "Actief archief", "Standaard"],
+          all("thead th").map(&:text)[3..-1]
+      end
+
+      it "should show no features" do
+        assert all("tbody tr").empty?
+      end
+    end
+
+    describe "with features" do
+      before do
+        Flipflop::FeatureSet.current.instance_variable_set(:@features, {})
+        Module.new do
+          extend Flipflop::Configurable
+          feature :world_domination, description: "Try and take over the world!"
+          feature :shiny_things, default: true
+        end
+
+        Capybara.current_session.driver.browser.clear_cookies
+        Flipflop::Feature.delete_all
+
+        visit "/flipflop"
+      end
+
+      it "should show feature header" do
+        assert_equal "My Test App Functionaliteiten", first("h1").text
+      end
+
+      it "should show feature names" do
+        assert_equal ["Wereldoverheersing", "Glimmende dingetjes"],
+          all("tr[data-feature] td.name").map(&:text)
+      end
+
+      it "should show feature descriptions" do
+        assert_equal ["Neem de wereld over!", "Glimmende dingetjes."],
+          all("tr[data-feature] td.description").map(&:text)
+      end
+
+      it "should not show feature group" do
+        assert_equal [], all("tr h2").map(&:text)
+      end
+    end
+
+    describe "with grouped features" do
+      before do
+        Flipflop::FeatureSet.current.instance_variable_set(:@features, {})
+        Module.new do
+          extend Flipflop::Configurable
+          group "world" do
+            feature :world_domination, description: "Try and take over the world!"
+          end
+          feature :shiny_things, default: true
+        end
+
+        Capybara.current_session.driver.browser.clear_cookies
+        Flipflop::Feature.delete_all
+
+        visit "/flipflop"
+      end
+
+      it "should show feature header" do
+        assert_equal "My Test App Functionaliteiten", first("h1").text
+      end
+
+      it "should show feature names" do
+        assert_equal ["Wereldoverheersing", "Glimmende dingetjes"],
+          all("tr[data-feature] td.name").map(&:text)
+      end
+
+      it "should show feature descriptions" do
+        assert_equal ["Neem de wereld over!", "Glimmende dingetjes."],
+          all("tr[data-feature] td.description").map(&:text)
+      end
+
+      it "should show feature groups" do
+        assert_equal ["Wereld", "Overige functionaliteiten"], all("tr h2").map(&:text)
       end
+    end
+
+    describe "with cookie strategy" do
+      before do
+        Flipflop::FeatureSet.current.instance_variable_set(:@features, {})
+        Module.new do
+          extend Flipflop::Configurable
+          feature :world_domination, description: "Try and take over the world!"
+          feature :shiny_things, default: true
+        end
+
+        Capybara.current_session.driver.browser.clear_cookies
+        Flipflop::Feature.delete_all
+
+        visit "/flipflop"
+      end
+
+      it "should enable feature" do
+        within("tr[data-feature=world-domination] td[data-strategy=cookie]") do
+          click_on "aan"
+        end
+
+        within("tr[data-feature=world-domination]") do
+          assert_equal "aan", first("td.status").text
+          assert_equal "aan", first("td[data-strategy=cookie] button.active").text
+        end
+      end
+
+      it "should disable feature" do
+        within("tr[data-feature=world-domination] td[data-strategy=cookie]") do
+          click_on "uit"
+        end
 
-      visit "/flipflop"
+        within("tr[data-feature=world-domination]") do
+          assert_equal "uit", first("td.status").text
+          assert_equal "uit", first("td[data-strategy=cookie] button.active").text
+        end
+      end
+
+      it "should enable and clear feature" do
+        within("tr[data-feature=world-domination] td[data-strategy=cookie]") do
+          click_on "aan"
+        end
+
+        within("tr[data-feature=world-domination] td[data-strategy=cookie]") do
+          click_on "wissen"
+        end
+
+        within("tr[data-feature=world-domination]") do
+          assert_equal "uit", first("td.status").text
+          refute has_selector?("td[data-strategy=cookie] button.active")
+        end
+      end
+
+      it "should enable feature after in spite of redefinition and reordering" do
+        Flipflop::FeatureSet.current.instance_variable_set(:@strategies, {})
+        Module.new do
+          extend Flipflop::Configurable
+          strategy :active_record, description: "Store in database."
+          strategy :cookie, description: "Store in cookie."
+        end
+
+        within("tr[data-feature=world-domination] td[data-strategy=cookie]") do
+          click_on "aan"
+        end
+
+        within("tr[data-feature=world-domination]") do
+          assert_equal "aan", first("td.status").text
+          assert_equal "aan", first("td[data-strategy=cookie] button.active").text
+        end
+      end
     end
 
-    it "should not show hidden strategy" do
-      assert_equal [], all("thead th").map(&:text)[3..-1]
+    describe "with active record strategy" do
+      before do
+        Flipflop::FeatureSet.current.instance_variable_set(:@features, {})
+        Module.new do
+          extend Flipflop::Configurable
+          feature :world_domination, description: "Try and take over the world!"
+          feature :shiny_things, default: true
+        end
+
+        Capybara.current_session.driver.browser.clear_cookies
+        Flipflop::Feature.delete_all
+
+        visit "/flipflop"
+      end
+
+      it "should enable feature" do
+        within("tr[data-feature=world-domination] td[data-strategy=active-record]") do
+          click_on "aan"
+        end
+
+        within("tr[data-feature=world-domination]") do
+          assert_equal "aan", first("td.status").text
+          assert_equal "aan", first("td[data-strategy=active-record] button.active").text
+        end
+      end
+
+      it "should disable feature" do
+        within("tr[data-feature=world-domination] td[data-strategy=active-record]") do
+          click_on "uit"
+        end
+
+        within("tr[data-feature=world-domination]") do
+          assert_equal "uit", first("td.status").text
+          assert_equal "uit", first("td[data-strategy=active-record] button.active").text
+        end
+      end
+
+      it "should enable and clear feature" do
+        within("tr[data-feature=world-domination] td[data-strategy=active-record]") do
+          click_on "aan"
+        end
+
+        within("tr[data-feature=world-domination] td[data-strategy=active-record]") do
+          click_on "wissen"
+        end
+
+        within("tr[data-feature=world-domination]") do
+          assert_equal "uit", first("td.status").text
+          refute has_selector?("td[data-strategy=active-record] button.active")
+        end
+      end
+
+      it "should enable feature after in spite of redefinition and reordering" do
+        Flipflop::FeatureSet.current.instance_variable_set(:@strategies, {})
+        Module.new do
+          extend Flipflop::Configurable
+          strategy :active_record, description: "Store in database."
+          strategy :cookie, description: "Store in cookie."
+        end
+
+        within("tr[data-feature=world-domination] td[data-strategy=active-record]") do
+          click_on "aan"
+        end
+
+        within("tr[data-feature=world-domination]") do
+          assert_equal "aan", first("td.status").text
+          assert_equal "aan", first("td[data-strategy=active-record] button.active").text
+        end
+      end
+    end
+
+    describe "with hidden strategy" do
+      before do
+        Flipflop::FeatureSet.current.instance_variable_set(:@strategies, {})
+        Module.new do
+          extend Flipflop::Configurable
+          strategy :query_string, hidden: true
+        end
+
+        visit "/flipflop"
+      end
+
+      it "should not show hidden strategy" do
+        assert_equal [], all("thead th").map(&:text)[3..-1]
+      end
     end
   end
 end

data/test/templates/nl.yml

@@ -0,0 +1,30 @@
+nl:
+  flipflop:
+    title: "%{application} Functionaliteiten"
+    feature: "Functionaliteit"
+    description: "Beschrijving"
+
+    feature_states:
+      enabled: "aan"
+      disabled: "uit"
+
+    clear: "wissen"
+
+    groups:
+      default: "Overige functionaliteiten"
+      world: "Wereld"
+
+    features:
+      world_domination: "Wereldoverheersing"
+      world_domination_description: "Neem de wereld over!"
+      shiny_things: "Glimmende dingetjes"
+
+    strategies:
+      cookie: "Koekje"
+      active_record: "Actief archief"
+      default: "Standaard"
+      lambda: "Lambda"
+      query_string: "Vraagkoord"
+      redis: "Herverdeel"
+      session: "Sessie"
+      test: "Test"

data/test/templates/test_app_features.rb

@@ -0,0 +1,7 @@
+Flipflop.configure do
+  strategy :cookie
+  strategy :active_record
+  strategy :default
+
+  feature :application_feature
+end

data/test/templates/test_engine.rb

@@ -0,0 +1,7 @@
+class TestEngine < Rails::Engine
+  config.root = "lib/test_engine"
+
+  initializer "features" do
+    Flipflop::FeatureLoader.current.append(self)
+  end
+end

data/test/templates/test_engine_features.rb

@@ -0,0 +1,3 @@
+Flipflop.configure do
+  feature :engine_feature
+end