flip_fab 1.0.1 → 1.0.2

data/lib/flip_fab/helper.rb

@@ -1,6 +1,5 @@
 module FlipFab
   module Helper
-
     def features
       @features ||= FlipFab.features.with_context self
     end

data/lib/flip_fab/persistence.rb

@@ -1,9 +1,8 @@
 module FlipFab
   class Persistence
-
     attr_reader :feature_name, :context
 
-    def initialize feature_name, context
+    def initialize(feature_name, context)
       @feature_name = feature_name
       @context      = context
     end
@@ -12,7 +11,7 @@ module FlipFab
       raise NotImplementedError
     end
 
-    def write state
+    def write(state)
       raise NotImplementedError
     end
   end

data/lib/flip_fab/version.rb

@@ -1,3 +1,3 @@
 module FlipFab
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'.freeze
 end

data/script/cibuild

@@ -0,0 +1,10 @@
+#!/bin/sh
+
+# script/cibuild: Setup environment for CI to run tests. This is primarily
+#                 designed to run on the continuous integration server.
+
+set -e
+
+cd "$(dirname "$0")/.."
+bundle exec rubocop --fail-level warning
+

data/spec/lib/flip_fab/contextual_feature_spec.rb

@@ -1,15 +1,14 @@
 module FlipFab
   describe ContextualFeature do
-    let(:override)             {  }
+    let(:override)             {}
     let(:default)              { :disabled }
     let(:persistence_adapters) { [TestPersistence] }
-    let(:feature)              { Feature.new :example_feature, { default: default, persistence_adapters: persistence_adapters } }
-    let(:feature_states)       {{ example_feature: :enabled }}
-    let(:context)              { TestContext.new feature_states, { 'example_feature' => override } }
-    subject{ described_class.new feature, context }
+    let(:feature)              { Feature.new :example_feature, default: default, persistence_adapters: persistence_adapters }
+    let(:feature_states)       { { example_feature: :enabled } }
+    let(:context)              { TestContext.new feature_states, 'example_feature' => override }
+    subject { described_class.new feature, context }
 
     describe '.new' do
-
       it 'assigns the feature' do
         expect(subject.feature).to eq(feature)
       end
@@ -22,23 +21,22 @@ module FlipFab
         let(:override) { 'disabled' }
 
         it 'persists the override' do
-          expect{ subject }.to change{ feature_states }.from({ example_feature: :enabled }).to({ example_feature: :disabled })
+          expect { subject }.to change { feature_states }.from(example_feature: :enabled).to(example_feature: :disabled)
         end
 
         context 'when the override provided is not one of enabled or disabled, it does not persist the override' do
           let(:override) { '' }
 
           it 'does not persist the override' do
-            expect{ subject }.not_to change{ feature_states }.from({ example_feature: :enabled })
+            expect { subject }.not_to change { feature_states }.from(example_feature: :enabled)
           end
         end
       end
     end
 
     describe '#enabled?' do
-
       context 'when the feature is enabled in the adapter' do
-        let(:feature_states) {{ example_feature: :enabled }}
+        let(:feature_states) { { example_feature: :enabled } }
 
         it 'returns true' do
           expect(subject.enabled?).to be_truthy
@@ -54,7 +52,7 @@ module FlipFab
       end
 
       context 'when the feature is disabled in the adapter' do
-        let(:feature_states) {{ example_feature: :disabled }}
+        let(:feature_states) { { example_feature: :disabled } }
 
         it 'returns false' do
           expect(subject.enabled?).to be_falsey
@@ -62,7 +60,7 @@ module FlipFab
       end
 
       context 'when the feature is not specified in the adapter' do
-        let(:feature_states) {{ }}
+        let(:feature_states) { {} }
 
         context 'when the default is :enabled' do
           let(:default) { :enabled }
@@ -85,7 +83,7 @@ module FlipFab
         let(:persistence_adapters) { [TestPersistence, TestMultiplePersistence] }
 
         context 'when the first adapter has enabled and the second adapter has nil' do
-          let(:feature_states) {{ example_feature: :enabled, different_example_feature: nil }}
+          let(:feature_states) { { example_feature: :enabled, different_example_feature: nil } }
 
           it 'returns true' do
             expect(subject.enabled?).to be_truthy
@@ -93,7 +91,7 @@ module FlipFab
         end
 
         context 'when the first adapter has nil and the second adapter has enabled' do
-          let(:feature_states) {{ example_feature: nil, different_example_feature: :enabled }}
+          let(:feature_states) { { example_feature: nil, different_example_feature: :enabled } }
 
           it 'returns true' do
             expect(subject.enabled?).to be_truthy
@@ -101,7 +99,7 @@ module FlipFab
         end
 
         context 'when the first adapter has disabled and the second adapter has enabled' do
-          let(:feature_states) {{ example_feature: :disabled, different_example_feature: :enabled }}
+          let(:feature_states) { { example_feature: :disabled, different_example_feature: :enabled } }
 
           it 'returns false' do
             expect(subject.enabled?).to be_falsey
@@ -111,9 +109,8 @@ module FlipFab
     end
 
     describe '#disabled?' do
-
       context 'when #enabled? returns true' do
-        let(:feature_states) {{ example_feature: :enabled }}
+        let(:feature_states) { { example_feature: :enabled } }
 
         it 'returns false' do
           expect(subject.disabled?).to be_falsey
@@ -121,7 +118,7 @@ module FlipFab
       end
 
       context 'when #enabled? returns false' do
-        let(:feature_states) {{ example_feature: :disabled }}
+        let(:feature_states) { { example_feature: :disabled } }
 
         it 'returns true' do
           expect(subject.disabled?).to be_truthy
@@ -130,34 +127,30 @@ module FlipFab
     end
 
     describe '#state=' do
-
       context 'when the provided value is not :enabled or :disabled' do
-
         it 'raises' do
-          expect{ subject.state = '' }.to raise_error 'Invalid state provided: ``, possible states are :enabled, :disabled'
-          expect{ subject.state = 'enabled' }.to raise_error 'Invalid state provided: `enabled`, possible states are :enabled, :disabled'
+          expect { subject.state = '' }.to raise_error 'Invalid state provided: ``, possible states are :enabled, :disabled'
+          expect { subject.state = 'enabled' }.to raise_error 'Invalid state provided: `enabled`, possible states are :enabled, :disabled'
         end
       end
 
       context 'when the provided value is :enabled or :disabled' do
-
         it 'changes the state of the feature' do
-          expect{ subject.state = :disabled }.to change{subject.enabled?}.from(true).to(false)
-          expect{ subject.state = :enabled }.to change{subject.enabled?}.from(false).to(true)
+          expect { subject.state = :disabled }.to change { subject.enabled? }.from(true).to(false)
+          expect { subject.state = :enabled }.to change { subject.enabled? }.from(false).to(true)
         end
       end
     end
 
     describe '#enable' do
-
       context 'when the state has been overridden' do
         let(:override) { 'disabled' }
 
         context 'and the persistence adapter has the opposite state' do
-          let(:feature_states) {{ example_feature: :disabled }}
+          let(:feature_states) { { example_feature: :disabled } }
 
           it 'does not change the state of the feature' do
-            expect{subject.enable}.not_to change{subject.enabled?}.from(false)
+            expect { subject.enable }.not_to change { subject.enabled? }.from(false)
           end
 
           it 'does not persist the state in the adapter' do
@@ -169,14 +162,14 @@ module FlipFab
 
       context 'when there are multiple persistence adapters' do
         let(:persistence_adapters) { [TestPersistence, TestMultiplePersistence] }
-        let(:feature_states) {{ example_feature: :disabled, different_example_feature: :disabled }}
+        let(:feature_states) { { example_feature: :disabled, different_example_feature: :disabled } }
 
         it 'changes the state of the feature' do
-          expect{subject.enable}.to change{subject.enabled?}.from(false).to(true)
+          expect { subject.enable }.to change { subject.enabled? }.from(false).to(true)
         end
 
         it 'persists the state in the adapters' do
-          expect{ subject.enable }.to change{ feature_states }.from({ example_feature: :disabled, different_example_feature: :disabled }).to({ example_feature: :enabled, different_example_feature: :enabled })
+          expect { subject.enable }.to change { feature_states }.from(example_feature: :disabled, different_example_feature: :disabled).to(example_feature: :enabled, different_example_feature: :enabled)
         end
       end
 
@@ -184,37 +177,37 @@ module FlipFab
         let(:persistence_adapters) { [TestPersistence] }
 
         context 'and the persistence adapter has the same state' do
-          let(:feature_states) {{ example_feature: :enabled }}
+          let(:feature_states) { { example_feature: :enabled } }
 
           it 'does not change the state of the feature' do
-            expect{subject.enable}.not_to change{subject.enabled?}.from(true)
+            expect { subject.enable }.not_to change { subject.enabled? }.from(true)
           end
         end
 
         context 'and the persistence adapter has the opposite state' do
-          let(:feature_states) {{ example_feature: :disabled }}
+          let(:feature_states) { { example_feature: :disabled } }
 
           it 'changes the state of the feature' do
-            expect{subject.enable}.to change{subject.enabled?}.from(false).to(true)
+            expect { subject.enable }.to change { subject.enabled? }.from(false).to(true)
           end
 
           it 'persists the state in the adapter' do
-            expect{ subject.enable }.to change{ feature_states }.from({ example_feature: :disabled }).to({ example_feature: :enabled })
+            expect { subject.enable }.to change { feature_states }.from(example_feature: :disabled).to(example_feature: :enabled)
           end
         end
 
         context 'and the persistence adapter has no state' do
-          let(:feature_states) {{ }}
+          let(:feature_states) { {} }
 
           context 'and the feature is disabled' do
             let(:default) { :disabled }
 
             it 'changes the state of the feature' do
-              expect{subject.enable}.to change{subject.enabled?}.from(false).to(true)
+              expect { subject.enable }.to change { subject.enabled? }.from(false).to(true)
             end
 
             it 'persists the state in the adapter' do
-              expect{ subject.enable }.to change{ feature_states }.from({ }).to({ example_feature: :enabled })
+              expect { subject.enable }.to change { feature_states }.from({}).to(example_feature: :enabled)
             end
           end
 
@@ -222,11 +215,11 @@ module FlipFab
             let(:default) { :enabled }
 
             it 'does not change the state of the feature' do
-              expect{subject.enable}.not_to change{subject.enabled?}.from(true)
+              expect { subject.enable }.not_to change { subject.enabled? }.from(true)
             end
 
             it 'persists the state in the adapter' do
-              expect{ subject.enable }.to change{ feature_states }.from({ }).to({ example_feature: :enabled })
+              expect { subject.enable }.to change { feature_states }.from({}).to(example_feature: :enabled)
             end
           end
         end
@@ -238,7 +231,7 @@ module FlipFab
             let(:default) { :enabled }
 
             it 'does not change the state of the feature' do
-              expect{subject.enable}.not_to change{subject.enabled?}.from(true)
+              expect { subject.enable }.not_to change { subject.enabled? }.from(true)
             end
           end
 
@@ -246,24 +239,22 @@ module FlipFab
             let(:default) { :disabled }
 
             it 'changes the state of the feature' do
-              expect{subject.enable}.to change{subject.enabled?}.from(false).to(true)
+              expect { subject.enable }.to change { subject.enabled? }.from(false).to(true)
             end
           end
         end
       end
     end
 
-
     describe '#disable' do
-
       context 'when the state has been overridden' do
         let(:override) { 'enabled' }
 
         context 'and the persistence adapter has the opposite state' do
-          let(:feature_states) {{ example_feature: :enabled }}
+          let(:feature_states) { { example_feature: :enabled } }
 
           it 'does not change the state of the feature' do
-            expect{subject.disable}.not_to change{subject.disabled?}.from(false)
+            expect { subject.disable }.not_to change { subject.disabled? }.from(false)
           end
 
           it 'does not persist the state in the adapter' do
@@ -277,18 +268,18 @@ module FlipFab
         let(:persistence_adapters) { [TestPersistence] }
 
         context 'and the persistence adapter has the same state' do
-          let(:feature_states) {{ example_feature: :disabled }}
+          let(:feature_states) { { example_feature: :disabled } }
 
           it 'does not change the state of the feature' do
-            expect{subject.disable}.not_to change{subject.disabled?}.from(true)
+            expect { subject.disable }.not_to change { subject.disabled? }.from(true)
           end
         end
 
         context 'and the persistence adapter has the opposite state' do
-          let(:feature_states) {{ example_feature: :enabled }}
+          let(:feature_states) { { example_feature: :enabled } }
 
           it 'changes the state of the feature' do
-            expect{subject.disable}.to change{subject.disabled?}.from(false).to(true)
+            expect { subject.disable }.to change { subject.disabled? }.from(false).to(true)
           end
 
           it 'persists the state in the adapter' do
@@ -298,13 +289,13 @@ module FlipFab
         end
 
         context 'and the persistence adapter has no state' do
-          let(:feature_states) {{ }}
+          let(:feature_states) { {} }
 
           context 'and the feature is enabled' do
             let(:default) { :enabled }
 
             it 'changes the state of the feature' do
-              expect{subject.disable}.to change{subject.disabled?}.from(false).to(true)
+              expect { subject.disable }.to change { subject.disabled? }.from(false).to(true)
             end
 
             it 'persists the state in the adapter' do
@@ -317,7 +308,7 @@ module FlipFab
             let(:default) { :disabled }
 
             it 'does not change the state of the feature' do
-              expect{subject.disable}.not_to change{subject.disabled?}.from(true)
+              expect { subject.disable }.not_to change { subject.disabled? }.from(true)
             end
 
             it 'persists the state in the adapter' do
@@ -334,7 +325,7 @@ module FlipFab
             let(:default) { :disabled }
 
             it 'does not change the state of the feature' do
-              expect{subject.disable}.not_to change{subject.disabled?}.from(true)
+              expect { subject.disable }.not_to change { subject.disabled? }.from(true)
             end
           end
 
@@ -342,7 +333,7 @@ module FlipFab
             let(:default) { :enabled }
 
             it 'changes the state of the feature' do
-              expect{subject.disable}.to change{subject.disabled?}.from(false).to(true)
+              expect { subject.disable }.to change { subject.disabled? }.from(false).to(true)
             end
           end
         end

data/spec/lib/flip_fab/cookie_persistence_spec.rb

@@ -3,66 +3,63 @@ require 'timecop'
 
 module FlipFab
   describe CookiePersistence do
-    let(:cookies) { }
+    let(:cookies) {}
     let(:context) { TestRackContext.new cookies, 'simplybusiness.co.uk' }
     before { FlipFab.define_feature :example_feature }
     after  { FlipFab.features.clear }
-    subject{ described_class.new :example_feature, context }
+    subject { described_class.new :example_feature, context }
 
-    it 'runs the feature' do
-      feature
-    end
-
-    step 'the host is :host' do |host|
-      @host = host
-    end
+    feature do
+      step 'the host is :host' do |host|
+        @host = host
+      end
 
-    step 'the feature name is :feature_name' do |feature_name|
-      @feature_name = feature_name
-    end
+      step 'the feature name is :feature_name' do |feature_name|
+        @feature_name = feature_name
+      end
 
-    step 'the time is :current_time' do |current_time|
-      Timecop.freeze(Time.parse current_time)
-    end
+      step 'the time is :current_time' do |current_time|
+        Timecop.freeze(Time.parse(current_time))
+      end
 
-    step 'the state of the feature is :feature_state' do |feature_state|
-      @feature_state = feature_state
-    end
+      step 'the state of the feature is :feature_state' do |feature_state|
+        @feature_state = feature_state
+      end
 
-    step 'I persist the feature state in a cookie' do
-      context = TestRackContext.new '', @host
-      (described_class.new @feature_name, context).write @feature_state
-      @cookie = context.response_cookies
-    end
+      step 'I persist the feature state in a cookie' do
+        context = TestRackContext.new '', @host
+        (described_class.new @feature_name, context).write @feature_state
+        @cookie = context.response_cookies
+      end
 
-    step 'the cookie has the path :path' do |path|
-      expect(@cookie).to match(/path=#{path};/)
-    end
+      step 'the cookie has the path :path' do |path|
+        expect(@cookie).to match(/path=#{path};/)
+      end
 
-    step 'the cookie has the domain :domain' do |domain|
-      if domain == ''
-        expect(@cookie).not_to match(/domain/)
-      else
-        expect(@cookie).to match(/domain=#{domain};/)
+      step 'the cookie has the domain :domain' do |domain|
+        if domain == ''
+          expect(@cookie).not_to match(/domain/)
+        else
+          expect(@cookie).to match(/domain=#{domain};/)
+        end
       end
-    end
 
-    step 'the cookie has the name :name' do |name|
-      expect(@cookie).to match(/\A#{name}.*/)
-    end
+      step 'the cookie has the name :name' do |name|
+        expect(@cookie).to match(/\A#{name}.*/)
+      end
 
-    step 'the cookie expires at :expiration' do |expiration|
-      expect(@cookie).to match(/expires=#{expiration}\Z/)
-    end
+      step 'the cookie expires at :expiration' do |expiration|
+        expect(@cookie).to match(/expires=#{expiration}\Z/)
+      end
 
-    step 'the cookie value is :value' do |value|
-      expect(@cookie).to match(/\=#{value};/)
+      step 'the cookie value is :value' do |value|
+        expect(@cookie).to match(/\=#{value};/)
+      end
     end
 
     describe '#read' do
-
       context 'when there is no existing cookie' do
-        let(:cookies) { }
+        let(:cookies) {}
 
         it 'returns nil' do
           expect(subject.read).to be_nil
@@ -83,7 +80,7 @@ module FlipFab
       after  { Timecop.return }
 
       it 'saves the feature state' do
-        expect{ subject.write :enabled }.to change{ context.response_cookies }.from(nil).to('flip_fab.example_feature=enabled; domain=.simplybusiness.co.uk; path=/; expires=Tue, 01 Jan 1991 00:00:00 -0000')
+        expect { subject.write :enabled }.to change { context.response_cookies }.from(nil).to('flip_fab.example_feature=enabled; domain=.simplybusiness.co.uk; path=/; expires=Tue, 01 Jan 1991 00:00:00 -0000')
       end
     end
   end