flip_fab 1.0.0 → 1.0.16

data/spec/lib/flip_fab/cookie_persistence_spec.rb

@@ -3,66 +3,59 @@ require 'timecop'
 
 module FlipFab
   describe CookiePersistence do
-    let(:cookies) { }
+    let(:cookies) {}
     let(:context) { TestRackContext.new cookies, 'simplybusiness.co.uk' }
     before { FlipFab.define_feature :example_feature }
     after  { FlipFab.features.clear }
-    subject{ described_class.new :example_feature, context }
+    subject { described_class.new :example_feature, context }
 
-    it 'runs the feature' do
-      feature
-    end
-
-    step 'the host is :host' do |host|
-      @host = host
-    end
+    feature do
+      step 'the host is :host' do |host|
+        @host = host
+      end
 
-    step 'the feature name is :feature_name' do |feature_name|
-      @feature_name = feature_name
-    end
+      step 'the feature name is :feature_name' do |feature_name|
+        @feature_name = feature_name
+      end
 
-    step 'the time is :current_time' do |current_time|
-      Timecop.freeze(Time.parse current_time)
-    end
+      step 'the time is :current_time' do |current_time|
+        Timecop.freeze(Time.parse(current_time))
+      end
 
-    step 'the state of the feature is :feature_state' do |feature_state|
-      @feature_state = feature_state
-    end
+      step 'the state of the feature is :feature_state' do |feature_state|
+        @feature_state = feature_state
+      end
 
-    step 'I persist the feature state in a cookie' do
-      context = TestRackContext.new '', @host
-      (described_class.new @feature_name, context).write @feature_state
-      @cookie = context.response_cookies
-    end
+      step 'I persist the feature state in a cookie' do
+        context = TestRackContext.new '', @host
+        (described_class.new @feature_name, context).write @feature_state
+        @cookie = context.response_cookies
+      end
 
-    step 'the cookie has the path :path' do |path|
-      expect(@cookie).to match(/path=#{path};/)
-    end
+      step 'the cookie has the path :path' do |path|
+        expect(@cookie).to match(/path=#{path};/)
+      end
 
-    step 'the cookie has the domain :domain' do |domain|
-      if domain == ''
-        expect(@cookie).not_to match(/domain/)
-      else
-        expect(@cookie).to match(/domain=#{domain};/)
+      step 'the cookie does not have domain :domain' do |domain|
+        expect(@cookie).not_to match(/domain=#{domain};/)
       end
-    end
 
-    step 'the cookie has the name :name' do |name|
-      expect(@cookie).to match(/\A#{name}.*/)
-    end
+      step 'the cookie has the name :name' do |name|
+        expect(@cookie).to match(/\A#{name}.*/)
+      end
 
-    step 'the cookie expires at :expiration' do |expiration|
-      expect(@cookie).to match(/expires=#{expiration}\Z/)
-    end
+      step 'the cookie expires at :expiration' do |expiration|
+        expect(@cookie).to match(/expires=#{expiration}\Z/)
+      end
 
-    step 'the cookie value is :value' do |value|
-      expect(@cookie).to match(/\=#{value};/)
+      step 'the cookie value is :value' do |value|
+        expect(@cookie).to match(/=#{value};/)
+      end
     end
 
     describe '#read' do
-
       context 'when there is no existing cookie' do
-        let(:cookies) { }
+        let(:cookies) {}
 
         it 'returns nil' do
           expect(subject.read).to be_nil
@@ -83,7 +76,7 @@ module FlipFab
       after  { Timecop.return }
 
       it 'saves the feature state' do
-        expect{ subject.write :enabled }.to change{ context.response_cookies }.from(nil).to('flip_fab.example_feature=enabled; domain=.simplybusiness.co.uk; path=/; expires=Tue, 01 Jan 1991 00:00:00 -0000')
+        expect { subject.write :enabled }.to change { context.response_cookies }.from(nil).to('flip_fab.example_feature=enabled; path=/; expires=Tue, 01 Jan 1991 00:00:00 GMT')
       end
     end
   end

data/spec/lib/flip_fab/feature_spec.rb

@@ -1,11 +1,10 @@
 module FlipFab
   describe Feature do
     let(:name) { :example_test }
-    let(:options) {{ default: :enabled, persistence_adapters: [] }}
+    let(:options) { { default: :enabled, persistence_adapters: [] } }
     subject { described_class.new name, options }
 
     describe '.new' do
-
       it 'assigns the name' do
         expect(subject.name).to eq(:example_test)
       end
@@ -36,9 +35,8 @@ module FlipFab
     end
 
     describe '#enabled?' do
-
       context 'when the feature is enabled' do
-        let(:options) {{ default: :enabled, persistence_adapters: [] }}
+        let(:options) { { default: :enabled, persistence_adapters: [] } }
 
         it 'returns true' do
           expect(subject.enabled?).to be_truthy
@@ -46,7 +44,7 @@ module FlipFab
       end
 
       context 'when the feature is disabled' do
-        let(:options) {{ default: :disabled, persistence_adapters: [] }}
+        let(:options) { { default: :disabled, persistence_adapters: [] } }
 
         it 'returns false' do
           expect(subject.enabled?).to be_falsey
@@ -55,9 +53,8 @@ module FlipFab
     end
 
     describe '#disabled?' do
-
       context 'when the feature is disabled' do
-        let(:options) {{ default: :disabled, persistence_adapters: [] }}
+        let(:options) { { default: :disabled, persistence_adapters: [] } }
 
         it 'returns true' do
           expect(subject.disabled?).to be_truthy
@@ -65,7 +62,7 @@ module FlipFab
       end
 
       context 'when the feature is enabled' do
-        let(:options) {{ default: :enabled, persistence_adapters: [] }}
+        let(:options) { { default: :enabled, persistence_adapters: [] } }
 
         it 'returns false' do
           expect(subject.disabled?).to be_falsey
@@ -77,7 +74,7 @@ module FlipFab
       let(:context) { double(:context) }
 
       it 'returns a contextual feature' do
-        expect(subject.with_context context).to be_a ContextualFeature
+        expect(subject.with_context(context)).to be_a ContextualFeature
         expect((subject.with_context context).feature).to eq(subject)
         expect((subject.with_context context).context).to eq(context)
       end

data/spec/lib/flip_fab/features_by_name_spec.rb

@@ -2,21 +2,18 @@ module FlipFab
   describe FeaturesByName do
     let(:feature)  { Feature.new :example_feature }
     let(:features) { { example_feature: feature } }
-    subject{ described_class.new features }
+    subject { described_class.new features }
 
     describe '#[]' do
-
       context 'when the feature exists' do
-
         it 'returns the feature' do
           expect(subject[:example_feature]).to eq(feature)
         end
       end
 
       context 'when the feature does not exist' do
-
         it 'raises' do
-          expect{ subject[:no_feature] }.to raise_error 'no feature has been defined with the name: no_feature'
+          expect { subject[:no_feature] }.to raise_error 'no feature has been defined with the name: no_feature'
         end
       end
     end
@@ -25,7 +22,7 @@ module FlipFab
       let(:context) { double(:context) }
 
       it 'returns contextual features by name' do
-        expect(subject.with_context context).to be_a described_class
+        expect(subject.with_context(context)).to be_a described_class
         expect((subject.with_context context)[:example_feature]).to be_a ContextualFeature
         expect((subject.with_context context)[:example_feature].feature).to eq(feature)
       end

data/spec/lib/flip_fab/helper_spec.rb

@@ -4,51 +4,49 @@ module FlipFab
   describe Helper do
     include Rack::Test::Methods
     let(:app) { TestApp.new }
-    after  { FlipFab.features.clear  }
+    after { FlipFab.features.clear }
 
-    it 'runs the feature' do
-      feature
-    end
-
-    step 'there is a feature with a default state of :default_state' do |default_state|
-      FlipFab.define_feature :example_feature, { default: default_state.to_sym, persistence_adapters: [TestPersistence] }
-    end
+    feature do
+      step 'there is a feature with a default state of :default_state' do |default_state|
+        FlipFab.define_feature :example_feature, default: default_state.to_sym, persistence_adapters: [TestPersistence]
+      end
 
-    step 'there are two contexts' do
-      @first_context  = TestContext.new
-      @second_context = TestContext.new
-    end
+      step 'there are two contexts' do
+        @first_context  = TestContext.new
+        @second_context = TestContext.new
+      end
 
-    step 'the feature is :expected_state_in_first_context in the first context, :expected_state_in_second_context in the second context' do |expected_state_in_first_context, expected_state_in_second_context|
-      expect(@first_context.features[:example_feature].enabled?).to eq(expected_state_in_first_context == 'enabled')
-      expect(@second_context.features[:example_feature].enabled?).to eq(expected_state_in_second_context == 'enabled')
-    end
+      step 'the feature is :expected_state_in_first_context in the first context, :expected_state_in_second_context in the second context' do |expected_state_in_first_context, expected_state_in_second_context|
+        expect(@first_context.features[:example_feature].enabled?).to eq(expected_state_in_first_context == 'enabled')
+        expect(@second_context.features[:example_feature].enabled?).to eq(expected_state_in_second_context == 'enabled')
+      end
 
-    step 'I :enable_or_disable the feature in the first context' do |enable_or_disable|
-      @first_context.features[:example_feature].send(enable_or_disable.to_sym)
-    end
+      step 'I :enable_or_disable the feature in the first context' do |enable_or_disable|
+        @first_context.features[:example_feature].send(enable_or_disable.to_sym)
+      end
 
-    step 'there is a feature with a default state of :default_state with cookie persistence' do |default_state|
-      FlipFab.define_feature :example_feature, { default: default_state.to_sym }
-    end
+      step 'there is a feature with a default state of :default_state with cookie persistence' do |default_state|
+        FlipFab.define_feature :example_feature, default: default_state.to_sym
+      end
 
-    step 'I override the state in the URL parameters with :overridden_state' do |overridden_state|
-      get "/?example_feature=#{overridden_state}"
-    end
+      step 'I override the state in the URL parameters with :overridden_state' do |overridden_state|
+        get "/?example_feature=#{overridden_state}"
+      end
 
-    step 'the feature is :state for the user' do |state|
-      expect(app.contextual_features[:example_feature].enabled?).to eq(state=='enabled')
-    end
+      step 'the feature is :state for the user' do |state|
+        expect(app.contextual_features[:example_feature].enabled?).to eq(state == 'enabled')
+      end
 
-    step 'I :enable_or_disable the feature for the user' do |enable_or_disable|
-      app.contextual_features[:example_feature].send(enable_or_disable.to_sym)
+      step 'I :enable_or_disable the feature for the user' do |enable_or_disable|
+        app.contextual_features[:example_feature].send(enable_or_disable.to_sym)
+      end
     end
 
     describe '#features' do
-      let(:params)         {{}}
-      let(:feature_states) {{ example_feature: :enabled }}
+      let(:params)         { {} }
+      let(:feature_states) { { example_feature: :enabled } }
       let(:context)        { (TestContext.new feature_states, params) }
-      before { FlipFab.define_feature :example_feature, { persistence_adapters: [TestPersistence] } }
+      before { FlipFab.define_feature :example_feature, persistence_adapters: [TestPersistence] }
       subject { context.features }
 
       it 'maps the features to contextual features by feature name' do
@@ -60,25 +58,24 @@ module FlipFab
       end
 
       context 'when the feature is overridden in the params' do
-        let(:params) {{'example_feature' => 'disabled'}}
+        let(:params) { { 'example_feature' => 'disabled' } }
 
         it 'applies the override to the feature' do
           expect(subject[:example_feature].disabled?).to be_truthy
         end
 
         it 'prevents the feature\'s state from being changed' do
-          expect{ subject[:example_feature].enable }.not_to change{ subject[:example_feature].enabled? }.from(false)
+          expect { subject[:example_feature].enable }.not_to change { subject[:example_feature].enabled? }.from(false)
         end
       end
 
       context 'passing the context to the feature' do
-
         it 'feature toggling is applied to the context' do
-          expect{ subject[:example_feature].disable }.to change{ subject[:example_feature].enabled? }.from(true).to(false)
+          expect { subject[:example_feature].disable }.to change { subject[:example_feature].enabled? }.from(true).to(false)
         end
 
         it 'feature toggling is persisted in the context' do
-          expect{ subject[:example_feature].disable }.to change{ feature_states }.from({ example_feature: :enabled }).to({ example_feature: :disabled })
+          expect { subject[:example_feature].disable }.to change { feature_states }.from(example_feature: :enabled).to(example_feature: :disabled)
         end
       end
 

data/spec/lib/flip_fab/persistence_spec.rb

@@ -5,7 +5,6 @@ module FlipFab
     subject { described_class.new feature_name, context }
 
     describe '.new' do
-
       it 'assigns the feature name' do
         expect(subject.feature_name).to eq(:example_test)
       end
@@ -16,16 +15,14 @@ module FlipFab
     end
 
     describe '#read' do
-
       it 'is not implemented' do
-        expect{ subject.read }.to raise_error NotImplementedError
+        expect { subject.read }.to raise_error NotImplementedError
       end
     end
 
     describe '#write' do
-
       it 'is not implemented' do
-        expect{ subject.write feature_name }.to raise_error NotImplementedError
+        expect { subject.write feature_name }.to raise_error NotImplementedError
       end
     end
   end

data/spec/lib/flip_fab_spec.rb

@@ -1,16 +1,14 @@
 describe FlipFab do
   let(:name) { :example_feature }
 
-  it 'runs the feature' do
-    feature
-  end
-
-  step 'I define a feature that is :enabled_or_disabled' do |enabled_or_disabled|
-    described_class.define_feature name, { default: enabled_or_disabled.to_sym }
-  end
+  feature do
+    step 'I define a feature that is :enabled_or_disabled' do |enabled_or_disabled|
+      described_class.define_feature name, default: enabled_or_disabled.to_sym
+    end
 
-  step 'the feature is :enabled_or_disabled' do |enabled_or_disabled|
-    expect(described_class.features[name].enabled?).to eq(enabled_or_disabled == 'enabled')
+    step 'the feature is :enabled_or_disabled' do |enabled_or_disabled|
+      expect(described_class.features[name].enabled?).to eq(enabled_or_disabled == 'enabled')
+    end
   end
 
   it 'initializes features' do
@@ -18,8 +16,8 @@ describe FlipFab do
   end
 
   context '.define_feature' do
-    subject{ described_class.define_feature name }
-    after{ described_class.features.clear }
+    subject { described_class.define_feature name }
+    after { described_class.features.clear }
 
     it 'returns the feature' do
       expect(subject).to be_a FlipFab::Feature
@@ -27,18 +25,16 @@ describe FlipFab do
     end
 
     context 'when the feature exists' do
-
       it 'overwrites the existing feature' do
         existing_feature = described_class.define_feature name
-        expect{ subject }.not_to change{ described_class.features.count }.from(1)
+        expect { subject }.not_to change { described_class.features.count }.from(1)
         expect(subject).not_to eq(existing_feature)
       end
     end
 
     context 'when the feature does not exist' do
-
       it 'saves the feature' do
-        expect{ subject }.to change{ described_class.features.count }.from(0).to(1)
+        expect { subject }.to change { described_class.features.count }.from(0).to(1)
         expected_feature = subject
         expect(described_class.features[:example_feature]).to eq(expected_feature)
       end

data/spec/spec_helper.rb

@@ -1,6 +1,6 @@
 require 'flip_fab'
 
-Dir['./spec/support/**/*.rb'].sort.each { |f| require f}
+Dir['./spec/support/**/*.rb'].sort.each { |f| require f }
 
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
@@ -42,52 +42,50 @@ RSpec.configure do |config|
     mocks.verify_partial_doubles = true
   end
 
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
-  config.filter_run :focus
-  config.run_all_when_everything_filtered = true
-
-  # Limits the available syntax to the non-monkey patched syntax that is recommended.
-  # For more details, see:
-  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
-  config.disable_monkey_patching!
-
-  # This setting enables warnings. It's recommended, but in some cases may
-  # be too noisy due to issues in dependencies.
-  config.warnings = true
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-=end
+  # The settings below are suggested to provide a good initial experience
+  # with RSpec, but feel free to customize to your heart's content.
+  #   # These two settings work together to allow you to limit a spec run
+  #   # to individual examples or groups you care about by tagging them with
+  #   # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  #   # get run.
+  #   config.filter_run :focus
+  #   config.run_all_when_everything_filtered = true
+  #
+  #   # Limits the available syntax to the non-monkey patched syntax that is recommended.
+  #   # For more details, see:
+  #   #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+  #   #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #   #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
+  #   config.disable_monkey_patching!
+  #
+  #   # This setting enables warnings. It's recommended, but in some cases may
+  #   # be too noisy due to issues in dependencies.
+  #   config.warnings = true
+  #
+  #   # Many RSpec users commonly either run the entire suite or an individual
+  #   # file, and it's useful to allow more verbose output when running an
+  #   # individual spec file.
+  #   if config.files_to_run.one?
+  #     # Use the documentation formatter for detailed output,
+  #     # unless a formatter has already been configured
+  #     # (e.g. via a command-line flag).
+  #     config.default_formatter = 'doc'
+  #   end
+  #
+  #   # Print the 10 slowest examples and example groups at the
+  #   # end of the spec run, to help surface which specs are running
+  #   # particularly slow.
+  #   config.profile_examples = 10
+  #
+  #   # Run specs in random order to surface order dependencies. If you find an
+  #   # order dependency and want to debug it, you can fix the order by providing
+  #   # the seed, which is printed after each run.
+  #   #     --seed 1234
+  #   config.order = :random
+  #
+  #   # Seed global randomization in this process using the `--seed` CLI option.
+  #   # Setting this allows you to use `--seed` to deterministically reproduce
+  #   # test failures related to randomization by passing the same `--seed` value
+  #   # as the one that triggered the failure.
+  #   Kernel.srand config.seed
 end

data/spec/support/test_app.rb

@@ -3,14 +3,14 @@ class TestApp
 
   attr_reader :request, :response, :params, :contextual_features
 
-  def call env
+  def call(env)
     @request  = Rack::Request.new env
     @response = Rack::Response.new
     @params   = request.params
 
     @contextual_features = features
 
-    request.cookies.each{|k,v| response.set_cookie k, v }
+    request.cookies.each { |k, v| response.set_cookie k, v }
     [response.status, response.header, response.body]
   end
 end

data/spec/support/test_context.rb

@@ -3,7 +3,7 @@ class TestContext
 
   attr_reader :feature_states, :params
 
-  def initialize feature_states={}, params={}
+  def initialize(feature_states = {}, params = {})
     @feature_states = feature_states
     @params         = params
   end

data/spec/support/test_multiple_persistence.rb

@@ -1,6 +1,5 @@
 class TestMultiplePersistence < FlipFab::Persistence
-
-  def initialize feature_name, context
+  def initialize(feature_name, context)
     super
   end
 
@@ -8,7 +7,7 @@ class TestMultiplePersistence < FlipFab::Persistence
     context.feature_states[:different_example_feature]
   end
 
-  def write value
+  def write(value)
     context.feature_states[:different_example_feature] = value
   end
 end

data/spec/support/test_persistence.rb

@@ -1,6 +1,5 @@
 class TestPersistence < FlipFab::Persistence
-
-  def initialize feature_name, context
+  def initialize(feature_name, context)
     super
   end
 
@@ -8,7 +7,7 @@ class TestPersistence < FlipFab::Persistence
     context.feature_states[feature_name]
   end
 
-  def write state
+  def write(state)
     context.feature_states[feature_name] = state
   end
 end

data/spec/support/test_rack_context.rb

@@ -3,10 +3,10 @@ class TestRackContext
 
   attr_reader :request, :response
 
-  def initialize cookies, host
-    @request  = Rack::Request.new({ 'HTTP_COOKIE' => cookies, 'HTTP_HOST' => host })
+  def initialize(cookies, host)
+    @request  = Rack::Request.new('HTTP_COOKIE' => cookies, 'HTTP_HOST' => host)
     @response = Rack::Response.new
-    request.cookies.each{|k,v| response.set_cookie k, v }
+    request.cookies.each { |k, v| response.set_cookie k, v }
   end
 
   def response_cookies