flip 0.1.0 → 0.2.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: a4385dc45cee88a9a76ac1e4a95137f2cbc5a790
+  data.tar.gz: 99d8d801d5a81cf84419a5631cc2072bf2b45453
+SHA512:
+  metadata.gz: 16474ee1caa55c414e4813ae31b16b76a51832b4e9e61ec719641122a087782883d5e19f83deed11c9851fa012648a5d22e7f22a1f3c662ccc62d4ee27c9abb1
+  data.tar.gz: 99c9fc607b5bb2dea98b01b19ec205c9a706a251ca0167cffcf5665306e5039918f368ea66b347980bc9702563d7a6c5e647d0ba3b1451ba9055041ae2e63054

data/.travis.yml

@@ -0,0 +1,6 @@
+language: ruby
+rvm:
+  - 2.0.0
+  - 1.9.3
+  - jruby-19mode
+  - rbx-19mode

data/README.md

@@ -1,6 +1,8 @@
 Flip — flip your features
 ================
 
+[![Build Status](https://travis-ci.org/pda/flip.png)](https://travis-ci.org/pda/flip)
+
 **Flip** provides a declarative, layered way of enabling and disabling application functionality at run-time.
 
 This gem optimizes for:
@@ -24,7 +26,7 @@ Flip has a dashboard UI that's easy to understand and use.
 Install
 -------
 
-**Rails 3.0 and 3.1+**
+**Rails 3.0, 3.1 and 3.2+**
 
     # Gemfile
     gem "flip"
@@ -35,36 +37,40 @@ Install
     # Run the migration
     > rake db:migrate
 
+    # Include the Feature model, e.g. config/initializers/feature.rb:
+    require 'feature'
 
 Declaring Features
 ------------------
 
-    # This is the model class generated by rails g flip:install
-    class Feature < ActiveRecord::Base
-      include Flip::Declarable
+```ruby
+# This is the model class generated by rails g flip:install
+class Feature < ActiveRecord::Base
+  include Flip::Declarable
 
-      # The recommended Flip strategy stack.
-      strategy Flip::CookieStrategy
-      strategy Flip::DatabaseStrategy
-      strategy Flip::DefaultStrategy
-      default false
-    
-      # A basic feature declaration.
-      feature :shiny_things
+  # The recommended Flip strategy stack.
+  strategy Flip::CookieStrategy
+  strategy Flip::DatabaseStrategy
+  strategy Flip::DefaultStrategy
+  default false
 
-      # Override the system-wide default.
-      feature :world_domination, default: true
+  # A basic feature declaration.
+  feature :shiny_things
 
-      # Enabled half the time..? Sure, we can do that.
-      feature :flakey,
-        default: proc { rand(2).zero? }
+  # Override the system-wide default.
+  feature :world_domination, default: true
 
-      # Provide a description, normally derived from the feature name.
-      feature :something,
-        default: true,
-        description: "Ability to purchase enrollments in courses",
-    
-    end
+  # Enabled half the time..? Sure, we can do that.
+  feature :flakey,
+    default: proc { rand(2).zero? }
+
+  # Provide a description, normally derived from the feature name.
+  feature :something,
+    default: true,
+    description: "Ability to purchase enrollments in courses",
+
+end
+```
 
 
 Checking Features
@@ -72,19 +78,23 @@ Checking Features
 
 `Flip.on?` or the dynamic predicate methods are used to check feature state:
 
-    Flip.on? :world_domination   # true
-    Flip.world_domination?       # true
-    
-    Flip.on? :shiny_things       # false
-    Flip.shiny_things?           # false
+```ruby
+Flip.on? :world_domination   # true
+Flip.world_domination?       # true
+
+Flip.on? :shiny_things       # false
+Flip.shiny_things?           # false
+```
 
 Views and controllers use the `feature?(key)` method:
 
-    <div>
-      <% if feature? :world_domination %>
-        <%= link_to "Dominate World", world_dominations_path %>
-      <% end %>
-    </div>
+```erb
+<div>
+  <% if feature? :world_domination %>
+    <%= link_to "Dominate World", world_dominations_path %>
+  <% end %>
+</div>
+```
 
 
 Feature Flipping Controllers
@@ -92,17 +102,19 @@ Feature Flipping Controllers
 
 The `Flip::ControllerFilters` module is mixed into the base `ApplicationController` class.  The following controller will respond with 404 Page Not Found to all but the `index` action unless the :new_stuff feature is enabled:
 
-    class SampleController < ApplicationController
-    
-      require_feature :something, :except => :index
-    
-      def show
-      end
-    
-      def index
-      end
-    
-    end
+```ruby
+class SampleController < ApplicationController
+
+  require_feature :something, :except => :index
+
+  def show
+  end
+
+  def index
+  end
+
+end
+```
 
 Dashboard
 ---------
@@ -111,32 +123,40 @@ The dashboard provides visibility and control over the features.
 
 The gem includes some basic styles:
 
-    = content_for :stylesheets_head do
-      = stylesheet_link_tag "flip"
+```haml
+= content_for :stylesheets_head do
+  = stylesheet_link_tag "flip"
+```
 
 You probably don't want the dashboard to be public.  Here's one way of implementing access control.
 
 app/controllers/admin/features_controller.rb:
 
-    class Admin::FeaturesController < Flip::FeaturesController
-      before_filter :assert_authenticated_as_admin
-    end
+```ruby
+class Admin::FeaturesController < Flip::FeaturesController
+  before_filter :assert_authenticated_as_admin
+end
+```
 
 app/controllers/admin/feature_strategies_controller.rb:
 
-    class Admin::FeatureStrategiesController < Flip::FeaturesController
-      before_filter :assert_authenticated_as_admin
-    end
+```ruby
+class Admin::FeatureStrategiesController < Flip::FeaturesController
+  before_filter :assert_authenticated_as_admin
+end
+```
 
 routes.rb:
 
-    namespace :admin do
-      resources :features, only: [ :index ] do
-        resources :feature_strategies, only: [ :update, :destroy ]
-      end
-    end
+```ruby
+namespace :admin do
+  resources :features, only: [ :index ] do
+    resources :feature_strategies, only: [ :update, :destroy ]
+  end
+end
 
-    mount Flip::Engine => "/admin/features"
+mount Flip::Engine => "/admin/features"
+```
 
 ----
 Created by Paul Annesley

data/Rakefile

@@ -6,5 +6,6 @@ task :default => :spec
 
 desc "Run specs"
 task :spec do
-  system 'bundle exec rspec --color --format documentation spec/*_spec.rb'
+  command = "bundle exec rspec --color --format documentation spec/*_spec.rb"
+  system(command) || raise("specs returned non-zero code")
 end

data/config/routes.rb

@@ -1,6 +1,6 @@
 Flip::Engine.routes.draw do
 
-  scope module: "Flip" do
+  scope module: "flip" do
 
     resources :features, path: "", only: [ :index ] do
 

data/flip.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_dependency("activesupport", "~> 3.0")
+  s.add_dependency("activesupport", ">= 3.0", "< 5")
   s.add_dependency("i18n")
 
   s.add_development_dependency("rspec", "~> 2.5")

data/lib/flip/database_strategy.rb

@@ -23,17 +23,19 @@ module Flip
     end
 
     def switch! key, enable
-      @klass.find_or_initialize_by_key(key).update_attributes! enabled: enable
+      @klass.where(key: key.to_s).first_or_initialize.update_attributes!(
+        enabled: enable
+      )
     end
 
     def delete! key
-      @klass.find_by_key(key).try(:destroy)
+      @klass.where(key: key.to_s).first.try(:destroy)
     end
 
     private
 
     def feature(definition)
-      @klass.find_by_key definition.key
+      @klass.where(key: definition.key.to_s).first
     end
 
   end

data/lib/flip/version.rb

@@ -1,3 +1,3 @@
 module Flip
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/database_strategy_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 describe Flip::DatabaseStrategy do
 
-  let(:definition) { double("definition").tap{ |d| d.stub(:key) { :one } } }
+  let(:definition) { double("definition", key: "one") }
   let(:strategy) { Flip::DatabaseStrategy.new(model_klass) }
   let(:model_klass) do
     Class.new do
@@ -20,44 +20,56 @@ describe Flip::DatabaseStrategy do
   its(:switchable?) { should be_true }
   its(:description) { should be_present }
 
+  let(:db_result) { [] }
+  before do
+    allow(model_klass).to(receive(:where).with(key: "one").and_return(db_result))
+  end
+
   describe "#knows?" do
-    it "does not know features that cannot be found" do
-      model_klass.stub(:find_by_key) { nil }
-      strategy.knows?(definition).should be_false
+    context "for unknown key" do
+      it "returns true" do
+        expect(strategy.knows?(definition)).to eq(false)
+      end
     end
-    it "knows features that can be found" do
-      model_klass.stub(:find_by_key) { disabled_record }
-      strategy.knows?(definition).should be_true
+    context "for known key" do
+      let(:db_result) { [disabled_record] }
+      it "returns false" do
+        expect(strategy.knows?(definition)).to eq(true)
+      end
     end
   end
 
   describe "#on?" do
-    it "is true for an enabled record from the database" do
-      model_klass.stub(:find_by_key) { enabled_record }
-      strategy.on?(definition).should be_true
+    context "for an enabled record" do
+      let(:db_result) { [enabled_record] }
+      it "returns true" do
+        expect(strategy.on?(definition)).to eq(true)
+      end
     end
-    it "is false for a disabled record from the database" do
-      model_klass.stub(:find_by_key) { disabled_record }
-      strategy.on?(definition).should be_false
+    context "for a disabled record" do
+      let(:db_result) { [disabled_record] }
+      it "returns true" do
+        expect(strategy.on?(definition)).to eq(false)
+      end
     end
   end
 
   describe "#switch!" do
     it "can switch a feature on" do
-      model_klass.should_receive(:find_or_initialize_by_key).with(:one).and_return(disabled_record)
+      expect(db_result).to receive(:first_or_initialize).and_return(disabled_record)
       disabled_record.should_receive(:update_attributes!).with(enabled: true)
       strategy.switch! :one, true
     end
     it "can switch a feature off" do
-      model_klass.should_receive(:find_or_initialize_by_key).with(:one).and_return(enabled_record)
+      expect(db_result).to receive(:first_or_initialize).and_return(enabled_record)
       enabled_record.should_receive(:update_attributes!).with(enabled: false)
       strategy.switch! :one, false
     end
   end
 
   describe "#delete!" do
+    let(:db_result) { [enabled_record] }
     it "can delete a feature record" do
-      model_klass.should_receive(:find_by_key).with(:one).and_return(enabled_record)
       enabled_record.should_receive(:try).with(:destroy)
       strategy.delete! :one
     end

data/spec/declarable_spec.rb

@@ -23,7 +23,7 @@ describe Flip::Declarable do
       it { should be_on(:three) }
     end
     context "with default set to true" do
-      before(:all) { model_class.send(:default, true) }
+      before { model_class.send(:default, true) }
       it { should be_on(:one) }
       it { should be_on(:three) }
     end

metadata

@@ -1,80 +1,77 @@
 --- !ruby/object:Gem::Specification
 name: flip
 version: !ruby/object:Gem::Version
-  version: 0.1.0
-  prerelease: 
+  version: 0.2.0
 platform: ruby
 authors:
 - Paul Annesley
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-19 00:00:00.000000000 Z
+date: 2013-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.0'
-    none: false
+    - - <
+      - !ruby/object:Gem::Version
+        version: '5'
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.0'
-    none: false
+    - - <
+      - !ruby/object:Gem::Version
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: i18n
-  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-    none: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-    none: false
 - !ruby/object:Gem::Dependency
   name: rspec
-  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.5'
-    none: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.5'
-    none: false
 - !ruby/object:Gem::Dependency
   name: rake
-  prerelease: false
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-    none: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-    none: false
 description: Declarative API for specifying features, switchable in declaration, database
   and cookies.
 email:
@@ -84,6 +81,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - README.md
 - Rakefile
@@ -129,27 +127,26 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/pda/flip
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-  none: false
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-  none: false
 requirements: []
 rubyforge_project: flip
-rubygems_version: 1.8.23
+rubygems_version: 2.1.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: A feature flipper for Rails web applications.
 test_files:
 - spec/abstract_strategy_spec.rb