flight-for-rails 1.4.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8f59894274e7f2232081a6dfd22968c2f8517af0
-  data.tar.gz: f1fe68c6d5bd82ac478f354f177fee9c401a26a7
+  metadata.gz: e82302342ecb36ec039517cad38d77939f4448da
+  data.tar.gz: b3f1a8107db18cd3abe7ac98d52afb45e7ce4922
 SHA512:
-  metadata.gz: 66b2828118f504bf268ef5e51be6ae0b6ab1250951b855dcea0f80754176c371ee6ec472cde8ae3d3f69283db88b5eabd69df083b45a63d32439219572e6422d
-  data.tar.gz: 0a312a8372b8cffc039f9279de4ad8c4a29d964b5231dcb43577166062b1ced9a71bf6e5e9955b7185976148f3737e62a24f70ee913b0e77c6925312eee2cec7
+  metadata.gz: 4fb952989e5591bff2459f9a2b057a1657bb3b233937e822aea21d485f9036217621e4c5f835fecf5e2d10e97477801f3e62a03703f9f317530fee4732851e34
+  data.tar.gz: 2d68ae5407347d29823bae526b3b8b39af4cad8c98d1b51aae25a23d1f0eea776b8d0653d16c12d2b8941b83598bcd2a830aeb347b91929316efd14b72e6b1be

data/README.md

@@ -20,7 +20,7 @@ This gem vendors Flight files and dependecies for Rails assets pipeline.
 First add the following lines to your application `Gemfile`:
 
 ``` ruby
-gem 'flight-for-rails', '~> 1.4.0'
+gem 'flight-for-rails', '~> 1.5.0'
 ```
 
 Then run `bundle install` to update your's gems bundle.

data/lib/flight-for-rails/version.rb

@@ -1,5 +1,5 @@
 # This file is automatically generated.
 # Change template/version.erb if you need.
 module FlightForRails
-  VERSION = '1.4.0'
+  VERSION = '1.5.0'
 end

data/vendor/assets/javascripts/flight/standalone.js

@@ -1,4 +1,4 @@
-/*! Flight v1.4.0 | (c) Twitter, Inc. | MIT License */
+/*! Flight v1.5.0 | (c) Twitter, Inc. | MIT License */
 (function webpackUniversalModuleDefinition(root, factory) {
 	if(typeof exports === 'object' && typeof module === 'object')
 		module.exports = factory();
@@ -168,6 +168,10 @@ var __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_DEFINE_RESULT__;/* Copyright 201
     'use strict';
 
     var functionNameRegEx = /function (.*?)\s?\(/;
+    var ignoredMixin = {
+      withBase: true,
+      withLogging: true
+    };
 
     // teardown for all instances of this constructor
     function teardownAll() {
@@ -216,9 +220,8 @@ var __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_DEFINE_RESULT__;/* Copyright 201
           // function name property not supported by this browser, use regex
           var m = mixin.toString().match(functionNameRegEx);
           return (m && m[1]) ? m[1] : '';
-        } else {
-          return (mixin.name != 'withBase') ? mixin.name : '';
         }
+        return (!ignoredMixin[mixin.name] ? mixin.name : '');
       }).filter(Boolean).join(', ');
     };
 
@@ -455,6 +458,12 @@ var __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_DEFINE_RESULT__;/* Copyright 201
         window.DEBUG = this;
       },
 
+      warn: function (message) {
+        if (!window.console) { return; }
+        var fn = (console.warn || console.log);
+        fn.call(console, this.toString() + ': ' + message);
+      },
+
       registry: registry,
 
       find: {
@@ -1146,13 +1155,20 @@ var __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_DEFINE_RESULT__;/* Copyright 201
       try {
         window.postMessage(data, '*');
       } catch (e) {
-        console.log('unserializable data for event',type,':',data);
-        throw new Error(
-          ['The event', type, 'on component', this.toString(), 'was triggered with non-serializable data'].join(' ')
-        );
+        debug.warn.call(this, [
+          'Event "', type, '" was triggered with non-serializable data. ',
+          'Flight recommends you avoid passing non-serializable data in events.'
+        ].join(''));
       }
     }
 
+    function warnAboutReferenceType(key) {
+      debug.warn.call(this, [
+        'Attribute "', key, '" defaults to an array or object. ',
+        'Enclose this in a function to avoid sharing between component instances.'
+      ].join(''));
+    }
+
     function initAttributes(attrs) {
       var definedKeys = [], incomingKeys;
 
@@ -1166,8 +1182,7 @@ var __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_DEFINE_RESULT__;/* Copyright 201
 
         for (var i = incomingKeys.length - 1; i >= 0; i--) {
           if (definedKeys.indexOf(incomingKeys[i]) == -1) {
-            console.warn('Passed unused attributes including "' + incomingKeys[i] +
-                         '" to component "' + this.toString() + '".');
+            debug.warn.call(this, 'Passed unused attribute "' + incomingKeys[i] + '".');
             break;
           }
         }
@@ -1179,6 +1194,10 @@ var __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_DEFINE_RESULT__;/* Copyright 201
             throw new Error('Required attribute "' + key +
                             '" not specified in attachTo for component "' + this.toString() + '".');
           }
+          // Warn about reference types in attributes
+          if (debug.enabled && typeof this.attr[key] === 'object') {
+            warnAboutReferenceType.call(this, key);
+          }
         } else {
           this.attr[key] = attrs[key];
         }
@@ -1198,6 +1217,10 @@ var __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_DEFINE_RESULT__;/* Copyright 201
       for (var key in this.defaults) {
         if (!attrs.hasOwnProperty(key)) {
           attr[key] = this.defaults[key];
+          // Warn about reference types in defaultAttrs
+          if (debug.enabled && typeof this.defaults[key] === 'object') {
+            warnAboutReferenceType.call(this, key);
+          }
         }
       }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flight-for-rails
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.0
 platform: ruby
 authors:
 - Sergey Rezvanov