flexmls_api 0.6.5 → 0.7.0

data/spec/unit/flexmls_api/models/document_spec.rb

@@ -16,7 +16,7 @@ describe Document do
 
   it "should get documents for a listing" do
     stub_auth_request
-    stub_api_get('/listings/1234/documents','listing_document_index.json')
+    stub_api_get('/listings/1234/documents','listings/document_index.json')
 
     v = Document.find_by_listing_key('1234')
     v.should be_an(Array)

data/spec/unit/flexmls_api/models/listing_cart_spec.rb

@@ -3,7 +3,7 @@ require './spec/spec_helper'
 describe ListingCart do
 
   it "should get all listing carts" do
-    stub_api_get("/#{subject.class.element_name}", 'listing_cart.json')
+    stub_api_get("/#{subject.class.element_name}", 'listing_carts/listing_cart.json')
     resources = subject.class.get
     resources.should be_an(Array)
     resources.length.should eq(2)
@@ -11,7 +11,7 @@ describe ListingCart do
   end
 
   it "should get a listing cart" do
-    stub_api_get("/#{subject.class.element_name}", 'listing_cart.json')
+    stub_api_get("/#{subject.class.element_name}", 'listing_carts/listing_cart.json')
     resource = subject.class.get.first
     resource.Id.should eq("20100912153422758914000000")
     resource.Name.should eq("My Listing Cart")
@@ -20,10 +20,10 @@ describe ListingCart do
   
   it "should add a listing to a cart" do
     list_id = "20110621133454434543000000"
-    stub_api_get("/#{subject.class.element_name}", 'listing_cart.json')
+    stub_api_get("/#{subject.class.element_name}", 'listing_carts/listing_cart.json')
     resource = subject.class.get.first
     resource.Id.should eq("20100912153422758914000000")
-    stub_api_post("/#{subject.class.element_name}/#{resource.Id}",'listing_cart_add_listing_post.json', 'listing_cart_add_listing.json')
+    stub_api_post("/#{subject.class.element_name}/#{resource.Id}",'listing_carts/add_listing_post.json', 'listing_carts/add_listing.json')
     resource.ListingCount.should eq(10)
     resource.add_listing(list_id)
     resource.ListingCount.should eq(11)
@@ -31,10 +31,10 @@ describe ListingCart do
   
   it "should remove a listing from a cart" do
     list_id = "20110621133454434543000000"
-    stub_api_get("/#{subject.class.element_name}", 'listing_cart.json')
+    stub_api_get("/#{subject.class.element_name}", 'listing_carts/listing_cart.json')
     resource = subject.class.get.first
     resource.Id.should eq("20100912153422758914000000")
-    stub_api_delete("/#{subject.class.element_name}/#{resource.Id}/listings/#{list_id}", 'listing_cart_remove_listing.json')
+    stub_api_delete("/#{subject.class.element_name}/#{resource.Id}/listings/#{list_id}", 'listing_carts/remove_listing.json')
     resource.ListingCount.should eq(10)
     resource.remove_listing(list_id)
     resource.ListingCount.should eq(9)
@@ -42,7 +42,7 @@ describe ListingCart do
 
   let(:listing){ Listing.new(:Id => "20110112234857732941000000") }
   it "should get all carts for a listing" do
-    stub_api_get("/#{subject.class.element_name}/for/#{listing.Id}", 'listing_cart.json')
+    stub_api_get("/#{subject.class.element_name}/for/#{listing.Id}", 'listing_carts/listing_cart.json')
     [listing, listing.Id ].each do |l|
         resources = subject.class.for(l)
         resources.should be_an(Array)
@@ -52,7 +52,7 @@ describe ListingCart do
   end
 
   it "should get the carts for a user" do
-    stub_api_get("/my/#{subject.class.element_name}", 'listing_cart.json')
+    stub_api_get("/my/#{subject.class.element_name}", 'listing_carts/listing_cart.json')
     resources = subject.class.my
     resources.should be_an(Array)
     resources.length.should eq(2)
@@ -60,7 +60,7 @@ describe ListingCart do
   end
 
   it "should get the carts specific to a portal user" do
-    stub_api_get("/#{subject.class.element_name}/portal", 'listing_cart.json')
+    stub_api_get("/#{subject.class.element_name}/portal", 'listing_carts/listing_cart.json')
     resources = subject.class.portal
     resources.should be_an(Array)
     resources.length.should eq(2)
@@ -68,7 +68,7 @@ describe ListingCart do
   end
   
   it "should save a new listing cart" do
-    stub_api_post("/#{subject.class.element_name}", 'listing_cart_new.json', 'listing_cart_post.json')
+    stub_api_post("/#{subject.class.element_name}", 'listing_carts/new.json', 'listing_carts/post.json')
     subject.ListingIds = [
       '20110112234857732941000000',
       '20110302120238448431000000',
@@ -79,9 +79,9 @@ describe ListingCart do
   end
 
   it "should save a listing cart" do
-    stub_api_get("/#{subject.class.element_name}", 'listing_cart.json')
+    stub_api_get("/#{subject.class.element_name}", 'listing_carts/listing_cart.json')
     resource = subject.class.get.first
-    stub_api_put("/#{subject.class.element_name}/#{resource.Id}", 'listing_cart_new.json', 'success.json')
+    stub_api_put("/#{subject.class.element_name}/#{resource.Id}", 'listing_carts/new.json', 'success.json')
     resource.ListingIds = [
       '20110112234857732941000000',
       '20110302120238448431000000',
@@ -93,7 +93,7 @@ describe ListingCart do
   end
   
   it "should fail saving" do
-    stub_api_post("/#{subject.class.element_name}",'listing_cart_empty.json') do |request|
+    stub_api_post("/#{subject.class.element_name}",'listing_carts/empty.json') do |request|
       request.to_return(:status => 400, :body => fixture('errors/failure.json'))
     end
     subject
@@ -102,13 +102,13 @@ describe ListingCart do
   end
 
   it "should delete a listing cart" do
-    stub_api_get("/#{subject.class.element_name}", 'listing_cart.json')
+    stub_api_get("/#{subject.class.element_name}", 'listing_carts/listing_cart.json')
     resource = subject.class.get.first
     resource.Id.should eq("20100912153422758914000000")
     resource.Name.should eq("My Listing Cart")
     resource.ListingCount.should eq(10)
     stub_api_delete("/#{subject.class.element_name}/#{resource.Id}", 'success.json')
-    resource.delete.should be(nil)
+    resource.delete.empty?.should be(true)
   end
 
 end

data/spec/unit/flexmls_api/models/listing_spec.rb

@@ -1,16 +1,14 @@
-require './spec/spec_helper'
-
 describe Listing do
   before(:each) do
 
     @listing = Listing.new({
       "ResourceUri"=>"/v1/listings/20080619000032866372000000", 
       "StandardFields"=>{
-        "StreetNumber"=>"********", 
+        "StreetNumber"=>"100", 
         "ListingId"=>"07-32", 
         "City"=>"Fargo", 
         "Longitude"=>"", 
-        "StreetName"=>"********", 
+        "StreetName"=>"Someone's", 
         "YearBuilt"=>nil, 
         "BuildingAreaTotal"=>"1321.0", 
         "PublicRemarks"=>nil, 
@@ -25,6 +23,7 @@ describe Listing do
         "BathsTotal"=>"0.0", 
         "BathsFull"=>nil, 
         "ListingKey"=>"20080619000032866372000000", 
+        "StreetSuffix"=>"St", 
         "StreetDirSuffix"=>"********", 
         "BedsTotal"=>2, 
         "ModificationTimestamp"=>"2010-11-22T23:36:42Z", 
@@ -42,7 +41,7 @@ describe Listing do
           "Caption"=>"apostrophe test for CUR-10508",
           "Uri1280"=>"http=>//devresize.flexmls.com/fgo/1280x1024/true/20101115201631519737000000-o.jpg",
           "UriThumb"=>"http=>//images.dev.fbsdata.com/fgo/20101115201631519737000000-t.jpg",
-           "Uri640"=>"http=>//devresize.flexmls.com/fgo/640x480/true/20101115201631519737000000-o.jpg"
+          "Uri640"=>"http=>//devresize.flexmls.com/fgo/640x480/true/20101115201631519737000000-o.jpg"
         }]
       }, 
       "Id"=>"20080619000032866372000000"
@@ -94,6 +93,7 @@ describe Listing do
       count = Listing.count()
       count.should == 2001
     end 
+    
   end
 
   describe "subresources" do
@@ -102,7 +102,7 @@ describe Listing do
     end
 
     it "should return an array of photos" do
-      stub_api_get("/listings/1234", 'listing_with_photos.json', { :_expand => "Photos" })
+      stub_api_get("/listings/1234", 'listings/with_photos.json', { :_expand => "Photos" })
       
       l = Listing.find('1234', :_expand => "Photos")
       l.photos.length.should == 5
@@ -112,7 +112,7 @@ describe Listing do
     end
 
     it "should return an array of documents" do
-      stub_api_get("/listings/1234", 'listing_with_documents.json', { :_expand => "Documents" })
+      stub_api_get("/listings/1234", 'listings/with_documents.json', { :_expand => "Documents" })
       
       l = Listing.find('1234', :_expand => "Documents")
       l.photos.length.should == 0
@@ -122,7 +122,7 @@ describe Listing do
     end
 
     it "should return an array of virtual tours" do
-      stub_api_get("/listings/1234", 'listing_with_vtour.json', { :_expand => "VirtualTours" })
+      stub_api_get("/listings/1234", 'listings/with_vtour.json', { :_expand => "VirtualTours" })
       
       l = Listing.find('1234', :_expand => "VirtualTours")
       l.virtual_tours.length.should == 1
@@ -131,9 +131,8 @@ describe Listing do
       l.videos.length.should == 0
     end
 
-
     it "should return an array of videos" do
-      stub_api_get("/listings/1234", 'listing_with_videos.json', { :_expand => "Videos" })
+      stub_api_get("/listings/1234", 'listings/with_videos.json', { :_expand => "Videos" })
       
       l = Listing.find('1234', :_expand => "Videos")
       l.videos.length.should == 2
@@ -143,8 +142,8 @@ describe Listing do
     end 
 
     it "should return tour of homes" do
-      stub_api_get("/listings/20060725224713296297000000", 'listing_no_subresources.json')
-      stub_api_get("/listings/20060725224713296297000000/tourofhomes", 'tour_of_homes.json')
+      stub_api_get("/listings/20060725224713296297000000", 'listings/no_subresources.json')
+      stub_api_get("/listings/20060725224713296297000000/tourofhomes", 'listings/tour_of_homes.json')
 
       l = Listing.find('20060725224713296297000000')
       l.tour_of_homes().length.should == 2
@@ -152,6 +151,73 @@ describe Listing do
       l.photos.length.should == 0
       l.documents.length.should == 0
     end 
+
+    it "should return street address" do
+        @listing.street_address.should eq("100 Someone's St")
+    end
+
+    it "should return the regional address" do
+        @listing.region_address.should eq("Fargo, ND 55320")
+    end
+
+    it "should return full address" do
+        @listing.full_address.should eq("100 Someone's St, Fargo, ND 55320")
+    end
+    
+    it "should return permissions" do
+      stub_api_get("/listings/20060725224713296297000000", 'listings/with_permissions.json', { :_expand => "Permissions" })
+      l = Listing.find('20060725224713296297000000', :_expand => "Permissions")
+      l.Permissions["Editable"].should eq(true)
+      l.editable?().should eq(true)
+      l.editable?(:PriceChange).should eq(true)
+      l.editable?(:Photos).should eq(false)
+    end 
+  end
+  
+  context "on save" do
+    it "should save a listing that has modified" do
+      list_id = "20060725224713296297000000"
+      stub_api_get("/listings/#{list_id}", 'listings/no_subresources.json')
+      stub_api_put("/listings/#{list_id}", 'listings/put.json', 'success.json')
+      l = Listing.find(list_id)
+      l.ListPrice = 10000.0
+      l.save.should be(true)
+    end
+    it "should not save a listing that does not exist" do
+      list_id = "20060725224713296297000000"
+      stub_api_get("/listings/#{list_id}", 'listings/no_subresources.json')
+      stub_api_put("/listings/lolwut", 'listings/put.json') do |request|
+        request.to_return(:status => 400, :body => fixture('errors/failure.json'))
+      end
+      l = Listing.find(list_id)
+      l.Id = "lolwut"
+      l.ListPrice = 10000.0
+      l.save.should be(false)
+      expect{ l.save! }.to raise_error(FlexmlsApi::ClientError){ |e| e.status.should == 400 }
+    end
+    it "should save a listing with constraints" do
+      list_id = "20060725224713296297000000"
+      stub_api_get("/listings/#{list_id}", 'listings/no_subresources.json')
+      stub_api_put("/listings/#{list_id}", 'listings/put.json', 'listings/constraints.json')
+      l = Listing.find(list_id)
+      l.ListPrice = 10000.0
+      l.save.should be(true)
+      l.constraints.size.should eq(1)
+      l.constraints.first.RuleName.should eq("MaxValue")
+    end
+    context "with pagination" do
+      # This is really a bogus call, but we should make sure our pagination collection impl still behaves sanely
+      it "should save a listing with constraints" do
+        list_id = "20060725224713296297000000"
+        stub_api_get("/listings/#{list_id}", 'listings/no_subresources.json')
+        stub_api_put("/listings/#{list_id}", 'listings/put.json', 'listings/constraints_with_pagination.json', :_pagination => '1')
+        l = Listing.find(list_id)
+        l.ListPrice = 10000.0
+        l.save(:_pagination => '1').should be(true)
+        l.constraints.size.should eq(1)
+        l.constraints.first.RuleName.should eq("MaxValue")
+      end
+    end
     
   end
 
@@ -159,5 +225,4 @@ describe Listing do
     @listing = nil
   end
 
-
 end

data/spec/unit/flexmls_api/models/note_spec.rb

@@ -20,13 +20,13 @@ describe Note do
     end
 
     it "should get my notes" do
-      stub_api_get("#{@note.path}", 'agent_shared_note.json')
+      stub_api_get("#{@note.path}", 'notes/agent_shared.json')
       ret = @note.get
       ret.Note.should == "lorem ipsum dolor sit amet"
     end
 
     it "should return a nil when no shared notes exist" do
-      stub_api_get("#{@note.path}", 'agent_shared_note_empty.json')
+      stub_api_get("#{@note.path}", 'notes/agent_shared_empty.json')
       @note.get.should be_nil
     end
 
@@ -38,7 +38,7 @@ describe Note do
     it "should raise an exception when adding a note fails" do
       n = @note.new(:Note => "lorem ipsum dolor")
       
-      stub_api_put("#{@note.path}", 'note_new.json') do |request|
+      stub_api_put("#{@note.path}", 'notes/new.json') do |request|
         request.to_return(:status => 500, :body => fixture('generic_failure.json'))
       end
 
@@ -48,7 +48,7 @@ describe Note do
 
     it "should allow adding of a note" do
       n = @note.new(:Note => "lorem ipsum dolor")
-      stub_api_put("#{@note.path}", 'note_new.json', 'add_note.json')
+      stub_api_put("#{@note.path}", 'notes/new.json', 'notes/add.json')
       n.save
       n.ResourceUri.should == '/v1/listings/20100909200152674436000000/shared/notes/contacts/20110407212043616271000000/'
     end

data/spec/unit/flexmls_api/models/open_house_spec.rb

@@ -26,7 +26,7 @@ describe OpenHouse do
 
   it "should get open house for a listing" do
     stub_auth_request
-    stub_api_get('/listings/20060412165917817933000000/openhouses','open_houses.json')
+    stub_api_get('/listings/20060412165917817933000000/openhouses','listings/open_houses.json')
     houses = subject.class.find_by_listing_key('20060412165917817933000000')
     houses.should be_an(Array)
     houses.length.should eq(2)

data/spec/unit/flexmls_api/models/photo_spec.rb

@@ -1,49 +1,82 @@
 require './spec/spec_helper'
 
 describe Photo do
-  before(:each) do
-    @photo = Photo.new({
-      "ResourceUri" => "/listings/20100815153524571646000000/photos/20101124153422574618000000",
-      "Id"          => "20101124153422574618000000",
-      "Name"        => "Photo 1 name",
-      "Caption"     => "caption here",
-      "UriThumb"    => "http://photos.cdn.flexmls.com/xyz-t.jpg",
-      "Uri300"      => "http://photos.cdn.flexmls.com/xyz.jpg",
-      "Uri640"      => "http://cdn.resize.flexmls.com/az/640x480/true/20101124153422574618000000-o.jpg",
-      "Uri800"      => "http://cdn.resize.flexmls.com/az/800x600/true/20101124153422574618000000-o.jpg",
-      "Uri1024"     => "http://cdn.resize.flexmls.com/az/1024x768/true/20101124153422574618000000-o.jpg",
-      "Uri1280"     => "http://cdn.resize.flexmls.com/az/1280x1024/true/20101124153422574618000000-o.jpg",
-      "UriLarge"    => "http://photos.cdn.flexmls.com/xyz-o.jpg",
-      "Primary"     => true
-    })
-
-  end
-
-  it "responds to" do
-    @photo.should respond_to(:primary?)
-    Photo.should respond_to(:find_by_listing_key)
-  end
-
-  it "knows if it's the primary photo" do
-    @photo.primary?.should be_true
-    @photo.Primary = false
-    @photo.primary?.should be_false
-  end
-
-  describe "find photos by listing id"  do
-    before do
-      stub_auth_request
-      stub_api_get('/listings/1234/photos', 'listing_photos_index.json')
+  describe "find" do
+    subject do
+      Photo.new({
+        "ResourceUri" => "/listings/20100815153524571646000000/photos/20101124153422574618000000",
+        "Id"          => "20101124153422574618000000",
+        "Name"        => "Photo 1 name",
+        "Caption"     => "caption here",
+        "UriThumb"    => "http://photos.cdn.flexmls.com/xyz-t.jpg",
+        "Uri300"      => "http://photos.cdn.flexmls.com/xyz.jpg",
+        "Uri640"      => "http://cdn.resize.flexmls.com/az/640x480/true/20101124153422574618000000-o.jpg",
+        "Uri800"      => "http://cdn.resize.flexmls.com/az/800x600/true/20101124153422574618000000-o.jpg",
+        "Uri1024"     => "http://cdn.resize.flexmls.com/az/1024x768/true/20101124153422574618000000-o.jpg",
+        "Uri1280"     => "http://cdn.resize.flexmls.com/az/1280x1024/true/20101124153422574618000000-o.jpg",
+        "UriLarge"    => "http://photos.cdn.flexmls.com/xyz-o.jpg",
+        "Primary"     => true
+      })
     end
-
-    it "should get an array of photos" do
-      p = Photo.find_by_listing_key('1234')
-      p.should be_an(Array)
+  
+    it "responds to" do
+      subject.should respond_to(:primary?)
+      Photo.should respond_to(:find_by_listing_key)
+    end
+  
+    it "knows if it's the primary photo" do
+      subject.primary?.should be_true
+      subject.Primary = false
+      subject.primary?.should be_false
+    end
+  
+    describe "find photos by listing id"  do
+      before do
+        stub_auth_request
+        stub_api_get('/listings/1234/photos', 'listings/photos/index.json')
+      end
+  
+      it "should get an array of photos" do
+        p = Photo.find_by_listing_key('1234')
+        p.should be_an(Array)
+      end
     end
   end
-
-  after(:each) do  
-    @photo = nil
+  
+  describe "save" do
+    subject do
+      p = Photo.build_subclass.tap do |photo|
+        photo.prefix = "/listings/1234"
+        photo.element_name ="/photos"
+      end.new
+      p.update_path = "/listings/1234/photos"
+      p
+    end
+    it "should be scoped to a listing" do
+      subject.class.path.should eq("/listings/1234/photos")
+    end
+    it "should upload a new photo" do
+      stub_api_post('/listings/1234/photos', 'listings/photos/new.json', 'listings/photos/post.json')
+      subject.Name  = "FBS Logo"
+      subject.Caption = "Creators of flexMLS!"
+      subject.load_picture("spec/fixtures/logo_fbs.png")
+      subject.save!
+      subject.Id.should eq("20110826220032167405000000")
+    end
+    it "should upload a modified photo" do
+      stub_api_put('/listings/1234/photos/20110826220032167405000000', 'listings/photos/new.json', 'listings/photos/post.json')
+      subject.Id = "20110826220032167405000000"
+      subject.Name  = "FBS Logo"
+      subject.Caption = "Creators of flexMLS!"
+      subject.load_picture("spec/fixtures/logo_fbs.png")
+      subject.save!
+      subject.Id.should eq("20110826220032167405000000")
+    end
+    it "should delete a photo" do
+      stub_api_delete('/listings/1234/photos/20110826220032167405000000','success.json')
+      subject.Id = "20110826220032167405000000"
+      subject.delete
+    end    
   end
 
 end