flexirest 1.6.2 → 1.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4ef0d167d4d731cacdb7ac4f272ca0cf0c1ebb24
-  data.tar.gz: b56d4dc78f1f6e5875f57e737cab0a1b4efd749f
+  metadata.gz: 395be9d32a66854a03dfee23f11da2773fce4852
+  data.tar.gz: 624db41375f5919e5495eef37d1bb5a2362e3f7e
 SHA512:
-  metadata.gz: 6cc9bfa84951e23c7ac5f12804967e27724f7f8f9a4de62d6cf4b293f57aaeb8a61138f6c7baccd7559b5707c83b3bcfc854492e6c838fcd976ff542630bc31f
-  data.tar.gz: 2bf14a68818a51363b2f3e3817dfc88b4e599516a2b2bc7125da773e05b041e2f0445dad4d561aa709ae3bd6e88ff28f3a1d86ea58442c22ac6704db5a628249
+  metadata.gz: a6721c8c74d486de9101c54f07909c479416cc49e6838738323c804ea20d82e42f2148dbc218c3ca90d3632b9ebe60bab1cf519a27c1789c6976cb0fa45993d3
+  data.tar.gz: b61cb95703f902fd1bdd26ef2c47fa67a230ff496d39ab30b111b5e9c65546c7f371af8f6c1d0fabd6e8fd584771b200c3b863cb1aeddc7f61e380fe14c290fc

data/CHANGELOG.md

@@ -1,10 +1,10 @@
 # Changelog
 
-## 1.6.2
+## 1.6.3
 
 Bugfix:
 
-- Flexirest wasn't supporting nested arrays in responses, it does now. Thanks to Rui Ribeiro for pointing this out.
+- Allowing instantiating a class if mapped request method is called for "JSON-API" functionality (thanks to Mike Voets for this PR).
 
 ## 1.6.1
 

data/lib/flexirest/request.rb

@@ -375,7 +375,10 @@ module Flexirest
           @body = ""
         else
           headers["Content-Type"] ||= "application/vnd.api+json"
-          @body = JsonAPIProxy::Request::Params.create(params || @post_params || {}, @object).to_json
+          @body = JsonAPIProxy::Request::Params.create(
+            params || @post_params || {},
+            object_is_class? ? @object.new : @object
+          ).to_json
         end
 
         headers["Accept"] ||= "application/vnd.api+json"

data/lib/flexirest/version.rb

@@ -1,3 +1,3 @@
 module Flexirest
-  VERSION = "1.6.2"
+  VERSION = "1.6.3"
 end

data/spec/lib/json_api_spec.rb

@@ -321,10 +321,36 @@ describe 'JSON API' do
       expect_any_instance_of(Flexirest::Connection).to receive(:post) { |_, _, _, options|
         expect(options[:headers]).to include('Content-Type' => 'application/vnd.api+json')
         expect(options[:headers]).to include('Accept' => 'application/vnd.api+json')
-      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body:'{}', response_headers:{})))
+      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body: '{}', response_headers: {})))
       JsonAPIExample::Article.new.create
     end
 
+    it 'should be able to call #.create on class' do
+      expect_any_instance_of(Flexirest::Connection).to receive(:post) { |_, path, data|
+        hash = MultiJson.load(data)
+        expect(path).to eq('/articles')
+        expect(hash['data']).to_not be_nil
+        expect(hash['data']['id']).to be_nil
+        expect(hash['data']['type']).to eq('articles')
+      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body: '{}', response_headers: {})))
+      JsonAPIExample::Article.create
+    end
+
+    it 'should be able to call #.create with params on class' do
+      expect_any_instance_of(Flexirest::Connection).to receive(:post) { |_, path, data|
+        hash = MultiJson.load(data)
+        expect(path).to eq('/articles')
+        expect(hash['data']).to_not be_nil
+        expect(hash['data']['id']).to be_nil
+        expect(hash['data']['type']).to eq('articles')
+        expect(hash['data']['relationships']['author']['data']['type']).to eq('authors')
+        expect(hash['data']['relationships']['tags']['data'].first['type']).to eq('tags')
+      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body: '{}', response_headers: {})))
+      author = JsonAPIExample::Author.new
+      tag = JsonAPIExample::Tag.new
+      JsonAPIExample::Article.create(item: 'item one', author: author, tags: [tag])
+    end
+
     it 'should perform a post request in proper json api format' do
       expect_any_instance_of(Flexirest::Connection).to receive(:post) { |_, path, data|
         hash = MultiJson.load(data)
@@ -334,7 +360,7 @@ describe 'JSON API' do
         expect(hash['data']['type']).to eq('articles')
         expect(hash['data']['relationships']['author']['data']['type']).to eq('authors')
         expect(hash['data']['relationships']['tags']['data'].first['type']).to eq('tags')
-      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body:'{}', response_headers:{})))
+      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body: '{}', response_headers: {})))
       author = JsonAPIExample::Author.new
       tag = JsonAPIExample::Tag.new
       article = JsonAPIExample::Article.new
@@ -350,7 +376,7 @@ describe 'JSON API' do
       article = JsonAPIExample::Article.new
       article.item = 'item one'
       article.tags = [tag, author]
-      expect(lambda { article.create }).to raise_error(Exception)
+      expect(-> { article.create }).to raise_error(Exception)
     end
 
     it 'should perform a patch request in proper json api format' do
@@ -360,7 +386,7 @@ describe 'JSON API' do
         expect(hash['data']).to_not be_nil
         expect(hash['data']['id']).to_not be_nil
         expect(hash['data']['type']).to_not be_nil
-      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body:'{}', response_headers:{})))
+      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body: '{}', response_headers: {})))
       article = JsonAPIExample::Article.find(1)
       article.item = 'item one'
       article.update
@@ -370,7 +396,7 @@ describe 'JSON API' do
       expect_any_instance_of(Flexirest::Connection).to receive(:delete) { |_, path, data|
         expect(path).to eq('/articles/1')
         expect(data).to eq('')
-      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body:'{}', response_headers:{})))
+      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body: '{}', response_headers: {})))
       JsonAPIExample::Article.find(1).delete
     end
 
@@ -379,7 +405,7 @@ describe 'JSON API' do
         hash = MultiJson.load(data)
         expect(hash['data']['type']).to eq(JsonAPIExample::ArticleAlias.alias_type.to_s)
         expect(hash['data']['relationships']['author']['data']['type']).to eq(JsonAPIExample::AuthorAlias.alias_type.to_s)
-      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body:'{}', response_headers:{})))
+      }.and_return(::FaradayResponseMock.new(OpenStruct.new(body: '{}', response_headers: {})))
       author = JsonAPIExample::AuthorAlias.new
       author.id = 1
       article = JsonAPIExample::ArticleAlias.find(1)
@@ -387,6 +413,5 @@ describe 'JSON API' do
       article.author = author
       article.update
     end
-
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flexirest
 version: !ruby/object:Gem::Version
-  version: 1.6.2
+  version: 1.6.3
 platform: ruby
 authors:
 - Andy Jeffries