flexirest 1.4.9 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fb5d697d79a1b6068d551ea5346b87d83189eaad
-  data.tar.gz: 727a87951be313b214bcfd7d20a63eae1020e6b2
+  metadata.gz: 9f28de2c590cd7b7b1e6f697ee8a7754b2229dd1
+  data.tar.gz: 4a5e1f2611b17b356af7660225d9bb5851131a7d
 SHA512:
-  metadata.gz: 2a2122e343b6ac01a63e2fb0b872f0e03a00d5fd7ee1337df1258bac60bcc2f6fa859e15e3df04ef6fe35ed5575165bbb5b2cd001f2adc32238f8f6449e75a7a
-  data.tar.gz: a29e038eba07930db404505bcf59e0e7cb39f2e807eff1bfdc3fb8cbe64f1addb1fd7f1824f4815b1334c775864011c261d1fdbebce04907dbf22176531fe43e
+  metadata.gz: c4f74bc929c9286f645fa652dfb8cace3ad70b463ca29272eb55a48b61ad1273239221c5ace8d10428c45423439fe64cf0675c19df3b66e6d2327900b92b9bb5
+  data.tar.gz: b1df82262931a447f99670d097dc662cac1b6c21733709640bea16d0133c4dbd143f3e792cfd4c88921ad3f95ba56d49ae874ea01a153a2424f41ea355d17984

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 1.5.0
+
+Bugfix:
+
+- GET requests with the same URL as PUT requests shouldn't use the etag cached version.
+
+## 1.4.8/1.4.9
+
+Bugfix:
+
+- Responses without content (202, 204) will return an empty object.
+
 ## 1.4.7
 
 Bugfix:

data/lib/flexirest/caching.rb

@@ -49,7 +49,7 @@ module Flexirest
       end
 
       def read_cached_response(request)
-        if cache_store && perform_caching
+        if cache_store && perform_caching && request.method[:method] == :get
           key = "#{request.class_name}:#{request.original_url}"
           Flexirest::Logger.debug "  \033[1;4;32m#{Flexirest.name}\033[0m #{key} - Trying to read from cache"
           value = cache_store.read(key)

data/lib/flexirest/version.rb

@@ -1,3 +1,3 @@
 module Flexirest
-  VERSION = "1.4.9"
+  VERSION = "1.5.0"
 end

data/spec/lib/caching_spec.rb

@@ -119,6 +119,7 @@ describe Flexirest::Caching do
         perform_caching true
         base_url "http://www.example.com"
         get :all, "/"
+        put :save_all, "/"
       end
 
       Person.cache_store = CachingExampleCacheStore5.new
@@ -141,6 +142,16 @@ describe Flexirest::Caching do
       expect(ret.first_name).to eq("Johnny")
     end
 
+    it "should not read from the cache store to check for an etag unless it's a GET request" do
+      cached_response = Flexirest::CachedResponse.new(
+        status:200,
+        result:@cached_object,
+        etag:@etag)
+      expect_any_instance_of(CachingExampleCacheStore5).to_not receive(:read)
+      expect_any_instance_of(Flexirest::Connection).to receive(:put).and_return(::FaradayResponseMock.new(OpenStruct.new(status:200, body: {result: "foo"}.to_json, response_headers:{})))
+      ret = Person.save_all
+    end
+
     it 'queries the server when the cache has expired' do
       cached_response = Flexirest::CachedResponse.new(
         status: 200,

data/spec/lib/request_spec.rb

@@ -29,7 +29,7 @@ describe Flexirest::Request do
       get :headers, "/headers"
       put :headers_default, "/headers_default"
       put :headers_json, "/headers_json", request_body_type: :json
-      get :find, "/:id"
+      get :find, "/:id", required: [:id]
       get :change, "/change"
       get :plain, "/plain/:id", plain: true
       post :create, "/create"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flexirest
 version: !ruby/object:Gem::Version
-  version: 1.4.9
+  version: 1.5.0
 platform: ruby
 authors:
 - Andy Jeffries
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-06 00:00:00.000000000 Z
+date: 2017-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler