flexirest 1.4.8 → 1.4.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dba0e20c09300337a907fded156a930de346a476
-  data.tar.gz: ec84a3c462438f8a9de3b854bee9e36de9b37a6b
+  metadata.gz: fb5d697d79a1b6068d551ea5346b87d83189eaad
+  data.tar.gz: 727a87951be313b214bcfd7d20a63eae1020e6b2
 SHA512:
-  metadata.gz: de7100e5145ac080cff313e89fe5e3e4bdb46e825fb11dd7e4e08fa430dcdf8e91999484ff5dd3ec81fe20672e280e8ee153123c98eb11e41870e99aadfa7246
-  data.tar.gz: f8ad4fc66b881b3f3f918ceed673bbba196569a4a1d519fcc1d722852728b9eefbba4407b3b12385138eabfe60886db77bac5bb90d52ccde1762a4d8d8e49a48
+  metadata.gz: 2a2122e343b6ac01a63e2fb0b872f0e03a00d5fd7ee1337df1258bac60bcc2f6fa859e15e3df04ef6fe35ed5575165bbb5b2cd001f2adc32238f8f6449e75a7a
+  data.tar.gz: a29e038eba07930db404505bcf59e0e7cb39f2e807eff1bfdc3fb8cbe64f1addb1fd7f1824f4815b1334c775864011c261d1fdbebce04907dbf22176531fe43e

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.4.7
+
+Bugfix:
+
+- Responses without content (202, 204) will still make the headers available in `_headers`.
+
 ## 1.4.6
 
 Feature:

data/lib/flexirest/request.rb

@@ -470,7 +470,8 @@ module Flexirest
         if @method[:options][:plain]
           return @response = Flexirest::PlainResponse.from_response(response)
         elsif [202, 204].include?(status) && @response.body.blank?
-          return true
+          @response.body = "{}"
+          return @response = Flexirest::PlainResponse.from_response(response)
         elsif is_json_response? || is_xml_response?
           if @response.respond_to?(:proxied) && @response.proxied
             Flexirest::Logger.debug "  \033[1;4;32m#{Flexirest.name}\033[0m #{@instrumentation_name} - Response was proxied, unable to determine size"

data/lib/flexirest/version.rb

@@ -1,3 +1,3 @@
 module Flexirest
-  VERSION = "1.4.8"
+  VERSION = "1.4.9"
 end

data/spec/lib/request_spec.rb

@@ -34,6 +34,7 @@ describe Flexirest::Request do
       get :plain, "/plain/:id", plain: true
       post :create, "/create"
       post :test_encoding, "/encoding", request_body_type: :json
+      post :testing_no_content_headers, "/no-content"
       put :update, "/put/:id"
       put :conversion, "/put/:id", parse_fields: [:converted]
       delete :remove, "/remove/:id"
@@ -556,6 +557,16 @@ describe Flexirest::Request do
     VerboseExampleClient.all
   end
 
+  it "should return the headers still for 202 responses" do
+    fake_location = "https://foo.example.com/123"
+    expect_any_instance_of(Flexirest::Connection).
+      to receive(:post).
+      with("/no-content", "", an_instance_of(Hash)).
+      and_return(::FaradayResponseMock.new(OpenStruct.new(body:"", response_headers:{"location" => fake_location}, status:202)))
+    response = ExampleClient.testing_no_content_headers
+    expect(response._headers["location"]).to eq(fake_location)
+  end
+
   it "should raise an unauthorised exception for 401 errors" do
     expect_any_instance_of(Flexirest::Connection).
       to receive(:post).

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flexirest
 version: !ruby/object:Gem::Version
-  version: 1.4.8
+  version: 1.4.9
 platform: ruby
 authors:
 - Andy Jeffries
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-01 00:00:00.000000000 Z
+date: 2017-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler