flexirecord 1.0.5 → 1.0.6

data/CHANGELOG

@@ -85,3 +85,11 @@
 
 - Release of version 1.0.5
 
+- 2007-04-17:
+  - >
+    When a database error occurs, the corresponding connection is marked as "spoiled" and will not be reused by the current or other threads. This is neccessary to get rid of broken connections, as the ruby "postgres" library doesn't pass PostgreSQL error codes, making it impossible to cleanly detect bad connections.
+  - >
+    PGError's raised during opening of a connection are now catched and transformed to FlexiRecord::DatabaseError exceptions.
+
+- Release of version 1.0.6
+

data/lib/flexirecord.rb

@@ -1256,12 +1256,22 @@ module FlexiRecord
         end
         options[:data_types] = @data_types.freeze
       end
-      @backend_connection = PGconn.new(@host, @port, @options, nil, @dbname, @login, @passwd)
+      begin
+        @backend_connection = PGconn.new(@host, @port, @options, nil, @dbname, @login, @passwd)
+      rescue PGError
+        raise FlexiRecord::DatabaseError, $!.message
+      end
       @transaction_stacklevel = 0
       @isolation_level = nil
+      @spoiled = false
       nil
     end
 
+    # Returns true, if an error has been occured in the lifetime of this connection.
+    def spoiled?
+      @spoiled
+    end
+
     # Executes an SQL query and returns an Array of objects of 'record_class' (which should be a sub-class of BaseRecord). The 'command_template' is an SQL statement with '$' placeholders to be replaced by the following 'command_arguments'.
     def record_query(record_class, command_template, *command_arguments)
       command = command_template.to_s.gsub(/\$([^0-9]|$)/) {
@@ -1374,6 +1384,7 @@ module FlexiRecord
           end
         end
       rescue PGError
+        @spoiled = true
         raise FlexiRecord::DatabaseError, $!.message
       end
     end
@@ -1506,7 +1517,7 @@ module FlexiRecord
 
     # Implementation of ThreadResourcePool#reset_resource.
     def reset_resource(connection)
-      true
+      not connection.spoiled?
     end
 
     # Implementation of ThreadResourcePool#destroy_resource.

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.0
 specification_version: 1
 name: flexirecord
 version: !ruby/object:Gem::Version 
-  version: 1.0.5
-date: 2007-03-25 00:00:00 +00:00
+  version: 1.0.6
+date: 2007-04-17 00:00:00 +00:00
 summary: Object-Oriented Database Access Library (ORM layer)
 require_paths: 
 - lib/