flash_notifier 1.1.2 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 75944ca872c8b6fc662849cbb654b593915623492328075bf2205dd1ea8702b6
-  data.tar.gz: e5f1862f429f308aad8bf011e7184c9c4ee1972f06fd02e4dd64844456220888
+  metadata.gz: a3256228195c8f57bfca429d0abb7a1eee5fae34930f28b0e252909b1a1c1be7
+  data.tar.gz: ab80d59b266672f2971426e57a62cc825bada57e1dd5b0de95e2b1871c3c4432
 SHA512:
-  metadata.gz: 23e9fda1af08594e39b09d77428a91a38b7284e25a0763a6fe308d349fc2e6790c05a8f4a1fa63c530f212a18e379f969299fbeec3c46eaff98a69075716fd20
-  data.tar.gz: e92df230689dfe367b9d9fdb8ba11aaa336bfb62beef52634e21e8122aac4c0775046bde77e633e270b22e917c4e5f6e31b4763a231faa40bb446a38bfa386b2
+  metadata.gz: 2251e75db6ee7ec1aabbcefc71347a23a60c22b1f9277d4df9656fe041347367a4a70cad0ef6d8cbe417e0ac50969fe89307ce1f5152e63a1672b32986e7a1c5
+  data.tar.gz: 9ffe5429f0a4dd0f1e4cd860119d2130ffba857b64c5a4e4370a979b640186dffffda1afa80e6f60bfd9eea469cba6c1a68d3717b891fb48a3d3893534207e67

data/README.md

@@ -67,14 +67,10 @@ In your layout add this helper method
     <%= build_flash %>
     
 ### Optional Step 3: Pass options to helper method  
-
-For Onscreen positioning of flash message pass param
-
-    <%= build_flash placement: 'topRight' %>
     
 To manage progress bar pass param
 
-    <%= build_flash progress_bar: true %>
+    <%= build_flash progressBar: true %>
     
 To set auto hide timeout pass param
 
@@ -84,7 +80,7 @@ To set default theme pass param (Note this param works only for Noty JS)
 
      <%= build_flash theme: 'mint' %>
     
-##### Values for these params can be found here [Noty JS](https://ned.im/noty/#/options), [Toastr JS](https://codeseven.github.io/toastr/demo.html)
+##### Values for these params and additional config options can be found here [Noty JS](https://ned.im/noty/#/options), [Toastr JS](https://codeseven.github.io/toastr/demo.html)
 
 ## Contributing
 

data/lib/flash_notifier/flash_helper.rb

@@ -4,7 +4,7 @@ module FlashHelper
     html = append_options_to_dom options
     flash.each do |type, message|
       flash_type = (%w(notice success).include?(type)) ? 'success' : (( %w(alert error).include?(type)) ? 'error' : (%w(warning info).include?(type) ? type : 'info' ))
-      html += content_tag(:div, '' , data: { flash_notifier: 'inside gem', flash_type: flash_type, flash_msg: escape_javascript(message) })
+      html += content_tag(:div, '' , data: { flash_notifier: '', flash_type: flash_type, flash_msg: escape_javascript(message) })
     end
     html.html_safe
   end

data/lib/flash_notifier/version.rb

@@ -1,3 +1,3 @@
 module FlashNotifier
-  VERSION = "1.1.2"
+  VERSION = "1.2.0"
 end

data/vendor/assets/javascripts/common.coffee

@@ -1,7 +1,6 @@
-window.fetchFlashOption = (attribute, defaultValue) ->
+window.fetchFlashOptions = ->
   options = $('[data-flash-notifier-options]').data('flash-notifier-options')
-  option = eval("options.#{attribute}")
-  if option == undefined then defaultValue else option
+  if Object.keys(options).length > 0 then options else {}
 
 window.initializeFlashNotifier = (method) ->
   try

data/vendor/assets/javascripts/noty_flash.coffee

@@ -1,17 +1,9 @@
 buildNotyFlash = () ->
-  Noty.overrideDefaults({
-    layout: fetchFlashOption('placement','topRight')
-    theme: fetchFlashOption('theme','mint')
-    timeout: fetchFlashOption('timeout','3500')
-    progressBar: fetchFlashOption('progress_bar',false)
-  })
+  Noty.overrideDefaults(fetchFlashOptions())
   $.each $('[data-flash-notifier]') , (index , val) ->
    new Noty({
      text: $(val).data('flash-msg')
      type: $(val).data('flash-type')
-     theme: 'mint'
-     timeout: 4000
-     progressBar: false
    }).show()
 
 initializeFlashNotifier(buildNotyFlash)

data/vendor/assets/javascripts/toastr_flash.coffee

@@ -1,10 +1,9 @@
 buildFlash = () ->
-  toastr.options =
-    positionClass: fetchFlashOption('placement', 'toast-bottom-right')
-    timeOut: fetchFlashOption('timeout','3500')
-    progressBar: fetchFlashOption('progress_bar',false)
+  toastr.options = fetchFlashOptions()
 
   $.each $('[data-flash-notifier]'), (index, val) ->
     eval("toastr.#{$(val).data('flash-type')}('#{$(val).data('flash-msg')}')")
 
+buildOptions = () ->
+
 initializeFlashNotifier(buildFlash)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flash_notifier
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.2.0
 platform: ruby
 authors:
 - Fakhir Shad
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-28 00:00:00.000000000 Z
+date: 2019-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler