flaky-friend 0.3.0 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c996492175a4e470f3ea4c08890a4626c90e4de13e35e33a1d919ef41a5b04b6
-  data.tar.gz: a7a08059d87983af6e0b163177cee5db2f659201f92267a338355e6b6df71024
+  metadata.gz: 3b8649d4ba762628bf9970b0e493e3d2ab06f7662d136b5f2809816fe243185a
+  data.tar.gz: b5db3f2cc290f02fb848ecd08ff72935a5727e8aacad548bad6cf41a83ada669
 SHA512:
-  metadata.gz: 7282d21702ca0d52b80c74c01dc6bf8fce827f4543bd082a45f57d2080b04d9cbc8b866b10aee1352a74ca1f0279cc3ba73d1baed98911b6843428bb5a184662
-  data.tar.gz: 5201e17baf1732b2cd21879c391021ba96d0a38a0a9b59970225c6b8f2cba52aaf4b72697e6ac052d9af17cc67bbb28336eb3685dcbb19e2daa0e1ef721e743b
+  metadata.gz: daf4b72ca24fcd98aa0d8a5d9ad8c2d40f465349b3f1bf75c536b820c4297bbaa962dde693c1906db0bc427e58136af7978d611a3319490772cef367081ea1d4
+  data.tar.gz: c9594cf996ef4461c496066f94e9eda162400ccf266a371e5331c1bbf216f8261422835933ba7c139a327e7de5a8e17bb78af20eb4e049c12f9155e14507e5a4

data/lib/flaky/commands/rank.rb

@@ -24,13 +24,12 @@ module Flaky
         total_runs = @repo.total_runs_count(branch: branch, since_days: @since_days)
 
         puts "Flaky tests on #{branch} (last #{@since_days} days, #{total_runs} CI runs):\n\n"
-        puts format("%-6s %-50s %s", "Fails", "Location", "Last Failure")
+        puts format("%-6s %s", "Fails", "Location")
         puts "-" * 90
 
         rows.each_with_index do |row, i|
           location = "#{row['spec_file']}:#{row['line_number']}"
-          truncated = location.length > 48 ? "...#{location[-45..]}" : location
-          puts format("%-6d %-50s %s", row["failure_count"], truncated, row["last_failure"])
+          puts format("%-6d %s  (%s)", row["failure_count"], location, row["last_failure"])
 
           if i == 0
             puts "\n  \e[33m▶ Next to investigate:\e[0m #{location}"

data/lib/flaky/commands/stress.rb

@@ -18,13 +18,14 @@ module Flaky
         env = {}
         env["FLAKY_CI_SIMULATE"] = "1" if @ci_simulate
 
+        seed = resolve_seed
         passes = 0
         failures = 0
-        failed_seeds = []
+        failed_seeds = Set.new
         start_time = Time.now
 
         puts "Stress testing: #{@spec_location}"
-        puts "  Iterations: #{@iterations}, Seed: #{@seed || 'random'}, CI simulation: #{@ci_simulate}"
+        puts "  Iterations: #{@iterations}, Seed: #{seed_description(seed)}, CI simulation: #{@ci_simulate}"
         puts ""
 
         @iterations.times do |i|
@@ -34,7 +35,7 @@ module Flaky
             break
           end
 
-          run_seed = @seed || rand(100_000)
+          run_seed = seed.presence || rand(100_000)
           cmd = "bundle exec rspec #{@spec_location} --seed #{run_seed} --format progress 2>&1"
 
           output = nil
@@ -50,7 +51,7 @@ module Flaky
             print "\e[32m.\e[0m"
           else
             failures += 1
-            failed_seeds << run_seed
+            failed_seeds.add(run_seed)
             print "\e[31mF\e[0m"
           end
         end
@@ -68,14 +69,47 @@ module Flaky
         end
 
         @repo.insert_stress_run(
-          spec_location: @spec_location, seed: @seed, iterations: @iterations,
-          passes: passes, failures: failures, ci_simulation: @ci_simulate ? 1 : 0
+          spec_location: @spec_location, seed: @seed.is_a?(Integer) ? @seed : nil,
+          iterations: @iterations, passes: passes, failures: failures,
+          ci_simulation: @ci_simulate ? 1 : 0
         )
 
         exit(failures > 0 ? 1 : 0)
       ensure
         @repo.close
       end
+
+      private
+
+      def resolve_seed
+        case @seed
+        when :random
+          nil
+        when Integer
+          @seed
+        when nil
+          file, line = parse_location(@spec_location)
+          db_seeds = @repo.failing_seeds(file: file, line: line)
+          db_seeds.any? ? db_seeds.first : nil
+        end
+      end
+
+      def seed_description(seed)
+        case @seed
+        when :random then "random"
+        when Integer then @seed.to_s
+        else seed.present? ? seed.to_s : "random (no known failing seeds)"
+        end
+      end
+
+      def parse_location(loc)
+        if loc.include?(":")
+          parts = loc.rpartition(":")
+          [parts[0], parts[2].to_i]
+        else
+          [loc, nil]
+        end
+      end
     end
   end
 end

data/lib/flaky/repository.rb

@@ -147,6 +147,23 @@ module Flaky
       connection.execute("SELECT * FROM stress_runs ORDER BY created_at DESC LIMIT ?", limit)
     end
 
+    # --- Seeds ---
+
+    def failing_seeds(file:, line: nil)
+      conditions = ["spec_file LIKE ?"]
+      params = ["%#{file}%"]
+
+      if line
+        conditions << "line_number = ?"
+        params << line
+      end
+
+      connection.execute(
+        "SELECT seed, COUNT(*) AS n FROM test_failures WHERE #{conditions.join(' AND ')} GROUP BY seed ORDER BY n DESC, MAX(failed_at) DESC",
+        params
+      ).map { |row| row["seed"] }
+    end
+
     # --- Stress ---
 
     def insert_stress_run(spec_location:, seed:, iterations:, passes:, failures:, ci_simulation:)

data/lib/flaky/tasks/flaky.rake

@@ -36,7 +36,7 @@ FLAKY_HELP = <<~HELP
     SINCE      Number of days to look back for rank               [default: 30]
     SPEC       Spec file location (path/to/spec.rb or path:line)
     N          Number of stress test iterations                   [default: 20]
-    SEED       RSpec seed for deterministic ordering
+    SEED       RSpec seed (omit=use known failing seeds, "random"=random)
     CI         Set to "true" to enable CI simulation (latency + reduced threads)
     TIMEOUT    Stress test timeout in seconds                     [default: 600]
 
@@ -78,10 +78,15 @@ namespace :flaky do
   task stress: :environment do
     require "flaky/commands/stress"
     spec = ENV["SPEC"] || abort("Usage: bin/rails flaky:stress SPEC=path/to/spec.rb:42")
+    seed = case ENV["SEED"]
+           when nil then nil
+           when "random" then :random
+           else ENV["SEED"].to_i
+           end
     Flaky::Commands::Stress.new(
       spec_location: spec,
       iterations: ENV.fetch("N", "20").to_i,
-      seed: ENV["SEED"]&.to_i,
+      seed: seed,
       ci_simulate: ENV["CI"] == "true",
       timeout: ENV.fetch("TIMEOUT", "600").to_i
     ).execute

data/lib/flaky/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Flaky
-  VERSION = "0.3.0"
+  VERSION = "0.3.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flaky-friend
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.3
 platform: ruby
 authors:
 - Flytedesk