flakey 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 041d20dc5bd4b3566cbb859cbb99a260c2365221
-  data.tar.gz: 2e2067c4e18a57ade6106b071f862c9696a40f51
+  metadata.gz: e5e3a881d55a7d7af795bf39c525efe323afa076
+  data.tar.gz: 7dac21622501551c67bb98edb50b56a7a60c59e1
 SHA512:
-  metadata.gz: ea453dcf9f83cf2d06f891a8b8e76d8f54a420f44cace9607a71f30f8125c0d1384ad8e794cf6b1346aaf789ed35319e2bef42ce7516dd68278b108cba191887
-  data.tar.gz: 284773f6648fffeedeae1751e69442c22fcb06d01579fe5bfaf50b903efae2e2f62106c6a1d586628d0c66e569798d4fa553aa44cc95571644773620b25babb8
+  metadata.gz: fccba15c21831ae81f4bca70eb1ca14c4388706725ce86555f42f0cd5ebbda3cba04be07f9126a90ac2b54805858fc456d5fb283dc81219263b12183edfd78de
+  data.tar.gz: 4502b6794fc4aededa6b02bc6fbbb6fa7aa02e95579ef4430b189cdf35badd35844d8d271f33ef9d28dfe3e2ba9416e6637de46f635d5f7be6fb8be0afc4c525

data/lib/flakey/facebook.rb

@@ -1,6 +1,11 @@
 module Flakey
   module Facebook
     SHARE_URL = 'https://www.facebook.com/sharer/sharer.php'
+    #
+    # Needed to be able to pass a block down into link_to.
+    # See the share_button method.
+    # INFO: http://stackoverflow.com/a/7562194/574190
+    attr_accessor :output_buffer
 
     def facebook_nickname(options = {})
       options[:nickname] ||
@@ -45,11 +50,26 @@ module Flakey
     # INFO: http://goo.gl/MvqIi4
     #
     # Returns a HTML string.
-    def share_button(options = {})
-      label = options[:label] || 'Share'
-      url = options[:url] || request.url
+    def share_button(options = {}, &block)
+      defaults = {
+        url: request.url,
+        label: 'Share',
+        target: '_blank',
+        class: 'facebook-share-button'
+      }
+
+      settings = defaults.merge options
+
+      url = "#{SHARE_URL}?u=#{CGI.escape settings[:url]}"
+      label = settings[:label]
+      settings.delete(:url)
+      settings.delete(:label)
 
-      link_to label, "#{SHARE_URL}?u=#{url}", target: '_blank'
+      if block_given?
+        link_to(url, settings, &block)
+      else
+        link_to label, url, settings
+      end
     end
   end
 end

data/lib/flakey/version.rb

@@ -1,3 +1,3 @@
 module Flakey
-  VERSION = "0.2.2"
+  VERSION = "0.3.0"
 end

data/spec/flakey/facebook_spec.rb

@@ -0,0 +1,31 @@
+# encoding: UTF-8
+require "spec_helper"
+require 'action_view'
+
+class DummyHelper
+  include ::ActionView::Helpers::UrlHelper
+  include Flakey::Facebook
+end
+
+describe Flakey::Facebook do
+  subject { DummyHelper.new }
+
+  describe 'share_button' do
+    before { subject.stub_chain('request.url') { 'http://example.com/hello' } }
+    let(:default_url) do
+      "#{Flakey::Facebook::SHARE_URL}?u=http%3A%2F%2Fexample.com%2Fhello"
+    end
+
+    it 'should add the url' do
+      subject.share_button.should include(default_url)
+    end
+
+    it 'should have a class' do
+      subject.share_button.should include('class="facebook-share-but')
+    end
+
+    it 'should render a label' do
+      subject.share_button(label: 'Grinnick').should include('>Grinnick</a>')
+    end
+  end
+end

data/spec/flakey/twitter_spec.rb

@@ -58,7 +58,9 @@ describe Flakey::Twitter do
 
   describe 'custom_tweet_button' do
     before { subject.stub_chain('request.url') { 'http://example.com/hello' } }
-    let(:default_url) { "#{Flakey::Twitter::SHARE_URL}?url=http%3A%2F%2Fexample.com%2Fhello" }
+    let(:default_url) do
+      "#{Flakey::Twitter::SHARE_URL}?url=http%3A%2F%2Fexample.com%2Fhello"
+    end
 
     it 'should include the default url and label' do
       subject.should_receive(:link_to)

data/vendor/assets/javascripts/flakey/popup.js

@@ -20,7 +20,7 @@ if (typeof jQuery === "undefined") {
   };
 
   $(function(){
-    $('.custom-tweet-button').on('click', function(e){
+    $('.custom-tweet-button, .facebook-share-button').on('click', function(e){
       e.preventDefault();
       openPopup($(e.target).closest('a').attr('href'), 'twitter');
     });

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flakey
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.0
 platform: ruby
 authors:
 - David Tuite
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-28 00:00:00.000000000 Z
+date: 2013-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -89,6 +89,7 @@ files:
 - lib/flakey/stackoverflow.rb
 - lib/flakey/twitter.rb
 - lib/flakey/version.rb
+- spec/flakey/facebook_spec.rb
 - spec/flakey/twitter_spec.rb
 - spec/spec_helper.rb
 - vendor/assets/javascripts/flakey/facebook.js.erb
@@ -119,5 +120,6 @@ signing_key:
 specification_version: 4
 summary: Makes a bunch of helper methods available for including in your Rails views.
 test_files:
+- spec/flakey/facebook_spec.rb
 - spec/flakey/twitter_spec.rb
 - spec/spec_helper.rb