flag_shih_tzu 0.3.21 → 0.3.22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8433736f25b1a4e35506a62d4379bca4a604c356890784361bd9dc5f6da1d281
-  data.tar.gz: 7280c2aa6c7ab7e08a733c412496b399f7d1f7369ec8ab871f12a75cd90ddb1e
+  metadata.gz: 5e43199789d6c30b71d15139ed647229e02f49116c45c4f4b7780b1d8a37f8b2
+  data.tar.gz: 7d5616a0535b314704e7d71420d2bbd3f3075e1aafd9a0ee9a77f8ab7974a425
 SHA512:
-  metadata.gz: f669b8f544f906f217b02538da085c2862d373cf6cd84648033461762cea501827ced978955ee6bb2fdc67c01643a51ddf1fbdd3925fab7b997a16041a220000
-  data.tar.gz: 2eef7f1dbf8cc80927c292f60fc1acc4e21ec4ee12683c00bf85495efac39494dc013cd0c48bd1d12a3fc5eb1d31ac1b5721a5f563fb541eba068b1de840e743
+  metadata.gz: b7e2245c742d73eaa3b9099fee558f276d18507e65f079b951a23d170ded6128564b72a1a94aaa89556b5b34241891128f6bd702f41e05b8ea1b36de6f44d239
+  data.tar.gz: 4dd8a47b5730c3ace7e6ae611efeaad46e4a983d4d7a0e01fe94c35e41fc945e09244fef47d15a49ca64ab8ce0b8cf5983c8055e577c8d13697ff7989c56adab

data/CHANGELOG.md

@@ -2,10 +2,16 @@
 
 * Work merged into master branch goes here until it is released.
 
+# Version 0.3.22 - SEP.18.2018
+
+* When #selected_flags= passed with nil it clears flag bits, by xpol
+  - This makes flag_shih_tzu behave like Rails: converts empty array to nil.
+
 # Version 0.3.21 - SEP.09.2018
 
+* Make required minimum Ruby version explicit: 1.9.3 and up by Peter Boling
 * Support Rails 5.2 by Peter Boling
-* Add Ruby 2.5 to build, and update/fix build
+* Add Ruby 2.5 to build, and update/fix build by Peter Boling
 
 # Version 0.3.20 - SEP.08.2018
 
@@ -31,7 +37,7 @@
 # Version 0.3.16 - JAN.16.2017
 
 * Fix complex custom sql queries with multiple references to the column by vegetaras
-* Improved documentation and compatibility matrix by pboling
+* Improved documentation and compatibility matrix  by Peter Boling
 
 # Version 0.3.15 - OCT.11.2015
 

data/README.md

@@ -5,9 +5,9 @@ Bit fields for ActiveRecord
 | Project                 |  FlagShihTzu      |
 |------------------------ | ----------------- |
 | gem name                |  flag_shih_tzu    |
-| license                 |  [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT) |
+| license                 |  [![License: MIT](https://img.shields.io/badge/License-MIT-green.svg)](https://opensource.org/licenses/MIT) |
 | expert support          |  [![Get help on Codementor](https://cdn.codementor.io/badges/get_help_github.svg)](https://www.codementor.io/peterboling?utm_source=github&utm_medium=button&utm_term=peterboling&utm_campaign=github) |
-| download rank           |  [![Total Downloads](https://img.shields.io/gem/rt/flag_shih_tzu.svg)](https://rubygems.org/gems/flag_shih_tzu) |
+| download rank           |  [![Total Downloads](https://img.shields.io/gem/rt/flag_shih_tzu.svg)](https://rubygems.org/gems/flag_shih_tzu) [![Daily Downloads](https://img.shields.io/gem/rd/flag_shih_tzu.svg)](https://rubygems.org/gems/flag_shih_tzu) |
 | version                 |  [![Gem Version](https://badge.fury.io/rb/flag_shih_tzu.png)](http://badge.fury.io/rb/flag_shih_tzu) |
 | dependencies            |  [![Depfu](https://badges.depfu.com/badges/f011a69cf2426f91483aaade580823ac/count.svg)](https://depfu.com/github/pboling/flag_shih_tzu?project_id=2685) |
 | code quality            |  [![Code Climate](https://codeclimate.com/github/pboling/flag_shih_tzu.png)](https://codeclimate.com/github/pboling/flag_shih_tzu) |
@@ -82,7 +82,7 @@ The gem is actively being tested against:
 
 * Ruby 1.8.7 compatibility is in the [0.2.X branch](https://github.com/pboling/flag_shih_tzu/tree/0.2.X) and no further releases are expected.  If you need a patch submit a pull request.
 
-* Ruby 1.9.3, 2.0.0, and 2.1.0 compatibility is still current on master, and the 0.3.x series releases, but those EOL'd Rubies, and any others that become EOL'd in the meantime, will not be supported in the next major release, version 1.0.
+* Ruby 1.9.3, 2.0.0, 2.1.x, and 2.2.x compatibility is still current on master, and the 0.3.x series releases, but those EOL'd Rubies, and any others that become EOL'd in the meantime, will not be supported in the next major release, version 1.0.
 
 ## Installation
 

data/bin/test.bash

@@ -64,6 +64,16 @@ do
   run_all_tests_for $rvm_ruby_version $rails_version
 done
 
+# Then run the tests for all versions supported on Ruby 2.5.1
+COMPATIBLE_VERSIONS=(5.0.x 5.1.x 5.2.x)
+Count=0
+while [ "x${COMPATIBLE_VERSIONS[Count]}" != "x" ]
+do
+  rvm_ruby_version=2.5.1
+  rails_version=${COMPATIBLE_VERSIONS[Count]}
+  run_all_tests_for $rvm_ruby_version $rails_version
+done
+
 # Then run the tests for all versions supported on jruby-1.7.26
 #   (which appears to pass for 3.1 - 4.2 inclusive)
 # TODO: Investigate 2 failures on Rails 2.3 and 3.0

data/lib/flag_shih_tzu.rb

@@ -224,6 +224,7 @@ To turn off this warning set check_for_column: false in has_flags definition her
             # useful for a form builder
             def selected_#{colmn}=(chosen_flags)
               unselect_all_flags("#{colmn}")
+              return if chosen_flags.nil?
               chosen_flags.each do |selected_flag|
                 enable_flag(selected_flag.to_sym, "#{colmn}") if selected_flag.present?
               end
@@ -514,6 +515,7 @@ To turn off this warning set check_for_column: false in has_flags definition her
   # use selected_#{column}= for custom column names.
   def selected_flags=(chosen_flags)
     unselect_all_flags
+    return if chosen_flags.nil?
     chosen_flags.each do |selected_flag|
       if selected_flag.present?
         enable_flag(selected_flag.to_sym, DEFAULT_COLUMN_NAME)

data/lib/flag_shih_tzu/version.rb

@@ -1,3 +1,3 @@
 module FlagShihTzu
-  VERSION = "0.3.21"
+  VERSION = "0.3.22"
 end

data/test/flag_shih_tzu_test.rb

@@ -846,6 +846,29 @@ class FlagShihTzuInstanceMethodsTest < Test::Unit::TestCase
     assert !@spaceship.has_flag?
   end
 
+  def test_should_define_a_selected_flags_writer_method
+    @spaceship.selected_flags = [:warpdrive]
+    assert @spaceship.warpdrive
+    assert !@spaceship.shields
+    assert !@spaceship.electrolytes
+
+    @spaceship.selected_flags = [:warpdrive, :shields, :electrolytes]
+    assert @spaceship.warpdrive
+    assert @spaceship.shields
+    assert @spaceship.electrolytes
+
+    @spaceship.selected_flags = []
+    assert !@spaceship.warpdrive
+    assert !@spaceship.shields
+    assert !@spaceship.electrolytes
+
+    @spaceship.selected_flags = [:warpdrive, :shields, :electrolytes]
+    @spaceship.selected_flags = nil
+    assert !@spaceship.warpdrive
+    assert !@spaceship.shields
+    assert !@spaceship.electrolytes
+  end
+
   # --------------------------------------------------
 
   def test_should_define_a_customized_all_flags_reader_method
@@ -901,6 +924,10 @@ class FlagShihTzuInstanceMethodsTest < Test::Unit::TestCase
     @small_spaceship.selected_bits = []
     assert !@small_spaceship.warpdrive
     assert !@small_spaceship.hyperspace
+
+    @small_spaceship.selected_bits = nil
+    assert !@small_spaceship.warpdrive
+    assert !@small_spaceship.hyperspace
   end
 
   def test_should_define_a_customized_has_flag_method
@@ -1007,6 +1034,13 @@ class FlagShihTzuInstanceMethodsTest < Test::Unit::TestCase
     assert !@big_spaceship.hyperspace
     assert !@big_spaceship.jeanlucpicard
     assert !@big_spaceship.dajanatroj
+
+    @big_spaceship.selected_bits = nil
+    @big_spaceship.selected_commanders = nil
+    assert !@big_spaceship.warpdrive
+    assert !@big_spaceship.hyperspace
+    assert !@big_spaceship.jeanlucpicard
+    assert !@big_spaceship.dajanatroj
   end
 
   def test_should_define_a_customized_has_flag_method_with_2_columns

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flag_shih_tzu
 version: !ruby/object:Gem::Version
-  version: 0.3.21
+  version: 0.3.22
 platform: ruby
 authors:
 - Peter Boling
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-09 00:00:00.000000000 Z
+date: 2018-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord