flag_shih_tzu 0.3.11 → 0.3.12

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MDhlNTc4NzQ0MDQ4Y2UxY2YwODM0ZTM0MzYzODZhNDZmY2JiMzU2ZQ==
-  data.tar.gz: !binary |-
-    YWZjMDBiZTE4YWRhZjI3MDhiYjRiMjk0NDBiOTJlNTE5NGUzOTk3OQ==
+SHA1:
+  metadata.gz: 90b55064f920798177d3ca8c7eaf24141d275266
+  data.tar.gz: 4c56f730ebcd6de7721312f81809ecede06cbcd7
 SHA512:
-  metadata.gz: !binary |-
-    ZTlkMzY1YTc2YWZkZmVkZmRiMTQ4OTliYmIyYTg2NDBkZGFmYTlmMmNhOGQw
-    MTZjZTYxY2IzMzc1ZThjMjZjYmRkMzc0Y2ZiYjkwNjE5ZTA2MjUxYWVlMDk5
-    ZGE2MzRhNGFhNDU0ZWIwNDU4OTA5YzllZjAzMjMxYmY0NzljZDM=
-  data.tar.gz: !binary |-
-    MWVhM2NiYmU3ZjQ3NGExNzZmOGZiZDU2ZmM1OWZmZWNlZjk4MzYzNTQ5YmNj
-    M2Q1YjE2ZjI2NDNkNzQ5YjhkZmNiZTNmYzFiOThiYTk1MGY1N2QzMGZmMTFh
-    ZWJiY2UyZGJlMzM5YTlhMDg4MDRlZDhmNzFkNmY5Mjc1ODVjOTQ=
+  metadata.gz: 3b9a1d00be762409224b7cafd6244a93cf062ff721d218ea5c9b167ee6963cfa1a1a1ba8ce3b24ae71146df74e674771d58e9139b139eb4c822c7af0546f108b
+  data.tar.gz: e5438b3889ca9d3caf04d18b54ecc26587190368978fa8cc51626b41c30596fa051a08c02a43a98aa3ce36d4a8938845d1e01a4dc87e3d651f5ecc5ad64fd2a6

data/.travis.yml

@@ -14,7 +14,9 @@ matrix:
   exclude:
     - rvm: 2.1.2
       gemfile: gemfiles/Gemfile.activerecord-2.3.x
+    - rvm: 2.1.2
       gemfile: gemfiles/Gemfile.activerecord-3.0.x
+    - rvm: 2.1.2
       gemfile: gemfiles/Gemfile.activerecord-3.1.x
     - rvm: 2.0.0
       gemfile: gemfiles/Gemfile.activerecord-2.3.x
@@ -22,4 +24,5 @@ matrix:
       gemfile: gemfiles/Gemfile.activerecord-4.1.x
     - rvm: 1.9.2
       gemfile: gemfiles/Gemfile.activerecord-4.0.x
+    - rvm: 1.9.2
       gemfile: gemfiles/Gemfile.activerecord-4.1.x

data/CHANGELOG

@@ -1,3 +1,13 @@
+Version 0.3.12 - OCT.01.2014
+* Improve testing instructions in readme by Peter Boling
+* fix check_flag_column to return false after warn by Peter Boling
+* bash script for running complete test suite on Ruby 1.9.3 and Ruby 2.1.2 by Peter Boling
+* Improve documentation in readme by trliner
+* use aliases to make attribute reader methods more DRY by trliner
+* add negative attribute reader and writer methods for improved interoperability with simple_form and formtastic by trliner
+* Adds specs for ActiveRecord version 4.1 by Peter Boling
+* Use Kernel#warn instead of puts by Peter Boling
+
 Version 0.3.11 - JUL.09.2014
 * Rename some ambigously-named methods mixed into AR::Base by jdelStrother
 * Add dynamic ".*_values_for" helpers by atipugin

data/README.md

@@ -2,7 +2,7 @@
 
 Bit fields for ActiveRecord
 
-| Project                 |  Sanitize Email   |
+| Project                 |  FlagShihTzu      |
 |------------------------ | ----------------- |
 | gem name                |  flag_shih_tzu    |
 | license                 |  MIT              |
@@ -180,6 +180,9 @@ on Spaceship:
     Spaceship#warpdrive
     Spaceship#warpdrive?
     Spaceship#warpdrive=
+    Spaceship#not_warpdrive
+    Spaceship#not_warpdrive?
+    Spaceship#not_warpdrive=
     Spaceship#warpdrive_changed?
     Spaceship#all_warpdrives
     Spaceship#selected_warpdrives
@@ -191,6 +194,9 @@ on Spaceship:
     Spaceship#shields
     Spaceship#shields?
     Spaceship#shields=
+    Spaceship#not_shields
+    Spaceship#not_shields?
+    Spaceship#not_shields=
     Spaceship#shields_changed?
     Spaceship#all_shields
     Spaceship#selected_shields
@@ -202,6 +208,9 @@ on Spaceship:
     Spaceship#electrolytes
     Spaceship#electrolytes?
     Spaceship#electrolytes=
+    Spaceship#not_electrolytes
+    Spaceship#not_electrolytes?
+    Spaceship#not_electrolytes=
     Spaceship#electrolytes_changed?
     Spaceship#all_electrolytes
     Spaceship#selected_electrolytes
@@ -364,35 +373,29 @@ false to avoid it.
 
 ## Running the gem tests
 
-First, make sure all required gems are installed:
+First, run some infrequent setup:
 
+    $ rvm use 1.9.3
     $ bundle install
-
-The default rake test task will run the tests against the currently locked
-ActiveRecord version (see `Gemfile.lock`):
-
-    $ NOCOVER=true bundle exec rake test
-
-If you want to run the tests against all supported ActiveRecord versions:
-
-* you will need to use ruby 1.9.3 as it is the only version of ruby that bridges the gap between rails 2.3 and rails 4.0
-* you may need to run each bundle once:
-
-
     $ BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-2.3.x' bundle update --quiet
     $ BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-3.0.x' bundle update --quiet
     $ BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-3.1.x' bundle update --quiet
     $ BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-3.2.x' bundle update --quiet
     $ BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-4.0.x' bundle update --quiet
+    $ rvm use 2.1.2
+    $ bundle install
+    $ BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-3.2.x' bundle update --quiet
+    $ BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-4.0.x' bundle update --quiet
+    $ BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-4.1.x' bundle update --quiet
 
 Then just:
 
-    $ NOCOVER=true bundle exec rake test:all
+    $ bundle exec rake test:all
 
-This will internally use bundler to load specific ActiveRecord versions
+This will internally use rvm and bundler to load specific ActiveRecord versions
 before executing the tests (see `gemfiles/`), e.g.:
 
-    $ NOCOVER=true BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-3.1.x' bundle exec rake test
+    $ NOCOVER=true BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-4.1.x' bundle exec rake test
 
 All tests will use an in-memory sqlite database by default.
 If you want to use a different database, see `test/database.yml`,

data/Rakefile

@@ -40,9 +40,6 @@ end
 namespace :test do
   desc 'Test against all supported ActiveRecord versions'
   task :all do
-    %w(2.3.x 3.0.x 3.1.x 3.2.x).each do |version|
-      sh "BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-#{version}' bundle --quiet"
-      sh "BUNDLE_GEMFILE='gemfiles/Gemfile.activerecord-#{version}' bundle exec rake test"
-    end
+    sh "bin/test.bash"
   end
 end

data/bin/test.bash

@@ -0,0 +1,27 @@
+#!/bin/bash --login
+
+# First run the tests of all versions supported on Ruby 1.9.3
+rvm use 1.9.3
+bundle install --quiet
+COMPATIBLE_VERSIONS=(2.3.x 3.0.x 3.1.x 3.2.x 4.0.x)
+count=0
+while [ "x${COMPATIBLE_VERSIONS[count]}" != "x" ]
+do
+  version=${COMPATIBLE_VERSIONS[count]}
+  BUNDLE_GEMFILE="gemfiles/Gemfile.activerecord-$version" bundle install --quiet
+  NOCOVER=true BUNDLE_GEMFILE="gemfiles/Gemfile.activerecord-$version" bundle exec rake test
+  count=$(( $count + 1 ))
+done
+
+# Then run the tests of all versions supported on Ruby 2.1.2
+rvm use 2.1.2
+bundle install --quiet
+COMPATIBLE_VERSIONS=(3.2.x 4.0.x 4.1.x)
+count=0
+while [ "x${COMPATIBLE_VERSIONS[count]}" != "x" ]
+do
+  version=${COMPATIBLE_VERSIONS[count]}
+  BUNDLE_GEMFILE="gemfiles/Gemfile.activerecord-$version" bundle install --quiet
+  NOCOVER=true BUNDLE_GEMFILE="gemfiles/Gemfile.activerecord-$version" bundle exec rake test
+  count=$(( $count + 1 ))
+done

data/gemfiles/Gemfile.activerecord-4.1.x

@@ -0,0 +1,6 @@
+source "http://rubygems.org"
+
+gemspec :path => '..'
+
+gem "activerecord", "~>4.1.0"
+gem "test-unit"

data/lib/flag_shih_tzu.rb

@@ -31,12 +31,12 @@ module FlagShihTzu
       }.update(opts)
       colmn = opts[:column].to_s
       if !is_valid_flag_column_name(opts[:column])
-        puts "FlagShihTzu says: Please use a String to designate column names! I see you here: #{caller.first}"
+        warn "FlagShihTzu says: Please use a String to designate column names! I see you here: #{caller.first}"
         opts[:column] = opts[:column].to_s
       end
       colmn = opts[:column]
       if opts[:check_for_column] && !check_flag_column(colmn)
-        puts "FlagShihTzu says: Flag column #{colmn} appears to be missing!\nTo turn off this warning set check_for_column: false in has_flags definition here: #{caller.first}"
+        warn "FlagShihTzu says: Flag column #{colmn} appears to be missing!\nTo turn off this warning set check_for_column: false in has_flags definition here: #{caller.first}"
         return
       end
 
@@ -67,15 +67,21 @@ module FlagShihTzu
           def #{flag_name}
             flag_enabled?(:#{flag_name}, '#{colmn}')
           end
-
-          def #{flag_name}?
-            flag_enabled?(:#{flag_name}, '#{colmn}')
-          end
+          alias :#{flag_name}? :#{flag_name}
 
           def #{flag_name}=(value)
             FlagShihTzu::TRUE_VALUES.include?(value) ? enable_flag(:#{flag_name}, '#{colmn}') : disable_flag(:#{flag_name}, '#{colmn}')
           end
 
+          def not_#{flag_name}
+            !#{flag_name}
+          end
+          alias :not_#{flag_name}? :not_#{flag_name}
+
+          def not_#{flag_name}=(value)
+            FlagShihTzu::TRUE_VALUES.include?(value) ? disable_flag(:#{flag_name}, '#{colmn}') : enable_flag(:#{flag_name}, '#{colmn}')
+          end
+
           def #{flag_name}_changed?
             if colmn_changes = changes['#{colmn}']
               flag_bit = self.class.flag_mapping['#{colmn}'][:#{flag_name}]
@@ -271,22 +277,15 @@ module FlagShihTzu
           #If you have not yet run the migration that adds the 'flags' column then we don't want to fail, because we need to be able to run the migration
           #If the column is there but is of the wrong type, then we must fail, because flag_shih_tzu will not work
           if found_column.nil?
-            if respond_to?(:logger)
-              logger.warn("Error: Column '#{colmn}' doesn't exist on table '#{custom_table_name}'.  Did you forget to run migrations?") and return false
-            else
-              puts("Error: Column '#{colmn}' doesn't exist on table '#{custom_table_name}'.  Did you forget to run migrations?") and return false
-            end
+            warn("Error: Column '#{colmn}' doesn't exist on table '#{custom_table_name}'.  Did you forget to run migrations?")
+            return false
           elsif found_column.type != :integer
-            raise IncorrectFlagColumnException.new("Table '#{custom_table_name}' must have an integer column named '#{colmn}' in order to use FlagShihTzu.") and return false
+            raise IncorrectFlagColumnException.new("Table '#{custom_table_name}' must have an integer column named '#{colmn}' in order to use FlagShihTzu.")
           end
         else
-          # ActiveRecord gem probably hasn't loaded yet?
-          if respond_to?(:logger)
-            logger.warn("FlagShihTzu#has_flags: Table '#{custom_table_name}' doesn't exist.  Have all migrations been run?") if has_ar
-            return false
-          #else
-          #  puts("FlagShihTzu#has_flags: Table '#{custom_table_name}' doesn't exist.  Have all migrations been run?") and return false
-          end
+          # ActiveRecord gem may not have loaded yet?
+          warn("FlagShihTzu#has_flags: Table '#{custom_table_name}' doesn't exist.  Have all migrations been run?") if has_ar
+          return false
         end
 
         true

data/lib/flag_shih_tzu/version.rb

@@ -1,3 +1,3 @@
 module FlagShihTzu
-  VERSION = "0.3.11"
+  VERSION = "0.3.12"
 end

data/test/flag_shih_tzu_test.rb

@@ -579,6 +579,10 @@ class FlagShihTzuInstanceMethodsTest < Test::Unit::TestCase
     assert_equal false, @spaceship.warpdrive
   end
 
+  def test_should_define_a_negative_attribute_reader_method
+    assert_equal true, @spaceship.not_warpdrive
+  end
+
   # --------------------------------------------------
 
   def test_should_define_an_all_flags_reader_method_with_arity_1
@@ -863,11 +867,20 @@ class FlagShihTzuInstanceMethodsTest < Test::Unit::TestCase
     assert_equal false, @spaceship.warpdrive?
   end
 
+  def test_should_define_a_negative_attribute_reader_predicate_method
+    assert_equal true, @spaceship.not_warpdrive?
+  end
+
   def test_should_define_an_attribute_writer_method
     @spaceship.warpdrive = true
     assert @spaceship.warpdrive
   end
 
+  def test_should_define_a_negative_attribute_writer_method
+    @spaceship.not_warpdrive = false
+    assert @spaceship.warpdrive
+  end
+
   def test_should_define_dirty_suffix_changed?
     assert !@spaceship.warpdrive_changed?
     assert !@spaceship.shields_changed?
@@ -952,7 +965,7 @@ class FlagShihTzuInstanceMethodsTest < Test::Unit::TestCase
       EOF
       )
     end
-
+    assert !SpaceshipWithoutFlagsColumn2.send(:check_flag_column, 'flags')
     assert !SpaceshipWithoutFlagsColumn2.method_defined?(:warpdrive)
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: flag_shih_tzu
 version: !ruby/object:Gem::Version
-  version: 0.3.11
+  version: 0.3.12
 platform: ruby
 authors:
 - Peter Boling
@@ -12,152 +12,150 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-09 00:00:00.000000000 Z
+date: 2014-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.4.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.4.2
 - !ruby/object:Gem::Dependency
   name: reek
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.2.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.2.8
 - !ruby/object:Gem::Dependency
   name: roodi
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.1.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ! 'Bit fields for ActiveRecord:
-
+description: |
+  Bit fields for ActiveRecord:
   This gem lets you use a single integer column in an ActiveRecord model
-
   to store a collection of boolean attributes (flags). Each flag can be used
-
   almost in the same way you would use any boolean attribute on an
-
   ActiveRecord object.
-
-'
 email: peter.boling@gmail.com
-executables: []
+executables:
+- test.bash
 extensions: []
 extra_rdoc_files: []
 files:
-- .DS_Store
-- .coveralls.yml
-- .gitignore
-- .travis.yml
+- ".DS_Store"
+- ".coveralls.yml"
+- ".gitignore"
+- ".travis.yml"
 - CHANGELOG
 - Gemfile
 - LICENSE
 - README.md
 - REEK
 - Rakefile
+- bin/test.bash
 - flag_shih_tzu.gemspec
 - gemfiles/Gemfile.activerecord-2.3.x
 - gemfiles/Gemfile.activerecord-3.0.x
 - gemfiles/Gemfile.activerecord-3.1.x
 - gemfiles/Gemfile.activerecord-3.2.x
 - gemfiles/Gemfile.activerecord-4.0.x
+- gemfiles/Gemfile.activerecord-4.1.x
 - lib/flag_shih_tzu.rb
 - lib/flag_shih_tzu/validators.rb
 - lib/flag_shih_tzu/version.rb
@@ -175,12 +173,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []