flag 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aa905390895050cd8a589c4c97f36cc1b3d8a8b9
-  data.tar.gz: 360389f7f12e04b64b009bc4ba63cad0b0d40481
+  metadata.gz: 6d92ca5beee75e55334375129bf62b0836adf5f7
+  data.tar.gz: 868a270b5142903ef440f22fd6385a380fcc4bf3
 SHA512:
-  metadata.gz: 839277859db6982e7fb3833642a79ff49f83c0764a50390021648b6319bea6746fd60bed4b965d55450fdceee9a481075bac5f6f35588fecb937430a860a3d1a
-  data.tar.gz: 16fdbe22d8fa51324ec895b2db0d20cf83e2ea12395b91cb782b34e4ce11fd89a42aea67ee18ba49e1bd28a92006a938ceff14a47f0232976acfe41dba87ee90
+  metadata.gz: c8f3b6480ce579aa163eea68559385b6790bd02072fc08089a8bc26d6aca6e18b6e45a53920c7a6ad3cd45353b5a6cd5b353d1a0cb8a0508d730faa8b0a49020
+  data.tar.gz: 7b064e5d80901a1b77d80b50f74cea3c91a681b089d570f596d9d958bc7016be866d6e7bba33d22587b1616d1746546d33aa2cd5adaad3208cc679ea9f993a41

data/README.md

@@ -26,6 +26,17 @@ else
 end
 ```
 
+If you enable (`on!`) with `Integer`, `Fixnum` or `String` they will be treated
+as ids of your application, in the other hand if you use `Symbol` it will be
+treated as a `Group`.
+
+```ruby
+Flag(:something).on!(1)
+Flag(:something).on!("uuid")
+
+Flag(:something).on!(:group)
+```
+
 ## Enable/Check feature flags
 
 ### Ids

data/SPEC.md

@@ -1,4 +1,4 @@
-``ruby
+```ruby
 if Flag(:experiment).on?
 end
 
@@ -12,5 +12,5 @@ Flag(:experiment).on!(:group)
 Flag(:experiment).on?(user.id)
 Flag(:experiment).on?(:group)
 
-Flag.group[:group] = lambda { |id| id % 2 }
+Flag.group[:group] = lambda { |id| id % 2 == 0 }
 ```

data/flag.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name              = "flag"
-  s.version           = "0.0.1"
+  s.version           = "0.0.2"
   s.summary           = "Simple feature flags"
   s.description       = "Feature flags for the humans and the coders"
   s.authors           = ["elcuervo"]
@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
   s.files             = `git ls-files`.split("\n")
   s.test_files        = `git ls-files test`.split("\n")
 
-  s.add_dependency("redic", "~> 0.0.8")
+  s.add_dependency("redic", "~> 1.4.1")
 
   s.add_development_dependency("minitest",        "~> 5.3.0")
   s.add_development_dependency("minitest-given",  "~> 3.0.0")

data/lib/flag.rb

@@ -20,15 +20,15 @@ module Flag
       "#{Flag::FEATURES}:#{name}"
     end
 
-    def actived
-      { percentage: percentage.to_i, users: users, groups: groups }
+    def activated
+      { percentage: percentage, users: users, groups: groups }
     end
 
     def groups; members_for(GROUPS).map(&:to_sym) end
     def users;  members_for(USERS) end
 
     def include?(item)
-      return percentage == item[0...-1].to_i if item.to_s.end_with?("%")
+      return percentage == item.to_i if item.to_s.end_with?("%")
       return true if Zlib.crc32(item.to_s) % 100 < percentage
 
       Flag.store.call("SISMEMBER", subkey(item), item).to_i == 1
@@ -38,16 +38,16 @@ module Flag
       [USERS, GROUPS].each { |k| Flag.store.call("DEL", "#{key}:#{k}") }
     end
 
+    def percentage
+      Flag.store.call("HGET", Flag::FEATURES, name).to_i
+    end
+
     private
 
     def members_for(type)
       Flag.store.call("SMEMBERS", "#{key}:#{type}") || []
     end
 
-    def percentage
-      Flag.store.call("HGET", Flag::FEATURES, name).to_i
-    end
-
     def subkey(item)
       "#{key}:#{subgroup(item)}"
     end
@@ -69,9 +69,9 @@ module Flag
       @members = Members.new(name)
     end
 
-    def reset;   @members.reset   end
-    def key;     @members.key     end
-    def actived; @members.actived end
+    def reset;     @members.reset     end
+    def key;       @members.key       end
+    def activated; @members.activated end
 
     def off?; !active? end
 
@@ -88,21 +88,17 @@ module Flag
     end
 
     def off!
-      Flag.store.call("HSET", Flag::FEATURES, name, 0)
+      @members << "0%"
     end
 
-    def on!(what = false)
-      if what
-        @members << what
-      else
-        Flag.store.call("HSET", Flag::FEATURES, name, 100)
-      end
+    def on!(what = "100%")
+      @members << what
     end
 
     private
 
     def active?
-      Flag.store.call("HGET", FEATURES, name).to_i == 100
+      @members.percentage == 100
     end
   end
 
@@ -116,7 +112,7 @@ module Flag
     end
 
     def enabled
-      features.select { |k, v| k if v.on? }.keys
+      features.select { |k, v| v.on? }.keys
     end
 
     def store; @store  ||= Redic.new end
@@ -127,9 +123,7 @@ module Flag
     def features
       @_features ||= Hash.new { |h, k| h[k] = Feature.new(k) }
 
-      self.store.call("HGETALL", FEATURES).each_slice(2) do |slice|
-        @_features[slice.first.to_sym]
-      end
+      self.store.call("HKEYS", FEATURES).each { |k| @_features[k.to_sym] }
 
       @_features
     end

data/test/flag_test.rb

@@ -36,7 +36,7 @@ describe Flag do
       Then { groups == [:staff] }
     end
 
-    context "testing if feature is actived for a group" do
+    context "testing if feature is activated for a group" do
       Given { Flag(:test).on!(:staff) }
       When(:feature) { Flag(:test).on?(:staff) }
       Then { feature == true }
@@ -91,9 +91,11 @@ describe Flag do
     Given { Flag(:test).on!("UUID") }
     Given { Flag(:test).on!(:staff) }
 
-    Then { Flag(:test).actived.is_a?(Hash) }
-    And  { Flag(:test).actived[:percentage] == 50 }
-    And  { Flag(:test).actived[:users] == ["25", "UUID"] }
-    And  { Flag(:test).actived[:groups] == [:staff] }
+    Then { Flag(:test).activated.is_a?(Hash) }
+    And  { Flag(:test).activated[:percentage] == 50 }
+    And  { Flag(:test).activated[:users].size == 2 }
+    And  { Flag(:test).activated[:users].include?("25") }
+    And  { Flag(:test).activated[:users].include?("UUID") }
+    And  { Flag(:test).activated[:groups] == [:staff] }
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: flag
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - elcuervo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-23 00:00:00.000000000 Z
+date: 2015-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redic
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.0.8
+        version: 1.4.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.0.8
+        version: 1.4.1
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement