flac2mp3 0.2.0

data/spec/flac2mp3_command_spec.rb

@@ -0,0 +1,31 @@
+require File.dirname(__FILE__) + '/spec_helper.rb'
+
+describe 'flac2mp3 command' do
+  before :all do
+    path = File.join(File.dirname(__FILE__), *%w[.. bin])
+    ENV['PATH'] = [path, ENV['PATH']].join(':')
+  end
+  
+  before :each do
+    Flac2mp3.stubs(:convert)
+  end
+  
+  it 'should exist' do
+    pending 'figuring out how to test this command'
+    
+    system('flac2mp3 blah').should be_true
+  end
+  
+  it 'should require a filename' do
+    pending 'figuring out how to test this command'
+      
+    `flac2mp3`.should match(/usage:.+filename/i)
+  end
+  
+  it 'should pass the filename to Flac2mp3 for conversion' do
+    pending 'figuring out how to test this command'
+    
+    Flac2mp3.expects(:convert).with('blah')
+    system('flac2mp3 blah')
+  end
+end

data/spec/flac2mp3_spec.rb

@@ -0,0 +1,312 @@
+require File.dirname(__FILE__) + '/spec_helper.rb'
+
+describe Flac2mp3 do
+  it 'should convert' do
+    Flac2mp3.should respond_to(:convert)
+  end
+  
+  it 'should provide output filename' do
+    Flac2mp3.should respond_to(:output_filename)
+  end
+  
+  it 'should provide tag mapping' do
+    Flac2mp3.should respond_to(:tag_mapping)
+  end
+  
+  it 'should get FLAC tag data' do
+    Flac2mp3.should respond_to(:flacdata)
+  end
+  
+  it 'should set MP3 tag data' do
+    Flac2mp3.should respond_to(:mp3data)
+  end
+end
+
+describe Flac2mp3, 'when converting' do
+  before :each do
+    Flac2mp3.stubs(:system)
+    Flac2mp3.stubs(:flacdata)
+    Flac2mp3.stubs(:mp3data)
+  end
+
+  it 'should require a filename' do
+    lambda { Flac2mp3.convert }.should raise_error(ArgumentError)
+  end
+  
+  it 'should accept a filename' do
+    lambda { Flac2mp3.convert('blah.flac') }.should_not raise_error(ArgumentError)
+  end
+  
+  it 'should check if the filename belongs to a regular file' do
+    filename = 'blah.flac'
+    FileTest.expects(:file?).with(filename).returns(true)
+    Flac2mp3.convert(filename)
+  end
+end
+
+describe Flac2mp3, 'when converting and given a filename belonging to a regular file' do
+  before :each do
+    @filename = 'blah.flac'
+    FileTest.stubs(:file?).with(@filename).returns(true)
+    @output_filename = 'blah.mp3'
+    Flac2mp3.stubs(:output_filename).with(@filename).returns(@output_filename)
+    Flac2mp3.stubs(:system)
+    
+    @flacdata = {}
+    Flac2mp3.stubs(:flacdata).with(@filename).returns(@flacdata)
+    Flac2mp3.stubs(:mp3data)
+  end
+  
+  it 'should not error' do
+    lambda { Flac2mp3.convert(@filename) }.should_not raise_error(TypeError)
+  end
+  
+  it 'should extend the filename with the string extensions' do
+    @filename.expects(:extend).with(Flac2mp3::StringExtensions).returns(@filename)
+    @filename.stubs(:safequote)
+    Flac2mp3.convert(@filename)
+  end
+  
+  it 'should get the output filename' do
+    Flac2mp3.expects(:output_filename).with(@filename).returns('outfile')
+    Flac2mp3.convert(@filename)
+  end
+  
+  it 'should extend the output filename with the string extensions' do
+    @output_filename.expects(:extend).with(Flac2mp3::StringExtensions).returns(@output_filename)
+    @output_filename.stubs(:safequote)
+    Flac2mp3.convert(@filename)
+  end
+  
+  it 'should use system commands to convert the FLAC to an MP3' do
+    @filename.stubs(:safequote).returns('-blah-flac-')
+    @output_filename.stubs(:safequote).returns('-blah-mp3-')
+    Flac2mp3.expects(:system).with("flac -c -d #{@filename.safequote} | lame --preset standard - #{@output_filename.safequote}")
+    
+    Flac2mp3.convert(@filename)
+  end
+  
+  it 'should set the MP3 tags from the FLAC data' do
+    Flac2mp3.expects(:mp3data).with(@output_filename, @flacdata)
+    Flac2mp3.convert(@filename)
+  end
+end
+
+describe Flac2mp3, 'when converting and given a filename not belonging to a regular file' do
+  before :each do
+    @filename = 'blah.flac'
+    FileTest.stubs(:file?).with(@filename).returns(false)
+  end
+  
+  it 'should error' do
+    lambda { Flac2mp3.convert(@filename) }.should raise_error(TypeError)
+  end
+end
+
+describe Flac2mp3, 'when getting an output filename' do
+  it 'should require a filename' do
+    lambda { Flac2mp3.output_filename }.should raise_error(ArgumentError)
+  end
+  
+  it 'should accept a filename' do
+    lambda { Flac2mp3.output_filename('blah.flac') }.should_not raise_error(ArgumentError)
+  end
+  
+  it 'should convert a .flac extension to an .mp3 extension' do
+    Flac2mp3.output_filename('blah.flac').should == 'blah.mp3'
+  end
+  
+  it 'should append an .mp3 extension if no .flac extension exists' do
+    Flac2mp3.output_filename('blah').should == 'blah.mp3'
+  end
+end
+
+describe Flac2mp3, 'providing a mapping of tags' do
+  it 'should return a hash' do
+    Flac2mp3.tag_mapping.should be_kind_of(Hash)
+  end
+  
+  it "should map 'album' to 'album'" do
+    Flac2mp3.tag_mapping[:album].should == :album
+  end
+  
+  it "should map 'artist' to 'artist'" do
+    Flac2mp3.tag_mapping[:artist].should == :artist
+  end
+  
+  it "should map 'bpm' to 'bpm'" do
+    Flac2mp3.tag_mapping[:bpm].should == :bpm
+  end
+  
+  it "should map 'comment' to 'comments'" do
+    Flac2mp3.tag_mapping[:comment].should == :comments
+  end
+  
+  it "should map 'composer' to 'composer'" do
+    Flac2mp3.tag_mapping[:composer].should == :composer
+  end
+  
+  it "should map 'date' to 'year'" do
+    Flac2mp3.tag_mapping[:date].should == :year
+  end
+  
+  it "should map 'genre' to 'genre_s'" do
+    Flac2mp3.tag_mapping[:genre].should == :genre_s
+  end
+  
+  it "should map 'title' to 'title'" do
+    Flac2mp3.tag_mapping[:title].should == :title
+  end
+  
+  it "should map 'tracknumber' to 'tracknum'" do
+    Flac2mp3.tag_mapping[:tracknumber].should == :tracknum
+  end
+end
+
+describe Flac2mp3, 'when getting FLAC tag data' do
+  before :each do
+    @filename = 'blah.flac'
+    @tags = {}
+    @flacinfo = stub('flacinfo', :tags => @tags)
+    FlacInfo.stubs(:new).with(@filename).returns(@flacinfo)
+  end
+  
+  it 'should require a filename' do
+    lambda { Flac2mp3.flacdata }.should raise_error(ArgumentError)
+  end
+  
+  it 'should accept a filename' do
+    lambda { Flac2mp3.flacdata('blah.flac') }.should_not raise_error(ArgumentError)
+  end
+  
+  it 'should create a FlacInfo object' do
+    FlacInfo.expects(:new).with(@filename).returns(@flacinfo)
+    Flac2mp3.flacdata(@filename)
+  end
+  
+  it 'should use the FlacInfo object tags' do
+    @flacinfo.expects(:tags).returns(@tags)
+    Flac2mp3.flacdata(@filename)
+  end
+  
+  it 'should return a hash of the tag data' do
+    @tags[:artist] = 'blah'
+    @tags[:blah] = 'boo'
+    @tags[:comment] = 'hey'
+    
+    data = Flac2mp3.flacdata(@filename)
+    data[:artist].should == 'blah'
+    data[:blah].should == 'boo'
+    data[:comment].should == 'hey'
+  end
+  
+  it 'should convert tags to symbols' do
+    @tags['artist'] = 'blah'
+    @tags['blah'] = 'boo'
+    @tags['comment'] = 'hey'
+    
+    data = Flac2mp3.flacdata(@filename)
+    data[:artist].should == 'blah'
+    data[:blah].should == 'boo'
+    data[:comment].should == 'hey'
+    
+    data.should_not have_key('artist')
+    data.should_not have_key('blah')
+    data.should_not have_key('comment')
+  end
+  
+  it 'should convert tags to lowercase' do
+    @tags['Artist'] = 'blah'
+    @tags[:BLAH] = 'boo'
+    @tags['cOmMeNt'] = 'hey'
+    
+    data = Flac2mp3.flacdata(@filename)
+    data[:artist].should == 'blah'
+    data[:blah].should == 'boo'
+    data[:comment].should == 'hey'
+    
+    data.should_not have_key('Artist')
+    data.should_not have_key(:BLAH)
+    data.should_not have_key('cOmMeNt')
+  end
+  
+  it 'should convert values consisting only of digits to actual numbers' do
+    @tags[:track] = '12'
+    
+    data = Flac2mp3.flacdata(@filename)
+    data[:track].should == 12
+  end
+end
+
+describe Flac2mp3, 'when setting MP3 tag data' do
+  before :each do
+    @filename = 'blah.mp3'
+    @tags = {}
+    @mp3tags = stub('mp3info tags')
+    @mp3info = stub('mp3info obj', :tag => @mp3tags)
+    Mp3Info.stubs(:open).with(@filename).yields(@mp3info)
+  end
+  
+  it 'should require a filename' do
+    lambda { Flac2mp3.mp3data }.should raise_error(ArgumentError)
+  end
+  
+  it 'should require tag data' do
+    lambda { Flac2mp3.mp3data('blah.mp3') }.should raise_error(ArgumentError)
+  end
+  
+  it 'should accept a filename and tag data' do
+    lambda { Flac2mp3.mp3data('blah.mp3', 'tags') }.should_not raise_error(ArgumentError)
+  end
+  
+  it 'should require a hash of tags' do
+    lambda { Flac2mp3.mp3data('blah.mp3', 'blah') }.should raise_error(TypeError)
+  end
+  
+  it 'should accept a hash of tags' do
+    lambda { Flac2mp3.mp3data('blah.mp3', {}) }.should_not raise_error(TypeError)
+  end
+  
+  it 'should use an Mp3Info object' do
+    Mp3Info.expects(:open).with(@filename).yields(@mp3info)
+    Flac2mp3.mp3data(@filename, @tags)
+  end
+  
+  it 'should set tags in the Mp3Info object' do
+    @tags[:album] = 'blah'
+    @tags[:artist] = 'boo'
+    @tags[:genre] = 'bang'
+    
+    @mp3tags.expects(:album=).with(@tags[:album])
+    @mp3tags.expects(:artist=).with(@tags[:artist])
+    @mp3tags.expects(:genre_s=).with(@tags[:genre])
+    
+    Flac2mp3.mp3data(@filename, @tags)
+  end
+  
+  it 'should not set tags not given' do
+    @tags[:album] = 'blah'
+    @tags[:artist] = 'boo'
+    @tags[:genre] = 'bang'
+    
+    @mp3tags.stubs(:album=)
+    @mp3tags.stubs(:artist=)
+    @mp3tags.stubs(:genre_s=)
+    
+    @mp3tags.expects(:bpm=).never
+    @mp3tags.expects(:comments=).never
+    @mp3tags.expects(:year=).never
+    
+    Flac2mp3.mp3data(@filename, @tags)
+  end
+  
+  it 'should not set tags not known' do
+    @tags[:blah] = 'blah'
+    @tags[:bang] = 'bang'
+    
+    @mp3tags.expects(:blah=).never
+    @mp3tags.expects(:bang=).never
+    
+    Flac2mp3.mp3data(@filename, @tags)
+  end
+end

data/spec/spec.opts

@@ -0,0 +1,3 @@
+--format
+s
+--colour

data/spec/spec_helper.rb

@@ -0,0 +1,24 @@
+begin
+  require 'spec'
+rescue LoadError
+  require 'rubygems'
+  gem 'rspec'
+  require 'spec'
+end
+
+# this is my favorite way to require ever
+begin
+  require 'mocha'
+rescue LoadError
+  require 'rubygems'
+  gem 'mocha'
+  require 'mocha'
+end
+
+Spec::Runner.configure do |config|
+  config.mock_with :mocha
+end
+
+$:.unshift File.join(File.dirname(__FILE__), *%w[.. lib])
+
+require 'flac2mp3'

data/spec/string_extensions_spec.rb

@@ -0,0 +1,29 @@
+require File.dirname(__FILE__) + '/spec_helper.rb'
+
+describe String, 'in general' do
+  it 'should not safequote' do
+    String.new.should_not respond_to(:safequote)
+  end
+end
+
+describe String, 'extended with string extensions' do
+  it 'should safequote' do
+    str = String.new
+    str.extend(Flac2mp3::StringExtensions)
+    str.should respond_to(:safequote)
+  end
+end
+
+describe String, 'safequoting' do
+  it 'should leave alphanumeric characters alone' do
+    str = 'abc_123'
+    str.extend(Flac2mp3::StringExtensions)
+    str.safequote.should == 'abc_123'
+  end
+  
+  it 'should escape non-alphanumeric characters' do
+    str = %q[a-b"c 12'3]
+    str.extend(Flac2mp3::StringExtensions)
+    str.safequote.should == %q[a\-b\"c\ 12\'3]
+  end
+end

data/tasks/deployment.rake

@@ -0,0 +1,34 @@
+desc 'Release the website and new gem version'
+task :deploy => [:check_version, :website, :release] do
+  puts "Remember to create SVN tag:"
+  puts "svn copy svn+ssh://#{rubyforge_username}@rubyforge.org/var/svn/#{PATH}/trunk " +
+    "svn+ssh://#{rubyforge_username}@rubyforge.org/var/svn/#{PATH}/tags/REL-#{VERS} "
+  puts "Suggested comment:"
+  puts "Tagging release #{CHANGES}"
+end
+
+desc 'Runs tasks website_generate and install_gem as a local deployment of the gem'
+task :local_deploy => [:website_generate, :install_gem]
+
+task :check_version do
+  unless ENV['VERSION']
+    puts 'Must pass a VERSION=x.y.z release version'
+    exit
+  end
+  unless ENV['VERSION'] == VERS
+    puts "Please update your version.rb to match the release version, currently #{VERS}"
+    exit
+  end
+end
+
+desc 'Install the package as a gem, without generating documentation(ri/rdoc)'
+task :install_gem_no_doc => [:clean, :package] do
+  sh "#{'sudo ' unless Hoe::WINDOZE }gem install pkg/*.gem --no-rdoc --no-ri"
+end
+
+namespace :manifest do
+  desc 'Recreate Manifest.txt to include ALL files'
+  task :refresh do
+    `rake check_manifest | patch -p0 > Manifest.txt`
+  end
+end

data/tasks/environment.rake

@@ -0,0 +1,7 @@
+task :ruby_env do
+  RUBY_APP = if RUBY_PLATFORM =~ /java/
+    "jruby"
+  else
+    "ruby"
+  end unless defined? RUBY_APP
+end