fixture_validation 0.1.2 → 0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5a64198be9d3b99091f2716500aba88e8d69fc25
-  data.tar.gz: ef1d836eadc863382b80a2cdebc7c9b9ff3d4383
+  metadata.gz: e29e73b106e837586ee66cb19f611471e1958dd7
+  data.tar.gz: 8c9145ad617e13e202784447ef463df9a2931a03
 SHA512:
-  metadata.gz: f552393f2462998bbdfc9381fb9ed36ae9a6f5fc7786303114de6d8744af786166091c2201ad3a7cd988be2f2d3095d24f016f2d00725163eb022276f68bafe8
-  data.tar.gz: de515457797bf2fa8afdf2fa008fb8869436a8d0fe3d13ee90aeb0cbf8d753eaa69d4edf37be7a1c045327152c48687874fc02f390f589e099349a1a24f7593b
+  metadata.gz: 85161e55ddba0b53c983e92254586569e0f0d6ec9c9ce1a7afa94eddb8c8ce2a6e30d9d5c577c5e049a8459c4616d588342e69f5ca203cd5036eda3acaa539da
+  data.tar.gz: 8c81993b0a47db8c8144551533590cdef72936fae927eb745470e1449a167230bfa9c6cd0f558b0ddf103aa072d530a5d6d0ed6b830741d66c25220506c31f40

data/.gitignore

@@ -7,4 +7,9 @@
 /pkg/
 /spec/reports/
 /tmp/
-/.idea/
+/.idea/
+log/*.log
+test/dummy/db/*.sqlite3
+test/dummy/db/*.sqlite3-journal
+test/dummy/log/*.log
+test/dummy/tmp/

data/README.md

@@ -1,6 +1,7 @@
 # FixtureValidation
 
-Adds a test that validates all your Rails fixtures.
+Adds a test that validates all your Rails fixtures.  Tested with Rails
+versions 4 and 5.
 
 As your Rails models grow and change over time, your fixtures may 
 become outdated without anyone noticing.  In my code I've found 
@@ -27,21 +28,23 @@ test 'task must have a name' do
 end
 ```
 
-With that extra line you can be sure the test will perform as expected.  But 
-what if you have many tests that use the same fixture?  Asserting validity 
-of the fixture in each test isn't DRY.  Furthermore, on a project with hundreds 
-or thousands of fixtures, you may find yourself repeating this pattern constantly.
+With that extra line you can be sure the test will perform as
+expected.  But what if you have many tests that use the same fixture?
+Furthermore, on a project with hundreds or thousands of fixtures, you
+may find yourself repeating this load/validate pattern constantly.
 
-This gem adds a test to your test suite that validates all fixtures at once.  If task 
-one is invalid, the fixture validation test will fail with output like this: 
+This gem adds a test to your test suite that validates all fixtures at
+once.  In the above example, if task :one is invalid the fixture
+validation test will fail with output like this:
 
 ```
 Expected Task fixture 708419058 to be valid.  Errors: Name can't be blank.  Attribute values: {"id"=>708419058, "name"=>nil, "created_at"=>Sat, 12 Nov 2016 17:29:02 UTC +00:00, "updated_at"=>Sat, 12 Nov 2016 17:29:02 UTC +00:00}.
 ```
 
-All fixture errors are printed when the test runs.  The YAML name of the fixture is 
-not known, but all attribute values are printed to assist in identifying 
-which fixture is invalid.
+All fixture errors are printed when the test runs.  It's not possible
+to look up the YAML name of the fixture based on the database entry,
+but the attribute values are printed to assist in identifying which
+fixture is invalid.
 
 ## Installation
 
@@ -61,11 +64,10 @@ Or install it yourself as:
 
     $ gem install fixture_validation
 
-Add this line to test/test_helper.rb, after the 'rails/test_help' require:
+Then call the generator to create the test stub:
 
-```ruby
-require 'rails/test_help'  
-require 'fixture_validation_test'  # add this line
+```bash
+$ rails g fixture_validation 
 ```
 
 ## Usage 
@@ -74,18 +76,34 @@ Run your test suite:
 
     $ rake test
     
+Or you can run the fixture validation test on its own, which is useful
+if you want to iterate over several errors:
+
+    $ rake test TEST=test/models/fixture_validation_test.rb
+    
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` to install
+dependencies. Then, run `rake test` to run the tests.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To install this gem onto your local machine, run `bundle exec rake
+install`. To release a new version, update the version number in
+`version.rb`, and then run `bundle exec rake release`, which will
+create a git tag for the version, push git commits and tags, and push
+the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/fixture_validation. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at
+https://github.com/[USERNAME]/fixture_validation. This project is
+intended to be a safe, welcoming space for collaboration, and
+contributors are expected to adhere to
+the [Contributor Covenant](http://contributor-covenant.org) code of
+conduct.
 
 
 ## License
 
-The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
+The gem is available as open source under the terms of
+the [MIT License](http://opensource.org/licenses/MIT).
 

data/Rakefile

@@ -1,10 +1,37 @@
-require "bundler/gem_tasks"
-require "rake/testtask"
+begin
+  require 'bundler/setup'
+rescue LoadError
+  puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
+end
+
+require 'rdoc/task'
+
+RDoc::Task.new(:rdoc) do |rdoc|
+  rdoc.rdoc_dir = 'rdoc'
+  rdoc.title    = 'FixtureValidation'
+  rdoc.options << '--line-numbers'
+  rdoc.rdoc_files.include('README.md')
+  rdoc.rdoc_files.include('lib/**/*.rb')
+end
+
+APP_RAKEFILE = File.expand_path('../test/dummy/Rakefile', __FILE__)
+load 'rails/tasks/engine.rake'
+
+
+load 'rails/tasks/statistics.rake'
+
+
+
+require 'bundler/gem_tasks'
+
+require 'rake/testtask'
 
 Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
-  t.test_files = FileList['test/**/*_test.rb']
+  t.libs << 'lib'
+  t.libs << 'test'
+  t.pattern = 'test/**/*_test.rb'
+  t.verbose = false
 end
 
-task :default => :test
+
+task default: :test

data/bin/rails

@@ -0,0 +1,13 @@
+#!/usr/bin/env ruby
+# This command will automatically be run when you run "rails" with Rails gems
+# installed from the root of your application.
+
+ENGINE_ROOT = File.expand_path('../..', __FILE__)
+ENGINE_PATH = File.expand_path('../../lib/fixture_validation/engine', __FILE__)
+
+# Set up gems listed in the Gemfile.
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])
+
+require 'rails/all'
+require 'rails/engine/commands'

data/fixture_validation.gemspec

@@ -20,8 +20,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.13'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'minitest', '~> 5.0'
-  spec.add_runtime_dependency 'rails', '~> 4.0', '~> 5.0'
+  spec.add_dependency 'rails', '> 4'
+  spec.add_development_dependency 'sqlite3'
 end

data/lib/fixture_validation.rb

@@ -1,5 +1,35 @@
 require 'fixture_validation/version'
+require 'active_support/concern'
 
 module FixtureValidation
+  extend ActiveSupport::Concern
 
+  included do
+    fixtures :all
+  end
+
+  def test_validate_fixtures
+    count = 0
+    klasses = []
+    fixture_table_names.each do |fixture_name|
+      klass_name = fixture_name.classify
+      begin
+        klasses << klass_name.constantize
+      rescue NameError
+        Rails.logger.debug "No model class (#{klass_name}) found for fixture #{fixture_name}"
+      end
+    end
+
+    errors = []
+    klasses.each do |klass|
+      klass.all.each do |obj|
+        errors << "Expected #{klass.to_s} fixture #{obj.id} to be valid.  Errors: #{obj.errors.to_a.join(', ')}.  Attribute values: #{obj.attributes.to_s}." unless obj.valid?
+        count += 1
+      end
+    end
+
+    assert errors.empty?, "\n#{errors.join("\n")}"
+    Rails.logger.debug "Validated #{count} fixtures"    
+  end  
 end
+

data/lib/fixture_validation/engine.rb

@@ -0,0 +1,4 @@
+module FixtureValidation
+  class Engine < ::Rails::Engine
+  end
+end

data/lib/fixture_validation/version.rb

@@ -1,3 +1,3 @@
 module FixtureValidation
-  VERSION = '0.1.2'
+  VERSION = '0.2'
 end

data/lib/generators/fixture_validation_generator.rb

@@ -0,0 +1,17 @@
+require 'rails/generators/named_base'
+
+class FixtureValidationGenerator < Rails::Generators::Base
+  def create_test
+    create_file 'test/models/fixture_validation_test.rb' do
+      <<END
+require 'test_helper'
+require 'fixture_validation'
+
+class FixtureValidationTest < ActiveSupport::TestCase
+  include FixtureValidation
+end
+
+END
+    end
+  end
+end

metadata

@@ -1,77 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: fixture_validation
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: '0.2'
 platform: ruby
 authors:
 - Dan Falcone
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-11-13 00:00:00.000000000 Z
+date: 2016-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.13'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.13'
-- !ruby/object:Gem::Dependency
-  name: rake
+  name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '10.0'
-  type: :development
+        version: '4'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '4'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-- !ruby/object:Gem::Dependency
-  name: rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4.0'
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '0'
 description: 
 email:
 - danfalcone@gmail.com
@@ -86,12 +52,12 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- bin/console
-- bin/setup
+- bin/rails
 - fixture_validation.gemspec
 - lib/fixture_validation.rb
+- lib/fixture_validation/engine.rb
 - lib/fixture_validation/version.rb
-- lib/fixture_validation_test.rb
+- lib/generators/fixture_validation_generator.rb
 homepage: https://github.com/falconed/fixture_validation
 licenses:
 - MIT

data/bin/console

@@ -1,14 +0,0 @@
-#!/usr/bin/env ruby
-
-require "bundler/setup"
-require "fixture_validation_test"
-
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require "irb"
-IRB.start

data/bin/setup

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-set -euo pipefail
-IFS=$'\n\t'
-set -vx
-
-bundle install
-
-# Do any other automated setup that you need to do here

data/lib/fixture_validation_test.rb

@@ -1,30 +0,0 @@
-# Requires at least one test in the project
-# Require 'fixture_validation_test' in test_helper after rails/test_help is required
-
-class FixtureValidation::Test < ActiveSupport::TestCase
-  fixtures :all
-
-  test 'fixtures are valid' do
-    count = 0
-    klasses = []
-    fixture_table_names.each do |fixture_name|
-      klass_name = fixture_name.classify
-      begin
-        klasses << klass_name.constantize
-      rescue NameError
-        Rails.logger.debug "No model class (#{klass_name}) found for fixture #{fixture_name}"
-      end
-    end
-
-    errors = []
-    klasses.each do |klass|
-      klass.all.each do |obj|
-        errors << "Expected #{klass.to_s} fixture #{obj.id} to be valid.  Errors: #{obj.errors.to_a.join(', ')}.  Attribute values: #{obj.attributes.to_s}." unless obj.valid?
-        count += 1
-      end
-    end
-
-    assert errors.empty?, "\n#{errors.join("\n")}"
-    Rails.logger.debug "Validated #{count} fixtures"
-  end
-end