fixme 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee77f3652407beeb65a9b00c0beda6ebebb970a0
-  data.tar.gz: e1938b519c3a1c98516abfd491ee290a65d38a78
+  metadata.gz: 5918a9a8d6c7ed2b50dffce574ddd35938855694
+  data.tar.gz: 174d74e39c33019eeb487ad97cf58c827a0618dd
 SHA512:
-  metadata.gz: 7904af13220ecc11babdea9ab748f3ce88af3008ad94ce1e3363a7da187377bf871dc41803fd0a06c0748fb8d5e582a7e453979543fda24e304d257be4d2a13f
-  data.tar.gz: def4c437d9ccdfe486c5cc3c4a2c332f1e8f42433fc59e0a303d7c22c39c5bb86426c74466be78acf84f4e1f300412c07c71f19f91cef38d340cafc59f69db92
+  metadata.gz: 42f862c20eb8fd60cbc2bd6fcefbaaee13ed635d0f4ebefe84167b13f9c8a3df23eeac57c5ae60c40ec1394f2b4ff029d5fee13d9f0a90138312da6e9977fa4a
+  data.tar.gz: 3bec830317f532f8e923ce858921f3ad12dc1a65ddeb753c8d4771ef0f38950ca672ee36788a368d44c7d65b515b8f92ddbe9eb1aa8ac0313a25124a6a36a010

data/fixme.gemspec

@@ -20,4 +20,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "timecop"
 end

data/lib/fixme.rb

@@ -13,9 +13,18 @@ module Fixme
 
       raw_date, message = date_and_message.split(": ", 2)
       due_date = Date.parse(raw_date)
-      return if Date.today < due_date
 
-      raise UnfixedError, "Fix by #{due_date}: #{message}"
+      raise_if_due = -> {
+        if Date.today >= due_date
+          raise UnfixedError, "Fix by #{due_date}: #{message}"
+        end
+      }
+
+      if defined?(Timecop)
+        Timecop.return(&raise_if_due)
+      else
+        raise_if_due.call
+      end
     end
   end
 end

data/lib/fixme/version.rb

@@ -1,3 +1,3 @@
 module Fixme
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/spec/fixme_spec.rb

@@ -1,4 +1,5 @@
 require "fixme"
+require "timecop"
 
 describe Fixme, "#FIXME" do
   it "raises after the given date" do
@@ -34,55 +35,73 @@ describe Fixme, "#FIXME" do
     }.to raise_error(Fixme::UnfixedError)
   end
 
+  it "is not fooled by the Timecop gem" do
+    future_date = Date.today + 2
+
+    Timecop.travel(future_date) do
+      expect {
+        FIXME "#{future_date}: Travel back in time."
+      }.not_to raise_error
+    end
+  end
+
   context "when a Rails environment is detected" do
     before do
       stub_const("Rails", double)
     end
 
     it "raises in the 'test' environment" do
-      Rails.stub(env: "test")
+      stub_rails_env "test"
       expect_to_raise
     end
 
     it "raises in the 'development' environment" do
-      Rails.stub(env: "development")
+      stub_rails_env "development"
       expect_to_raise
     end
 
     it "does not raise in other environments" do
-      Rails.stub(env: "production")
+      stub_rails_env "production"
       expect_not_to_raise
     end
   end
 
   context "when a Rack environment is detected" do
     before do
-      ENV.stub(:[]).with("DO_NOT_RAISE_FIXMES")
+      stub_env "DO_NOT_RAISE_FIXMES", nil
     end
 
     it "raises in the 'test' environment" do
-      ENV.stub(:[]).with("RACK_ENV").and_return("test")
+      stub_env "RACK_ENV", "test"
       expect_to_raise
     end
 
     it "raises in the 'development' environment" do
-      ENV.stub(:[]).with("RACK_ENV").and_return("development")
+      stub_env "RACK_ENV", "development"
       expect_to_raise
     end
 
     it "does not raise in other environments" do
-      ENV.stub(:[]).with("RACK_ENV").and_return("production")
+      stub_env "RACK_ENV", "production"
       expect_not_to_raise
     end
   end
 
   it "does not raise when the DO_NOT_RAISE_FIXMES environment variable is set" do
-    ENV.stub(:[]).with("DO_NOT_RAISE_FIXMES").and_return("true")
+    stub_env "DO_NOT_RAISE_FIXMES", true
     expect_not_to_raise
   end
 
   private
 
+  def stub_rails_env(value)
+    allow(Rails).to receive(:env).and_return(value)
+  end
+
+  def stub_env(name, value)
+    allow(ENV).to receive(:[]).with(name).and_return(value)
+  end
+
   def expect_to_raise
     expect { FIXME "2013-12-31: X" }.to raise_error(Fixme::UnfixedError)
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fixme
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-04 00:00:00.000000000 Z
+date: 2014-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - henrik@nyh.se