fixjour 0.5.1 → 0.5.2

data/spec/merging_proxy_spec.rb

@@ -0,0 +1,48 @@
+require 'spec/spec_helper'
+
+describe Fixjour::MergingProxy do
+  attr_reader :merger
+
+  before(:each) do
+    @merger = Fixjour::MergingProxy.new(Foo, :name => "MERGED!")
+  end
+
+  describe "#new" do
+    it "merges options with overrides" do
+      mock.proxy(defaults = { :name => "Pat" }).merge(:name => "MERGED!")
+      merger.new(defaults)
+    end
+
+    it "returns an instance of the klass with the merged options" do
+      merger.new(:name => "Pat").should be_kind_of(Foo)
+    end
+  end
+
+  describe "protected" do
+    it "stores the protected attributes" do
+      @merger.protected :name
+      @merger.protected.should == Set.new([:name])
+    end
+
+    it "sends values to instance" do
+      mock.proxy(Foo).new(:name => "MERGED!").never
+      mock.proxy(Foo).new({ }).once
+      @merger.protected :name
+      @merger.new(:name => "MERGED!").name.should == "MERGED!"
+    end
+  end
+
+  describe "proxying to klass" do
+    it "proxies other methods to klass" do
+      merger.superclass.should == ActsAsFu::Connection
+    end
+
+    it "proxies respond_to? to klass" do
+      merger.should respond_to(:superclass)
+    end
+
+    it "should keep its own inspect method" do
+      merger.inspect.should_not == Foo.inspect
+    end
+  end
+end

data/spec/overrides_hash_spec.rb

@@ -0,0 +1,61 @@
+require 'spec/spec_helper'
+
+describe Fixjour::OverridesHash do
+  attr_reader :overrides
+
+  before(:each) do
+    @overrides = Fixjour::OverridesHash.new(:name => "Pat")
+  end
+
+  it "inherits from Hash" do
+    Fixjour::OverridesHash.superclass.should == Hash
+  end
+
+  describe "#process" do
+    context "when the option isn't present" do
+      it "doesn't do anything" do
+        called = false
+        overrides.process(:not_there) do
+          called = true
+        end
+        called.should_not be
+      end
+
+      it "returns nil" do
+        overrides.process(:not_there).should be_nil
+      end
+    end
+
+    context "when the option is present" do
+      it "deletes the option from the hash" do
+        overrides.process(:name)
+        overrides.should_not have_key(:name)
+      end
+
+      it "passes the value to the block" do
+        overrides.process(:name) do |value|
+          value.should == "Pat"
+        end
+      end
+
+      it "allows values to be re-assigned in hash" do
+        overrides.process(:name) do |value|
+          overrides[:result] = value
+        end
+        overrides[:result].should == "Pat"
+      end
+
+      it "returns the value" do
+        overrides.process(:name).should == "Pat"
+      end
+    end
+  end
+
+  describe "#delete" do
+    it "is private" do
+      proc {
+        overrides.delete(:name)
+      }.should raise_error(NoMethodError, /private/)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,90 @@
+require 'rubygems'
+require 'cgi'
+require 'spec'
+require 'faker'
+require 'rr'
+
+begin
+  require 'acts_as_fu'
+rescue LoadError
+  puts "You need the acts_as_fu gem to run the specs."
+  exit!
+end
+
+require File.dirname(__FILE__) + '/../lib/fixjour'
+
+def pre(*args)
+  args.each { |arg|
+    puts '<pre>' + CGI.escapeHTML(arg.is_a?(String) ? arg : arg.inspect) + '</pre>'
+  }
+end
+
+Spec::Runner.configure do |c|
+  c.mock_with(:rr)
+end
+
+include ActsAsFu
+
+build_model(:foos) do
+  attr_accessor :bizzle
+
+  string :name
+  integer :age
+  integer :bar_id
+  integer :person_id
+
+  belongs_to :bar
+  belongs_to :owner, :foreign_key => :person_id, :class_name => 'Person'
+
+  validates_presence_of :bar, :message => "BAR AIN'T THURR"
+  validates_presence_of :name
+end
+
+build_model(:bars) do
+  string :name
+
+  has_many :people
+  has_many :foos
+end
+
+build_model(:bazzs) do
+  string :name
+  integer :bar_id
+
+  belongs_to :bar
+end
+
+build_model(:foo_bars) do
+  string :name
+end
+
+build_model(:people) do
+  string :first_name
+  string :last_name
+  integer :bar_id
+end
+
+def define_all_builders
+  Fixjour.builders.clear
+  Fixjour do
+    define_builder(Foo) do |klass, overrides|
+      klass.new({ :name => 'Foo Namery', :bar => new_bar, :owner => new_person }.merge(overrides))
+    end
+
+    define_builder(Bar) do |klass, overrides|
+      klass.new({ :name => "Bar Namery", :people => [new_person] }.merge(overrides))
+    end
+
+    define_builder(FooBar) do |klass, overrides|
+      klass.new(:name => "foobar-#{counter(:foobar)}")
+    end
+
+    define_builder(Bazz) do |klass|
+      klass.new(:name => "Bazz Namery")
+    end
+
+    define_builder Person do |klass|
+      klass.new
+    end
+  end
+end

data/spec/verify_spec.rb

@@ -0,0 +1,136 @@
+require 'spec/spec_helper'
+
+describe Fixjour, ".verify!" do
+  before(:each) do
+    define_all_builders
+    Fixjour.builders.clear
+  end
+
+  it "can take verify as an option" do
+    mock(Fixjour).verify!.once
+    Fixjour(:verify => true) { }
+  end
+
+  describe "clearing the transaction" do
+    before(:each) do
+      Fixjour do
+        define_builder(Foo) { |overrides| Foo.new(:name => 'ok', :bar => new_bar) }
+      end
+    end
+
+    it "rolls back the transaction" do
+      proc {
+        Fixjour.verify!
+      }.should_not change(Foo, :count)
+    end
+  end
+
+  context "when the builder returns an invalid object" do
+    context "when the validations are not related to uniqueness" do
+      before(:each) do
+        Fixjour do
+          define_builder(Foo) { |overrides| Foo.new(:bar => nil) }
+        end
+      end
+
+      it "raises InvalidBuilder" do
+        proc {
+          Fixjour.verify!
+        }.should raise_error(Fixjour::InvalidBuilder)
+      end
+
+      it "includes information about the failure" do
+        proc {
+          Fixjour.verify!
+        }.should raise_error(/BAR AIN'T THURR/)
+      end
+    end
+
+    context "when the validations are related to uniqueness" do
+      before(:each) do
+        Bar.delete_all
+        Bar.validates_uniqueness_of :name
+        Fixjour do
+          define_builder(Bar) { |overrides| Bar.new(:name => "percy") }
+        end
+      end
+
+      it "raises DangerousBuilder" do
+        proc {
+          Fixjour.verify!
+        }.should raise_error(Fixjour::DangerousBuilder)
+      end
+
+      it "includes information about the failure" do
+        proc {
+          Fixjour.verify!
+        }.should raise_error(/uniqueness/)
+      end
+    end
+  end
+
+  context "when the builder returns an object that cannot be saved" do
+    before(:each) do
+      Fixjour.builders.clear
+
+      klass = build_model(:bars) {
+        string :name
+        has_many :people
+      }
+
+      bar_bomb = Object.new
+      stub(bar_bomb).save! { raise ActiveRecord::StatementInvalid.new("oops!") }
+      stub(bar_bomb).valid? { true }
+      stub(bar_bomb).new_record? { true }
+      stub(bar_bomb).is_a?(Bar) { true }
+
+      stub(Fixjour).new_record(anything) { bar_bomb }
+
+      Fixjour do
+        define_builder(klass) { |overrides| klass.new }
+      end
+    end
+
+    it "raises UnsavableBuilder" do
+      proc {
+        Fixjour.verify!
+      }.should raise_error(Fixjour::UnsavableBuilder)
+    end
+
+    it "includes information about the failure" do
+      proc {
+        Fixjour.verify!
+      }.should raise_error(/ActiveRecord::StatementInvalid/)
+    end
+  end
+
+  context "when the builder saves the object" do
+    before(:each) do
+      Fixjour do
+        define_builder(Foo) do |overrides|
+          Foo.create(:name => 'saved!', :bar => new_bar)
+        end
+      end
+    end
+
+    it "raises BuilderSavedRecord" do
+      proc {
+        Fixjour.verify!
+      }.should raise_error(Fixjour::BuilderSavedRecord)
+    end
+  end
+
+  context "when the object is not the correct type" do
+    before(:each) do
+      Fixjour do
+        define_builder(Foo) { |overrides| Bar.new(:name => 'saved!') }
+      end
+    end
+
+    it "raises WrongBuilderType" do
+      proc {
+        Fixjour.verify!
+      }.should raise_error(Fixjour::WrongBuilderType)
+    end
+  end
+end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: fixjour
 version: !ruby/object:Gem::Version 
+  hash: 15
   prerelease: false
   segments: 
   - 0
   - 5
-  - 1
-  version: 0.5.1
+  - 2
+  version: 0.5.2
 platform: ruby
 authors: 
 - Pat Nakajima
@@ -21,9 +22,11 @@ dependencies:
   name: activerecord
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -33,9 +36,11 @@ dependencies:
   name: faker
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -45,9 +50,11 @@ dependencies:
   name: acts_as_fu
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -62,21 +69,33 @@ extensions: []
 extra_rdoc_files: []
 
 files: 
+- README.textile
+- Rakefile
+- fixjour.gemspec
 - lib/core_ext/hash.rb
 - lib/core_ext/object.rb
+- lib/fixjour.rb
 - lib/fixjour/builder.rb
 - lib/fixjour/builders.rb
 - lib/fixjour/counter.rb
+- lib/fixjour/define.rb
 - lib/fixjour/definitions.rb
 - lib/fixjour/deprecation.rb
-- lib/fixjour/define.rb
 - lib/fixjour/errors.rb
 - lib/fixjour/generator.rb
 - lib/fixjour/merging_proxy.rb
 - lib/fixjour/overrides_hash.rb
 - lib/fixjour/redundant_check.rb
 - lib/fixjour/verify.rb
-- lib/fixjour.rb
+- spec/builder_spec.rb
+- spec/define_spec.rb
+- spec/dev.rip
+- spec/edge_cases_spec.rb
+- spec/fixjour_spec.rb
+- spec/merging_proxy_spec.rb
+- spec/overrides_hash_spec.rb
+- spec/spec_helper.rb
+- spec/verify_spec.rb
 has_rdoc: true
 homepage: http://github.com/nakajima/fixjour
 licenses: []
@@ -87,23 +106,27 @@ rdoc_options: []
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 2
 summary: Object creation methods everyone already has