fix-protocol 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 78bfecbb42df8d4fa0dc000256d0ea61e07756d2
-  data.tar.gz: 27444889ea27d17d726039237f4b4573c07074ed
+  metadata.gz: 8c0beed30259b1a1ac0e530e0b4a96ac0329e5ab
+  data.tar.gz: cb85ffdeb3c76826ad078091219ecbbd22e796cc
 SHA512:
-  metadata.gz: daed09c49db6d46f3e7aa6827fca4fc3fe880b43187b1d57a9ac8332b1afaf276f19915c59d23cdc391e5d3b48c90a7384ad8145e62fa72a1494553f301b1488
-  data.tar.gz: 560496f1d487ab9f56eee9721843dc2d8caca933760bd1e920becaa504758ec8f98ee1ede6dab83e0fcc31e1ab764f2a60ab20f1913c8ac1b82b30818cd65bae
+  metadata.gz: 620109d57d076bc3ccac65e8edfe1ec96db7e0cc01e048458d495fbb0f69503273148910fa9240eb352e39c7dc8f1d48468a581dba614b63e2480606a99fffbd
+  data.tar.gz: fcce3d4785f25e28e4f962c27e525e4a7d803109448265cfb41383bcf2d1a24533beca16c002e536ade01940d3f17feb9ec2aa74a97c7a37919736c0ebe34437

data/lib/fix/protocol.rb

@@ -41,8 +41,9 @@ module Fix
 
         # Check checksum
         checksum = str.match(/10\=([^\x01]+)\x01/)[1]
-        if checksum != ('%03d' % (str.gsub(/10\=[^\x01]+\x01/, '').bytes.inject(&:+) % 256))
-          errors << "Incorrect checksum"
+        expected = ('%03d' % (str.gsub(/10\=[^\x01]+\x01/, '').bytes.inject(&:+) % 256))
+        if checksum != expected
+          errors << "Incorrect checksum, expected <#{expected}>, got <#{checksum}>"
         end
 
         if errors.empty?

data/lib/fix/protocol/message.rb

@@ -10,8 +10,16 @@ module Fix
     #
     class Message < MessagePart
 
+      # Default version for when we do not specify anything
+      DEFAULT_VERSION = 'FIX.4.4'
+      @@expected_version = DEFAULT_VERSION
+
+      def self.version=(v)
+        @@expected_version = v
+      end
+
       part :header do
-        field :version,     tag: 8, required: true, default: 'FIX.4.4'
+        field :version,     tag: 8, required: true, default: @@expected_version
         field :body_length, tag: 9
 
         unordered :header_fields do
@@ -58,10 +66,10 @@ module Fix
       # @return [Array<String>] The errors on the message header
       #
       def errors
-        if (version == 'FIX.4.4')
+        if (version == @@expected_version)
           super
         else
-          [super, "Unsupported version: <#{version}>"].flatten
+          [super, "Unsupported version: <#{version}>, expected <#{@@expected_version}>"].flatten
         end
       end
 

data/lib/fix/protocol/messages/resend_request.rb

@@ -19,7 +19,7 @@ module Fix
         #
         def errors
           e = []
-          e << "EndSeqNo must either be 0 (inifinity) or be >= BeginSeqNo" unless (end_seq_no.zero? || (end_seq_no >= begin_seq_no))
+          e << "EndSeqNo must either be 0 (inifinity) or be >= BeginSeqNo" unless (begin_seq_no && (end_seq_no.zero? || (end_seq_no >= begin_seq_no)))
           [super, e].flatten
         end
 

data/lib/fix/protocol/messages/sequence_reset.rb

@@ -10,7 +10,7 @@ module Fix
       class SequenceReset < Message
 
         field :gap_fill_flag,   tag: 123, type: :yn_bool, default: false
-        field :new_seq_no,      tag: 36,  type: integer,  required: true
+        field :new_seq_no,      tag: 36,  type: :integer, required: true
 
       end
 

data/lib/fix/protocol/version.rb

@@ -4,7 +4,7 @@ module Fix
     #
     # The fix-protocol gem version string
     #   
-    VERSION = '1.1.0'
+    VERSION = '1.1.1'
 
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fix-protocol
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - David François
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-08 00:00:00.000000000 Z
+date: 2015-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec