fiveruns_tuneup 0.8.7 → 0.8.8

data/CHANGELOG

@@ -1,3 +1,5 @@
+v0.8.8. Fixed login broken when serving pages as xhtml strict.  Filtered params logged to tuneup.log.  TuneUp partials now rendered with exlicit extensions (.html.erb).
+
 v0.8.7. Sandboxed javascript for non-Prototype apps (Thanks, Howard Rauscher). The tuneup.log now written explicitly to RAILS_ROOT/log.  Removed History.rdoc in favor of CHANGELOG.
 
 v0.8.6. Performance optimizations, CSS fixes that prevents some layout issues that occurred when system doesn't have tuneup's preferred fonts.

data/assets/javascripts/init.js

@@ -9,4 +9,4 @@ setTimeout(function() {
 	style.height     = '0';
 	
 	document.body.appendChild(ifr);
-}, 0);
+}, 50);

data/assets/javascripts/prototype.js

@@ -1112,9 +1112,9 @@ Element.extend = function(element) {
   if (!element._extended && element.tagName && element != window) {
     var methods = Object.clone(Element.Methods), cache = Element.extend.cache;
 
-    if (element.tagName == 'FORM')
+    if (element.tagName.toUpperCase() == 'FORM')
       Object.extend(methods, Form.Methods);
-    if (['INPUT', 'TEXTAREA', 'SELECT'].include(element.tagName))
+    if (['INPUT', 'TEXTAREA', 'SELECT'].include(element.tagName.toUpperCase()))
       Object.extend(methods, Form.Element.Methods);
 
     Object.extend(methods, Element.Methods.Simulated);

data/fiveruns_tuneup.gemspec

@@ -1,10 +1,10 @@
 
-# Gem::Specification for Fiveruns_tuneup-0.8.7
+# Gem::Specification for Fiveruns_tuneup-0.8.8
 # Originally generated by Echoe
 
 Gem::Specification.new do |s|
   s.name = %q{fiveruns_tuneup}
-  s.version = "0.8.7"
+  s.version = "0.8.8"
 
   s.specification_version = 2 if s.respond_to? :specification_version=
 

data/lib/fiveruns/tuneup/version.rb

@@ -66,7 +66,7 @@ module Fiveruns
 
       MAJOR = 0
       MINOR = 8
-      TINY  = 7
+      TINY  = 8
 
       # The current version as a Version instance
       CURRENT = new(MAJOR, MINOR, TINY)

data/lib/tuneup_controller.rb

@@ -3,7 +3,9 @@ require 'ostruct'
 require 'open-uri'
 
 class TuneupController < ActionController::Base 
-  
+
+ filter_parameter_logging :password
+   
   def self.request_forgery_protection_options
     ApplicationController.request_forgery_protection_options || {}
   rescue
@@ -91,7 +93,7 @@ class TuneupController < ActionController::Base
   
   def collect(state)
     Fiveruns::Tuneup.collecting = state
-    render(:update) { |p| p['tuneup-panel'].replace(render(:partial => 'tuneup/panel/registered')) }
+    render(:update) { |p| p['tuneup-panel'].replace(render(:partial => 'tuneup/panel/registered.html.erb')) }
   end
 
   def find_config

data/lib/tuneup_helper.rb

@@ -157,7 +157,7 @@ module TuneupHelper #:nodoc:
   def tuneup_reload_panel
     update_page do |page|
       page['tuneup-flash'].removeClassName('tuneup-show');
-      page['tuneup-content'].replace_html(render(:partial => "tuneup/panel/#{@config.state}"))
+      page['tuneup-content'].replace_html(render(:partial => "tuneup/panel/#{@config.state}.html.erb"))
       page << 'TuneUp.adjustAbsoluteElements(_document.body);'
       page << 'TuneUp.adjustFixedElements();'
     end
@@ -166,7 +166,7 @@ module TuneupHelper #:nodoc:
   def tuneup_show_flash(type, locals)
     types = [:error, :notice].reject { |t| t == type }
     update_page do |page|
-      page['tuneup-flash'].replace_html(render(:partial => 'flash', :locals => locals.merge(:type => type)))
+      page['tuneup-flash'].replace_html(render(:partial => 'flash.html.erb', :locals => locals.merge(:type => type)))
       page['tuneup-flash'].addClassName('tuneup-show');
       types.each do |other_type|
         page['tuneup-flash'].removeClassName("tuneup-#{other_type}")

data/views/tuneup/_data.html.erb

@@ -6,9 +6,9 @@
     </div>
     <%= link_to_upload %>
   </div>
-  <%= render :partial => 'schema' %>
+  <%= render :partial => 'schema.html.erb' %>
   <ul id="tuneup-details">
-    <%= render :partial => 'step', :collection => tuneup_data.children %>
+    <%= render :partial => 'step.html.erb', :collection => tuneup_data.children %>
 		<li style="clear:both"></li>
   </ul>
 </div>

data/views/tuneup/_step.html.erb

@@ -8,10 +8,10 @@
     <li class="tuneup-detail-bar"><%= tuneup_bar(step, :width => (280 * (step.time / tuneup_data.time))) %></li>
 		<li style="clear:both"></li>
   </ul>
-  <%= render :partial => 'sql', :object => step.sql, :locals => {:step => step} if step.sql %>
+  <%= render :partial => 'sql.html.erb', :object => step.sql, :locals => {:step => step} if step.sql %>
   <% if step.children.any? %>  
     <ul id='<%= dom_id step, :children %>'<% if step.depth > 1 %> class='fiveruns_tuneup_children' <% unless open_step?(step) %>style='display:none'<% end %><% end %>>
-      <%= render :partial => 'step', :collection => step.children_with_disparity %>
+      <%= render :partial => 'step.html.erb', :collection => step.children_with_disparity %>
     </ul>
   <% end %>
 <% end %>

data/views/tuneup/panel/_unregistered.html.erb

@@ -1,4 +1,4 @@
-<form onsubmit="new TuneUpSandbox.Ajax.Request('/tuneup/signin', {asynchronous:true, evalScripts:true, onComplete:function(request){TuneUp.Spinner.stop()}, onLoading:function(request){TuneUp.Spinner.start()}, parameters:Form.serialize(this)}); return false;" method="post" action="/tuneup/signin">
+<form onsubmit="new TuneUpSandbox.Ajax.Request('/tuneup/signin', {asynchronous:true, evalScripts:true, onComplete:function(request){TuneUp.Spinner.stop()}, onLoading:function(request){TuneUp.Spinner.start()}, parameters:TuneUpSandbox.Form.serialize(this)}); return false;" method="post" action="/tuneup/signin">
   <p class='tuneup-full'>
     <label for='email'>Email</label>
     <%= text_field_tag :email, nil, :size => 20 %>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: fiveruns_tuneup
 version: !ruby/object:Gem::Version 
-  version: 0.8.7
+  version: 0.8.8
 platform: ruby
 authors: 
 - FiveRuns Development Team