fiveruns-fiveruns-memcache-client 1.5.0.2 → 1.5.0.3

data/History.txt

@@ -1,3 +1,7 @@
+= 1.5.0.3 (FiveRuns fork)
+
+* Integrated ITU-T CRC32 operation in native C extension for speed.  Thanks to Justin Balthrop!
+
 = 1.5.0.2 (FiveRuns fork)
 
 * Add support for seamless failover between servers.  If one server connection dies,

data/README.txt

@@ -1,26 +1,21 @@
 = memcache-client
 
+This is the FiveRuns fork of seattle.rb's memcache-client 1.5.0.  We've fixed several bugs
+which are in that version.
+
 Rubyforge Project:
 
 http://rubyforge.org/projects/seattlerb
 
-File bugs:
-
-http://rubyforge.org/tracker/?func=add&group_id=1513&atid=5921
-
 Documentation:
 
 http://seattlerb.org/memcache-client
 
-== About
-
-memcache-client is a client for Danga Interactive's memcached.
-
 == Installing memcache-client
 
 Just install the gem:
 
-  $ sudo gem install memcache-client
+  $ sudo gem install fiveruns-memcache-client --source http://gems.github.com
 
 == Using memcache-client
 
@@ -52,3 +47,8 @@ use with Rails.  To use it be sure to assign your memcache connection to
 CACHE.  Cache returns nil on all memcache errors so you don't have to rescue
 the errors yourself.  It has #get, #put and #delete module functions.
 
+=== Improving Performance ===
+
+Performing the CRC-32 ITU-T step to determine which server to use for a given key
+is VERY slow in Ruby.  RubyGems should compile a native library for performing this
+operation when the gem is installed.

data/ext/crc32/crc32.c

@@ -0,0 +1,28 @@
+#include "ruby.h"
+#include "stdio.h"
+
+static VALUE t_itu_t(VALUE self, VALUE string) {
+  VALUE str = StringValue(string);
+  int   n = RSTRING(str)->len;
+  char* p = RSTRING(str)->ptr;
+  unsigned long r = 0xFFFFFFFF;
+  int i, j;
+
+  for (i = 0; i < n; i++) {
+    r = r ^ p[i];
+    for (j = 0; j < 8; j++) {
+      if ( (r & 1) != 0 ) {
+        r = (r >> 1) ^ 0xEDB88320;
+      } else {
+        r = r >> 1;
+      }
+    }
+  }
+  return INT2FIX(r ^ 0xFFFFFFFF);
+}
+
+VALUE cCRC32;
+void Init_crc32() {
+  cCRC32 = rb_define_module("CRC32");
+  rb_define_module_function(cCRC32, "itu_t", t_itu_t, 1);
+}

data/ext/crc32/extconf.rb

@@ -0,0 +1,5 @@
+require 'mkmf'
+
+dir_config("crc32")
+
+create_makefile("crc32")

data/lib/memcache.rb

@@ -9,25 +9,33 @@ class String
 
   ##
   # Uses the ITU-T polynomial in the CRC32 algorithm.
-
-  def crc32_ITU_T
-    n = length
-    r = 0xFFFFFFFF
-
-    n.times do |i|
-      r ^= self[i]
-      8.times do
-        if (r & 1) != 0 then
-          r = (r>>1) ^ 0xEDB88320
-        else
-          r >>= 1
+  begin
+    require 'crc32'
+    def crc32_ITU_T
+      CRC32.itu_t(self)
+    end
+  rescue LoadError => e
+    puts "Loading with slow CRC32 ITU-T implementation: #{e.message}"
+    
+    def crc32_ITU_T
+      n = length
+      r = 0xFFFFFFFF
+
+      n.times do |i|
+        r ^= self[i]
+        8.times do
+          if (r & 1) != 0 then
+            r = (r>>1) ^ 0xEDB88320
+          else
+            r >>= 1
+          end
         end
       end
-    end
 
-    r ^ 0xFFFFFFFF
+      r ^ 0xFFFFFFFF
+    end
   end
-
+  
 end
 
 ##

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: fiveruns-fiveruns-memcache-client
 version: !ruby/object:Gem::Version 
-  version: 1.5.0.2
+  version: 1.5.0.3
 platform: ruby
 authors: 
 - Eric Hodel
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-05-14 00:00:00 -07:00
+date: 2008-06-25 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -19,8 +19,8 @@ description: A Ruby-based memcached client library
 email: mike@fiveruns.com
 executables: []
 
-extensions: []
-
+extensions: 
+- ext/crc32/extconf.rb
 extra_rdoc_files: []
 
 files: 
@@ -30,6 +30,7 @@ files:
 - Rakefile
 - lib/memcache.rb
 - lib/memcache_util.rb
+- ext/crc32/crc32.c
 has_rdoc: false
 homepage: http://github.com/fiveruns/memcache-client
 post_install_message: 
@@ -52,7 +53,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.0.1
+rubygems_version: 1.2.0
 signing_key: 
 specification_version: 2
 summary: A Ruby-based memcached client library