fitting 2.14.1 → 2.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 442894f4d3f5ebc1db8187887cdbbcd9fd5ca04952e0bccfb2b7c9d77e0e12f9
-  data.tar.gz: d521ac6035a27b8adf600e0d53e4e4aa36836c7b4207f1d3479a3e9bb81f16e3
+  metadata.gz: 122a6d2713a74d7e0610f1378b7be6fdd42d0798fa6f6a008dc114186f86eade
+  data.tar.gz: 3af5cf786f1489c9b249603551fe64c2d1fbb6b69183054d9ddadc8553b0a6de
 SHA512:
-  metadata.gz: e97a22523182921796b087b4ca73b684c9853f8131dcd9102f76cdb3ca940bc60dbb2f17f653a26d05ffca559529a927a21a48de8f6a687a3b5cad3588cd5dd3
-  data.tar.gz: 660cbb6a209448f92ebb5463887b406f5021e81886dca21ae5a13d4e35d31f775eea288c65462a9189977d8a9501590ad906c2f5f5320d553258a32960f849c4
+  metadata.gz: f11047db22a04c8562c75be538152e61cbf78ecd223ac941a61adaca5c2edda6ad44d1a14ac2dd535ca3f5e20bc4ffde4c101e9b48f0525392e248f6c870157e
+  data.tar.gz: 99309897c90a7ea145141a00a073cf82ad56091557c9cd0044a9c5421440f945439e510440820f0f48c7a9f5dd8abec246e6e1872d8ba77d25d8843e94519b80

data/.github/workflows/ruby.yml

@@ -0,0 +1,33 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+      uses: ruby/setup-ruby@v1
+    # uses: ruby/setup-ruby@ec106b438a1ff6ff109590de34ddc62c540232e0
+      with:
+        ruby-version: 2.7
+    - name: Install dependencies
+      run: bundle install
+    - name: Run tests
+      run: bundle exec rake

data/.ruby-version

@@ -1 +1 @@
-2.3.0
+2.6.1

data/.tool-versions

@@ -1 +1 @@
-ruby 2.3.0
+ruby 2.6.1

data/CHANGELOG.md

@@ -1,5 +1,32 @@
 # Change log
 
+### 2.17.0 - 2021-09-20
+
+* features
+  * display tests_without_responses details on the main page [#115](https://github.com/funbox/fitting/issues/115)
+
+### 2.16.1 - 2021-02-10
+* patch
+  * make prefix optional [#98](https://github.com/funbox/fitting/issues/98)
+
+### 2.16.0 - 2021-02-10
+
+* features
+  * support swagger and openapi [#96](https://github.com/funbox/fitting/issues/96)
+* patch
+  * let's bump to tomograph '3.0.1' [#95](https://github.com/funbox/fitting/issues/95)
+
+### 2.15.0 - 2020-10-12
+
+* features
+  * color for bad response [#79](https://github.com/funbox/fitting/issues/79)
+  * show test details [#81](https://github.com/funbox/fitting/issues/81)
+* patch
+  * update ruby [#83](https://github.com/funbox/fitting/issues/83)
+  * update bundler [#84](https://github.com/funbox/fitting/issues/84)
+  * update tomograph [#85](https://github.com/funbox/fitting/issues/85)
+  * use github actions for CI instead of Travis [#30](https://github.com/funbox/fitting/issues/30)
+
 ### 2.14.1 - 2020-09-23
 
 * fixes

data/README.md

@@ -1,42 +1,38 @@
 # Fitting
 
-[![Gem Version](https://badge.fury.io/rb/fitting.svg)](https://badge.fury.io/rb/fitting)
-[![Build Status](https://travis-ci.org/funbox/fitting.svg?branch=master)](https://travis-ci.org/funbox/fitting)
+<img align="right" width="192" height="192"
+alt="Optimizt avatar: OK sign with Mona Lisa picture between the fingers"
+src="./images/logo.png">
 
-This gem will help you implement your API in strict accordance to the documentation in [API Blueprint](https://apiblueprint.org/) format.
-To do this, when you run your RSpec tests on controllers, it automatically searches for the corresponding JSON-schemas in the documentation and then validates responses with them.
+There are such ways of describing the API documentation as API Blueprint, Swagger and OpenAPI. And using the tests already writed for your code, you can reuse them to find out the documentation coverage.
+This makes it easy to find out how much the documentation matches the implementation.
 
-## Installation
+* Cool if you already have a project with tests and documentation, you can check how good everything is and fix microbags.
 
-First you need to install [drafter](https://github.com/apiaryio/drafter).
+* If are you going developing API and  write documentation for it, this tool will help you document-driven development easily create high-quality write API documentation and API.
 
-Then add this line to your application's Gemfile:
+* Also, if you have an undocumented API, this is an easy way to describe it.
 
+![exmaple](images/example.png)
+
+## Installation
+Add this line to your application's Gemfile:
 ```ruby
 gem 'fitting'
 ```
 
 After that execute:
-
 ```bash
 $ bundle
 ```
 
 Or install the gem by yourself:
-
 ```bash
 $ gem install fitting
 ```
 
 ## Usage
-
-Add this to your `.fitting.yml`:
-
-```yaml
-apib_path: /path/to/doc.apib
-```
-
-And this to your `spec_helper.rb`:
+And next to your `spec_helper.rb`:
 
 ```ruby
 require 'fitting'
@@ -44,304 +40,122 @@ require 'fitting'
 Fitting.save_test_data
 ```
 
-The result files will be created in `./fitting_tests/` folder.
-
-Output example:
-
-```json
-[
-  {
-    "method": "GET",
-    "path": "/api/v1/book",
-    "body": {},
-    "response": {
-      "status": 200,
-      "body": {
-        "title": "The Martian Chronicles"
-      }
-    },
-    "title": "/spec/controllers/api/v1/books_controller_spec.rb:11",
-    "group": "/spec/controllers/api/v1/books_controller_spec.rb"
-  },
-  {
-    "method": "POST",
-    "path": "/api/v1/book",
-    "body": {},
-    "response": {
-      "status": 200,
-      "body": {
-        "title": "The Old Man and the Sea"
-      }
-    },
-    "title": "/spec/controllers/api/v1/books_controller_spec.rb:22",
-    "group": "/spec/controllers/api/v1/books_controller_spec.rb"
-  }
-]
-```
-
-## Documentation coverage
-
-To match routes and validate JSON-schemas run:
-
-```bash
-rake fitting:documentation_responses[report_size]
-```
-
-There are four types (or `report_size`) of reports available: 
-  
-- `xs` — the smallest report;
-- `s` — includes coverage for `required` fields;
-- `m` — includes coverage for `required` and `enum` fields;
-- `l` — includes coverage for `required`, `enum` and `oneOf` fields.
-
-E.g. for `xs` size:
-
-```bash
-rake fitting:documentation_responses[xs]
-```
-
-**Note**: In zsh you should add quotes around the task:
-
-```bash
-rake 'fitting:documentation_responses[xs]'
-```
-
-Also you can use `documentation_responses_error` to get more detailed errors description.
-Check the examples below. 
-
-### Examples
-
-`xs` size:
-
-```text
-Fully conforming requests:
-DELETE  /api/v1/book                 ✔ 200 ✔ 201 ✔ 404
-DELETE  /api/v1/book/{id}            ✔ 200 ✔ 201 ✔ 404
-GET     /api/v1/book/{id}/seller     ✔ 200 ✔ 201 ✔ 404
-
-Partially conforming requests:
-GET     /api/v1/book                 ✖ 200 ✔ 404
-POST    /api/v1/book                 ✖ 200 ✔ 201 ✔ 404
-GET     /api/v1/book/{id}            ✖ 200 ✔ 404 ✔ 200
-PATCH   /api/v1/book/{id}            ✖ 200 ✔ 201 ✔ 404
-
-Non-conforming requests:
-GET     /api/v1/seller               ✖ 200 ✖ 201 ✖ 404
-GET     /api/v1/buyer                ✖ 200 ✖ 404
-
-API requests with fully implemented responses: 3 (33.33% of 9).
-API requests with partially implemented responses: 4 (44.44% of 9).
-API requests with no implemented responses: 2 (22.22% of 9).
-
-API responses conforming to the blueprint: 16 (64.00% of 25).
-API responses with validation errors or untested: 9 (36.00% of 25).
-```
-
-`s` size:
-
-```text
-Fully conforming requests:
-DELETE  /api/v1/book                 100% 200 100% 201 100% 404
-DELETE  /api/v1/book/{id}            100% 200 100% 201 100% 404
-GET     /api/v1/book/{id}/seller     100% 200 100% 201 100% 404
-
-Partially conforming requests:
-GET     /api/v1/book                 0% 200 66% 404
-POST    /api/v1/book                 0% 200 90% 201 100% 404
-GET     /api/v1/book/{id}            0% 200 88% 404 10% 200
-PATCH   /api/v1/book/{id}            0% 200 100% 201 10% 404
-
-Non-conforming requests:
-GET     /api/v1/seller               0% 200 0% 201 0 404
-GET     /api/v1/buyer                0% 200 0% 404
-
-API requests with fully implemented responses: 3 (33.33% of 9).
-API requests with partially implemented responses: 4 (44.44% of 9).
-API requests with no implemented responses: 2 (22.22% of 9).
-
-API responses conforming to the blueprint: 16 (64.00% of 25).
-API responses with validation errors or untested: 9 (36.00% of 25).
-```
+Add this to your `.fitting.yml`:
 
-`documentation_responses_error[s]` example:
+### OpenAPI 2.0
+Also Swagger
 
+```yaml
+prefixes:
+  - name: /api/v1
+    openapi2_json_path: doc.json
 ```
-request method: GET
-request path: /api/v1/book
-response status: 200
-source json-schema: {"$schema"=>"http://json-schema.org/draft-04/schema#", "type"=>"object", ...}
-combination: ["required", "pages"]
-new json-schema: {"$schema"=>"http://json-schema.org/draft-04/schema#", "type"=>"object", ...}
-```
-
-### Experimental report
 
-This report will be available and properly documented in the next major update, but you already can try it by running:   
+### OpenAPI 3.0
+Also OpenAPI
 
-```bash
-bundle e rake fitting:report
+```yaml
+prefixes:
+  - name: /api/v1
+    openapi3_yaml_path: doc.yaml
 ```
 
-Using this you can document API prefixes. 
-The task will create JSON (`fitting/report.json`) and HTML (`fitting/index.html`) reports.
-
-## Tests coverage
+### API Blueprint
+First you need to install [drafter](https://github.com/apiaryio/drafter).
+Works after conversion from API Blueprint to API Elements (in YAML file) with Drafter.
 
-Only `xs` size is available for tests coverage:
+That is, I mean that you first need to do this
 
 ```bash
-rake fitting:tests_responses[xs]
+drafter doc.apib -o doc.yaml
 ```
 
-## Config
-
-You can specify the settings either in a YAML file `.fitting.yml` or in a config.
-If your project uses several prefixes, for each one you should create a separate YAML file in the folder `fitting` (`fitting/*.yml`).
-
-All the available config options are described below.
-
-### `apib_path`
-
-Path to API Blueprint v3 documentation. 
-There must be an installed [drafter](https://github.com/apiaryio/drafter) to parse it.
-
-### `drafter_yaml_path`
-
-Path to API Blueprint v3 documentation, pre-parsed with `drafter` and saved to a YAML file.
-
-### `drafter_4_apib_path`
-
-Path to API Blueprint v4 documentation. 
-There must be an installed [drafter](https://github.com/apiaryio/drafter) to parse it.
-
-### `drafter_4_yaml_path`
-
-Path to API Blueprint v4 documentation, pre-parsed with `drafter` and saved to a YAML file.
-
-### `crafter_apib_path`
-
-Path to API Blueprint v4 documentation.
-
-### `crafter_yaml_path`
-
-Path to API Blueprint v4 documentation, pre-parsed with `crafter` and saved to a YAML file.
-
-### `tomogram_json_path`
-
-Path to Tomogram documentation, pre-parsed with [tomograph](https://github.com/funbox/tomograph) and saved to a JSON file.
-
-### `strict`
-
-Default: `false`
-
-When `true` all properties are considered to have `"required": true` and all objects are considered to have `"additionalProperties": false`.
-
-### `prefix`
-
-Prefix for API requests. E.g. `'/api'`. Validation will not be performed if the request path does not start with a prefix.
-
-### `white_list`
-
-Default: all paths
- 
-This is an array of paths that are mandatory for implementation.
-The list does not affect the work of the matcher.
-It's used for the CLI report only.
+and then
 
 ```yaml
-white_list:
-  /users:
-    - DELETE
-    - POST
-  /users/{id}:
-    - GET
-    - PATCH
-  /users/{id}/employees:
-    - GET
-  /sessions: []
+prefixes:
+  - name: /api/v1
+    drafter_yaml_path: doc.yaml
 ```
 
-Empty array (`[]`) means all methods.
+### Tomograph
 
-### `resource_white_list`
-
-Default: all resources
-
-This is an array of resources that are mandatory for implementation.
-The list does not affect the work of the matcher.
-It's used for the CLI report only.
+To use additional features of the pre-converted [tomograph](https://github.com/funbox/tomograph)
 
 ```yaml
-resource_white_list:
-  /users:
-    - DELETE /users/{id}
-    - POST /users
-    - GET /users/{id}
-    - PATCH /users/{id}
-  /users/{id}/employees:
-    - GET /users/{id}/employees
-  /sessions: []
+prefixes:
+  - name: /api/v1
+    tomogram_json_path: doc.json
 ```
 
-Empty array (`[]`) means all methods.
-
-### `json_schema_cover`
-
-Default: false
-
-JSON-schema covering becomes mandatory.
-However, if you don't use `Fitting.statistics` you can call `responses.statistics.cover_save`.
-
-### `include_resources`
-
-Default: all resources (but only when `include_resources` and `include_actions` are not defined)
-
-This is an array of resources that are mandatory for implementation.
-The list does not affect the work of the matcher.
-It's used for the CLI report only.
-
-```yaml
-include_resources:
-  - /sessions
+## Run
+Run tests first to get run artifacts
+```bash
+bundle e rspec
 ```
 
-### `include_actions`
-
-Default: all paths (but only when `include_resources` and `include_actions` are not defined)
-
-This is an array of paths that are mandatory for implementation.
-The list does not affect the work of the matcher.
-It's used for the CLI report only.
-
-```yaml
-include_actions:
-  - DELETE /users/{id}
-  - POST /users
-  - GET /users/{id}
-  - PATCH /users/{id}
-  - GET /users/{id}/employees
+and then
+```bash
+bundle e rake fitting:report
 ```
 
-### `ignore_list`
+Console ouptut
 
-You can use ignore list to omit checks with matchers.
+```text
+/api/v1
+POST	/api/v1/accounts/{account_id}/inboxes				 0% 200 0% 404 0% 403
+PATCH	/api/v1/accounts/{account_id}/inboxes/{id}			 0% 200 0% 404 0% 403
+POST	/api/v1/accounts/{account_id}/inboxes/{id}/set_agent_bot	 0% 204 100% 404 0% 403
+GET	/api/v1/agent_bots						 0% 200 0% 404 0% 403
+GET	/api/v1/accounts/{account_id}/conversations			 0% 200 0% 400 0% description
+POST	/api/v1/accounts/{account_id}/conversations			 0% 200 0% 403
+GET	/api/v1/accounts/{account_id}/conversations/{id}		 59% 200 0% 404 0% 403
+POST	/api/v1/accounts/{account_id}/conversations/{id}/toggle_status	 80% 200 0% 404 0% 403
+GET	/api/v1/accounts/{account_id}/conversations/{id}/messages	 47% 200 0% 404 0% 403
+POST	/api/v1/accounts/{account_id}/conversations/{id}/messages	 0% 200 0% 404 0% 403
+GET	/api/v1/accounts/{account_id}/conversations/{id}/labels		 100% 200 0% 404 0% 403
+POST	/api/v1/accounts/{account_id}/conversations/{id}/labels		 100% 200 0% 404 0% 403
+POST	/api/v1/accounts/{account_id}/conversations/{id}/assignments	 77% 200 0% 404 0% 403
+GET	/api/v1/accounts/{account_id}/contacts				 0% 200 0% 400
+POST	/api/v1/accounts/{account_id}/contacts				 14% 200 0% 400
+GET	/api/v1/accounts/{account_id}/contacts/{id}			 14% 200 0% 404 0% 403
+PUT	/api/v1/accounts/{account_id}/contacts/{id}			 0% 204 0% 404 0% 403
+GET	/api/v1/accounts/{account_id}/contacts/{id}/conversations	 0% 200 0% 404 0% 403
+GET	/api/v1/accounts/{account_id}/contacts/search			 0% 200 0% 401
+POST	/api/v1/accounts/{account_id}/contacts/{id}/contact_inboxes	 0% 200 0% 401 100% 422
+GET	/api/v1/profile							 88% 200 100% 401
+
+tests_without_prefixes: 42
+tests_without_actions: 144
+tests_without_responses: 43
+```
+
+And task will create HTML (`fitting/index.html`) reports.
+
+![exmaple](images/example.png)
+
+More information on action coverage
+
+![exmaple2](images/example2.png)
+
+## prefix name
+
+Setting the prefix name is optional. For example, you can do this:
 
 ```yaml
-ignore_list:
-  - %r{/api/v1/users/[1-9].}
-  - %r{/api/v1/comments}
+prefixes:
+  - openapi2_json_path: doc.json
 ```
 
-It works only for `match_schema` and **not** for `strictly_match_schema`.
-
-### `prefixes`
-
-Example:
+## prefix skip
 
+It is not necessary to immediately describe each prefix in detail, you can only specify its name and skip it until you are ready to documented it
 ```yaml
 prefixes:
-  - name: /api/v1
-  - name: /api/v2
+- name: /api/v1
+  openapi2_json_path: doc.json
+- name: /api/v3
+  skip: true
 ```
 
 ## Contributing

data/fitting.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ['d.efimov']
   spec.email         = ['d.efimov@fun-box.ru']
 
-  spec.summary       = 'Validation in the rspec of API Blueprint'
-  spec.description   = 'Validation responses in the rspec with the help of API Blueprint'
+  spec.summary       = 'Coverage API Blueprint, Swagger and OpenAPI with RSpec'
+  spec.description   = 'Coverage API Blueprint, Swagger and OpenAPI with RSpec for easily make high-quality API and documenatiton'
   spec.homepage      = 'https://github.com/funbox/fitting'
   spec.license       = 'MIT'
 
@@ -20,10 +20,10 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'json-schema', '~> 2.6', '>= 2.6.2'
   spec.add_runtime_dependency 'multi_json', '~> 1.11'
-  spec.add_runtime_dependency 'tomograph', '~> 2.0', '>= 2.2.0'
-  spec.add_development_dependency 'bundler', '~> 1.12'
+  spec.add_runtime_dependency 'tomograph', '~> 3.1', '>= 3.1.0'
+  spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'byebug', '~> 8.2', '>= 8.2.1'
-  spec.add_development_dependency 'rake', '>= 12.3.3'
+  spec.add_development_dependency 'rake', '~> 12.3', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.4', '>= 3.4.0'
   spec.add_development_dependency 'rubocop', '~> 0.49.1', '>= 0.49.1'
   spec.add_development_dependency 'simplecov', '~> 0.11', '>= 0.11.2'

data/lib/fitting/report/actions.rb

@@ -3,11 +3,7 @@ require 'fitting/report/action'
 module Fitting
   module Report
     class Actions
-      def initialize(prefix, tomogram_json_path)
-        actions = Tomograph::Tomogram.new(
-            prefix: prefix,
-            tomogram_json_path: tomogram_json_path
-        )
+      def initialize(actions)
         @actions = []
         actions.to_a.map do |action|
           @actions.push(Fitting::Report::Action.new(action))

data/lib/fitting/report/console.rb

@@ -15,7 +15,7 @@ module Fitting
           @tests_without_actions += prefix_details[:actions][:tests_without_actions]
           res += prefix_details[:actions][:actions_details].inject('') do |res_actions, action|
             res_actions += "#{action[:method]}\t#{action[:path]}"
-            tab = "\t" * ((3 - action[:path].size / 8) + 3)
+            tab = "\t" * (8 - action[:path].size / 8)
             @tests_without_responses += action[:responses][:tests_without_responses]
             res_actions += tab + action[:responses][:responses_details].inject('') do |res_responses, response|
               @good = false if response[:combinations][:cover_percent] != '100%'

data/lib/fitting/report/prefix.rb

@@ -3,13 +3,48 @@ require 'fitting/report/actions'
 module Fitting
   module Report
     class Prefix
-      def initialize(name, tomogram_json_path, skip = false)
+      def initialize(name: '', openapi2_json_path: nil, openapi3_yaml_path: nil, drafter_yaml_path: nil, tomogram_json_path: nil, crafter_yaml_path: nil, skip: false)
         @name = name
         @tomogram_json_path = tomogram_json_path
         @tests = Fitting::Report::Tests.new([])
         @skip = skip
         unless skip
-          @actions = Fitting::Report::Actions.new(name, tomogram_json_path)
+          @actions = if openapi2_json_path
+                       Fitting::Report::Actions.new(
+                         Tomograph::Tomogram.new(
+                           prefix: name,
+                           openapi2_json_path: openapi2_json_path
+                         )
+                       )
+                     elsif openapi3_yaml_path
+                       Fitting::Report::Actions.new(
+                         Tomograph::Tomogram.new(
+                           prefix: name,
+                           openapi3_yaml_path: openapi3_yaml_path
+                         )
+                       )
+                     elsif drafter_yaml_path
+                       Fitting::Report::Actions.new(
+                         Tomograph::Tomogram.new(
+                           prefix: name,
+                           drafter_yaml_path: drafter_yaml_path
+                         )
+                       )
+                     elsif crafter_yaml_path
+                       Fitting::Report::Actions.new(
+                         Tomograph::Tomogram.new(
+                           prefix: name,
+                           crafter_yaml_path: crafter_yaml_path
+                         )
+                       )
+                     else
+                       Fitting::Report::Actions.new(
+                         Tomograph::Tomogram.new(
+                           prefix: name,
+                           tomogram_json_path: tomogram_json_path
+                         )
+                       )
+                     end
         end
       end
 

data/lib/fitting/report/prefixes.rb

@@ -6,12 +6,24 @@ module Fitting
       def initialize(config_path)
         @prefixes = []
         YAML.safe_load(File.read(config_path))['prefixes'].map do |prefix|
-          @prefixes.push(Fitting::Report::Prefix.new(prefix['name'], prefix['tomogram_json_path'], prefix['skip']))
+          @prefixes.push(
+            Fitting::Report::Prefix.new(
+              name: prefix['name'],
+              openapi2_json_path: prefix['openapi2_json_path'],
+              openapi3_yaml_path: prefix['openapi3_yaml_path'],
+              drafter_yaml_path: prefix['drafter_yaml_path'],
+              tomogram_json_path: prefix['tomogram_json_path'],
+              crafter_yaml_path: prefix['crafter_yaml_path'],
+              skip: prefix['skip']
+            )
+          )
         end
       end
 
       def is_there_a_suitable_prefix?(test_path)
         @prefixes.map do |prefix|
+          return true if prefix.name.nil?
+          return true if prefix.name == ''
           return true if test_path[0..prefix.name.size - 1] == prefix.name
         end
 
@@ -20,7 +32,7 @@ module Fitting
 
       def cram_into_the_appropriate_prefix(test)
         @prefixes.map do |prefix|
-          if test.path[0..prefix.name.size - 1] == prefix.name
+          if prefix.name.nil? || prefix.name == '' || test.path[0..prefix.name.size - 1] == prefix.name
             prefix.add_test(test)
             return
           end