fit_kit 0.1.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cfc4c2435b6e655fe41d4e467e373b5b282eaab6f738922d1d5a93721c8adaaa
-  data.tar.gz: a1ab87078789a8e83fc13d9f2ee39bf4e060d35f2b290adbadd95e4def05afcf
+  metadata.gz: 3fb71b8237876ebc05273a7cb9c78306424ad04ba4c1505f8bc70781cf2c35c2
+  data.tar.gz: 5ac086bb3a7b95729c74ad69c6818495ef3111b0cbf062b3f0beca072bcd53ff
 SHA512:
-  metadata.gz: 2c25a7c3cb74581d959c406c89fa8a1df686c7632e52c52cab58c3b3a9bd1771e90ef7b0d2c67ae386e21a12d45eed52759dd951bc14b8b2a8622877d88d095c
-  data.tar.gz: bc93a12200a50dd2d7cdaf4e9eaf165a7308ca59e83640ac26cd4b701305cda9a9b0e7908b885a7d55d4ec1281c5dc62db0b5ffbd57705ff1f8153c4ddb1ce4e
+  metadata.gz: f56f45e3911e4ba9cfab9bf1acb57b53f58e06cf3abae892dc3ad5f58d48c10ba8ec54a895056e0612295b32815db838ccb7f01428d9558aeac190fd6ca3ba6a
+  data.tar.gz: 4544ae74e7bc2510f4bcff6826ecc08850e9c01f6bdf0c6e7f95873c2e80753989bbc471855cfd72f6293946016d682223d33e64816310fe517b38ee1b4c7d4c

data/CHANGELOG.md

@@ -1,4 +1,10 @@
-## [Unreleased]
+## [0.3.0] - 2024-10-16
+
+- Simplify to return hash for the parsing
+
+## [0.2.0] - 2024-10-15
+
+- Simplify to return hash fileds for records
 
 ## [0.1.0] - 2024-10-14
 

data/Cargo.lock

@@ -41,7 +41,7 @@ dependencies = [
  "bitflags",
  "cexpr",
  "clang-sys",
- "itertools",
+ "itertools 0.12.1",
  "lazy_static",
  "lazycell",
  "proc-macro2",
@@ -131,6 +131,7 @@ name = "fit_kit"
 version = "0.1.0"
 dependencies = [
  "fitparser",
+ "itertools 0.13.0",
  "magnus",
 ]
 
@@ -183,6 +184,15 @@ dependencies = [
  "either",
 ]
 
+[[package]]
+name = "itertools"
+version = "0.13.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "413ee7dfc52ee1a4949ceeb7dbc8a33f2d6c088194d9f922fb8318faf1f01186"
+dependencies = [
+ "either",
+]
+
 [[package]]
 name = "js-sys"
 version = "0.3.72"

data/README.md

@@ -17,7 +17,51 @@ If bundler is not being used to manage dependencies, install the gem by executin
 ```ruby
 test_fit_file = File.join(Dir.pwd, "example.fit")
 fit_data_records = ::FitKit.parse_fit_file(test_fit_file)
-# [RFitDataRecord, RFitDataRecord, RFitDataRecord ...]
+# { record: [{...}, {...}], session: [{...}], lap: [..], activity: [...] }
+```
+
+## Performance
+Here is the performance parsing __4090__ fit files on my M1 Mac Mini (16G, 8 Cores) took 6 seconds (in parallel):
+
+```txt
+❯ ruby app.rb
+Parsing 4090 fit files...
+       user     system      total        real
+  0.129862   0.102642  45.192900 (  6.121117)
+```
+
+Code to parse a given folder (contains __4090__ fit files) in parallel:
+
+```ruby
+require 'fit_kit'
+require 'benchmark'
+require 'parallel'
+
+def parse_concurrently
+  puts "Parsing all fit files here"
+  fit_files = Dir.glob("/Users/mikeli/docs/HealthFit/*.{fit,FIT}")
+  puts "Parsing #{fit_files.size} fit files..."
+
+  # Determine the number of processors
+  num_processors = Parallel.processor_count
+
+  # Parse files concurrently
+  Parallel.each(fit_files, in_processes: num_processors) do |file|
+    begin
+      FitKit.parse_fit_file(file)
+    rescue => e
+      puts "Error parsing #{file}: #{e.message}"
+    end
+  end
+end
+
+
+Benchmark.bm do |x|
+  x.report do
+    parse_concurrently
+  end
+end
+
 ```
 
 ## Contributing

data/ext/fit_kit/Cargo.toml

@@ -11,4 +11,5 @@ crate-type = ["cdylib"]
 
 [dependencies]
 fitparser = "0.7.0"
+itertools = "0.13.0"
 magnus = { version = "0.6.2" }

data/ext/fit_kit/src/lib.rs

@@ -1,12 +1,8 @@
-use fitparser::{self, FitDataField, FitDataRecord, Value};
-use magnus::{function, method, prelude::*, Error, IntoValue, RArray, Ruby};
+use fitparser::{self, FitDataRecord, Value};
+use itertools::Itertools;
+use magnus::{function, prelude::*, Error, IntoValue, RArray, RHash, Ruby, Symbol};
 use std::fs::File;
 
-///////////////////////// RFitDataField ///////////////////////////
-// define a wrapper ruby class for FitDataField
-#[magnus::wrap(class = "RFitDataField")]
-struct RFitDataField(FitDataField);
-
 // recursive method to turn Fit value into magnus::Value
 fn value_to_rb_value(value: &Value) -> magnus::Value {
     match value {
@@ -38,52 +34,22 @@ fn value_to_rb_value(value: &Value) -> magnus::Value {
     }
 }
 
-impl RFitDataField {
-    fn name(&self) -> String {
-        self.0.name().to_string()
-    }
-
-    fn value(&self) -> magnus::Value {
-        value_to_rb_value(self.0.value())
-    }
-}
-
-///////////////////////// RFitDataRecord ///////////////////////////
-#[magnus::wrap(class = "RFitDataRecord")]
-struct RFitDataRecord(FitDataRecord);
-
-impl RFitDataRecord {
-    fn kind(&self) -> String {
-        self.0.kind().to_string()
+fn get_fields_hash(record: &FitDataRecord) -> RHash {
+    let hash = RHash::new();
+    for field in record.fields() {
+        let value = value_to_rb_value(field.value());
+        let pair = RHash::new();
+        pair.aset(Symbol::new("units"), field.units()).unwrap();
+        pair.aset(Symbol::new("value"), value).unwrap();
+        // here we add the stuff to the hash
+        let field_name_symbol = Symbol::new(field.name());
+        hash.aset(field_name_symbol, pair).unwrap();
     }
 
-    fn fields(&self) -> RArray {
-        let array = RArray::new();
-        for field in self.0.fields() {
-            array.push(RFitDataField(field.clone())).unwrap();
-        }
-        array
-    }
+    hash
 }
 
-// Here we define two ruby classes
-// RFitDataRecord and RFitDataField
-fn define_ruby_classes(ruby: &Ruby) -> Result<(), magnus::Error> {
-    let class = ruby.define_class("RFitDataField", ruby.class_object())?;
-
-    // define bunch of methods
-    class.define_method("name", method!(RFitDataField::name, 0))?;
-    class.define_method("value", method!(RFitDataField::value, 0))?;
-
-    // definie the the other one here
-    let data_record_class = ruby.define_class("RFitDataRecord", ruby.class_object())?;
-    data_record_class.define_method("kind", method!(RFitDataRecord::kind, 0))?;
-    data_record_class.define_method("fields", method!(RFitDataRecord::fields, 0))?;
-
-    Ok(())
-}
-
-fn parse_fit_file(file_path: String) -> Result<RArray, magnus::Error> {
+fn parse_fit_file(file_path: String) -> Result<RHash, magnus::Error> {
     let mut fp = File::open(file_path)
         .map_err(|e| Error::new(Ruby::get().unwrap().exception_io_error(), e.to_string()))?;
     let data = fitparser::from_reader(&mut fp).map_err(|e| {
@@ -93,19 +59,30 @@ fn parse_fit_file(file_path: String) -> Result<RArray, magnus::Error> {
         )
     })?;
 
-    // finally we have the result array of record
-    let array = RArray::new();
-    for record in data {
-        array.push(RFitDataRecord(record)).unwrap();
+    // now let's group by the record by kind
+    let result_hash = RHash::new();
+    for (kind, kind_records) in data
+        .iter()
+        .chunk_by(|record| record.kind().to_string())
+        .into_iter()
+    {
+        // turn records into rarray
+        let array = RArray::new();
+        for record in kind_records {
+            // TODO here do not pass RFitDataRecord
+            // turn it into fields_hash directly
+            array.push(get_fields_hash(record)).unwrap();
+        }
+
+        result_hash.aset(Symbol::new(kind), array).unwrap();
     }
 
-    Ok(array)
+    Ok(result_hash)
 }
 
 #[magnus::init]
 fn init(ruby: &Ruby) -> Result<(), Error> {
     let module = ruby.define_module("FitKit")?;
-    let _ = define_ruby_classes(&ruby);
 
     module.define_singleton_method("parse_fit_file", function!(parse_fit_file, 1))?;
 

data/lib/fit_kit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FitKit
-  VERSION = "0.1.0"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fit_kit
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.3.0
 platform: ruby
 authors:
 - 29decibel
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-10-15 00:00:00.000000000 Z
+date: 2024-10-16 00:00:00.000000000 Z
 dependencies: []
 description: Garmin fit file parser wrapping Rust crate fitparse_rs.
 email: