fit-commit 3.2.1 → 3.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0872555343a9157e7d2b06333eb2965366de6c42
-  data.tar.gz: 115c0d4cb09484f15f885c02180646dacb94e00c
+  metadata.gz: a192b55fd47925dbae22610a7fc15811751d0b57
+  data.tar.gz: 58e5247361be7806cbf568b05ef5f10bb8a9a811
 SHA512:
-  metadata.gz: c6cc995fa3a43833a0c898ca47fbcca74d44118384458f7669156c96c4f980c1ceca8442a3d873b276cfaab8a99693642c6afdc47043af87e54b03735854d135
-  data.tar.gz: 4ff7da0c1223e67c080f28913a8f6e35805c473f3a518eca389becc06074defbe78df31c7567015a1c8db7919194518289b8e2e9a9bcaef686fa1561cecd9130
+  metadata.gz: 3d09f8222037da2a6f794870762e7720e49f86afb45fdd233a16910ba2c14d1b73deae27179ff01cb7ec67a09d41691302d48ab38e3ee060a411982e7378b463
+  data.tar.gz: c4ecf05c835b1d2d4f0896e82c535f05737b386985520dfa4341cf0f98cf8ed455299ef983977b7971a6243a64097b0ebb19cce5d4bde0eb5a318e23c3c6b2fd

data/lib/fit_commit.rb

@@ -17,7 +17,6 @@ module FitCommit
   end
 
   def self.branch_name
-    ENV["GIT_BRANCH_NAME"] ||
-      fail("Git branch not found. You might need to re-run `fit-commit install`")
+    ENV.fetch("GIT_BRANCH_NAME")
   end
 end

data/lib/fit_commit/version.rb

@@ -1,3 +1,3 @@
 module FitCommit
-  VERSION = "3.2.1"
+  VERSION = "3.2.2"
 end

data/templates/hooks/commit-msg

@@ -18,13 +18,7 @@ if [ ! -r "$COMMIT_MESSAGE_PATH" ]; then
   exit 0
 fi
 
-export GIT_BRANCH_NAME=`git symbolic-ref --short HEAD`
-if [ -z "$GIT_BRANCH_NAME" ]; then
-  >&2 echo "fit-commit: WARNING: Skipping checks because the Git branch cannot be determined."
-  >&2 echo "fit-commit: Please submit a bug report with the project:"
-  >&2 echo "fit-commit: https://github.com/m1foley/fit-commit/issues"
-  exit 0
-fi
+export GIT_BRANCH_NAME=`git symbolic-ref --short HEAD 2> /dev/null`
 
 # find appropriate Ruby command
 if which rbenv > /dev/null 2>&1; then

data/test/unit/runner_test.rb

@@ -101,6 +101,13 @@ describe FitCommit::Runner do
         assert_equal FitCommit::Runner::EXIT_CODE_REJECT_COMMIT, call_runner
         assert_error_output
       end
+      describe "empty branch name" do
+        let(:branch_name) { "" }
+        it "prints errors to stderr and rejects commit" do
+          assert_equal FitCommit::Runner::EXIT_CODE_REJECT_COMMIT, call_runner
+          assert_error_output
+        end
+      end
     end
     describe "user forces commit" do
       let(:stdin) { fake_tty("y") }

data/test/unit/validator_loader_test.rb

@@ -23,7 +23,7 @@ describe FitCommit::ValidatorLoader do
   end
 
   it "loads enabled validators" do
-    assert validators.any? { |v| v.is_a? FitCommit::Validators::Wip }
+    assert validators.one? { |v| v.is_a? FitCommit::Validators::Wip }
   end
 
   it "doesn't load disabled validators" do
@@ -31,22 +31,37 @@ describe FitCommit::ValidatorLoader do
   end
 
   describe "non-boolean options for Enabled" do
-    it "doesn't load validators with a non-matching string/regex Enabled values" do
-      assert validators.none? { |v| v.is_a? FitCommit::Validators::Frathouse }
+    describe "branch_name does not match validator" do
+      it "doesn't load validator" do
+        assert validators.none? { |v| v.is_a? FitCommit::Validators::Frathouse }
+      end
     end
 
-    describe "validator has a matching string Enabled value" do
+    describe "branch_name matches validator via String" do
       let(:branch_name) { "bar" }
       it "loads validator" do
-        assert validators.any? { |v| v.is_a? FitCommit::Validators::Frathouse }
+        assert validators.one? { |v| v.is_a? FitCommit::Validators::Frathouse }
       end
     end
 
-    describe "validator has a matching regex Enabled value" do
+    describe "branch_name matches validator via regex" do
       let(:branch_name) { "bazzz" }
       it "loads validator" do
-        assert validators.any? { |v| v.is_a? FitCommit::Validators::Frathouse }
+        assert validators.one? { |v| v.is_a? FitCommit::Validators::Frathouse }
       end
     end
   end
+
+  describe "branch_name is blank" do
+    let(:branch_name) { "" }
+    it "loads enabled validators" do
+      assert validators.one? { |v| v.is_a? FitCommit::Validators::Wip }
+    end
+    it "doesn't load disabled validators" do
+      assert validators.none? { |v| v.is_a? FitCommit::Validators::LineLength }
+    end
+    it "doesn't load validators that have non-boolean options for Enabled" do
+      assert validators.none? { |v| v.is_a? FitCommit::Validators::Frathouse }
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fit-commit
 version: !ruby/object:Gem::Version
-  version: 3.2.1
+  version: 3.2.2
 platform: ruby
 authors:
 - Michael Foley