fission 0.3.0 → 0.4.0.beta.1

data/spec/fission/command/suspend_spec.rb

@@ -1,82 +1,87 @@
 require File.expand_path('../../../spec_helper.rb', __FILE__)
 
 describe Fission::Command::Suspend do
+  include_context 'command_setup'
+
   before do
-    @vm_info = ['foo']
-    @string_io = StringIO.new
-    Fission.stub!(:ui).and_return(Fission::UI.new(@string_io))
+    @target_vm = ['foo']
+    Fission::VM.stub(:new).and_return(@vm_mock)
+
+    @suspend_response_mock = mock('suspend_response')
+
+    @vm_mock.stub(:name).and_return(@target_vm.first)
   end
 
   describe 'execute' do
-    it "should output an error and the help when no VM argument is passed in" do
-      Fission::Command::Suspend.should_receive(:help)
+    subject { Fission::Command::Suspend }
 
-      lambda {
-        command = Fission::Command::Suspend.new
-        command.execute
-      }.should raise_error SystemExit
+    it_should_not_accept_arguments_of [], 'suspend'
 
-      @string_io.string.should match /Incorrect arguments for suspend command/
-    end
+    it 'should suspend the vm' do
+      @suspend_response_mock.stub_as_successful
 
-    it "should output an error and exit if it can't find the vm" do
-      Fission::VM.should_receive(:exists?).with(@vm_info.first).and_return(false)
+      @vm_mock.should_receive(:suspend).and_return(@suspend_response_mock)
 
-      lambda {
-        command = Fission::Command::Suspend.new @vm_info
-        command.execute
-      }.should raise_error SystemExit
+      command = Fission::Command::Suspend.new @target_vm
+      command.execute
 
-      @string_io.string.should match /Unable to find the VM #{@vm_info.first}/
+      @string_io.string.should match /Suspending '#{@target_vm.first}'/
+      @string_io.string.should match /VM '#{@target_vm.first}' suspended/
     end
 
+    it 'should output an error and exit if there was an error suspending the vm' do
+      @suspend_response_mock.stub_as_unsuccessful
 
-    it "should output and exit if the vm is not running" do
-      Fission::VM.should_receive(:exists?).with(@vm_info.first).and_return(true)
-      Fission::VM.should_receive(:all_running).and_return([])
+      @vm_mock.should_receive(:suspend).and_return(@suspend_response_mock)
 
-      lambda {
-        command = Fission::Command::Suspend.new @vm_info
-        command.execute
-      }.should raise_error SystemExit
-
-      @string_io.string.should match /VM '#{@vm_info.first}' is not running/
-    end
-
-    it 'should try to suspend the vm if it is running' do
-      @vm_mock = mock('vm_mock')
-      Fission::VM.should_receive(:exists?).with(@vm_info.first).and_return(true)
-      Fission::VM.should_receive(:all_running).and_return([@vm_info.first])
-      Fission::VM.should_receive(:new).with(@vm_info.first).and_return(@vm_mock)
-      @vm_mock.should_receive(:suspend)
-
-      command = Fission::Command::Suspend.new @vm_info
-      command.execute
+      command = Fission::Command::Suspend.new @target_vm
+      lambda { command.execute }.should raise_error SystemExit
 
-      @string_io.string.should match /Suspending '#{@vm_info.first}'/
+      @string_io.string.should match /Suspending '#{@target_vm.first}'/
+      @string_io.string.should match /There was an error suspending the VM.+it blew up.+/m
     end
 
     describe 'with --all' do
-      it 'should suspend all running VMs' do
+      before do
         @vm_mock_1 = mock('vm_mock_1')
         @vm_mock_2 = mock('vm_mock_2')
 
-        vm_items = {'vm_1' => @vm_mock_1,
-                    'vm_2' => @vm_mock_2
+        @vm_mock_1.stub(:name).and_return('vm_1')
+        @vm_mock_2.stub(:name).and_return('vm_2')
+
+        @vm_items = {'vm_1' => @vm_mock_1,
+                     'vm_2' => @vm_mock_2
         }
+      end
+
+      it 'should output an error and exit if there was an error getting the list of running vms' do
+        @all_running_response_mock.stub_as_unsuccessful
+
+        Fission::VM.should_receive(:all_running).and_return(@all_running_response_mock)
+
+        command = Fission::Command::Suspend.new ['--all']
+        lambda { command.execute }.should raise_error SystemExit
+
+        @string_io.string.should match /There was an error getting the list of running VMs.+it blew up.+/m
+      end
 
-        Fission::VM.should_receive(:all_running).and_return(vm_items.keys)
+      it 'should suspend all running VMs' do
+        @all_running_response_mock.stub_as_successful @vm_items.values
+        @suspend_response_mock.stub_as_successful
+
+        Fission::VM.should_receive(:all_running).and_return(@all_running_response_mock)
 
-        vm_items.each_pair do |name, mock|
-          Fission::VM.should_receive(:new).with(name).and_return(mock)
-          mock.should_receive(:suspend)
+        @vm_items.each_pair do |name, mock|
+          mock.should_receive(:suspend).and_return(@suspend_response_mock)
         end
 
         command = Fission::Command::Suspend.new ['--all']
         command.execute
 
-        @string_io.string.should match /Suspending 'vm_1'/
-        @string_io.string.should match /Suspending 'vm_2'/
+        @vm_items.keys.each do |vm|
+          @string_io.string.should match /Suspending '#{vm}'/
+          @string_io.string.should match /VM '#{vm}' suspended/
+        end
       end
     end
 
@@ -86,7 +91,7 @@ describe Fission::Command::Suspend do
     it 'should output info for this command' do
       output = Fission::Command::Suspend.help
 
-      output.should match /suspend \[vm \| --all\]/
+      output.should match /suspend \[vm_name \| --all\]/
     end
   end
 end

data/spec/fission/command_helpers_spec.rb

@@ -0,0 +1,30 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Fission::CommandHelpers do
+  include_context 'command_setup'
+
+  before do
+    @object = Object.new
+    @object.extend Fission::CommandHelpers
+  end
+
+  describe 'incorrect_arguments' do
+    before do
+      @object.class.should_receive(:help).and_return('foo help')
+      @object.stub(:output)
+      @object.stub(:output_and_exit)
+    end
+
+    it "should output the command's help text" do
+      @object.should_receive(:output).with("foo help\n")
+      @object.incorrect_arguments 'delete'
+    end
+
+    it 'should output that the argumets are incorrect and exit' do
+      @object.should_receive(:output_and_exit).
+              with('Incorrect arguments for delete command', 1)
+      @object.incorrect_arguments 'delete'
+    end
+  end
+
+end

data/spec/fission/command_spec.rb

@@ -22,4 +22,23 @@ describe Fission::Command do
     end
   end
 
+  describe 'ui' do
+    it 'should load a ui object' do
+      Fission::Command.new.ui.should be_a Fission::UI
+    end
+
+    [:output, :output_and_exit, :output_printf].each do |item|
+      it "should delegate '#{item.to_s}' to the ui instance" do
+        @ui_mock = mock('ui')
+        @ui_mock.should_receive(item)
+
+        Fission::UI.stub!(:new).and_return(@ui_mock)
+
+        @cmd_instance = Fission::Command.new
+        @cmd_instance.send item, 'foo'
+      end
+    end
+
+  end
+
 end

data/spec/fission/config_spec.rb

@@ -42,6 +42,30 @@ describe Fission::Config do
       end
     end
 
+    it 'should use the fusion default lease file' do
+      @config = Fission::Config.new
+      @config.attributes['lease_file'].should == '/var/db/vmware/vmnet-dhcpd-vmnet8.leases'
+    end
+
+  end
+
+  describe '[]' do
+    before do
+      @config_items = { 'vmrun_bin' => '/foo/bar/vmrun',
+                        'vmrun_cmd' => '/foo/bar/vmrun -T fusion',
+                        'plist_file' => '/foo/bar/plist',
+                        'gui_bin' => '/foo/bar/gui',
+                        'vm_dir' => '/foo/bar/vms'}
+      @config = Fission::Config.new
+      @config.attributes = @config_items
+    end
+
+    it 'should return the value for specifed key' do
+      @config_items.each_pair do |k, v|
+        @config[k].should == v
+      end
+    end
+
   end
 
 end

data/spec/fission/fusion_spec.rb

@@ -1,22 +1,22 @@
 require File.expand_path('../../spec_helper.rb', __FILE__)
 
 describe Fission::Fusion do
-  describe 'self.is_running?' do
+  describe 'self.running?' do
     before do
       @cmd = "ps -ef | grep -v grep | "
-      @cmd << "grep -c #{Fission.config.attributes['gui_bin'].gsub(' ', '\ ')} 2>&1"
+      @cmd << "grep -c #{Fission.config['gui_bin'].gsub(' ', '\ ')} 2>&1"
     end
 
-    it 'should return true if the fusion app is running' do
+    it 'should return a successful response and true if the fusion app is running' do
       Fission::Fusion.should_receive(:`).with(@cmd).
                                          and_return("1\n")
-      Fission::Fusion.is_running?.should == true
+      Fission::Fusion.running?.should == true
     end
 
-    it 'should return false if the fusion app is not running' do
+    it 'should return a successful response and false if the fusion app is not running' do
       Fission::Fusion.should_receive(:`).with(@cmd).
                                          and_return("0\n")
-      Fission::Fusion.is_running?.should == false
+      Fission::Fusion.running?.should == false
     end
   end
 end

data/spec/fission/lease_spec.rb

@@ -0,0 +1,176 @@
+require File.expand_path('../../spec_helper.rb', __FILE__)
+
+describe Fission::Lease do
+  before do
+    @lease_info = [ { :ip_address   => '172.16.248.197',
+                      :mac_address  => '00:0c:29:2b:af:50',
+                      :start        => '2011/10/11 01:50:58',
+                      :end          => '2011/10/11 02:20:58' },
+                    { :ip_address   => '172.16.248.132',
+                      :mac_address  => '00:0c:29:10:23:57',
+                      :start        => '2010/07/12 21:31:28',
+                      :end          => '2010/07/12 22:01:28' },
+                    { :ip_address   => '172.16.248.130',
+                      :mac_address  => '00:0c:29:b3:63:d0',
+                      :start        => '2010/05/27 00:54:52',
+                      :end          => '2010/05/27 01:24:52' },
+                    { :ip_address   => '172.16.248.129',
+                      :mac_address  => '00:0c:29:0a:e9:b3',
+                      :start        => '2010/02/16 23:16:05',
+                      :end          => '2010/02/16 23:46:05' } ]
+
+    @lease_file_content = '# This is a comment
+# And here is another
+lease 172.16.248.197 {
+    starts 2 2011/10/11 01:50:58;
+    ends 2 2011/10/11 02:20:58;
+    hardware ethernet 00:0c:29:2b:af:50;
+}
+lease 172.16.248.132 {
+    starts 1 2010/07/12 21:31:28;
+    ends 1 2010/07/12 22:01:28;
+    hardware ethernet 00:0c:29:10:23:57;
+}
+lease 172.16.248.130 {
+    starts 4 2010/05/27 00:54:52;
+    ends 4 2010/05/27 01:24:52;
+    hardware ethernet 00:0c:29:b3:63:d0;
+}
+lease 172.16.248.129 {
+    starts 2 2010/02/16 23:16:05;
+    ends 2 2010/02/16 23:46:05;
+    hardware ethernet 00:0c:29:0a:e9:b3;
+}'
+  end
+
+  describe 'new' do
+    { :ip_address   => '127.0.0.1',
+      :mac_address  => '00:00:00:00:00:00',
+      :start        => '2004/07/25 17:18:00',
+      :end          => '2004/07/25 18:18:00' }
+    it 'should set the ip address' do
+      lease = Fission::Lease.new :ip_address => '127.0.0.1'
+      lease.ip_address.should == '127.0.0.1'
+    end
+
+    it 'should set the mac address' do
+      lease = Fission::Lease.new :mac_address => '00:00:00:00:00:00'
+      lease.mac_address.should == '00:00:00:00:00:00'
+    end
+
+    it 'should set the lease start date/time' do
+      date_time = DateTime.parse('2000/01/01 17:00:00')
+      lease = Fission::Lease.new :start => date_time
+      lease.start.should == date_time
+    end
+
+    it 'should set the lease end date/time' do
+      date_time = DateTime.parse('2000/01/01 17:00:00')
+      lease = Fission::Lease.new :end => date_time
+      lease.end.should == date_time
+    end
+  end
+
+  describe 'expired?' do
+    it 'should return true if the lease is expired' do
+      lease = Fission::Lease.new :end => DateTime.now - 1
+      lease.expired?.should == true
+    end
+
+    it 'should return false if the lease has not expired' do
+      lease = Fission::Lease.new :end => DateTime.now + 1
+      lease.expired?.should == false
+    end
+  end
+
+  describe 'self.all' do
+    it 'should query the configured lease file' do
+      File.should_receive(:read).with(Fission.config['lease_file']).
+                                 and_return('')
+
+      Fission::Lease.all
+    end
+
+    it 'should return a successful response with the list of the found leases' do
+      File.should_receive(:read).with(Fission.config['lease_file']).
+                                 and_return(@lease_file_content)
+
+      example_leases = @lease_info.collect do |lease|
+        Fission::Lease.new :ip_address  => lease[:ip_address],
+                           :mac_address => lease[:mac_address],
+                           :start       => DateTime.parse(lease[:start]),
+                           :end         => DateTime.parse(lease[:end])
+
+      end
+
+      response = Fission::Lease.all
+      response.should be_a_successful_response
+
+      response.data.each do |lease|
+        example_lease = example_leases.select { |l| l.ip_address == lease.ip_address }
+
+        [:ip_address, :mac_address, :start, :end].each do |attrib|
+          lease.send(attrib).should == example_lease.first.send(attrib)
+        end
+      end
+
+    end
+
+    it 'should return a successful response with an empty list if there are no leases found' do
+      File.should_receive(:read).with(Fission.config['lease_file']).
+                                 and_return('')
+      response = Fission::Lease.all
+      response.should be_a_successful_response
+      response.data.should == []
+    end
+
+    it 'should return an unsuccessful response if the configured lease file does not exist' do
+      File.should_receive(:file?).with(Fission.config['lease_file']).
+                                  and_return(false)
+      response = Fission::Lease.all
+      error_string = "Unable to find the lease file '#{Fission.config['lease_file']}'"
+      response.should be_an_unsuccessful_response(error_string)
+    end
+
+  end
+
+  describe 'self.find_by_mac_address' do
+    describe 'when able to get all of the leases' do
+      before do
+        File.should_receive(:read).with(Fission.config['lease_file']).
+                                   and_return(@lease_file_content)
+      end
+
+      it 'should return a response with the lease associated with the provided mac address' do
+
+        response = Fission::Lease.find_by_mac_address '00:0c:29:10:23:57'
+
+        response.should be_a_successful_response
+
+        response.data.ip_address.should == '172.16.248.132'
+        response.data.mac_address.should == '00:0c:29:10:23:57'
+        response.data.start.should == DateTime.parse('2010/07/12 21:31:28')
+        response.data.end.should == DateTime.parse('2010/07/12 22:01:28')
+      end
+
+      it "should return a response with nil if the mac address can't be found" do
+        response = Fission::Lease.find_by_mac_address('00:11:22:33:44:55')
+
+        response.should be_a_successful_response
+        response.data.should be_nil
+      end
+    end
+
+    it 'should return an unsuccessful response if there was an error getting all of the leases' do
+      @all_response_mock = mock('all_response')
+      @all_response_mock.stub_as_unsuccessful
+
+      Fission::Lease.stub(:all).and_return(@all_response_mock)
+
+      response = Fission::Lease.find_by_mac_address('00:11:22:33:44:55')
+
+      response.should be_an_unsuccessful_response
+    end
+  end
+
+end

data/spec/fission/metadata_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path('../../spec_helper.rb', __FILE__)
 describe Fission::Metadata do
   before do
     @plist_mock = mock('plist_mock')
-    @plist_file_path = Fission.config.attributes['plist_file']
+    @plist_file_path = Fission.config['plist_file']
     @metadata = Fission::Metadata.new
   end
 
@@ -28,19 +28,19 @@ describe Fission::Metadata do
     end
 
     it 'should remove the vm item from the list if the vm path is in the list' do
-      @metadata.delete_vm_restart_document(Fission::VM.path('foo'))
+      @metadata.delete_vm_restart_document(Fission::VM.new('foo').path)
       @metadata.content.should == { 'PLRestartDocumentPaths' => ['/vm/bar.vmwarevm']}
     end
 
     it 'should not doing anything if the vm is not in the list' do
-      @metadata.delete_vm_restart_document(Fission::VM.path('baz'))
+      @metadata.delete_vm_restart_document(Fission::VM.new('baz').path)
       @metadata.content.should == @data
     end
 
     it 'should not do anything if the restart document list does not exist' do
       other_data = { 'OtherConfigItem' => ['foo', 'bar']}
       @metadata.content = other_data
-      @metadata.delete_vm_restart_document(Fission::VM.path('foo'))
+      @metadata.delete_vm_restart_document(Fission::VM.new('foo').path)
       @metadata.content.should == other_data
     end
   end
@@ -52,12 +52,12 @@ describe Fission::Metadata do
     end
 
     it 'should remove the vm item from the list' do
-      @metadata.delete_vm_favorite_entry(Fission::VM.path('foo'))
+      @metadata.delete_vm_favorite_entry(Fission::VM.new('foo').path)
       @metadata.content.should == { 'VMFavoritesListDefaults2' => [] }
     end
 
     it 'should not do anything if the vm is not in the list' do
-      @metadata.delete_vm_favorite_entry(Fission::VM.path('bar'))
+      @metadata.delete_vm_favorite_entry(Fission::VM.new('bar').path)
       @metadata.content.should == @data
     end
   end
@@ -73,13 +73,13 @@ describe Fission::Metadata do
     it 'should remove the vm from the restart document list' do
       @md_mock.should_receive(:delete_vm_restart_document).with('/vm/foo.vmwarevm')
       @md_mock.stub!(:delete_vm_favorite_entry)
-      Fission::Metadata.delete_vm_info(Fission::VM.path('foo'))
+      Fission::Metadata.delete_vm_info(Fission::VM.new('foo').path)
     end
 
     it 'should remove the vm from the favorite list' do
       @md_mock.should_receive(:delete_vm_favorite_entry).with('/vm/foo.vmwarevm')
       @md_mock.stub!(:delete_vm_restart_document)
-      Fission::Metadata.delete_vm_info(Fission::VM.path('foo'))
+      Fission::Metadata.delete_vm_info(Fission::VM.new('foo').path)
     end
   end