firstgiving 1.0.1 → 1.0.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZTBmYmNjYzNmNGMwODhjN2QzMTE1ZWIyZjU4MGIyYmRhMGM4ZmRiOA==
+    MmIwOTM3NTI3MjY3ZmRlM2YxZTU2OTlmODk4YWUwZjI1NDJiM2Q4ZA==
   data.tar.gz: !binary |-
-    NmNhYTY2YTA5OGY4ZWQxZTIzZmMwNmFiMDMwNzQzNjllNTM5ZGQ1ZQ==
+    MGYwZDhjNGQ3N2I4MjQ0ZmYyOTNmZGU4OTU1NWU2NDkyNjg4ZTBlOA==
 SHA512:
   metadata.gz: !binary |-
-    MjM2NjBjMDQ4ZDkzOTc3MGYyNzg5MDcxZTEzNjNjM2IxODJmMzk0N2ZiMjFi
-    NTNlZTRmZjM1YzVkMzQ1NDNhMzIzOWQzZWNlYjA1ZjA2YzBiMmIzMTAyM2Ri
-    NjU4ZDE4NzZmOWM2MGU5ZDMxMTQ5NDhkNGI0ZWM4OGViOTc0MTE=
+    MTllMWRhYWZlNjFmY2QzNjdkNGRkY2EyN2Y3Y2VhYzA4ODhmZmQ3M2M0YjZm
+    ZTQyMGNlZjI5ZTA4NGZjODJiMjgyNDU1NGU1ZDkyM2NiOGNiZTMyNWQ5Njcx
+    ODc2ZTllMzQ2YjBlOTQzZTAzYTY1NTFkN2Y2MmVlY2RlMTljODE=
   data.tar.gz: !binary |-
-    ZWY4YjNlMTZkMjQ5NzRmNGFiYjc2NGMzZmI0MzM5MWU1NjMwZTQzYTU2ODUw
-    MTYwNDM4ZDBlYzg4Y2QwM2FiZTBjODAwMTg2YTljM2I0MWY1MTZhNDQyNGVm
-    MGVkYTc0ZDJhYTI0YjJiNjllMDU3YTFjZGE1ZTcyMGQ1MThkOTQ=
+    YjJjZWRlMDkwODAzNmI0YjQ4NWVkYWFhNWYwOGIzNDc2ZmExNTc3OGVkOGY0
+    YTZiNWUwYWE4ODA4MzQ3ZTc3ZDk2NWM3MjFjYzgwZDk1NzU4ZGNkYWRjMTBh
+    N2ZhMjdhMWVlZDcxYjZhNjhkNjZiNzA1Zjk3ZjdjNTk2YTJjYjM=

data/README.md

@@ -1,5 +1,8 @@
 # FirstGiving
 
+[![Code Climate](https://codeclimate.com/github/boosterllc/firstgiving_ruby.png)](https://codeclimate.com/github/boosterllc/firstgiving_ruby)
+[![Gem Version](https://badge.fury.io/rb/firstgiving.svg)](http://badge.fury.io/rb/firstgiving)
+
 FirstGiving Ruby Client Open Source.
 
 ## Installation

data/lib/firstgiving.rb

@@ -1,6 +1,7 @@
 require 'rubygems'
 require 'firstgiving/version'
 require 'firstgiving/base'
+require 'firstgiving/response'
 require 'firstgiving/donation'
 require 'firstgiving/lookup'
 require 'firstgiving/search'

data/lib/firstgiving/base.rb

@@ -20,29 +20,18 @@ module FirstGiving
       }
     end
 
-    def post_call(api_endpoint, action, params, headers)
-      conn = Faraday.new(url: api_endpoint) do |faraday|
-        faraday.request  :url_encoded
-        faraday.adapter  Faraday.default_adapter
-      end
-
-      conn.post do |req|
-        req.url action
-        req.params = params
-        req.headers = headers
-      end
-    end
-
-    def get_call(api_endpoint, action, params, headers)
-      conn = Faraday.new(url: api_endpoint) do |faraday|
-        faraday.request  :url_encoded             # form-encode POST params
-        faraday.adapter  Faraday.default_adapter  # make requests with Net::HTTP
-      end
-
-      conn.get do |req|
-        req.url action
-        req.params = params
-        req.headers = headers
+    [:post, :get].each do |method|
+      define_method "#{method}_call" do |api_endpoint, action, params, headers|
+        conn = Faraday.new(url: api_endpoint) do |faraday|
+          faraday.request  :url_encoded
+          faraday.adapter  Faraday.default_adapter
+        end
+
+        conn.send("#{method}") do |req|
+          req.url action
+          req.params = params
+          req.headers = headers
+        end
       end
     end
 

data/lib/firstgiving/lookup.rb

@@ -32,8 +32,23 @@ module FirstGiving
       call(Actions::TRANSACTION_LIST, params, headers)
     end
 
+    def success_from(response)
+      ack = response['firstGivingDonationApi']['firstGivingResponse']['acknowledgement']
+      ack == 'Success' ? true : false
+    end
+
+    def params_from(response)
+      params = response['firstGivingDonationApi']['firstGivingResponse']['transaction']
+      params ||= response['firstGivingDonationApi']['firstGivingResponse']['transactions']
+    end
+
+    def message_from(response)
+      response['firstGivingDonationApi']['firstGivingResponse']['verboseErrorMessage']
+    end
+
     def parse(body)
-      Crack::XML.parse(body)
+      response = Crack::XML.parse(body)
+      response = Response.new(success_from(response), message_from(response), params_from(response))
     end
   end
 end

data/lib/firstgiving/response.rb

@@ -0,0 +1,15 @@
+module FirstGiving
+  class Response
+
+    attr_reader :params, :message
+
+    def success?
+      @success
+    end
+
+    def initialize(success, message, params, options = {})
+      @success, @message, @params = success, message, params
+    end
+
+  end
+end

data/lib/firstgiving/version.rb

@@ -1,3 +1,3 @@
 module FirstGiving
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/spec/first_giving_spec.rb

@@ -72,13 +72,15 @@ describe FirstGiving do
 
     it 'should return a list of transactions' do
       params = {
-        page_size: 10,
+        page_size: 40,
         date_from: '1388707200',
         count: 10,
         page: 1
       }
       resp = FG.lookup.list(params)
-      assert_acknowledgement(resp)
+      expect(resp.is_a? FirstGiving::Response).to be_true
+      expect(resp.success?).to be_true
+      expect(resp.params).to_not be_nil
     end
 
     it 'should return a transaction detail' do
@@ -86,7 +88,19 @@ describe FirstGiving do
         transactionId: 'a-0070dde28ca48048a1fc24'
       }
       resp = FG.lookup.detail(params)
-      assert_acknowledgement(resp)
+      expect(resp.is_a? FirstGiving::Response).to be_true
+      expect(resp.success?).to be_true
+      expect(resp.params).to_not be_nil
+    end
+
+    it 'should return unsuccesful lookup transaction' do
+      params = {
+        transactionId: 'a-123'
+      }
+      resp = FG.lookup.detail(params)
+      expect(resp.is_a? FirstGiving::Response).to be_true
+      expect(resp.success?).to be_false
+      expect(resp.params).to be_nil
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: firstgiving
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Faizal Zakaria
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-26 00:00:00.000000000 Z
+date: 2014-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -112,6 +112,7 @@ files:
 - lib/firstgiving/base.rb
 - lib/firstgiving/donation.rb
 - lib/firstgiving/lookup.rb
+- lib/firstgiving/response.rb
 - lib/firstgiving/search.rb
 - lib/firstgiving/version.rb
 - spec/first_giving_spec.rb