firstfm 0.5.2 → 0.6.0

data/VERSION.yml

@@ -1,5 +1,5 @@
 ---
 :major: 0
-:minor: 5
-:patch: 2
+:minor: 6
+:patch: 0
 :build: 

data/firstfm.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "firstfm"
-  s.version = "0.5.2"
+  s.version = "0.6.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Aleksandr Lossenko"]
-  s.date = "2013-01-17"
+  s.date = "2013-01-27"
   s.description = "Firstfm is a ruby wrapper for the Last.fm APIs ( http://www.last.fm/api ). My main focus is to import events from Last.FM, but with time I will try to add support for all API methods."
   s.email = "aleksandr.lossenko@gmail.com"
   s.extra_rdoc_files = [
@@ -41,6 +41,8 @@ Gem::Specification.new do |s|
     "test/fixtures/geo_event.xml",
     "test/fixtures/geo_events.xml",
     "test/fixtures/geo_get_metro_artist_chart.xml",
+    "test/fixtures/get_correction.xml",
+    "test/fixtures/get_correction_blank.xml",
     "test/fixtures/get_images.xml",
     "test/fixtures/top_tracks.xml",
     "test/fixtures/tracks.xml",

data/lib/firstfm/artist.rb

@@ -60,6 +60,17 @@ module Firstfm
       end
     end
     
+    def self.get_correction(artist)
+      response = get("/2.0/", {:query => {:method => 'artist.getcorrection', :artist => artist, :api_key => Firstfm.config.api_key}})
+      if response && response["lfm"] && response["lfm"] && response["lfm"]["status"] == "ok"
+        if response["lfm"]["corrections"] && response["lfm"]["corrections"]["correction"]
+          init_from_hash(response["lfm"]["corrections"]["correction"]["artist"]) rescue nil
+        elsif response["lfm"].key?("corrections")
+          init_from_hash({"name" => artist})
+        end
+      end
+    end
+    
     def self.init_from_array(array)
       return [] unless array.is_a?(Array)
       array.inject([]) do |arr, artist|

data/test/fixtures/get_correction.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="utf-8"?>
+<lfm status="ok">
+<corrections>
+                        <correction index='0'>
+                                <artist>
+    <name>Guns N' Roses</name>
+            <mbid>6e40312c-2a6d-445b-b2c9-f68e86f6a0a3</mbid>
+        <url>http://www.last.fm/music/Guns+N%27+Roses</url>
+</artist>            </correction>
+            </corrections>
+</lfm>

data/test/fixtures/get_correction_blank.xml

@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<lfm status="ok">
+<corrections>
+                </corrections>
+</lfm>

data/test/test_artist.rb

@@ -54,4 +54,18 @@ class TestArtist < Test::Unit::TestCase
     assert (tags - ["pop", "female vocalists", "80s", "dance", "rock"]).empty?
   end
   
+  def test_should_get_correction
+    FakeWeb.register_uri(:get, %r|http://ws.audioscrobbler.com/|, :body => File.read(File.dirname(__FILE__) + "/fixtures/get_correction.xml"))
+    artist = Firstfm::Artist.get_correction("Guns")
+    assert_equal "Guns N' Roses", artist.name
+    assert_equal "6e40312c-2a6d-445b-b2c9-f68e86f6a0a3", artist.mbid
+    assert_equal "http://www.last.fm/music/Guns+N%27+Roses", artist.url
+  end
+  
+  def test_should_get_correction_even_if_correct
+    FakeWeb.register_uri(:get, %r|http://ws.audioscrobbler.com/|, :body => File.read(File.dirname(__FILE__) + "/fixtures/get_correction_blank.xml"))
+    artist = Firstfm::Artist.get_correction("Eminem")
+    assert_equal "Eminem", artist.name
+  end
+  
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: firstfm
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.6.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-17 00:00:00.000000000 Z
+date: 2013-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -173,6 +173,8 @@ files:
 - test/fixtures/geo_event.xml
 - test/fixtures/geo_events.xml
 - test/fixtures/geo_get_metro_artist_chart.xml
+- test/fixtures/get_correction.xml
+- test/fixtures/get_correction_blank.xml
 - test/fixtures/get_images.xml
 - test/fixtures/top_tracks.xml
 - test/fixtures/tracks.xml
@@ -198,7 +200,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3228774971336924183
+      hash: 3155602274475506363
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: