firespring_dev_commands 1.5.0.pre.alpha.4 → 1.5.1.pre.alpha.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ea24bf7d2abac993a227d9812a7d6a0de93a215f23850c81dae81d3d1a22d5d
-  data.tar.gz: '091a5b77894268283e1c08ce383fb3fdaea162980652241b6ec95edc53fca924'
+  metadata.gz: 5d51e212a8400122ffc51b71c211012d10a787878a4ba23e44cd5236ecb27b85
+  data.tar.gz: c09ea9cce609c9328f0f851bfaa49032380f2c2f55acc7cc5f33d62a295fdad0
 SHA512:
-  metadata.gz: 6599b07b498c352f6c0dfea440e326dc73ae6d3d3ae2a106b81ce2afcf3e4a0c3dd37dfb1700de538d7cb4542311af3c61d9f0aa83c1be019a3e71fbe8df8af9
-  data.tar.gz: 4eeb80a2ecb84cb1912777766344361c1bfd58211de216dbb76106a85b98d68d218b6e68626fbbbbc43d1cf962880f543c928473a06855c61f7d7c6b39fe2dfb
+  metadata.gz: fef3154ccd47c74c96db052499a10bb78b8d3415d193aee75dff9078719d286e1c19aa07d9ab05ff085e1ad95f9b79c2c69e2138e2535f3f2c0fadd311c0db61
+  data.tar.gz: cba0a6fb666cb598cfa6e068a19edc607087200b9d7ba044afa8fa1b7da3f6451259554f9c9018ff3895f35396ee147e2f6f025b89b19e3fb687c16aa915eb61

data/lib/firespring_dev_commands/audit/report.rb

@@ -32,7 +32,9 @@ module Dev
       # Exit with a non-zero status if any vulnerabilities were found
       def check
         puts(to_s)
-        exit(1) unless filtered_items.empty?
+        return if filtered_items.empty?
+
+        at_exit { exit(1) }
       end
 
       # Returns a string representation of this audit report

data/lib/firespring_dev_commands/aws/account.rb

@@ -85,8 +85,8 @@ module Dev
         #       it made it much more difficult to switch between different root accounts.
         mfa_name_default = defaultini['mfa_serial']&.split(%r{mfa/})&.last || ENV['AWS_MFA_ARN']&.split(%r{mfa/})&.last || ENV.fetch('USERNAME', nil)
         defaultini['mfa_serial_name'] = Dev::Common.new.ask('Default mfa name', mfa_name_default)
-        # TODO: Eventually, we should delete the mfa_serial entry from the config. Leaving it for now because some projects
-        #       may be using older versions of the dev_commands library
+        # TODO: mfa_serial is deprecated. Eventually, we should delete the mfa_serial entry from the config. Leaving it for now
+        #       because some projects may be using older versions of the dev_commands library
         # defaultini.delete('mfa_serial')
 
         session_name_default = defaultini['role_session_name'] || "#{ENV.fetch('USERNAME', nil)}_cli"
@@ -128,8 +128,8 @@ module Dev
         #       it made it much more difficult to switch between different accounts.
         role_name_default = profileini['role_name'] || profileini['role_arn']&.split(%r{role/})&.last || self.class.config.default_login_role_name
         profileini['role_name'] = Dev::Common.new.ask('Default role name', role_name_default)
-        # TODO: Eventually, we should delete the role_arn entry from the config. Leaving it for now because some projects
-        #       may be using older versions of the dev_commands library
+        # TODO: role_arn is deprecated. Eventually, we should delete the role_arn entry from the config. Leaving it for now
+        #       because some projects may be using older versions of the dev_commands library
         # profileini.delete('role_arn')
 
         cfgini.write

data/lib/firespring_dev_commands/aws/credentials.rb

@@ -75,8 +75,6 @@ module Dev
         credini = IniFile.new(filename: "#{Dev::Aws::CONFIG_DIR}/credentials", default: 'default')
         defaultini = credini['default']
 
-        # TODO: Should we allow for multiple sets of base credentials? How do I use this for both FDP and SBF?
-
         access_key_default = defaultini['aws_access_key_id']
         defaultini['aws_access_key_id'] = Dev::Common.new.ask('AWS Access Key ID', access_key_default)
 

data/lib/firespring_dev_commands/aws/login.rb

@@ -82,7 +82,8 @@ module Dev
 
       # Authroizes the docker cli to pull/push images from the Aws container registry (e.g. if docker compose needs to pull an image)
       # Authroizes the docker ruby library to pull/push images from the Aws container registry
-      def registry_logins!(registry_ids: Dev::Aws::Account.new.ecr_registry_ids, region: nil)
+      def registry_logins!(registry_ids: nil, region: nil)
+        registry_ids ||= Dev::Aws::Account.new.ecr_registry_ids
         region ||= Dev::Aws::Credentials.new.logged_in_region || Dev::Aws::DEFAULT_REGION
         return if registry_ids.empty?
 
@@ -93,7 +94,8 @@ module Dev
 
       # Authroizes the docker cli to pull/push images from the Aws container registry (e.g. if docker compose needs to pull an image)
       # Authroizes the docker ruby library to pull/push images from the Aws container registry
-      def registry_login!(registry_id: Dev::Aws::Account.new.ecr_registry_ids.first, region: nil)
+      def registry_login!(registry_id: nil, region: nil)
+        registry_id ||= Dev::Aws::Account.new.ecr_registry_ids.first
         region ||= Dev::Aws::Credentials.new.logged_in_region || Dev::Aws::DEFAULT_REGION
         raise 'registry_id is required' if registry_id.to_s.strip.empty?
         raise 'region is required' if region.to_s.strip.empty?
@@ -109,7 +111,8 @@ module Dev
       # Authroizes the docker cli to pull/push images from the Aws container registry
       # (e.g. if docker compose needs to pull an image)
       # @deprecated Please use {Dev::Aws::Login#registry_login!} instead
-      def docker_login!(registry_id: Dev::Aws::Account.new.ecr_registry_ids.first, region: nil)
+      def docker_login!(registry_id: nil, region: nil)
+        registry_id ||= Dev::Aws::Account.new.ecr_registry_ids.first
         region ||= Dev::Aws::Credentials.new.logged_in_region || Dev::Aws::DEFAULT_REGION
         warn '[DEPRECATION] `Dev::Aws::Login#docker_login!` is deprecated. Please use `Dev::Aws::Login#registry_login!` instead.'
         docker_cli_login!(registry: "#{registry_id}.dkr.ecr.#{region}.amazonaws.com", region: region)
@@ -128,7 +131,8 @@ module Dev
 
       # Authroizes the docker ruby library to pull/push images from the Aws container registry
       # @deprecated Please use {Dev::Aws::Login#registry_login!} instead
-      def ecr_login!(registry_id: Dev::Aws::Account.new.ecr_registry_ids.first, region: nil)
+      def ecr_login!(registry_id: nil, region: nil)
+        registry_id ||= Dev::Aws::Account.new.ecr_registry_ids.first
         region ||= Dev::Aws::Credentials.new.logged_in_region || Dev::Aws::DEFAULT_REGION
         warn '[DEPRECATION] `Dev::Aws::Login#ecr_login!` is deprecated. Please use `Dev::Aws::Login#registry_login!` instead.'
         docker_lib_login!(registry_id: registry_id, region: region)

data/lib/firespring_dev_commands/version.rb

@@ -6,6 +6,6 @@ module Dev
     # Use 'v.v.v.pre.alpha.v' for pre-release vesions
     # Use 'v.v.v.beta.v for beta versions
     # Use semantic versioning for any releases (https://semver.org/)
-    VERSION = '1.5.0.pre.alpha.4'.freeze
+    VERSION = '1.5.1.pre.alpha.1'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: firespring_dev_commands
 version: !ruby/object:Gem::Version
-  version: 1.5.0.pre.alpha.4
+  version: 1.5.1.pre.alpha.1
 platform: ruby
 authors:
 - Firespring
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-17 00:00:00.000000000 Z
+date: 2023-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -457,7 +457,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.3.25
 signing_key:
 specification_version: 4
 summary: Development environment maintenance command library