firebug 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f325b82b912c9d5724034a312b99499f49183c3c59509c17144fbdca88e06f9
-  data.tar.gz: efdf4899b982206be40c8297169752aaf13914eb61e1f6109932ef99ba46f753
+  metadata.gz: 47f730e5a45a44a96661d01fc4331f33103c9b306e5a910f5b9ec868f858d960
+  data.tar.gz: 7ebbfa00cacbc730ee3a18666dd6a35b7212fb7baa9fcd9d24017cf28fd5fa8f
 SHA512:
-  metadata.gz: 8888b2e0cc06a0a1f21a981304c3eca2f73517f9e1f1e8b12a53d3faa87ab54ad4adc705273709deab22b85ed264f5c1ed6246de378f8f21f54b8914c1b68e2a
-  data.tar.gz: 9c55376cda286481b81b5a27c840c71c652c458dc71216de270f6ff9db044e561b47b4ff1c531af32414de4a592248149ad6fc74c4f26fb9ca045a88d9042e5b
+  metadata.gz: 35361b28047791b6d8f24cad802da7423dcb663f7fa2941f26d9f1fc7489074955b9604941eac1e5fd660305415c37b7ca5aac6c38d4df9d29d16d0d52ee8adc
+  data.tar.gz: 863583e8e78b2f607b0802a77c6ed42a49ca3d646ae0420816cbe4d9bb5b73466ff9d03ef116cccd0ecc5faab8cbce2cd1e76fa35d92efbe92f8ffbe905fd6e1

data/.rubocop.yml

@@ -1,7 +1,7 @@
 require: rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.6
 
   Exclude:
     - 'bin/*'

data/CHANGELOG.md

@@ -0,0 +1,18 @@
+# 1.2.2
+
+* Fix for reading multibyte characters.
+* Added a test for the multibyte character bug.
+* Added tests for silence logger
+* Renamed `Firebug::FirebugError` to `Firebug::Error`.
+
+# 1.2.1
+
+* Fixed nested empty hash bug and added a test for it.
+* Added more documentation.
+
+# 1.2.0
+
+* Rewrote `Firebug::Unserializer` to use `StringIO` instead of `StringScanner`.
+  In most cases this results in a 10x performance increase.
+* Updated `.ruby-version` and `Dockerfile` to use Ruby 2.6
+* Updated development dependencies.

data/firebug.gemspec

@@ -11,21 +11,21 @@ Gem::Specification.new do |spec| # rubocop:disable BlockLength
   spec.email         = ['aaron@rvshare.com']
 
   spec.summary       = 'Gem for working with CodeIgniter sessions'
-  spec.description   = 'Gem for working with CodeIgniter sessions'
+  spec.description   = spec.summary
   spec.homepage      = 'https://github.com/rvshare/firebug'
   spec.license       = 'MIT'
 
-  spec.files = `git ls-files -z`.split("\x0").reject do |f|
-    f.match(%r{^(test|spec|features)/})
-  end
+  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.metadata['yard.run'] = 'yri' # use "yard" to build full HTML docs.
+  spec.metadata['yard.run']        = 'yri' # use "yard" to build full HTML docs.
+  spec.metadata['changelog_uri']   = 'https://github.com/rvshare/firebug/blob/master/CHANGELOG.md'
+  spec.metadata['source_code_uri'] = spec.homepage
 
-  spec.add_dependency 'actionpack', '<= 6.0'
-  spec.add_dependency 'activerecord', '<= 6.0'
+  spec.add_dependency 'actionpack', '>= 5.0'
+  spec.add_dependency 'activerecord', '>= 5.0'
   spec.add_dependency 'ruby-mcrypt', '~> 0.2'
 
   spec.add_development_dependency 'bundler', '~> 2.0', '>= 2.0.1'

data/lib/action_dispatch/session/code_igniter_store.rb

@@ -9,6 +9,8 @@ module ActionDispatch # :nodoc:
     class CodeIgniterStore < AbstractStore
       # The key name used to store the session model in the request env.
       SESSION_RECORD_KEY = 'rack.session.record'
+      # The request env hash key that has the logger instance.
+      ACTION_DISPATCH_LOGGER_KEY = 'action_dispatch.logger'
 
       # @param [Object] app
       # @param [Hash] options
@@ -126,6 +128,8 @@ module ActionDispatch # :nodoc:
         Firebug.decrypt_cookie(sid)[:session_id]
       end
 
+      # Attempts to find an existing session record or returns a new one.
+      #
       # @param [ActionDispatch::Request] req
       # @param [String] sid
       # @return [Firebug::Session]
@@ -147,6 +151,8 @@ module ActionDispatch # :nodoc:
         )
       end
 
+      # The parameters used to find a session in the database.
+      #
       # @param [ActionDispatch::Request] req
       # @param [String] sid
       # @return [Hash]
@@ -159,10 +165,12 @@ module ActionDispatch # :nodoc:
         params
       end
 
+      # If silence logger is enabled, disable logger output for the block.
+      #
       # @param [ActionDispatch::Request] req
       def silence_logger(req)
-        logger = req.env['action_dispatch.logger'] || ActiveRecord::Base.logger
-        if logger && Firebug.config.silence_logger
+        logger = req.env[ACTION_DISPATCH_LOGGER_KEY] || ActiveRecord::Base.logger
+        if logger.respond_to?(:silence) && Firebug.config.silence_logger
           logger.silence { yield }
         else
           yield

data/lib/firebug/errors.rb

@@ -2,7 +2,7 @@
 
 module Firebug
   # Base error class.
-  FirebugError = Class.new(StandardError)
+  Error = Class.new(StandardError)
   # An error unserializing a string.
-  ParserError = Class.new(FirebugError)
+  ParserError = Class.new(Error)
 end

data/lib/firebug/string_io_reader.rb

@@ -9,7 +9,10 @@ module Firebug
     # @param [Boolean] include If +char+ should be included in the result.
     # @return [String, nil]
     def read_until(char, include: true)
-      if (idx = string.index(char, pos)) # rubocop:disable Style/GuardClause
+      # because UTF-8 is a variable-length encoding and +String#index+ returns the character index, not the byte index,
+      # we use +String#b+ to convert the string to ASCII-8BIT. This forces Ruby to treat each byte as a single
+      # character. This is needed because we have to know how many bytes from +pos+ the +char+ is.
+      if (idx = string.b.index(char, pos)) # rubocop:disable Style/GuardClause
         read(idx - pos + (include ? 1 : 0))
       end
     end

data/lib/firebug/version.rb

@@ -2,5 +2,5 @@
 
 module Firebug
   # The current version of Firebug
-  VERSION = '1.2.1'
+  VERSION = '1.2.2'
 end

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: firebug
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Aaron Frase
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-03-29 00:00:00.000000000 Z
+date: 2019-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: ruby-mcrypt
   requirement: !ruby/object:Gem::Requirement
@@ -233,6 +233,7 @@ files:
 - ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -258,6 +259,8 @@ licenses:
 - MIT
 metadata:
   yard.run: yri
+  changelog_uri: https://github.com/rvshare/firebug/blob/master/CHANGELOG.md
+  source_code_uri: https://github.com/rvshare/firebug
 post_install_message: 
 rdoc_options: []
 require_paths: