firebrew 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5a542b1a8f741b5c1e6def0a8086d9c79d68f67e
-  data.tar.gz: a029dfe002d81c711026d3ea9df4fbe2f2d9fe0c
+  metadata.gz: d60374125f704299bad2102f82186e95397ebd26
+  data.tar.gz: 11c9f75973a885d728e389f0383f0b33f2b690c2
 SHA512:
-  metadata.gz: c46210782bdf747211f0f9a18c86ea35dcacd99d831ead9817dfcb8870f0598aa41894a5a4d9c5f1778cb743b484a249b019d586bd82a6ce4698bea436a2155a
-  data.tar.gz: 59ad9eef3e13be8c5f4f21926374464d2f7ad0b34c5e02e73dd42f409d0487f457fcc64c777f2560a85a42e8740b3fd76bcbb44a0ea591cf8770d22d96a7e392
+  metadata.gz: d480f31e469ef6bd6b3f3fcd108138cc455b3cd4adf76e3c7c0308162011c5c7a18ea4ecd882ec8e82f6e11868932402f4ed64284f41fb46d7d0266f366e40e4
+  data.tar.gz: d513c0fcaf40b6fe92d32c522e2ea577a24727c446c6182715985952ff109282494db9ab1d58123ed038690fcf31e73212dec6c2266bfc04cc150e186105c059

data/CHANGELOG.md

@@ -0,0 +1,13 @@
+# Changelog
+
+## [0.1.2](https://github.com/mrk21/firebrew/tree/v0.1.2) - 2014-08-15
+
+* Bugfix [#23](https://github.com/mrk21/firebrew/issues/23): If the `install` element of the extension which was got by the generic AMO API was equal or greater than two, then occurs errors
+* Future [#22](https://github.com/mrk21/firebrew/issues/22): Designate the current platform to the `os` parameter when use the `Amo::Search`
+
+## [0.1.1](https://github.com/mrk21/firebrew/tree/v0.1.1) - 2014-07-16
+
+* Bugfix [#12](https://github.com/mrk21/firebrew/issues/12): The unit test failed on the Windows(#10): The 2 to 5 errors
+* Bugfix [#11](https://github.com/mrk21/firebrew/issues/11): The unit test failed on the Windows(#10): The first error
+* Bugfix [#9](https://github.com/mrk21/firebrew/issues/9): Is not able to install on the profile creation immediate aftermath
+* Bugfix [#8](https://github.com/mrk21/firebrew/issues/8): The typo of the `Runner::default_options` for the Windows

data/lib/firebrew/firefox/extension.rb

@@ -42,7 +42,7 @@ module Firebrew::Firefox
         FileUtils.mkdir_p dir
         install_path = '%s.xpi' % File.join(dir, extension.guid)
         
-        open(extension.uri, 'rb') do |i|
+        open([extension.uri].flatten.first, 'rb') do |i|
           open(install_path, 'wb') do |o|
             o.write i.read
           end

data/lib/firebrew/runner.rb

@@ -17,16 +17,19 @@ module Firebrew
       when /darwin/ then
         result[:base_dir] ||= '~/Library/Application Support/Firefox'
         result[:firefox] ||= '/Applications/Firefox.app/Contents/MacOS/firefox-bin'
+        result[:os] = 'darwin'
         
       when /linux/ then
         result[:base_dir] ||= '~/.mozilla/firefox'
         result[:firefox] ||= '/usr/bin/firefox'
+        result[:os] = 'linux'
         
       when /mswin(?!ce)|mingw|cygwin|bccwin/ then
         appdata = ENV['APPDATA'].to_s.gsub('\\','/')
         programfiles = (ENV['PROGRAMFILES(X86)'] || ENV['PROGRAMFILES']).to_s.gsub('\\','/')
         result[:base_dir] ||= File.join(appdata, 'Mozilla/Firefox')
         result[:firefox] ||= File.join(programfiles, 'Mozilla Firefox/firefox.exe')
+        result[:os] = 'winnt'
       end
       
       result
@@ -78,7 +81,7 @@ module Firebrew
     protected
     
     def fetch_api(params={})
-      params.merge!(version: @firefox.version)
+      params.merge!(version: @firefox.version, os: self.config[:os])
       AmoApi::Search.fetch!(params)
     end
   end

data/lib/firebrew/version.rb

@@ -1,3 +1,3 @@
 module Firebrew
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/firebrew/firefox/extension_spec.rb

@@ -87,7 +87,7 @@ module Firebrew::Firefox
       end
       
       describe '#install(extension)' do
-        before { self.instance.install(self.extension) }
+        subject { self.instance.install(self.extension) }
         
         let(:extension) do
           Extension.new({
@@ -97,11 +97,13 @@ module Firebrew::Firefox
         end
         
         it 'should copy the `path/to/profile/extensions/guid.xpi`' do
+          subject
           path = File.join(self.instance.profile.path, 'extensions/%s.xpi' % self.extension.guid)
           expect(File.exists? path).to be_truthy
         end
         
         it 'should add the `extension` extension' do
+          subject
           all = self.instance.all
           extension = self.extension
           extension.uri = './tmp/extensions/hoge@example.org.xpi'
@@ -110,6 +112,22 @@ module Firebrew::Firefox
           expect(all[1]).to eq(self.extensions[1])
           expect(all[2]).to eq(self.extension)
         end
+        
+        context 'when an `uri` of the `extension` was equal or greater than two' do
+          let(:extension) do
+            Extension.new({
+              guid: 'hoge@example.org',
+              uri: [
+                './spec/fixtures/amo_api/search/base.xml',
+                './spec/fixtures/amo_api/search/not_exists.xml'
+              ]
+            }, self.manager)
+          end
+          
+          it 'should not throw exceptions' do
+            expect{subject}.to_not raise_error
+          end
+        end
       end
       
       describe '#uninstall(extension)' do

data/spec/firebrew/runner_spec.rb

@@ -7,7 +7,7 @@ module Firebrew
         Runner.default_config(self.platform)
       end
       
-      let(:platform){RUBY_PLATFORM}
+      let(:platform){'x86_64-darwin13.0'}
       
       before do
         ENV['FIREBREW_FIREFOX_PROFILE_BASE_DIR'] = nil
@@ -27,7 +27,8 @@ module Firebrew
           is_expected.to eq(
             base_dir: '~/Library/Application Support/Firefox',
             firefox: '/Applications/Firefox.app/Contents/MacOS/firefox-bin',
-            profile: 'default'
+            profile: 'default',
+            os: 'darwin'
           )
         end
       end
@@ -38,7 +39,8 @@ module Firebrew
           is_expected.to eq(
             base_dir: '~/.mozilla/firefox',
             firefox: '/usr/bin/firefox',
-            profile: 'default'
+            profile: 'default',
+            os: 'linux'
           )
         end
       end
@@ -70,7 +72,8 @@ module Firebrew
               is_expected.to eq(
                 base_dir: 'C:/Users/admin/AppData/Roaming/Mozilla/Firefox',
                 firefox: 'C:/Program Files (x86)/Mozilla Firefox/firefox.exe',
-                profile: 'default'
+                profile: 'default',
+                os: 'winnt'
               )
             end
           end
@@ -86,7 +89,8 @@ module Firebrew
               is_expected.to eq(
                 base_dir: 'C:/Documents and Settings/Administrator/Application Data/Mozilla/Firefox',
                 firefox: 'C:/Program Files/Mozilla Firefox/firefox.exe',
-                profile: 'default'
+                profile: 'default',
+                os: 'winnt'
               )
             end
           end
@@ -104,7 +108,8 @@ module Firebrew
               is_expected.to eq(
                 base_dir: 'C:/Users/admin/AppData/Roaming/Mozilla/Firefox',
                 firefox: 'C:/Program Files (x86)/Mozilla Firefox/firefox.exe',
-                profile: 'default'
+                profile: 'default',
+                os: 'winnt'
               )
             end
           end
@@ -122,7 +127,8 @@ module Firebrew
           is_expected.to eq(
             base_dir: 'path/to/profile_base_directory',
             firefox: 'path/to/firefox',
-            profile: 'profile-name'
+            profile: 'profile-name',
+            os: 'darwin'
           )
         end
       end
@@ -139,7 +145,7 @@ module Firebrew
         )
       end
       
-      let(:search_params){{term: 'hoge', version: '30.0', max: 1}}
+      let(:search_params){{term: 'hoge', version: '30.0', max: 1, os: Runner.default_config[:os]}}
       
       before do
         FileUtils.cp './spec/fixtures/firefox/profile/base.ini', './tmp/profiles.ini'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: firebrew
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Yuichi Murata
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-15 00:00:00.000000000 Z
+date: 2014-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -119,6 +119,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md