firebase 0.1.4 → 0.1.5

data/VERSION

@@ -1 +1 @@
-0.1.4
+0.1.5

data/firebase.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "firebase"
-  s.version = "0.1.4"
+  s.version = "0.1.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Oscar Del Ben"]
-  s.date = "2013-03-24"
+  s.date = "2013-11-10"
   s.description = "Firebase wrapper for Ruby"
   s.email = "info@oscardelben.com"
   s.extra_rdoc_files = [

data/lib/firebase/request.rb

@@ -42,7 +42,7 @@ module Firebase
       def process(method, path, options={})
         raise "Please set Firebase.base_uri before making requests" unless Firebase.base_uri
 
-	@@hydra ||= Typhoeus::Hydra.new
+	      @@hydra ||= Typhoeus::Hydra.new
         request = Typhoeus::Request.new(build_url(path),
                                         :body => options[:body],
                                         :method => method)
@@ -61,7 +61,9 @@ module Firebase
     end
 
     def body
-      JSON.parse(response.body)
+      JSON.parse(response.body, :quirks_mode => true)
+    rescue JSON::ParserError => e
+      response.body == 'null' ? nil : raise
     end
 
     def raw_body
@@ -69,7 +71,7 @@ module Firebase
     end
 
     def success?
-      response.code.in? [200, 204]
+      [200, 204].include? response.code
     end
 
     def code

data/spec/firebase_spec.rb

@@ -24,6 +24,31 @@ describe "Firebase" do
       Firebase::Request.should_receive(:get).with('users/info')
       Firebase.get('users/info')
     end
+
+    it "return nil if response body contains 'null'" do
+      mock_response = mock(:body => 'null')
+      @request = Firebase::Request.new(mock_response)
+      expect { @request.body }.to_not raise_error(JSON::ParserError)
+    end
+
+    it "return true if response body contains 'true'" do
+      mock_response = mock(:body => 'true')
+      @request = Firebase::Request.new(mock_response)
+      @request.body.should eq(true)
+    end
+
+    it "return false if response body contains 'false'" do
+      mock_response = mock(:body => 'false')
+      @request = Firebase::Request.new(mock_response)
+      @request.body.should eq(false)
+    end
+
+    it "raises JSON::ParserError if response body contains invalid JSON" do
+      mock_response = mock(:body => '{"this is wrong"')
+      @request = Firebase::Request.new(mock_response)
+      expect { @request.body }.to raise_error(JSON::ParserError)
+    end
+
   end
 
   describe "push" do

metadata

@@ -1,80 +1,80 @@
 --- !ruby/object:Gem::Specification
 name: firebase
 version: !ruby/object:Gem::Version
-  version: 0.1.4
   prerelease: 
+  version: 0.1.5
 platform: ruby
 authors:
 - Oscar Del Ben
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-24 00:00:00.000000000 Z
+date: 2013-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: typhoeus
-  requirement: !ruby/object:Gem::Requirement
-    none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.6.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
     none: false
+  prerelease: false
+  name: typhoeus
+  type: :runtime
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: 0.6.1
-- !ruby/object:Gem::Dependency
-  name: json
-  requirement: !ruby/object:Gem::Requirement
     none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
     none: false
+  prerelease: false
+  name: json
+  type: :runtime
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
     none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
     none: false
+  prerelease: false
+  name: rspec
+  type: :development
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: jeweler
-  requirement: !ruby/object:Gem::Requirement
     none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.8.3
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
     none: false
+  prerelease: false
+  name: jeweler
+  type: :development
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.8.3
+    none: false
 description: Firebase wrapper for Ruby
 email: info@oscardelben.com
 executables: []
@@ -105,20 +105,20 @@ rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
-      version: '0'
       segments:
       - 0
-      hash: -2098595268824288091
-required_rubygems_version: !ruby/object:Gem::Requirement
+      hash: 675265491536299218
+      version: '0'
   none: false
+required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+  none: false
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23