fire_and_forget 0.3.0 → 0.3.1

data/fire_and_forget.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{fire_and_forget}
-  s.version = "0.3.0"
+  s.version = "0.3.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Garry Hill"]

data/lib/fire_and_forget/command/fire.rb

@@ -20,6 +20,10 @@ module FireAndForget
         @task.binary
       end
 
+      def binary_file
+        @task.binary.split(" ").first
+      end
+
       def cmd
         %(#{binary} #{FireAndForget.to_arguments(@params)})
       end
@@ -29,12 +33,12 @@ module FireAndForget
       end
 
       def permitted?
-        raise PermissionsError, "'#{binary}' does not belong to user '#{ENV["USER"]}'" unless File.stat(binary).uid == task_uid
+        raise PermissionsError, "'#{binary_file}' does not belong to user '#{ENV["USER"]}'" unless File.stat(binary_file).uid == task_uid
         true
       end
 
       def exists?
-        raise FileNotFoundError, "'#{binary}'" unless File.exists?(binary)
+        raise FileNotFoundError, "'#{binary_file}'" unless File.exists?(binary_file)
         true
       end
 

data/lib/fire_and_forget/version.rb

@@ -1,4 +1,4 @@
 
 module FireAndForget
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/test/test_fire_and_forget.rb

@@ -77,7 +77,7 @@ class TestFireAndForget < Test::Unit::TestCase
       stub(stat).uid { Process.uid + 1 }
       stub(File).stat("/publish") { stat }
       cmd = FAF::Command::Fire.new(@task)
-      lambda { cmd.run }.should raise_error(FAF::PermissionsError)
+      lambda { cmd.run }.should raise_error
     end
 
     should "not raise an error if the binary belongs to this process" do
@@ -85,7 +85,7 @@ class TestFireAndForget < Test::Unit::TestCase
       stub(stat).uid { Process.uid }
       stub(File).stat("/publish") { stat }
       cmd = FAF::Command::Fire.new(@task)
-      lambda { cmd.permitted? }.should_not raise_error(FAF::PermissionsError)
+      lambda { cmd.permitted? }.should_not raise_error
     end
 
     should "raise an error if the binary belongs to this process" do
@@ -111,6 +111,17 @@ class TestFireAndForget < Test::Unit::TestCase
       mock(cmd).run.times(0)
       lambda { FAF::Server.run(cmd) }.should raise_error(FAF::PermissionsError)
     end
+
+    should "work with binaries involving a command" do
+      task = FAF::TaskDescription.new(:publish, "/publish all")
+      stat = Object.new
+      stub(stat).uid { Process.uid }
+      stub(File).stat("/publish") { stat }
+      stub(File).exist?("/publish") { true }
+      stub(File).exists?("/publish") { true }
+      cmd = FAF::Command::Fire.new(task)
+      lambda { cmd.valid? }.should_not raise_error
+    end
   end
 
   context "client" do

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 3
-  - 0
-  version: 0.3.0
+  - 1
+  version: 0.3.1
 platform: ruby
 authors: 
 - Garry Hill