fintoc 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ca33789fab6412d340066281c2c2d80f1f64bb4e7f8648b3fb9328e054b2dcf
-  data.tar.gz: ed649e528e5476d9e98064ddffd18962c54b2ba1640b0a24bd811fc23952f84b
+  metadata.gz: 2b6fd84b01a0debcf2e3641566db792081bc9d101a4aa7c16c5de4833e573fca
+  data.tar.gz: 72ae1022ebe59fb82ce5ce68ca4327d70975fbe87f64b4b20df6d0d30705f7ec
 SHA512:
-  metadata.gz: 4209e5b24ee42a6329c2be4dd523a600cac46a1bacc1c4e20711ecaa6cbe3f5c5fdaf78772768404d43469cd3b58e114ac9fc05a8298c086a54832e5c83a6712
-  data.tar.gz: f88ebb122809d04175dbf43149c2bf093dbf2760e6f255efe60c8cad2d767f3b544f902204b1e5117356c71c3fa62e70ce8f8bfa8703e842d40a1ec9f4b114a2
+  metadata.gz: d5d6354afddadc96ddd7b4795e6d7b6d4679fb9838378f0b6f3a130442a35505e518394aabf3ebc543d6b9dad7071f5141853e747a7832e2bc8920a57d719cd6
+  data.tar.gz: 9d98cb9b5f113793b62458d55e6f425ff7dc3f8a811a7f664fdf09630e7bcbcfa3234a95ebb903648ba3053981e4acfd9bfb76471ae49c44c0d670bb368518ce

data/.github/pull_request_template.md

@@ -0,0 +1,47 @@
+<!-- markdownlint-disable MD041 -->
+## Contexto
+
+¿Por qué?
+
+Agregar un pequeño resumen que de contexto y explicar por qué es importante el cambio
+que se está proponiendo.
+
+## ¿Qué hay de nuevo?
+
+¿Qué?
+
+Resumen que explique que es lo que se implementó concretamente. Un punteo
+de cambios específicos también es bienvenido.
+
+- [x] Endpoint para exponer x
+- [x] Se elimina configuración y
+- [x] Clase Z
+
+## Tests
+
+¿Cómo nos aseguramos de que esto funciona?
+
+- [x] Tests unitarios para x
+- [x] Tests de integración entre x e y
+
+## Safety Checks
+
+- [ ] Versión y CHANGELOG actualizados (si corresponde)
+
+## Consideraciones
+
+Cosas generales que el reviewer debería tener en cuenta. Pueden ser componentes
+que se ven afectados por el PR, decisiones que se tomaron para el desarrollo,
+dudas para discutir con los reviewers, cosas que quedaron fuera de scope, etc.
+
+Ej.:
+
+- Se decidió separar x funcionalidad en dos endpoints
+- ¿Les parece bien este nombre para y?
+- Se decidió no incluir el refactor de x en este PR
+
+## Rollback
+
+¿Es seguro hacer rollback?
+¿Cuáles son los pasos para hacer rollback?
+****

data/.github/workflows/ci.yml

@@ -0,0 +1,46 @@
+name: CI
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+  release:
+    types: [published]
+  workflow_dispatch:
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    name: Lint with RuboCop
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v4
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: '3.2.2'
+        bundler-cache: true
+
+    - name: Run RuboCop
+      run: bundle exec rubocop
+
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['3.2', '3.3', '3.4']
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v4
+
+    - name: Set up Ruby ${{ matrix.ruby-version }}
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true
+
+    - name: Run tests
+      run: COVERAGE=true bundle exec rspec

data/.rubocop.yml

@@ -1,14 +1,16 @@
-require:
+plugins:
   - rubocop-rspec
   - rubocop-performance
+  - rubocop-capybara
+  - rubocop-rails
+
 AllCops:
   Exclude:
   - "vendor/**/*"
   - "db/**/*"
   - "bin/**/*"
-  TargetRubyVersion: 2.6
-Rails:
-  Enabled: false
+  TargetRubyVersion: 3.2
+  NewCops: enable
 Performance:
   Enabled: true
 Layout/ParameterAlignment:
@@ -115,7 +117,7 @@ Style/PercentLiteralDelimiters:
     "%w": "()"
     "%W": "()"
     "%x": "()"
-Naming/PredicateName:
+Naming/PredicatePrefix:
   Description: Check the names of predicate methods.
   StyleGuide: https://github.com/bbatsov/ruby-style-guide#bool-methods-qmark
   Enabled: true
@@ -509,5 +511,10 @@ RSpec/ExpectChange:
   EnforcedStyle: block
 RSpec/EmptyExampleGroup:
   Enabled: true
-  CustomIncludeMethods:
-    - run_test!
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+Rails/Output:
+  Enabled: false
+Rails/Delegate:
+  Description: Prefer delegate method for delegations.
+  Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,45 @@
 # Changelog
 
+## 1.0.0 - 2025-09-05
+
+### 🚀 New Features
+
+- **New Client Architecture**: Restructured client to distinguish between API versions
+  - Movements API now accessible via `Fintoc::V1::Client`
+  - Transfers API accessible via `Fintoc::V2::Client`
+  - Unified client interface with `Fintoc::Client` providing access to both versions
+  - Backward compatibility maintained for existing method signatures
+
+- **V2 Client - Transfers API Implementation**: Partial implementation of Transfers API endpoints in `Fintoc::V2::Client`
+  - **Entities**: List and retrieve business entities
+  - **Transfer Accounts**: Create, read, update, and list transfer accounts
+  - **Account Numbers**: Manage account numbers/CLABEs
+  - **Transfers**: Create, retrieve, list, and return transfers
+  - **Simulation**: Simulate receiving transfers for testing
+  - **Account Verifications**: Verify account numbers
+  - **Movements**: TODO! Not yet implemented
+
+### 🧪 Testing & Quality
+
+- **100% Line Coverage**: Achieved full line coverage using SimpleCov gem, increasing the spec coverage and testing all new code.
+  - Configured with `minimum_coverage 100` and `minimum_coverage_by_file 100`
+  - Uses `simplecov_text_formatter` and `simplecov_linter_formatter` for reporting
+
+- **Robust CI Pipeline**: Enhanced GitHub Actions workflow for comprehensive testing
+  - **Linting**: Dedicated RuboCop job for code quality enforcement
+  - **Multi-version Testing**: Tests against all currently supported Ruby versions (3.2, 3.3, and 3.4) for version compatibility
+  - **Coverage Integration**: Automated coverage reporting in CI pipeline
+
+### Others
+
+- **Money-Rails Integration**: Added `money-rails` gem for proper currency handling
+- **Comprehensive README Update**: Extensively updated documentation with usage examples and development instructions
+- **Improved Error Handling**: Better error management across API versions
+- **JWS Support**: JSON Web Signature support for secure V2 API operations
+- **HMac Signature verification**: Added the `Fintoc::WebhookSignature` class for easing webhook signature verification
+
 ## 0.1.0 - 2021-01-18
 
+Initial version
+
 * Up to date with the [2020-11-17](https://docs.fintoc.com/docs/api-changelog#2020-11-17) API version

data/Gemfile

@@ -1,4 +1,23 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in fintoc.gemspec
 gemspec
+
+# Development dependencies
+group :development do
+  gem 'rubocop', '~> 1.80'
+  gem 'rubocop-capybara', '~> 2.22', '>= 2.22.1'
+  gem 'rubocop-performance', '~> 1.25'
+  gem 'rubocop-rails', '~> 2.33', '>= 2.33.3'
+  gem 'rubocop-rspec', '~> 3.6'
+end
+
+group :test do
+  gem 'rexml'  # Required for webmock in Ruby 3.0+
+  gem 'rspec', '~> 3.0'
+  gem 'simplecov', '~> 0.21'
+  gem 'simplecov_linter_formatter'
+  gem 'simplecov_text_formatter'
+  gem 'vcr', '~> 6.3'
+  gem 'webmock'
+end

data/Gemfile.lock

@@ -1,93 +1,269 @@
 PATH
   remote: .
   specs:
-    fintoc (0.1.0)
+    fintoc (1.0.0)
       http
+      money-rails
       tabulate
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.7.0)
-      public_suffix (>= 2.0.2, < 5.0)
-    ast (2.4.1)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
-    diff-lcs (1.4.4)
-    domain_name (0.5.20190701)
-      unf (>= 0.0.5, < 1.0.0)
-    ffi (1.13.1)
-    ffi-compiler (1.0.1)
-      ffi (>= 1.0.0)
+    actionpack (8.0.2.1)
+      actionview (= 8.0.2.1)
+      activesupport (= 8.0.2.1)
+      nokogiri (>= 1.8.5)
+      rack (>= 2.2.4)
+      rack-session (>= 1.0.1)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.2)
+      rails-html-sanitizer (~> 1.6)
+      useragent (~> 0.16)
+    actionview (8.0.2.1)
+      activesupport (= 8.0.2.1)
+      builder (~> 3.1)
+      erubi (~> 1.11)
+      rails-dom-testing (~> 2.2)
+      rails-html-sanitizer (~> 1.6)
+    activesupport (8.0.2.1)
+      base64
+      benchmark (>= 0.3)
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
+      minitest (>= 5.1)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
+    addressable (2.8.7)
+      public_suffix (>= 2.0.2, < 7.0)
+    ast (2.4.3)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.2)
+    builder (3.3.0)
+    concurrent-ruby (1.3.5)
+    connection_pool (2.5.3)
+    crack (1.0.0)
+      bigdecimal
+      rexml
+    crass (1.0.6)
+    date (3.4.1)
+    diff-lcs (1.6.2)
+    docile (1.4.1)
+    domain_name (0.6.20240107)
+    drb (2.2.3)
+    erb (5.0.2)
+    erubi (1.13.1)
+    ffi (1.17.2)
+    ffi (1.17.2-aarch64-linux-gnu)
+    ffi (1.17.2-aarch64-linux-musl)
+    ffi (1.17.2-arm-linux-gnu)
+    ffi (1.17.2-arm-linux-musl)
+    ffi (1.17.2-arm64-darwin)
+    ffi (1.17.2-x86_64-darwin)
+    ffi (1.17.2-x86_64-linux-gnu)
+    ffi (1.17.2-x86_64-linux-musl)
+    ffi-compiler (1.3.2)
+      ffi (>= 1.15.5)
       rake
-    hashdiff (1.0.1)
-    http (4.4.1)
-      addressable (~> 2.3)
+    hashdiff (1.2.0)
+    http (5.3.1)
+      addressable (~> 2.8)
       http-cookie (~> 1.0)
       http-form_data (~> 2.2)
-      http-parser (~> 1.2.0)
-    http-cookie (1.0.3)
+      llhttp-ffi (~> 0.5.0)
+    http-cookie (1.0.8)
       domain_name (~> 0.5)
     http-form_data (2.3.0)
-    http-parser (1.2.1)
-      ffi-compiler (>= 1.0, < 2.0)
-    jaro_winkler (1.5.4)
-    parallel (1.20.1)
-    parser (3.0.0.0)
+    i18n (1.14.7)
+      concurrent-ruby (~> 1.0)
+    io-console (0.8.1)
+    irb (1.15.2)
+      pp (>= 0.6.0)
+      rdoc (>= 4.0.0)
+      reline (>= 0.4.2)
+    json (2.13.2)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
+    llhttp-ffi (0.5.1)
+      ffi-compiler (~> 1.0)
+      rake (~> 13.0)
+    logger (1.7.0)
+    loofah (2.24.1)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.12.0)
+    minitest (5.25.5)
+    monetize (1.13.0)
+      money (~> 6.12)
+    money (6.19.0)
+      i18n (>= 0.6.4, <= 2)
+    money-rails (1.15.0)
+      activesupport (>= 3.0)
+      monetize (~> 1.9)
+      money (~> 6.13)
+      railties (>= 3.0)
+    nokogiri (1.18.9-aarch64-linux-gnu)
+      racc (~> 1.4)
+    nokogiri (1.18.9-aarch64-linux-musl)
+      racc (~> 1.4)
+    nokogiri (1.18.9-arm-linux-gnu)
+      racc (~> 1.4)
+    nokogiri (1.18.9-arm-linux-musl)
+      racc (~> 1.4)
+    nokogiri (1.18.9-arm64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.18.9-x86_64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.18.9-x86_64-linux-gnu)
+      racc (~> 1.4)
+    nokogiri (1.18.9-x86_64-linux-musl)
+      racc (~> 1.4)
+    parallel (1.27.0)
+    parser (3.3.9.0)
       ast (~> 2.4.1)
-    public_suffix (4.0.5)
-    rainbow (3.0.0)
-    rake (12.3.3)
-    rexml (3.2.4)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.2)
-      rspec-support (~> 3.9.3)
-    rspec-expectations (3.9.2)
+      racc
+    pp (0.6.2)
+      prettyprint
+    prettyprint (0.2.0)
+    prism (1.4.0)
+    psych (5.2.6)
+      date
+      stringio
+    public_suffix (6.0.2)
+    racc (1.8.1)
+    rack (3.2.0)
+    rack-session (2.1.1)
+      base64 (>= 0.1.0)
+      rack (>= 3.0.0)
+    rack-test (2.2.0)
+      rack (>= 1.3)
+    rackup (2.2.1)
+      rack (>= 3)
+    rails-dom-testing (2.3.0)
+      activesupport (>= 5.0.0)
+      minitest
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.6.2)
+      loofah (~> 2.21)
+      nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
+    railties (8.0.2.1)
+      actionpack (= 8.0.2.1)
+      activesupport (= 8.0.2.1)
+      irb (~> 1.13)
+      rackup (>= 1.0.0)
+      rake (>= 12.2)
+      thor (~> 1.0, >= 1.2.2)
+      zeitwerk (~> 2.6)
+    rainbow (3.1.1)
+    rake (13.3.0)
+    rdoc (6.14.2)
+      erb
+      psych (>= 4.0.0)
+    regexp_parser (2.11.2)
+    reline (0.6.2)
+      io-console (~> 0.5)
+    rexml (3.4.2)
+    rspec (3.13.1)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.5)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.1)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.3)
-    rubocop (0.81.0)
-      jaro_winkler (~> 1.5.1)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.5)
+    rubocop (1.80.0)
+      json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      rexml
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.46.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-performance (1.6.1)
-      rubocop (>= 0.71.0)
-    rubocop-rspec (1.41.0)
-      rubocop (>= 0.68.1)
-    ruby-progressbar (1.11.0)
-    safe_yaml (1.0.5)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.46.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-capybara (2.22.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-performance (1.25.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rails (2.33.3)
+      activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
+      rack (>= 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
+    rubocop-rspec (3.6.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    ruby-progressbar (1.13.0)
+    securerandom (0.4.1)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.13.2)
+    simplecov_json_formatter (0.1.4)
+    simplecov_linter_formatter (0.2.0)
+      rainbow
+    simplecov_text_formatter (0.1.0)
+    stringio (3.1.7)
     tabulate (0.1.2)
-    unf (0.1.4)
-      unf_ext
-    unf_ext (0.0.7.7)
-    unicode-display_width (1.7.0)
-    vcr (6.0.0)
-    webmock (3.8.3)
-      addressable (>= 2.3.6)
+    thor (1.4.0)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (3.1.5)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
+    uri (1.0.3)
+    useragent (0.16.11)
+    vcr (6.3.1)
+      base64
+    webmock (3.25.1)
+      addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
+    zeitwerk (2.7.3)
 
 PLATFORMS
-  ruby
+  aarch64-linux-gnu
+  aarch64-linux-musl
+  arm-linux-gnu
+  arm-linux-musl
+  arm64-darwin
+  x86_64-darwin
+  x86_64-linux
+  x86_64-linux-gnu
+  x86_64-linux-musl
 
 DEPENDENCIES
   fintoc!
+  rexml
   rspec (~> 3.0)
-  rubocop (~> 0.81.0)
-  rubocop-performance
-  rubocop-rspec
-  vcr
+  rubocop (~> 1.80)
+  rubocop-capybara (~> 2.22, >= 2.22.1)
+  rubocop-performance (~> 1.25)
+  rubocop-rails (~> 2.33, >= 2.33.3)
+  rubocop-rspec (~> 3.6)
+  simplecov (~> 0.21)
+  simplecov_linter_formatter
+  simplecov_text_formatter
+  vcr (~> 6.3)
   webmock
 
 BUNDLED WITH
-   2.1.4
+   2.7.1