fino 1.10.0 → 1.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b848e452b4dd15c07680a8e27822e978a35152e8a2fcf24193e61af3bdbc2c55
-  data.tar.gz: dabde784e2b9c36d9f258b70a9885052f8d567e0ffc21ace004d1441bb219651
+  metadata.gz: 677e25b9a4daff0aaf1fa179f2571f954b7afdc495685339c3dbff7183656802
+  data.tar.gz: 9ca91a58789efec0a8db42c92aa557de41ce1d6f5c812d71477b32f9d76644fd
 SHA512:
-  metadata.gz: 795b2922a6b205ce6e9015f34c69d7cf7b5b501d54cec81968766d6510148d734b1f0c09fd3193646616759b826964aef9def7d7a572e11dbe362ca50f06a6fe
-  data.tar.gz: 9a85da0390f427490012c41a2eb004bbdb7bdabdf7a2166da450fc7e003d010f9a97baed16ea2f6cdb316a41474703198220ebb2dda0b28bac12cf86d7f96775
+  metadata.gz: dfb43f74199a960f91c72d7e234df8e376eb30a7169b596f0985716e5df63dc09a08af2f834b036d359367139fd8675a62de1dd0ff62337608955c8b1c10550a
+  data.tar.gz: 55932466337a4bfe50926786810c22f9dc3fe81285f08620699cc5409814ed38651ade65a9caeaae3e6c10d2ecc56cb163f66f2c8cb122343db86f3c677c79e2

data/README.md

@@ -238,7 +238,7 @@ Fino.value(:model, at: :openai, for: "user_2") #=> "gpt-5"
 
 #### Experiment analysis
 
-Some Fino adapters support A/B testing analysis, e.g built-in Redis adapter
+Fino adapters might support A/B testing analysis, both built-in `solid` and `redis` adapters do
 
 When you run an A/B test for a setting, fino automatically calculates variant based on a stable identifier you pass as
 a `for` option
@@ -416,6 +416,14 @@ end
    end
    ```
 
+## Development
+
+To create and mugrate dummy app db to test solid adapter, do
+
+```bash
+cd spec/dummy && bin/rails db:create db:migrate
+```
+
 ## Releasing
 
 `rake release`

data/lib/fino/library/ab_testing_analysis_support.rb

@@ -11,9 +11,8 @@ module Fino::Library::AbTestingAnalysisSupport
 
     setting_instance = fetch_ab_testable_setting(setting_name, at: at)
     variant = setting_instance.experiment.variant(for: scope)
-    timestamp_ms = (time.to_f * 1000).to_i
 
-    adapter.record_ab_testing_conversion(setting_instance.definition, variant, scope, timestamp_ms)
+    adapter.record_ab_testing_conversion(setting_instance.definition, variant, scope, time)
   end
 
   def convert(setting_name, at: nil, time: Time.now, **context)

data/lib/fino/settings/select.rb

@@ -62,7 +62,7 @@ class Fino::Settings::Select
     def resolve(path, force: false)
       string_path = path.compact.map(&:to_s)
 
-      return if !force && @options.dig(*string_path)
+      return if !force && @options.dig(*string_path).present?
 
       builder = @builders.dig(*string_path)
       options = builder.respond_to?(:call) ? builder.call(refresh: force) : builder

data/lib/fino/solid/adapter.rb

@@ -37,7 +37,7 @@ module Fino
 
         Fino::Solid::Setting.upsert(
           { key: setting_definition.key, data: data },
-          unique_by: :key
+          **unique_by_option(:key)
         )
       end
 
@@ -45,8 +45,8 @@ module Fino
         Fino::Solid::Setting.pluck(:key)
       end
 
-      def clear(setting_key)
-        Fino::Solid::Setting.where(key: setting_key).delete_all > 0
+      def clear(setting_key) # rubocop:disable Naming/PredicateMethod
+        Fino::Solid::Setting.where(key: setting_key).delete_all.positive?
       end
 
       def fetch_value_from(raw_adapter_data)
@@ -62,6 +62,36 @@ module Fino
         end
       end
 
+      def record_ab_testing_conversion(setting_definition, variant, scope, time)
+        Fino::Solid::Conversion.insert(
+          {
+            setting_key: setting_definition.key,
+            variant_id: variant.id,
+            scope: scope.to_s,
+            converted_at: time
+          },
+          **unique_by_option(:idx_fino_conversions_unique)
+        )
+      end
+
+      def read_ab_testing_conversions(setting_definition, variants)
+        rows =
+          Fino::Solid::Conversion
+          .where(setting_key: setting_definition.key, variant_id: variants.map(&:id))
+          .pluck(:variant_id, :scope, :converted_at)
+
+        grouped = rows.group_by(&:first)
+
+        variants.each_with_object({}) do |variant, memo|
+          entries = grouped.fetch(variant.id, [])
+          memo[variant] = entries.map { |_vid, scope, converted_at| [scope, (converted_at.to_f * 1000).to_i] }
+        end
+      end
+
+      def clear_ab_testing_conversions(setting_key)
+        Fino::Solid::Conversion.where(setting_key: setting_key).delete_all
+      end
+
       def fetch_raw_variants_from(raw_adapter_data)
         raw_adapter_data.each_with_object([]) do |(key, value), memo|
           next unless key.start_with?("#{VARIANT_PREFIX}/")
@@ -71,6 +101,18 @@ module Fino
           memo << { percentage: percentage.to_f, value: value }
         end
       end
+
+      private
+
+      def unique_by_option(constraint)
+        return {} if mysql_adapter?
+
+        { unique_by: constraint }
+      end
+
+      def mysql_adapter?
+        Fino::Solid::Record.connection.adapter_name.match?(/Mysql2|Trilogy/i)
+      end
     end
   end
 end

data/lib/fino/solid/conversion.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module Fino
+  module Solid
+    class Conversion < Record
+      self.table_name = "fino_ab_testing_conversions"
+    end
+  end
+end

data/lib/fino/solid/generators/install/install_generator.rb

@@ -11,8 +11,10 @@ module Fino
 
         source_root File.expand_path("templates", __dir__)
 
-        def copy_migration
+        def copy_migrations
           migration_template "create_fino_settings.rb.tt", File.join(db_migrate_path, "create_fino_settings.rb")
+          migration_template "create_fino_ab_testing_conversions.rb.tt",
+                             File.join(db_migrate_path, "create_fino_ab_testing_conversions.rb")
         end
 
         private

data/lib/fino/solid.rb

@@ -16,6 +16,7 @@ end
 
 require "fino/solid/record"
 require "fino/solid/setting"
+require "fino/solid/conversion"
 require "fino/solid/adapter"
 require "fino/solid/railtie" if defined?(Rails::Railtie)
 

data/lib/fino/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Fino
-  VERSION = "1.10.0"
+  VERSION = "1.11.1"
   REQUIRED_RUBY_VERSION = ">= 3.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fino
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.11.1
 platform: ruby
 authors:
 - Egor Iskrenkov
@@ -67,6 +67,7 @@ files:
 - lib/fino/settings/string.rb
 - lib/fino/solid.rb
 - lib/fino/solid/adapter.rb
+- lib/fino/solid/conversion.rb
 - lib/fino/solid/generators/install/install_generator.rb
 - lib/fino/solid/railtie.rb
 - lib/fino/solid/record.rb
@@ -93,7 +94,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.6
 specification_version: 4
 summary: Plug & play distributed settings engine for Ruby and Rails
 test_files: []