fino-solid 1.10.0 → 1.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d001f6bb38d131992464c9cdeab1e5927fd5a16623759459c7020b1c35d6664a
-  data.tar.gz: 339ab6d35c8dc40ecd553f835f536eb74a6978375ed29943cf5c8905c9c812e2
+  metadata.gz: dab2e123b7d5d9d00d30db649e0c70230180f8f4239bf4e48b609a7ff7b92c9b
+  data.tar.gz: bf585a94289c2f70bf12d6222478aa6c4182e940b7d2474d8b61e3500d8df7dd
 SHA512:
-  metadata.gz: 6f81641ee84473e0fb6262bfa41d6beefd0e2051eb8caf6fc15364198385324f162f395a959d6658791dd70b9dbc28de46259a561a7c08b7df90f7d04f7c0f54
-  data.tar.gz: 53eef4644ef38aaa358cf40d9f2cbf5ed587800a5acb0e47b94cf09b8f51371d5cb5a34678385f691a524d2beda08ed5814e029ebbf0180cf63a6055299585c8
+  metadata.gz: b6504803c3963065069f690c30089cd76f5e08a2c6156bca88a798753f3b45f0bf9b2fc1ba5985e7f65f3dddda8a24ab97466710514f5e22a4be66a9b5fb5237
+  data.tar.gz: b2167cdbea48102228fef66fcf63cf0c4e30c38cca534c0a7784c487597e48801091e0eba9ba2173bb93ff3e8495718c140f7fe580063d4044e7018bc3944a75

data/README.md

@@ -238,7 +238,7 @@ Fino.value(:model, at: :openai, for: "user_2") #=> "gpt-5"
 
 #### Experiment analysis
 
-Some Fino adapters support A/B testing analysis, e.g built-in Redis adapter
+Fino adapters might support A/B testing analysis, both built-in `solid` and `redis` adapters do
 
 When you run an A/B test for a setting, fino automatically calculates variant based on a stable identifier you pass as
 a `for` option
@@ -416,6 +416,14 @@ end
    end
    ```
 
+## Development
+
+To create and mugrate dummy app db to test solid adapter, do
+
+```bash
+cd spec/dummy && bin/rails db:create db:migrate
+```
+
 ## Releasing
 
 `rake release`

data/lib/fino/solid/adapter.rb

@@ -37,7 +37,7 @@ module Fino
 
         Fino::Solid::Setting.upsert(
           { key: setting_definition.key, data: data },
-          unique_by: :key
+          **unique_by_option(:key)
         )
       end
 
@@ -45,8 +45,8 @@ module Fino
         Fino::Solid::Setting.pluck(:key)
       end
 
-      def clear(setting_key)
-        Fino::Solid::Setting.where(key: setting_key).delete_all > 0
+      def clear(setting_key) # rubocop:disable Naming/PredicateMethod
+        Fino::Solid::Setting.where(key: setting_key).delete_all.positive?
       end
 
       def fetch_value_from(raw_adapter_data)
@@ -62,6 +62,36 @@ module Fino
         end
       end
 
+      def record_ab_testing_conversion(setting_definition, variant, scope, time)
+        Fino::Solid::Conversion.insert(
+          {
+            setting_key: setting_definition.key,
+            variant_id: variant.id,
+            scope: scope.to_s,
+            converted_at: time
+          },
+          **unique_by_option(:idx_fino_conversions_unique)
+        )
+      end
+
+      def read_ab_testing_conversions(setting_definition, variants)
+        rows =
+          Fino::Solid::Conversion
+          .where(setting_key: setting_definition.key, variant_id: variants.map(&:id))
+          .pluck(:variant_id, :scope, :converted_at)
+
+        grouped = rows.group_by(&:first)
+
+        variants.each_with_object({}) do |variant, memo|
+          entries = grouped.fetch(variant.id, [])
+          memo[variant] = entries.map { |_vid, scope, converted_at| [scope, (converted_at.to_f * 1000).to_i] }
+        end
+      end
+
+      def clear_ab_testing_conversions(setting_key)
+        Fino::Solid::Conversion.where(setting_key: setting_key).delete_all
+      end
+
       def fetch_raw_variants_from(raw_adapter_data)
         raw_adapter_data.each_with_object([]) do |(key, value), memo|
           next unless key.start_with?("#{VARIANT_PREFIX}/")
@@ -71,6 +101,18 @@ module Fino
           memo << { percentage: percentage.to_f, value: value }
         end
       end
+
+      private
+
+      def unique_by_option(constraint)
+        return {} if mysql_adapter?
+
+        { unique_by: constraint }
+      end
+
+      def mysql_adapter?
+        Fino::Solid::Record.connection.adapter_name.match?(/Mysql2|Trilogy/i)
+      end
     end
   end
 end

data/lib/fino/solid/conversion.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module Fino
+  module Solid
+    class Conversion < Record
+      self.table_name = "fino_ab_testing_conversions"
+    end
+  end
+end

data/lib/fino/solid/generators/install/USAGE

@@ -1,8 +1,9 @@
 Description:
-    Installs Fino::Solid adapter by creating necessary database migration.
+    Installs Fino::Solid adapter by creating necessary database migrations.
 
 Example:
     bin/rails generate fino:solid:install
 
     This will create:
         db/migrate/[timestamp]_create_fino_settings.rb
+        db/migrate/[timestamp]_create_fino_ab_testing_conversions.rb

data/lib/fino/solid/generators/install/install_generator.rb

@@ -11,8 +11,10 @@ module Fino
 
         source_root File.expand_path("templates", __dir__)
 
-        def copy_migration
+        def copy_migrations
           migration_template "create_fino_settings.rb.tt", File.join(db_migrate_path, "create_fino_settings.rb")
+          migration_template "create_fino_ab_testing_conversions.rb.tt",
+                             File.join(db_migrate_path, "create_fino_ab_testing_conversions.rb")
         end
 
         private

data/lib/fino/solid/generators/install/templates/create_fino_ab_testing_conversions.rb.tt

@@ -0,0 +1,17 @@
+class CreateFinoAbTestingConversions < ActiveRecord::Migration[<%= ActiveRecord::Migration.current_version %>]
+  def change
+    create_table :fino_ab_testing_conversions do |t|
+      t.string :setting_key, null: false
+      t.string :variant_id, null: false
+      t.string :scope, null: false
+      t.datetime :converted_at, null: false
+
+      t.timestamps
+    end
+
+    add_index :fino_ab_testing_conversions, %i[setting_key variant_id scope],
+              unique: true, name: :idx_fino_conversions_unique
+    add_index :fino_ab_testing_conversions, %i[setting_key variant_id],
+              name: :idx_fino_conversions_lookup
+  end
+end

data/lib/fino/solid.rb

@@ -16,6 +16,7 @@ end
 
 require "fino/solid/record"
 require "fino/solid/setting"
+require "fino/solid/conversion"
 require "fino/solid/adapter"
 require "fino/solid/railtie" if defined?(Rails::Railtie)
 

data/lib/fino/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Fino
-  VERSION = "1.10.0"
+  VERSION = "1.11.1"
   REQUIRED_RUBY_VERSION = ">= 3.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fino-solid
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.11.1
 platform: ruby
 authors:
 - Egor Iskrenkov
@@ -29,56 +29,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.0
+        version: 1.11.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.0
-- !ruby/object:Gem::Dependency
-  name: mysql2
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.5'
-- !ruby/object:Gem::Dependency
-  name: pg
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.4'
+        version: 1.11.1
 email:
 - egor@iskrenkov.me
 executables: []
@@ -91,8 +49,10 @@ files:
 - lib/fino/solid.rb
 - lib/fino/solid/README.md
 - lib/fino/solid/adapter.rb
+- lib/fino/solid/conversion.rb
 - lib/fino/solid/generators/install/USAGE
 - lib/fino/solid/generators/install/install_generator.rb
+- lib/fino/solid/generators/install/templates/create_fino_ab_testing_conversions.rb.tt
 - lib/fino/solid/generators/install/templates/create_fino_settings.rb.tt
 - lib/fino/solid/railtie.rb
 - lib/fino/solid/record.rb
@@ -119,7 +79,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.6
 specification_version: 4
 summary: ActiveRecord adapter for Fino settings engine
 test_files: []