fine_print 4.0.1 → 5.0.0

data/spec/dummy/tmp/development_secret.txt

@@ -0,0 +1 @@
+8f50fc44121351f7729dacebe9300545123edb157f229b78988e2ccd91c35d0e2184c7a8942e7ce5816b9e1b8c3bb07ba10102147d810db516f5d96c0b00ea42

data/spec/factories/fine_print/contract.rb

@@ -1,20 +1,20 @@
 FactoryBot.define do
   factory :fine_print_contract, class: FinePrint::Contract do
-    name { Faker::Lorem.words.join('_') }
-    title { Faker::Lorem.words.join(' ').capitalize }
+    name    { Faker::Lorem.words.join('_') }
+    title   { Faker::Lorem.words.join(' ').capitalize }
     content { Faker::Lorem.paragraphs.join("\n") }
 
     trait :published do
       transient do
-        user_factory :user
-        signatures_count 0
+        user_factory     { :user }
+        signatures_count { 0 }
       end
 
       after(:build) do |contract, evaluator|
         contract.version = (contract.same_name.published
                                     .first.try(:version) || 0) + 1
 
-        evaluator.signatures_count.times do 
+        evaluator.signatures_count.times do
           contract.signatures << FactoryBot.build(
                                    :fine_print_signature,
                                    user_factory: evaluator.user_factory

data/spec/factories/fine_print/signature.rb

@@ -3,11 +3,11 @@ FactoryBot.define do
     association :contract, factory: [:fine_print_contract, :published]
 
     trait :implicit do
-      is_implicit FinePrint::SIGNATURE_IS_IMPLICIT
+      is_implicit { FinePrint::SIGNATURE_IS_IMPLICIT }
     end
 
     transient do
-      user_factory :user
+      user_factory { :user }
     end
 
     after(:build) do |signature, evaluator|

data/spec/lib/fine_print/action_controller/base_spec.rb

@@ -2,9 +2,9 @@ require 'spec_helper'
 
 module FinePrint
   module ActionController
-    describe Base, type: :lib do
-      let!(:controller)            { ::ActionController::Base.new }
-      let!(:dummy_controller)      { DummyModelsController.new }
+    RSpec.describe Base, type: :lib do
+      let!(:controller)       { ::ActionController::Base.new }
+      let!(:dummy_controller) { DummyModelsController.new }
 
       it 'must add fine_print_sign to ActionController instances' do
         expect(controller).to respond_to(:fine_print_require)

data/spec/lib/fine_print_spec.rb

@@ -1,17 +1,13 @@
 require 'spec_helper'
 
-describe FinePrint, type: :lib do
+RSpec.describe FinePrint, type: :lib do
   before :each do
-    @alpha_1 = FactoryBot.create(:fine_print_contract, :published,
-                                                        name: 'alpha')
-    @beta_1 = FactoryBot.create(:fine_print_contract, :published,
-                                                       name: 'beta')
+    @alpha_1 = FactoryBot.create(:fine_print_contract, :published, name: 'alpha')
+    @beta_1 = FactoryBot.create(:fine_print_contract, :published, name: 'beta')
 
     @user = DummyUser.create
-    @alpha_1_sig = FactoryBot.create(:fine_print_signature, contract: @alpha_1,
-                                                             user: @user)
-    @beta_1_sig = FactoryBot.create(:fine_print_signature, contract: @beta_1,
-                                                            user: @user)
+    @alpha_1_sig = FactoryBot.create(:fine_print_signature, contract: @alpha_1, user: @user)
+    @beta_1_sig = FactoryBot.create(:fine_print_signature, contract: @beta_1, user: @user)
 
     @alpha_2 = @alpha_1.new_version
     @alpha_2.update_attribute(:content, 'foo')
@@ -28,13 +24,11 @@ describe FinePrint, type: :lib do
   end
 
   it 'gets signed contracts' do
-    expect(FinePrint.signed_contracts_for(@user)).to(
-      eq [@beta_1]
-    )
+    expect(FinePrint.signed_contracts_for(@user)).to eq [@beta_1]
   end
 
   it 'gets unsigned contracts' do
-    names = [@alpha_2, @beta_1].collect{|c| c.name}
+    names = [@alpha_2, @beta_1].map(&:name)
     expect(FinePrint.unsigned_contracts_for(@user, name: names)).to eq [@alpha_2]
   end
 
@@ -57,8 +51,7 @@ describe FinePrint, type: :lib do
   end
 
   it 'can record implicit signatures' do
-    signature = FinePrint.sign_contract(@user, @alpha_2,
-                                        FinePrint::SIGNATURE_IS_IMPLICIT)
+    signature = FinePrint.sign_contract(@user, @alpha_2, FinePrint::SIGNATURE_IS_IMPLICIT)
 
     expect(signature.is_implicit?).to eq true
     expect(signature.is_explicit?).to eq false

data/spec/models/contract_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module FinePrint
-  describe Contract, type: :model do
+  RSpec.describe Contract, type: :model do
     it 'can be published and unpublished' do
       contract = FactoryBot.create(:fine_print_contract)
       expect(contract.is_published?).to eq false

data/spec/models/signature_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module FinePrint
-  describe Signature, type: :model do
+  RSpec.describe Signature, type: :model do
     it "can't be associated with unpublished contracts" do
       contract = FactoryBot.create(:fine_print_contract)
       expect(contract.is_published?).to eq false

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fine_print
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 5.0.0
 platform: ruby
 authors:
 - JP Slavinsky
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-20 00:00:00.000000000 Z
+date: 2019-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: jquery-rails
   requirement: !ruby/object:Gem::Requirement
@@ -41,20 +41,6 @@ dependencies:
         version: '0'
 - !ruby/object:Gem::Dependency
   name: action_interceptor
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: baby_squeel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -255,9 +241,11 @@ files:
 - spec/dummy/config/routes.rb
 - spec/dummy/config/spring.rb
 - spec/dummy/config/storage.yml
+- spec/dummy/db/development.sqlite3
 - spec/dummy/db/migrate/1000_create_dummy_users.rb
 - spec/dummy/db/schema.rb
 - spec/dummy/db/test.sqlite3
+- spec/dummy/log/development.log
 - spec/dummy/log/test.log
 - spec/dummy/package.json
 - spec/dummy/public/404.html
@@ -266,6 +254,7 @@ files:
 - spec/dummy/public/apple-touch-icon-precomposed.png
 - spec/dummy/public/apple-touch-icon.png
 - spec/dummy/public/favicon.ico
+- spec/dummy/tmp/development_secret.txt
 - spec/factories/fine_print/contract.rb
 - spec/factories/fine_print/signature.rb
 - spec/factories/user.rb
@@ -294,79 +283,81 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Manages site agreements with versioning.
 test_files:
+- spec/models/signature_spec.rb
+- spec/models/contract_spec.rb
 - spec/spec_helper.rb
-- spec/dummy/app/mailers/application_mailer.rb
+- spec/controllers/signatures_controller_spec.rb
+- spec/controllers/contracts_controller_spec.rb
+- spec/controllers/home_controller_spec.rb
+- spec/factories/user.rb
+- spec/factories/fine_print/signature.rb
+- spec/factories/fine_print/contract.rb
 - spec/dummy/app/models/dummy_user.rb
 - spec/dummy/app/models/application_record.rb
-- spec/dummy/app/jobs/application_job.rb
-- spec/dummy/app/controllers/application_controller.rb
-- spec/dummy/app/controllers/dummy_models_controller.rb
-- spec/dummy/app/views/layouts/application.html.erb
-- spec/dummy/app/views/layouts/mailer.html.erb
-- spec/dummy/app/views/layouts/mailer.text.erb
-- spec/dummy/app/assets/config/manifest.js
-- spec/dummy/app/assets/javascripts/cable.js
 - spec/dummy/app/assets/javascripts/application.js
+- spec/dummy/app/assets/javascripts/cable.js
 - spec/dummy/app/assets/stylesheets/application.css
-- spec/dummy/app/helpers/application_helper.rb
-- spec/dummy/app/channels/application_cable/connection.rb
+- spec/dummy/app/assets/config/manifest.js
+- spec/dummy/app/views/layouts/mailer.text.erb
+- spec/dummy/app/views/layouts/mailer.html.erb
+- spec/dummy/app/views/layouts/application.html.erb
 - spec/dummy/app/channels/application_cable/channel.rb
+- spec/dummy/app/channels/application_cable/connection.rb
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/controllers/dummy_models_controller.rb
+- spec/dummy/app/jobs/application_job.rb
+- spec/dummy/app/mailers/application_mailer.rb
+- spec/dummy/app/helpers/application_helper.rb
+- spec/dummy/tmp/development_secret.txt
+- spec/dummy/db/migrate/1000_create_dummy_users.rb
+- spec/dummy/db/development.sqlite3
+- spec/dummy/db/test.sqlite3
+- spec/dummy/db/schema.rb
+- spec/dummy/log/test.log
+- spec/dummy/log/development.log
+- spec/dummy/public/favicon.ico
+- spec/dummy/public/422.html
+- spec/dummy/public/apple-touch-icon-precomposed.png
+- spec/dummy/public/404.html
+- spec/dummy/public/apple-touch-icon.png
+- spec/dummy/public/500.html
+- spec/dummy/config.ru
+- spec/dummy/package.json
 - spec/dummy/bin/update
+- spec/dummy/bin/rails
+- spec/dummy/bin/yarn
 - spec/dummy/bin/rake
 - spec/dummy/bin/setup
 - spec/dummy/bin/bundle
-- spec/dummy/bin/yarn
-- spec/dummy/bin/rails
-- spec/dummy/config/routes.rb
-- spec/dummy/config/locales/en.yml
-- spec/dummy/config/cable.yml
-- spec/dummy/config/environments/production.rb
-- spec/dummy/config/environments/development.rb
-- spec/dummy/config/environments/test.rb
-- spec/dummy/config/spring.rb
-- spec/dummy/config/environment.rb
-- spec/dummy/config/storage.yml
 - spec/dummy/config/application.rb
-- spec/dummy/config/puma.rb
-- spec/dummy/config/database.yml
-- spec/dummy/config/boot.rb
-- spec/dummy/config/initializers/application_controller_renderer.rb
-- spec/dummy/config/initializers/backtrace_silencers.rb
-- spec/dummy/config/initializers/mime_types.rb
 - spec/dummy/config/initializers/filter_parameter_logging.rb
-- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/initializers/fine_print.rb
 - spec/dummy/config/initializers/assets.rb
+- spec/dummy/config/initializers/application_controller_renderer.rb
 - spec/dummy/config/initializers/cookies_serializer.rb
 - spec/dummy/config/initializers/content_security_policy.rb
 - spec/dummy/config/initializers/inflections.rb
-- spec/dummy/config/initializers/fine_print.rb
-- spec/dummy/config.ru
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/cable.yml
+- spec/dummy/config/spring.rb
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
+- spec/dummy/config/database.yml
+- spec/dummy/config/storage.yml
+- spec/dummy/config/environment.rb
+- spec/dummy/config/puma.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/environments/development.rb
 - spec/dummy/Rakefile
-- spec/dummy/public/favicon.ico
-- spec/dummy/public/422.html
-- spec/dummy/public/apple-touch-icon.png
-- spec/dummy/public/500.html
-- spec/dummy/public/404.html
-- spec/dummy/public/apple-touch-icon-precomposed.png
-- spec/dummy/package.json
-- spec/dummy/db/schema.rb
-- spec/dummy/db/test.sqlite3
-- spec/dummy/db/migrate/1000_create_dummy_users.rb
-- spec/dummy/log/test.log
-- spec/models/signature_spec.rb
-- spec/models/contract_spec.rb
 - spec/support/controller.rb
-- spec/factories/fine_print/signature.rb
-- spec/factories/fine_print/contract.rb
-- spec/factories/user.rb
 - spec/lib/fine_print_spec.rb
 - spec/lib/fine_print/action_controller/base_spec.rb
-- spec/controllers/signatures_controller_spec.rb
-- spec/controllers/contracts_controller_spec.rb
-- spec/controllers/home_controller_spec.rb