fine_print 1.4.1 → 2.0.0

data/spec/controllers/home_controller_spec.rb

@@ -1,25 +1,27 @@
 require 'spec_helper'
 
 module FinePrint
-  describe HomeController do
-    before do
+  describe HomeController, :type => :controller do
+    routes { FinePrint::Engine.routes }
+
+    before(:each) do
       setup_controller_spec
     end
 
     it "won't get index unless authorized" do
       expect { get :index, :use_route => :fine_print }
-             .to raise_error(FinePrint::SecurityTransgression)
+             .to raise_error(ActionController::RoutingError)
       
       sign_in @user
       expect { get :index, :use_route => :fine_print }
-             .to raise_error(FinePrint::SecurityTransgression)
+             .to raise_error(ActionController::RoutingError)
     end
     
     it 'must get index if authorized' do
       sign_in @user
       @user.is_admin = true
       get :index, :use_route => :fine_print
-      assert_response :success
+      expect(response).to redirect_to contracts_path
     end
   end
 end

data/spec/controllers/signatures_controller_spec.rb

@@ -1,46 +1,75 @@
 require 'spec_helper'
 
 module FinePrint
-  describe SignaturesController do
+  describe SignaturesController, :type => :controller do
     routes { FinePrint::Engine.routes }
 
-    before do
+    before(:each) do
       setup_controller_spec
-      @signature = FactoryGirl.create(:signature)
-      @signature.reload
     end
 
+    let!(:signature) { FactoryGirl.create(:signature) }
+
     it "won't get index unless authorized" do
-      expect { get :index, :use_route => :fine_print }
-             .to raise_error(FinePrint::SecurityTransgression)
+      expect { get :index, :contract_id => signature.contract.id,
+                           :use_route => :fine_print }
+             .to raise_error(ActionController::RoutingError)
       
       sign_in @user
-      expect { get :index, :use_route => :fine_print }
-             .to raise_error(FinePrint::SecurityTransgression)
+      expect { get :index, :contract_id => signature.contract.id,
+                           :use_route => :fine_print }
+             .to raise_error(ActionController::RoutingError)
     end
     
     it 'must get index if authorized' do
       sign_in @admin
-      get :index, :use_route => :fine_print
-      assert_response :success
+      get :index, :contract_id => signature.contract.id,
+                  :use_route => :fine_print
+      expect(response.status).to eq 200
+    end
+
+    it "won't get new unless signed in" do
+      get :new, :contract_id => signature.contract.id,
+                :use_route => :fine_print
+      expect(response.status).to eq 401
+    end
+    
+    it 'must get new if signed in' do
+      sign_in @user
+      get :new, :contract_id => signature.contract.id,
+                :use_route => :fine_print
+      expect(response.status).to eq 200
+    end
+
+    it "won't create unless signed in" do
+      post :create, :contract_id => signature.contract.id,
+                    :use_route => :fine_print
+      expect(response.status).to eq 401
+    end
+    
+    it 'must create if signed in' do
+      sign_in @user
+      get :new, :contract_id => signature.contract.id,
+                :use_route => :fine_print
+      expect(response.status).to eq 200
     end
 
     it "won't destroy unless authorized" do
-      expect { delete :destroy, :id => @signature.id, :use_route => :fine_print }
-             .to raise_error(FinePrint::SecurityTransgression)
-      expect(Signature.find(@signature.id)).to eq @signature
+      expect { delete :destroy, :id => signature.id, :use_route => :fine_print }
+             .to raise_error(ActionController::RoutingError)
+      expect(Signature.find(signature.id)).to eq signature
       
       sign_in @user
-      expect { delete :destroy, :id => @signature.id, :use_route => :fine_print }
-             .to raise_error(FinePrint::SecurityTransgression)
-      expect(Signature.find(@signature.id)).to eq @signature
+      expect { delete :destroy, :id => signature.id, :use_route => :fine_print }
+             .to raise_error(ActionController::RoutingError)
+      expect(Signature.find(signature.id)).to eq signature
     end
     
     it 'must destroy if authorized' do
       sign_in @admin
-      delete :destroy, :id => @signature.id, :use_route => :fine_print
-      assert_redirected_to signatures_path
-      expect(Signature.find_by_id(@signature.id)).to be_nil
+      delete :destroy, :id => signature.id, :use_route => :fine_print
+      expect(response).to redirect_to contract_signatures_path(signature.contract)
+      expect(Signature.find_by_id(signature.id)).to be_nil
     end
   end
 end

data/spec/dummy/app/models/dummy_user.rb

@@ -1,3 +1,2 @@
 class DummyUser < ActiveRecord::Base
-  # attr_accessible :title, :body
 end

data/spec/dummy/config/initializers/fine_print.rb

@@ -1,4 +1,5 @@
 # Configuration file for the dummy app
 FinePrint.configure do |config|
-  config.user_admin_proc = lambda { |user| user.is_admin }
+  config.can_manage_proc = lambda { |user| user.try(:is_admin) || \
+                                           raise(ActionController::RoutingError, 'Not Found') }
 end