findit 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a2e4ae4411e438b0ca6b05ee3c908af0705c33e1
-  data.tar.gz: 2e227b91fa3311eaf118e342065e45f1de42c4a0
+  metadata.gz: b6aa33998f5217a364e18c0baa9a200db22bf7e4
+  data.tar.gz: f4a9c78c55428e9847e126f5ec55bb439f157977
 SHA512:
-  metadata.gz: 2104233901b47ecabf8062e6641fdf78c3bcd1f54d19ec923623e9548362c5c4cef814cdf4609deee08e05317906d268bd7564d4a5e56c7c031597b6a3383e74
-  data.tar.gz: b717349e17368e0e70fed8c1f8a9515a55d608b5d5312fc3057adeeb002bf250da6a64f7a16d41524930314deab01f08781cf68544e1fede45f805d852ad243a
+  metadata.gz: 0ac341fc995d8f86a510f6e496a4ff356c8f5e2f1f4034a09cf32c25ddc4a8963e650b19cb184287ee7c24c0e1e8c4d22fab0e1aca941863245bf99dcc7198bb
+  data.tar.gz: 5c9c935939a362afa6e347e2a916468bbdc44d8652a338179f1e06c44670b6bc57548631350874ba82e05709b9e0da64daea1d94ca59f47cb1fb9693c35a1dea

data/README.md

@@ -1,8 +1,8 @@
 # Findit
 
-Tired of writing fat controllers? But you must do all these queries.. There is a solution, move it to a Finder class.
+Tired of writing fat controllers? But you must do all these queries.. There is a solution, move it to a special Finder class!
 
-Don't write this:
+Stop writing this:
 
 ```ruby
 class SomeController
@@ -47,7 +47,9 @@ class SomeFinder
     # some initialize, maybe params parse
   end
 
-  def call
+  private
+
+  def find
     # put here you find logic
   end
 end
@@ -91,13 +93,15 @@ Or install it yourself as:
 
 ### Collections
 
-It makes Finder work as Enumerator.
-Result can be accessed with `each`, `[]` and `size` methods, but to make things work you *must* implement `call` method.
+It makes Finder work as Enumerator with lazy load.
+Result can be accessed with `each`, `[]` and `size` methods, but to make things work you *must* implement `find` method.
 ```
   class PostFinder
     incliude Findit::Collections
 
-    def call
+    private # make it private, so no one call it without lazy load
+
+    def find
       Post.where(user_id: 1)
     end
   end
@@ -130,13 +134,14 @@ class PostFinder
   end
 
   # custom initializer, do whatever you want here
-  def initialize(user, options = {})
-    @user = user
+  def initialize(options = {})
+    @user = options.fetch(:user)
     @query = options[:query]
   end
 
+  private
   # Here we fetch results. You MUST implement it
-  def call
+  def find
     scope = scope.where(user_id: @user.id)
     scope = scope.where('description like :query', query: @query) if @query.present?
     scope

data/lib/findit/collections.rb

@@ -9,18 +9,14 @@
 #      [@user.id, @query]
 #    end
 #
-#    cache_tags do
-#      {user_id: @user.id}
-#    end
-#
-#    expire_in 30.minutes
-#
 #    def initialize(user, options = {})
 #      @user = user
 #      @query = options[:query]
 #    end
 #
-#    def call
+#    private
+#
+#    def find
 #      scope = scope.where(user_id: @user.id)
 #      scope = scope.where('description like :query', query: @query) if @query.present?
 #      scope
@@ -44,24 +40,24 @@ module Findit
     extend ActiveSupport::Concern
 
     included do
-      delegate :each, :[], :size, :empty?, to: :data
+      delegate :each, :[], :size, :empty?, to: :call
     end
 
     module ClassMethods
       def cache_key(&block)
         define_method :cache_key do
-          @cache_key ||= ActiveSupport::Cache.expand_cache_key(instance_exec(&block))
+          @cache_key ||= ActiveSupport::Cache.expand_cache_key(instance_exec(&block), self.class.name.underscore)
         end
       end
     end
 
-    def call
+    def find
     end
-    undef :call
+    undef :find
 
-    def data
+    def call
       return @data if defined?(@data)
-      @data = call
+      @data = find
     end
   end
 end

data/lib/findit/version.rb

@@ -1,3 +1,3 @@
 module Findit
-  VERSION = "0.1.0"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: findit
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Denis Korobicyn
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-05-04 00:00:00.000000000 Z
+date: 2016-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   version_requirements: !ruby/object:Gem::Requirement