findbug 0.2.2 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3fa20a61fac2a31774221b97ae1ee2d440f22cca7fef93f4be78916cdec9f654
-  data.tar.gz: dee79d1e8f6ef1b2e611bb33f42182a6277f0a8c7c5443e86ee27abd992ccb0c
+  metadata.gz: 1c29bc5c8718f46a269d9987839af57928d7aab2c0b3451f08edd4683729f381
+  data.tar.gz: fd9771ef2dee52d0b50fa1b5226c401b15ce85e3c4481e15684907d5756b83db
 SHA512:
-  metadata.gz: 9d7db9d7de4e0a0e9ff768c7d92313eed9d81de2424d0dca928e56fca402980f228dd7ef832e25e378bcec182ff0612c85d49bd37ab02dbc1a86671e6ba3738e
-  data.tar.gz: deb16d95ba63c5e17aa44f6d4ad766c5192ff6009746703f327dbefb7f097fd8aa8e1d03ea73e68a2c910a13d95da7c4ce4db8c6834951241d00b3837764406e
+  metadata.gz: '018370d27b3517272c7ecf1c1f392c2d3abbcd54b92d223227ad200f39232f534a0ecc875fc79019bad2bf7e48fdbe9b81ac51326fdfdc9854fa6da2f8c9149d'
+  data.tar.gz: 64bb0554fd369ed717dd17b3c05fdfc7ae5fb275c461491ee85a19dcae91938e07e371941bc21940def52d69426f2d1bc6397300a365b3d1782555642ed18387

data/README.md

@@ -1,6 +1,6 @@
 # FindBug
 
-[![Gem Version](https://badge.fury.io/rb/findbug.svg)](https://badge.fury.io/rb/findbug/install)
+[![Gem Version](https://badge.fury.io/rb/findbug.svg)](https://badge.fury.io/rb/findbug)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 [![GitHub](https://img.shields.io/github/stars/ITSSOUMIT/findbug?style=social)](https://github.com/ITSSOUMIT/findbug)
 
@@ -297,6 +297,59 @@ rails findbug:clear_buffers
 rails findbug:db:stats
 ```
 
+## Multi-Tenant Applications (Apartment/ros-apartment)
+
+If you're using [ros-apartment](https://github.com/rails-on-services/apartment) or similar multi-tenant gems with PostgreSQL schemas, FindBug's tables need to stay in the public schema and the dashboard path should be excluded from tenant switching.
+
+### 1. Exclude FindBug Models
+
+Add FindBug models to the `excluded_models` list in `config/initializers/apartment.rb`:
+
+```ruby
+Apartment.configure do |config|
+  config.excluded_models = %w[
+    # Your existing excluded models...
+    Findbug::ErrorEvent
+    Findbug::PerformanceEvent
+  ]
+end
+```
+
+### 2. Exclude FindBug Dashboard Path
+
+Add `/findbug` to your tenant switching middleware's excluded paths:
+
+```ruby
+class SwitchTenantMiddleware < Apartment::Elevators::Generic
+  EXCLUDED_PATHS = %w[
+    /findbug
+    # Your other excluded paths...
+  ].freeze
+
+  def parse_tenant_name(request)
+    return nil if excluded_path?(request.path)
+    # ... rest of your tenant logic
+  end
+
+  private
+
+  def excluded_path?(path)
+    EXCLUDED_PATHS.any? { |excluded| path.start_with?(excluded) }
+  end
+end
+```
+
+### 3. Run Migrations in Public Schema
+
+Ensure FindBug migrations run in the public schema:
+
+```bash
+# Run migrations in public schema only (not per-tenant)
+rails db:migrate
+```
+
+The FindBug tables (`findbug_error_events`, `findbug_performance_events`) will be created in the public schema and shared across all tenants.
+
 ## Advanced: Using ActiveJob Instead of Built-in Thread
 
 By default, FindBug uses a built-in background thread for persistence. If you prefer to use ActiveJob with your own job backend:

data/app/views/findbug/errors/index.html.erb

@@ -9,27 +9,28 @@
       ["Resolved", "resolved"],
       ["Ignored", "ignored"],
       ["All Statuses", ""]
-    ], params[:status]), onchange: "this.form.submit()" %>
+    ], params.key?(:status) ? params[:status] : "unresolved"), onchange: "this.form.submit()" %>
 
     <%= select_tag :severity, options_for_select([
       ["All Severities", ""],
       ["Error", "error"],
       ["Warning", "warning"],
       ["Info", "info"]
-    ], params[:severity]), onchange: "this.form.submit()" %>
+    ], params[:severity] || ""), onchange: "this.form.submit()" %>
 
     <%= select_tag :since, options_for_select([
+      ["All Time", ""],
       ["Last Hour", "1h"],
       ["Last 24 Hours", "24h"],
       ["Last 7 Days", "7d"],
       ["Last 30 Days", "30d"]
-    ], params[:since]), onchange: "this.form.submit()" %>
+    ], params[:since] || ""), onchange: "this.form.submit()" %>
 
     <%= select_tag :sort, options_for_select([
       ["Most Recent", "recent"],
       ["Most Occurrences", "occurrences"],
       ["Oldest", "oldest"]
-    ], params[:sort]), onchange: "this.form.submit()" %>
+    ], params[:sort] || "recent"), onchange: "this.form.submit()" %>
   </div>
 
   <div class="filter-bar-search">

data/lib/findbug/engine.rb

@@ -6,11 +6,7 @@ require "rails/engine"
 # __dir__ is lib/findbug, so we go up two levels to get the gem root
 FINDBUG_GEM_ROOT = File.expand_path("../..", __dir__)
 
-# Require models (needed for persistence)
-require_relative "../../app/models/findbug/error_event"
-require_relative "../../app/models/findbug/performance_event"
-
-# Require controllers
+# Require controllers (needed for routing)
 require_relative "../../app/controllers/findbug/application_controller"
 require_relative "../../app/controllers/findbug/dashboard_controller"
 require_relative "../../app/controllers/findbug/errors_controller"
@@ -77,6 +73,14 @@ module Findbug
       end
     end
 
+    # Load models after ActiveRecord is ready
+    # This is important for multi-tenant setups (Apartment) where excluded_models
+    # are resolved early in the boot process
+    initializer "findbug.load_models", after: :load_config_initializers do
+      require_relative "../../app/models/findbug/error_event"
+      require_relative "../../app/models/findbug/performance_event"
+    end
+
     # NOTE: We intentionally do NOT add session/flash middleware here.
     # Adding middleware to API-mode apps would change their behavior
     # (e.g., showing HTML error pages instead of JSON).

data/lib/findbug/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Findbug
-  VERSION = "0.2.2"
+  VERSION = "0.3.1"
 end

data/lib/generators/findbug/templates/POST_INSTALL

@@ -36,6 +36,12 @@ Next steps:
        )
      end
 
+7. (Multi-tenant apps) If using Apartment/ros-apartment, add to apartment.rb:
+
+     config.excluded_models = %w[Findbug::ErrorEvent Findbug::PerformanceEvent]
+
+   And exclude /findbug from your tenant switching middleware.
+
 For more information, see: https://github.com/ITSSOUMIT/findbug
 
 ===============================================================================

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: findbug
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.1
 platform: ruby
 authors:
 - Soumit Das